Add "(default)" to conflict warnings in user resolver.
When reporting conflicts between parent and child elements during attachment, the warning message now indicates if a value is derived from the default rather than being explicitly authored in the XML. This improves clarity in conflict resolution warnings. PiperOrigin-RevId: 936724265 Change-Id: I68c677b19020c19bf0260f5b3b77fe6ca3661bb9
This commit is contained in:
committed by
Copybara-Service
parent
5637f74327
commit
080668df42
@@ -914,5 +914,52 @@ TEST_F(MujocoTest, AttachWarningBoundaryAndPreservation) {
|
||||
mj_deleteSpec(child2);
|
||||
}
|
||||
|
||||
TEST_F(MujocoTest, AttachConflictWarningZFarDefaultMessage) {
|
||||
mock_warning_handler.ExpectWarnings();
|
||||
|
||||
static constexpr char parent_xml[] = R"(
|
||||
<mujoco>
|
||||
<compiler conflict="warning"/>
|
||||
<worldbody/>
|
||||
</mujoco>
|
||||
)";
|
||||
|
||||
static constexpr char child_xml[] = R"(
|
||||
<mujoco>
|
||||
<visual>
|
||||
<map zfar="30"/>
|
||||
</visual>
|
||||
<worldbody/>
|
||||
</mujoco>
|
||||
)";
|
||||
|
||||
std::array<char, 1024> error;
|
||||
mjSpec* parent =
|
||||
mj_parseXMLString(parent_xml, nullptr, error.data(), error.size());
|
||||
ASSERT_THAT(parent, NotNull()) << error.data();
|
||||
|
||||
mjSpec* child =
|
||||
mj_parseXMLString(child_xml, nullptr, error.data(), error.size());
|
||||
ASSERT_THAT(child, NotNull()) << error.data();
|
||||
|
||||
mjsBody* world = mjs_findBody(parent, "world");
|
||||
mjsElement* attached =
|
||||
mjs_attach(world->element, child->element, "child_", "");
|
||||
ASSERT_THAT(attached, NotNull()) << "Error details: " << mjs_getError(parent);
|
||||
|
||||
// Since only the child authored 'zfar' and the parent relied on defaults,
|
||||
// we warning-log and state that the parent has the default value.
|
||||
EXPECT_TRUE(mjs_isWarning(parent));
|
||||
EXPECT_EQ(mjs_numWarnings(parent), 1);
|
||||
EXPECT_THAT(
|
||||
mjs_getWarning(parent, 0),
|
||||
HasSubstr("zfar: parent has 50 (default), child has "
|
||||
"30, keeping parent value"));
|
||||
|
||||
mj_deleteSpec(parent);
|
||||
mj_deleteSpec(child);
|
||||
}
|
||||
|
||||
} // namespace
|
||||
} // namespace mujoco
|
||||
|
||||
|
||||
Reference in New Issue
Block a user