From 2800a682e42d0db7f36cb43d90e8b67c15eb17b5 Mon Sep 17 00:00:00 2001 From: Haroon Qureshi Date: Tue, 23 Jun 2026 02:28:37 -0700 Subject: [PATCH] Remove unused render_flags parameters. PiperOrigin-RevId: 936528056 Change-Id: Iae8545ec1d71bc7d5a20c46394104fb1db369d5d --- src/experimental/filament/compat/scene_bridge.cc | 2 +- src/experimental/filament/compat/scene_geom_util.cc | 12 ++++++------ src/experimental/filament/compat/scene_geom_util.h | 7 ++++--- 3 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/experimental/filament/compat/scene_bridge.cc b/src/experimental/filament/compat/scene_bridge.cc index 25e8fd39..dc033610 100644 --- a/src/experimental/filament/compat/scene_bridge.cc +++ b/src/experimental/filament/compat/scene_bridge.cc @@ -213,7 +213,7 @@ void SceneBridge::Update(const mjrRect& viewport, const mjvScene* scene) { } UniquePtr renderable = CreateGeomRenderable( - *geom, ctx_, model_objects_.get(), scene_objects_.get(), scene->flags); + *geom, ctx_, model_objects_.get(), scene_objects_.get()); mjrf_addRenderableToScene(scene_.get(), renderable.get()); renderables_.push_back(std::move(renderable)); diff --git a/src/experimental/filament/compat/scene_geom_util.cc b/src/experimental/filament/compat/scene_geom_util.cc index cff09a47..84ad6727 100644 --- a/src/experimental/filament/compat/scene_geom_util.cc +++ b/src/experimental/filament/compat/scene_geom_util.cc @@ -145,8 +145,7 @@ static void PrepareGeomMeshes(mjrfRenderable* renderable, const mjvGeom& geom, } static void UpdateGeomMaterial(mjrfRenderable* renderable, const mjvGeom& geom, - ModelObjects* model_objs, - const mjtByte render_flags[mjNRNDFLAG]) { + ModelObjects* model_objs) { const mjModel* model = model_objs->GetModel(); mjrfMaterial material; @@ -271,14 +270,15 @@ static void UpdateGeomMaterial(mjrfRenderable* renderable, const mjvGeom& geom, mjrf_setRenderableMaterial(renderable, &material); } -UniquePtr CreateGeomRenderable( - const mjvGeom& geom, mjrfContext* ctx, ModelObjects* model_objs, - SceneObjects* scene_objs, const mjtByte render_flags[mjNRNDFLAG]) { +UniquePtr CreateGeomRenderable(const mjvGeom& geom, + mjrfContext* ctx, + ModelObjects* model_objs, + SceneObjects* scene_objs) { mjrfRenderableParams params; mjrf_defaultRenderableParams(¶ms); auto renderable = CreateRenderable(ctx, params); PrepareGeomMeshes(renderable.get(), geom, model_objs, scene_objs); - UpdateGeomMaterial(renderable.get(), geom, model_objs, render_flags); + UpdateGeomMaterial(renderable.get(), geom, model_objs); return renderable; } } // namespace mujoco diff --git a/src/experimental/filament/compat/scene_geom_util.h b/src/experimental/filament/compat/scene_geom_util.h index 636acdcb..857c274f 100644 --- a/src/experimental/filament/compat/scene_geom_util.h +++ b/src/experimental/filament/compat/scene_geom_util.h @@ -25,9 +25,10 @@ namespace mujoco { // Creates a Renderable from the given mjvGeom. -UniquePtr CreateGeomRenderable( - const mjvGeom& geom, mjrfContext* ctx, ModelObjects* model_objs, - SceneObjects* scene_objs, const mjtByte render_flags[mjNRNDFLAG]); +UniquePtr CreateGeomRenderable(const mjvGeom& geom, + mjrfContext* ctx, + ModelObjects* model_objs, + SceneObjects* scene_objs); } // namespace mujoco