chenlin/Mujoco_WASM
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

Ensure last XML is freed after tests.

Browse Source 
This fixes undetected memory leaks in tests calling mj_loadXML.

Additionally, a specific test for `mj_freeLastXML` is introduced.

PiperOrigin-RevId: 764294041
Change-Id: I8b5a5683d8431ed920cdd52b06ad3515d8e19e14
This commit is contained in:
Alessio Quaglino
2025-05-28 09:25:45 -07:00
committed by Copybara-Service
parent 18b0e68a5a
commit 287f46b220
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/xml/xml_api_test.cc
+10
View File
@@ -199,5 +199,15 @@ TEST_F(MujocoTest, SaveXmlWithDefaultMesh) {
mj_deleteModel(saved_model);
}
TEST_F(MujocoTest, FreeLastXml) {
static constexpr char xml[] = "<mujoco/>";
mjModel* model = LoadModelFromString(xml, 0, 0);
ASSERT_THAT(model, NotNull());
mj_deleteModel(model);
ASSERT_NE(mj_saveLastXML(nullptr, nullptr, nullptr, 0), 0);
mj_freeLastXML();
ASSERT_EQ(mj_saveLastXML(nullptr, nullptr, nullptr, 0), 0);
}
} // namespace
} // namespace mujoco