review comments

This commit is contained in:
mlutter
2023-03-15 20:51:47 -04:00
parent 3cb0121474
commit 5215992d55
+8 -9
View File
@@ -19,6 +19,7 @@ import ctypes.util
import os
import platform
import subprocess
import warnings
_SYSTEM = platform.system()
if _SYSTEM == 'Windows':
@@ -54,15 +55,13 @@ PLUGIN_HANDLES = []
def _load_all_bundled_plugins():
for directory, _, filenames in os.walk(PLUGINS_DIR):
for filename in filenames:
if os.path.splitext(filename)[-1] == ".so":
PLUGIN_HANDLES.append(ctypes.CDLL(os.path.join(directory, filename)))
elif filename == "__init__.py":
pass
else:
raise ValueError(f"Trying to load the plugin {os.path.join(directory, filename)} "
"that is not a shared library.")
if os.path.splitext(filename)[-1] in [".dll", ".dylib", ".so"]:
PLUGIN_HANDLES.append(ctypes.CDLL(os.path.join(directory, filename)))
elif filename == "__init__.py":
pass
else:
warnings.warn('Ignoring non-library in plugin directory: '
f'{os.path.join(directory, filename)}', ImportWarning)
_load_all_bundled_plugins()