From 5f42078dc1491b08917606ad17f8a37038c1945d Mon Sep 17 00:00:00 2001 From: Alessio Quaglino Date: Tue, 10 Jun 2025 10:14:42 -0700 Subject: [PATCH] Do not write nameless frames whose class is "main". PiperOrigin-RevId: 769685151 Change-Id: I3d993d7521db2b2adbf611c3e4eb5b4b293bdc30 --- src/xml/xml_native_writer.cc | 3 ++- test/xml/xml_native_writer_test.cc | 8 +++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/xml/xml_native_writer.cc b/src/xml/xml_native_writer.cc index de2aef96..1b82b9fb 100644 --- a/src/xml/xml_native_writer.cc +++ b/src/xml/xml_native_writer.cc @@ -1595,7 +1595,8 @@ XMLElement* mjXWriter::OneFrame(XMLElement* elem, mjCFrame* frame) { return elem; } - if (frame->name.empty() && frame->classname.empty()) { + // TODO: empty classname should not occur (but does) + if (frame->name.empty() && (frame->classname.empty() || frame->classname == "main")) { return elem; } diff --git a/test/xml/xml_native_writer_test.cc b/test/xml/xml_native_writer_test.cc index 2ad13bc7..6876245a 100644 --- a/test/xml/xml_native_writer_test.cc +++ b/test/xml/xml_native_writer_test.cc @@ -762,7 +762,7 @@ TEST_F(XMLWriterTest, WritesFrameDefaults) { - + @@ -791,16 +791,14 @@ TEST_F(XMLWriterTest, WritesFrameDefaults) { - + - - - +