chenlin/Mujoco_WASM
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change mjtSize from uint64_t to int64_t.

Browse Source 
This change makes `mjtSize` a signed, rather than unsigned 64-bit integer. While sizes are non-negative, the type promotion rules for unsigned integers can lead to unituitive downstream bugs, and 8 billion terabytes are enough bytes.

PiperOrigin-RevId: 834292964
Change-Id: Iea9c47c2a5d80fde63851a543d59ed0549db0f01
This commit is contained in:
Yuval Tassa
2025-11-19 07:55:00 -08:00
committed by Copybara-Service
parent 49394d57d9
commit 86a77ff8eb
5 changed files with 149 additions and 143 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/mujoco/mjtnum.h
+4 -3
View File
@@ -17,6 +17,7 @@
#include <stdint.h>
//---------------------------------- floating-point definition -------------------------------------
// floating point data type and minval
@@ -30,15 +31,15 @@
//-------------------------------------- byte definition -------------------------------------------
//---------------------------------- byte definition -----------------------------------------------
typedef unsigned char mjtByte; // used for true/false
//-------------------------------------- size definition -------------------------------------------
//---------------------------------- size definition -----------------------------------------------
typedef uint64_t mjtSize; // used for buffer sizes
typedef int64_t mjtSize; // used for buffer sizes