diff --git a/.github/workflows/build_steps.sh b/.github/workflows/build_steps.sh index fc290633..6cc80792 100755 --- a/.github/workflows/build_steps.sh +++ b/.github/workflows/build_steps.sh @@ -231,21 +231,18 @@ build_test_wasm() { } package_wasm() { - mkdir -p wasm/dist + echo "Publishing WASM bindings..." cp wasm/package.npm.json wasm/dist/package.json cp wasm/README.md wasm/dist/README.md || true VERSION=${GITHUB_REF#refs/tags/} npm --prefix wasm/dist version "${VERSION}" --no-git-tag-version - if [ -z "${NPM_TOKEN}" ]; then echo "NPM_TOKEN is not set or is invalid; aborting publish" exit 1 fi echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc - npm pack --dry-run ./wasm/dist - npm publish ./wasm/dist --access public } diff --git a/.github/workflows/publish-wasm.yml b/.github/workflows/publish-wasm.yml index d4eeadf9..33c5b7c1 100644 --- a/.github/workflows/publish-wasm.yml +++ b/.github/workflows/publish-wasm.yml @@ -28,6 +28,7 @@ jobs: - name: Build WASM bindings run: bash ./.github/workflows/build_steps.sh build_test_wasm + - name: Package WASM bindings env: NPM_TOKEN: ${{ secrets.NPM_ACCESS_TOKEN }} diff --git a/wasm/README.md b/wasm/README.md index efc6d396..3eb78fd9 100644 --- a/wasm/README.md +++ b/wasm/README.md @@ -134,9 +134,9 @@ Use the generated `.delete()` method on wrapped instances to destroy the underlying C++ object: ```typescript - const obj = new Module.MyClass(...); - // ... use obj ... - obj.delete(); // free the C++ memory +const obj = new Module.MyClass(...); +// ... use obj ... +obj.delete(); // free the C++ memory ``` Be careful to call `.delete()` exactly once per created object (double-delete