chenlin/Mujoco_WASM
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

When reporting compilation errors, include warning strings.

Browse Source 
This allows plugins to call mju_warning, and have the string propagate to users.

PiperOrigin-RevId: 650621601
Change-Id: I608e7a3a1ad126ab8da2ff0634fa708458fb9ccc
This commit is contained in:
Nimrod Gileadi
2024-07-09 07:32:26 -07:00
committed by Copybara-Service
parent 450e7ff777
commit c5f958bdff
3 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/plugin/actuator/pid_test.cc
+2 -2
View File
@@ -648,8 +648,8 @@ TEST_F(PidTest, InvalidClamp) {
mjModel* m = LoadModelFromString(kModelXml, error, sizeof(error));
EXPECT_THAT(m, IsNull());
// TODO: b/303654852 - ensure that the compilation error includes "imax"
EXPECT_THAT(std::string_view(error), HasSubstr("plugin"));
EXPECT_THAT(std::string_view(error), HasSubstr("imax"));
}
TEST_F(PidTest, InvalidSlew) {
@@ -679,8 +679,8 @@ TEST_F(PidTest, InvalidSlew) {
mjModel* m = LoadModelFromString(kModelXml, error, sizeof(error));
ASSERT_THAT(m, IsNull());
// TODO: b/303654852 - ensure that the compilation error includes "slewmax"
EXPECT_THAT(std::string_view(error), HasSubstr("plugin"));
EXPECT_THAT(std::string_view(error), HasSubstr("slewmax"));
}
} // namespace
} // namespace mujoco