chenlin/Mujoco_WASM
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace fabs with std::abs.

Browse Source 
Using fabs with int arguments broke the clang build on GitHub Actions, with a `-Wabsolute-value` error.

PiperOrigin-RevId: 453872474
Change-Id: I5c1278e9e628b0ea3d6f26c7ee7d6925c6276850
This commit is contained in:
Alessio Quaglino
2022-06-09 02:30:31 -07:00
committed by Copybara-Service
parent c7c765b6eb
commit d61a575a8c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/xml/xml_util.cc
+3 -3
View File
@@ -494,7 +494,7 @@ bool mjXUtil::SameVector(const T* vec1, const T* vec2, int n) {
bool same = true; bool same = true;
for (int i=0; i<n; i++) { for (int i=0; i<n; i++) {
if (fabs(vec1[i] - vec2[i]) > std::numeric_limits<T>::epsilon()) { if (std::abs(vec1[i] - vec2[i]) > std::numeric_limits<T>::epsilon()) {
same = false; same = false;
} }
} }
@@ -783,13 +783,13 @@ bool mjXUtil::MapValue(XMLElement* elem, const char* attr, int* data,
// check if double is int // check if double is int
static bool isint(double x) { static bool isint(double x) {
return ((fabs(x - floor(x)) < 1E-12) || (fabs(x - ceil(x)) < 1E-12)); return ((std::abs(x - floor(x)) < 1E-12) || (std::abs(x - ceil(x)) < 1E-12));
} }
// round to nearest int // round to nearest int
static int Round(double x) { static int Round(double x) {
if (fabs(x - floor(x)) < fabs(x - ceil(x))) { if (std::abs(x - floor(x)) < std::abs(x - ceil(x))) {
return (int)floor(x); return (int)floor(x);
} else { } else {
return (int)ceil(x); return (int)ceil(x);