From ed6fa7fe098928cb1c66952bc5f82896a57742c7 Mon Sep 17 00:00:00 2001 From: Haroon Qureshi Date: Wed, 27 Aug 2025 03:18:15 -0700 Subject: [PATCH] Remove unused mjMOUSE_SELECT option. PiperOrigin-RevId: 799957524 Change-Id: I69d091781dc2a2e4a762d2255d04fc411295602a --- doc/changelog.rst | 11 ++++++++--- doc/includes/references.h | 3 +-- include/mujoco/mjvisualize.h | 3 +-- python/mujoco/introspect/enums.py | 1 - unity/Runtime/Bindings/MjBindings.cs | 1 - 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/doc/changelog.rst b/doc/changelog.rst index ea2fa6c4..0a7c914a 100644 --- a/doc/changelog.rst +++ b/doc/changelog.rst @@ -16,9 +16,6 @@ General .. admonition:: Breaking API changes :class: attention - - The promotion of islanding to default involved removing the enable flag ``mjENBL_ISLAND`` and - converting it to a disable flag :ref:`mjDSBL_ISLAND `. - - The update of ``mjData.qacc_warmstart`` was moved from the end of the solver call (:ref:`mj_fwdConstraint`) to the end of :ref:`mj_step`, and is now updated with all other state variables. This change makes :ref:`mj_forward` fully idempotent. @@ -37,6 +34,14 @@ General principled and well-defined. Since this change to RK4 is effectively a bug fix, migration to the previous behavior is not provided. +.. admonition:: Breaking ABI changes + :class: attention + + - Removed ``mjMOUSE_SELECT`` flag for :ref:`mjtMouse` as it is no longer in use. + + - The promotion of islanding to default involved removing the enable flag ``mjENBL_ISLAND`` and + converting it to a disable flag :ref:`mjDSBL_ISLAND `. + - Added support for shells with a curved reference configuration. See this `example `__. diff --git a/doc/includes/references.h b/doc/includes/references.h index 5fcf3c44..823b2f57 100644 --- a/doc/includes/references.h +++ b/doc/includes/references.h @@ -2673,8 +2673,7 @@ typedef enum mjtMouse_ { // mouse interaction mode mjMOUSE_ROTATE_H, // rotate, horizontal plane mjMOUSE_MOVE_V, // move, vertical plane mjMOUSE_MOVE_H, // move, horizontal plane - mjMOUSE_ZOOM, // zoom - mjMOUSE_SELECT // selection + mjMOUSE_ZOOM // zoom } mjtMouse; typedef enum mjtPertBit_ { // mouse perturbations mjPERT_TRANSLATE = 1, // translation diff --git a/include/mujoco/mjvisualize.h b/include/mujoco/mjvisualize.h index 93102451..2198278f 100644 --- a/include/mujoco/mjvisualize.h +++ b/include/mujoco/mjvisualize.h @@ -44,8 +44,7 @@ typedef enum mjtMouse_ { // mouse interaction mode mjMOUSE_ROTATE_H, // rotate, horizontal plane mjMOUSE_MOVE_V, // move, vertical plane mjMOUSE_MOVE_H, // move, horizontal plane - mjMOUSE_ZOOM, // zoom - mjMOUSE_SELECT // selection + mjMOUSE_ZOOM // zoom } mjtMouse; diff --git a/python/mujoco/introspect/enums.py b/python/mujoco/introspect/enums.py index b67471fa..06efe324 100644 --- a/python/mujoco/introspect/enums.py +++ b/python/mujoco/introspect/enums.py @@ -574,7 +574,6 @@ ENUMS: Mapping[str, EnumDecl] = dict([ ('mjMOUSE_MOVE_V', 3), ('mjMOUSE_MOVE_H', 4), ('mjMOUSE_ZOOM', 5), - ('mjMOUSE_SELECT', 6), ]), )), ('mjtPertBit', diff --git a/unity/Runtime/Bindings/MjBindings.cs b/unity/Runtime/Bindings/MjBindings.cs index 27b553d5..301af3df 100644 --- a/unity/Runtime/Bindings/MjBindings.cs +++ b/unity/Runtime/Bindings/MjBindings.cs @@ -581,7 +581,6 @@ public enum mjtMouse : int{ mjMOUSE_MOVE_V = 3, mjMOUSE_MOVE_H = 4, mjMOUSE_ZOOM = 5, - mjMOUSE_SELECT = 6, } public enum mjtPertBit : int{ mjPERT_TRANSLATE = 1,