chenlin/Mujoco_WASM
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix missing fclose when resource is closed without being read. Fixes #1685.

Browse Source 
PiperOrigin-RevId: 649416747
Change-Id: I05eeb1071868116b6e5be76e26b465788e4d35b1
This commit is contained in:
Kyle Bayes
2024-07-04 08:06:34 -07:00
committed by Copybara-Service
parent a5a3c9efc7
commit f8b944bf7f
3 changed files with 23 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/user/user_objects_test.cc
+8 -8
View File
@@ -69,7 +69,7 @@ TEST_F(VfsTest, HFieldPngWithVFS) {
mjModel* model = LoadModelFromString(xml, error, error_sz, vfs.get());
EXPECT_THAT(model, IsNull());
EXPECT_THAT(error,
HasSubstr("resource not found via provider or OS filesystem"));
HasSubstr("Error opening file"));
mj_deleteVFS(vfs.get());
}
@@ -97,7 +97,7 @@ TEST_F(VfsTest, HFieldCustomWithVFS) {
mjModel* model = LoadModelFromString(xml, error, error_sz, vfs.get());
EXPECT_THAT(model, IsNull());
EXPECT_THAT(error,
HasSubstr("resource not found via provider or OS filesystem"));
HasSubstr("Error opening file"));
mj_deleteVFS(vfs.get());
}
@@ -126,7 +126,7 @@ TEST_F(VfsTest, TexturePngWithVFS) {
mjModel* model = LoadModelFromString(xml, error, error_sz, vfs.get());
EXPECT_THAT(model, IsNull());
EXPECT_THAT(error,
HasSubstr("resource not found via provider or OS filesystem"));
HasSubstr("Error opening file"));
mj_deleteVFS(vfs.get());
}
@@ -155,7 +155,7 @@ TEST_F(VfsTest, TextureCustomWithVFS) {
mjModel* model = LoadModelFromString(xml, error, error_sz, vfs.get());
EXPECT_THAT(model, IsNull());
EXPECT_THAT(error,
HasSubstr("resource not found via provider or OS filesystem"));
HasSubstr("Error opening file"));
mj_deleteVFS(vfs.get());
}
@@ -188,7 +188,7 @@ TEST_F(ContentTypeTest, HFieldPngWithContentType) {
mjModel* model = LoadModelFromString(xml, error, error_sz, vfs.get());
EXPECT_THAT(model, IsNull());
EXPECT_THAT(error,
HasSubstr("resource not found via provider or OS filesystem"));
HasSubstr("Error opening file"));
mj_deleteVFS(vfs.get());
}
@@ -217,7 +217,7 @@ TEST_F(ContentTypeTest, HFieldCustomWithContentType) {
mjModel* model = LoadModelFromString(xml, error, error_sz, vfs.get());
EXPECT_THAT(model, IsNull());
EXPECT_THAT(error,
HasSubstr("resource not found via provider or OS filesystem"));
HasSubstr("Error opening file"));
mj_deleteVFS(vfs.get());
}
@@ -274,7 +274,7 @@ TEST_F(ContentTypeTest, TexturePngWithContentType) {
mjModel* model = LoadModelFromString(xml, error, error_sz, vfs.get());
EXPECT_THAT(model, IsNull());
EXPECT_THAT(error,
HasSubstr("resource not found via provider or OS filesystem"));
HasSubstr("Error opening file"));
mj_deleteVFS(vfs.get());
}
@@ -304,7 +304,7 @@ TEST_F(ContentTypeTest, TextureCustomWithContentType) {
mjModel* model = LoadModelFromString(xml, error, error_sz, vfs.get());
EXPECT_THAT(model, IsNull());
EXPECT_THAT(error,
HasSubstr("resource not found via provider or OS filesystem"));
HasSubstr("Error opening file"));
mj_deleteVFS(vfs.get());
}