From fae896c51b9825adf35fe4ec5a725bd276a5569c Mon Sep 17 00:00:00 2001 From: Nimrod Gileadi Date: Fri, 5 Aug 2022 03:54:00 -0700 Subject: [PATCH] Use a negative size instead of overflow in EngineIoTest. The MSVC build on GH Actions doesn't detect overflows in mjData or mjModel sizes, so use a negative size instead to trigger an intentional failure in the test. PiperOrigin-RevId: 465529615 Change-Id: Ic7f15eed782cdda11b29984b136ed4f625418cc8 --- test/engine/engine_io_test.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/engine/engine_io_test.cc b/test/engine/engine_io_test.cc index a4d2174d..034b9069 100644 --- a/test/engine/engine_io_test.cc +++ b/test/engine/engine_io_test.cc @@ -186,9 +186,9 @@ TEST_F(EngineIoTest, MakeDataReturnsNullOnFailure) { mjModel* model = LoadModelFromString(xml, error.data(), error.size()); ASSERT_THAT(model, NotNull()) << "Failed to load model: " << error.data(); - // trigger overflow intentionally - model->nbody = INT_MAX; - static bool warning = false; + // fail mj_makeData intentionally with a bad size + model->nbody = -1; + static bool warning; warning = false; mju_user_warning = [](const char* error) { warning = true;