chenlin/Mujoco_WASM
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

Fix damper kv inheritance from default classes in XML native reader

Browse Source 
Ensured dampers correctly read inherited values from gainprm[2].

PiperOrigin-RevId: 945086959
Change-Id: I10900f3ad057036115da88ad6d649d3d058e7373
This commit is contained in:
Google DeepMind
2026-07-09 06:43:38 -07:00
committed by Copybara-Service
parent ac29b596fb
commit faf0dabc32
2 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/xml/xml_native_reader_test.cc
+23
View File
@@ -2984,6 +2984,29 @@ TEST_F(ActuatorParseTest, DampersDontRequireRange) {
EXPECT_EQ(model->actuator_ctrlrange[1], 2);
}
TEST_F(ActuatorParseTest, DamperInheritsKv) {
static constexpr char xml[] = R"(
<mujoco>
<default>
<damper kv="5" ctrlrange="0 2"/>
</default>
<worldbody>
<body name="sphere">
<joint name="hinge"/>
<geom size="1"/>
</body>
</worldbody>
<actuator>
<damper joint="hinge"/>
</actuator>
</mujoco>
)";
std::array<char, 1024> error;
MjModelPtr model = LoadModelFromString(xml, error.data(), error.size());
ASSERT_THAT(model.get(), NotNull()) << error.data();
EXPECT_EQ(model->actuator_gainprm[2], -5.0);
}
// adhesion actuators inherit from general defaults
TEST_F(ActuatorParseTest, AdhesionInheritsFromGeneral) {
static constexpr char xml[] = R"(