// Copyright 2023 DeepMind Technologies Limited // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. // Tests for engine/engine_solver.c #include #include #include #include #include #include #include "test/fixture.h" namespace mujoco { namespace { using ::std::max; using ::testing::NotNull; using SolverTest = MujocoTest; static const char* const kModelPath = "engine/testdata/solver/model.xml"; static const char* const kHumanoidPath = "engine/testdata/solver/humanoid.xml"; // compare accelerations produced by CG solver with and without islands TEST_F(SolverTest, IslandsEquivalent) { const std::string xml_path = GetTestDataFilePath(kModelPath); char error[1024]; mjModel* model = mj_loadXML(xml_path.c_str(), nullptr, error, sizeof(error)); ASSERT_THAT(model, NotNull()) << error; model->opt.solver = mjSOL_CG; // use CG solver model->opt.jacobian = mjJAC_SPARSE; // use sparse model->opt.tolerance = 0; // set tolerance to 0 model->opt.ls_tolerance = 0; // set ls_tolerance to 0 model->opt.ccd_tolerance = 0; // set ccd_tolerance to 0 model->opt.disableflags |= mjDSBL_MULTICCD; // disable multiccd int nv = model->nv; int state_size = mj_stateSize(model, mjSTATE_INTEGRATION); mjtNum* state = (mjtNum*) mju_malloc(sizeof(mjtNum)*state_size); mjData* data_island = mj_makeData(model); mjData* data_noisland = mj_makeData(model); constexpr int kNumTol = 3; mjtNum maxiter[kNumTol] = {30, 40, 60}; // Below are 3 tolerances associated with 3 different iteration counts. // Tolerances are set to be ~12x higher than failure thresholds. // The point of this test is to show that CG convergence is actually not very // precise, simply changing whether islands are used changes the solution by // quite a lot, even at high iteration count and zero {ls_}tolerance. // Increasing the iteration count higher than 60 does not improve convergence. mjtNum rtol[kNumTol] = { MjTol(1e-1, 1.2e-1), MjTol(3e-2, 2e-2), MjTol(1.3e-5, 2.8e-3) }; for (int i = 0; i < kNumTol; ++i) { model->opt.iterations = maxiter[i]; model->opt.ls_iterations = maxiter[i]; for (bool coldstart : {true, false}) { mj_resetDataKeyframe(model, data_noisland, 0); if (coldstart) { model->opt.disableflags |= mjDSBL_WARMSTART; } else { model->opt.disableflags &= ~mjDSBL_WARMSTART; } mjtNum max_ratio = 0; mjtNum worst_diff = 0; mjtNum worst_scale = 1.0; mjtNum worst_expected = 0; mjtNum worst_actual = 0; std::string worst_time = ""; int worst_dof = -1; while (data_noisland->time < .1) { mj_getState(model, data_noisland, state, mjSTATE_INTEGRATION); mj_setState(model, data_island, state, mjSTATE_INTEGRATION); model->opt.disableflags &= ~mjDSBL_ISLAND; // enable islands mj_forward(model, data_island); model->opt.disableflags |= mjDSBL_ISLAND; // disable islands mj_forward(model, data_noisland); for (int j = 0; j < nv; j++) { mjtNum diff = std::abs(data_noisland->qacc[j] - data_island->qacc[j]); mjtNum scale = 0.5 * max(static_cast(2.0), std::abs(data_noisland->qacc[j]) + std::abs(data_island->qacc[j])); mjtNum ratio = diff / scale; if (ratio > max_ratio) { max_ratio = ratio; worst_diff = diff; worst_scale = scale; worst_expected = data_island->qacc[j]; worst_actual = data_noisland->qacc[j]; worst_time = std::to_string(data_noisland->time); worst_dof = j; } } mj_step(model, data_noisland); } // Assert once per condition with the worst offender. // rtol[i] is already scaled by MjTolScale() at initialization. mjtNum allowed_tol = worst_scale * rtol[i]; EXPECT_NEAR(worst_actual, worst_expected, allowed_tol) << "Worst offender info:\n" << "time: " << worst_time << '\n' << "dof: " << worst_dof << '\n' << "maxiter: " << maxiter[i] << '\n' << "coldstart: " << coldstart << '\n' << "rtol: " << worst_scale * rtol[i] << '\n' << "actual diff: " << worst_diff << " (allowed: " << allowed_tol << ")"; } } mj_deleteData(data_noisland); mj_deleteData(data_island); mju_free(state); mj_deleteModel(model); } // compare accelerations produced by CG/Newton solver with and without islands TEST_F(SolverTest, IslandsEquivalentForward) { const std::string xml_path = GetTestDataFilePath(kModelPath); char error[1024]; mjModel* model = mj_loadXML(xml_path.c_str(), nullptr, error, sizeof(error)); ASSERT_THAT(model, NotNull()) << error; int nv = model->nv; // set tolerance to 0 so opt.iterations are always run model->opt.tolerance = 0; mjData* data_island = mj_makeData(model); mjData* data_noisland = mj_makeData(model); for (bool warmstart : {false, true}) { for (mjtJacobian jacobian : {mjJAC_DENSE, mjJAC_SPARSE}) { for (mjtSolver solver : {mjSOL_CG, mjSOL_NEWTON}) { for (mjtCone cone : {mjCONE_PYRAMIDAL, mjCONE_ELLIPTIC}) { if (warmstart) { model->opt.disableflags &= ~mjDSBL_WARMSTART; } else { model->opt.disableflags |= mjDSBL_WARMSTART; } model->opt.jacobian = jacobian; model->opt.solver = solver; model->opt.cone = cone; // disable islands, reset and step both datas to populate warmstart model->opt.disableflags |= mjDSBL_ISLAND; mj_resetDataKeyframe(model, data_island, 0); mj_resetDataKeyframe(model, data_noisland, 0); mj_step(model, data_island); mj_step(model, data_noisland); // forward with islands disabled mj_forward(model, data_noisland); // forward with islands enabled model->opt.disableflags &= ~mjDSBL_ISLAND; // enable islands mj_forward(model, data_island); mjtNum max_diff = 0; mjtNum worst_expected = 0; mjtNum worst_actual = 0; int worst_idx = -1; mjtNum scale = 0.5 * (mju_norm(data_noisland->qacc, nv) + mju_norm(data_island->qacc, nv)); mjtNum rtol = solver == mjSOL_CG ? MjTol(1e-8, 1e-4) : MjTol(1e-13, 1e-3); mjtNum worst_allowed = scale * rtol; for (int j = 0; j < nv; j++) { mjtNum diff = std::abs(data_island->qacc[j] - data_noisland->qacc[j]); if (diff > max_diff) { max_diff = diff; worst_expected = data_noisland->qacc[j]; worst_actual = data_island->qacc[j]; worst_idx = j; } } EXPECT_NEAR(worst_actual, worst_expected, worst_allowed) << "Worst offender in IslandsEquivalentForward:\n" << "idx: " << worst_idx << '\n' << "warmstart: " << warmstart << '\n' << "jacobian: " << (jacobian ? "sparse" : "dense") << '\n' << "solver: " << (solver == mjSOL_CG ? "CG" : "Newton") << '\n' << "cone: " << (cone == 1 ? "elliptic" : "pyramidal") << '\n' << "actual diff: " << max_diff << " (allowed: " << worst_allowed << ")"; } } } } mj_deleteData(data_noisland); mj_deleteData(data_island); mj_deleteModel(model); } TEST_F(SolverTest, SolversEquivalent) { struct SolverTolerances { mjtNum newton; mjtNum cg; mjtNum pgs_pyramidal; mjtNum pgs_elliptic; }; // Relative tolerances: 10x above failure thresholds on Linux, clang, x86-64. // MjTol(f64, f32) selects the appropriate tolerance for the current build. const struct { const char* path; SolverTolerances tolerances; } kConfigs[] = { {.path = kModelPath, .tolerances = { .newton = MjTol(1e-13, 1e-5), .cg = MjTol(1e-13, 1e-5), .pgs_pyramidal = MjTol(1e-12, 1e-5), .pgs_elliptic = MjTol(1e-3, 1e-2), }}, {.path = kHumanoidPath, .tolerances = { .newton = MjTol(1e-13, 1e-5), .cg = MjTol(1e-12, 1e-5), .pgs_pyramidal = MjTol(1e-5, 1e-5), .pgs_elliptic = MjTol(1e-8, 1e-4), }}, }; for (const auto& config : kConfigs) { const std::string xml_path = GetTestDataFilePath(config.path); char error[1024]; mjModel* model = mj_loadXML(xml_path.c_str(), nullptr, error, sizeof(error)); ASSERT_THAT(model, NotNull()) << error; model->opt.tolerance = 0; // set tolerance to 0 model->opt.iterations = 500; // set iterations to 500 model->opt.disableflags |= mjDSBL_WARMSTART; // disable warmstart int nv = model->nv; mjData* data = mj_makeData(model); mjData* data_truth = mj_makeData(model); for (mjtCone cone : {mjCONE_PYRAMIDAL, mjCONE_ELLIPTIC}) { model->opt.cone = cone; // use Newton Dense as ground truth model->opt.solver = mjSOL_NEWTON; model->opt.jacobian = mjJAC_DENSE; mj_resetDataKeyframe(model, data_truth, 0); mj_forward(model, data_truth); mjtNum scale = mju_norm(data_truth->qfrc_constraint, nv); for (mjtSolver solver : {mjSOL_NEWTON, mjSOL_CG, mjSOL_PGS}) { mjtNum rtol; switch (solver) { case mjSOL_NEWTON: rtol = config.tolerances.newton; break; case mjSOL_CG: rtol = config.tolerances.cg; break; case mjSOL_PGS: rtol = cone == mjCONE_PYRAMIDAL ? config.tolerances.pgs_pyramidal : config.tolerances.pgs_elliptic; break; } mjtNum tolerance = scale * rtol; for (mjtJacobian jacobian : {mjJAC_DENSE, mjJAC_SPARSE}) { model->opt.solver = solver; model->opt.jacobian = jacobian; mj_resetDataKeyframe(model, data, 0); mj_forward(model, data); const char* cone_str = (cone == mjCONE_PYRAMIDAL ? "pyramidal" : "elliptic"); const char* solver_str = (solver == mjSOL_NEWTON ? "Newton" : (solver == mjSOL_CG ? "CG" : "PGS")); const char* jacobian_str = (jacobian == mjJAC_DENSE ? "dense" : "sparse"); mjtNum max_diff = 0; mjtNum worst_expected = 0; mjtNum worst_actual = 0; int worst_idx = -1; for (int j = 0; j < nv; j++) { mjtNum diff = std::abs(data->qfrc_constraint[j] - data_truth->qfrc_constraint[j]); if (diff > max_diff) { max_diff = diff; worst_expected = data_truth->qfrc_constraint[j]; worst_actual = data->qfrc_constraint[j]; worst_idx = j; } } EXPECT_NEAR(worst_actual, worst_expected, tolerance) << "Worst offender in SolversEquivalent:\n" << "idx: " << worst_idx << '\n' << "model: " << config.path << "\n" << "cone: " << cone_str << "\n" << "solver: " << solver_str << "\n" << "jacobian: " << jacobian_str << "\n" << "actual diff: " << max_diff << " (allowed: " << tolerance << ")"; } } } mj_deleteData(data_truth); mj_deleteData(data); mj_deleteModel(model); } } } // namespace } // namespace mujoco