Include callable skill and live-GUI prerequisites, epoch sensor reads, packed snapshots, sampled bit-exact kinematics, and verified-tick rendering without changing the physical/control schedule. Record bounded analytic S1 GUI/headless qualification, original failures and CPU evidence (1557 passed, 6 skipped). Preserve accepted_skill=false and sub-real-time limitations. Exclude native authorities, caches, large media and local delivery copies; retain sealed artifact digest.
3.7 KiB
Review
Paths below use T = source/SkillFactory/SkillFactory/tasks/manager_based/contact_cycle_sim/.
- Correct — invocation-local reads/restoration:
T/readonly_scope_v042.py:24–53memoizes only listed no-argument reads, preserves instance overrides versus inherited methods, and restores them infinally. Clock/anchor identities and completed-physics/reset/pose counters are checked before normal return. Installation scopes only original safety evaluation; packed snapshot has its own separate scope (:56–62;T/packed_recording_v042.py:94–98). - Correct — physical sequencing/reset guards: mount-reference routing requires source identity (
T/readonly_scope_v042.py:65–71). Proxy reset still delegates to the guarded original sensor. Installation occurs before initial reset (scripts/evaluate_cycle_functional_flow.py:255–258); per-tick safety and synchronous evidence remain before another step (T/evaluation_env.py:457–471). - Correct — batching/layout:
T/batched_kinematics_v042.py:12–17orders probes as three positive then three negative perturbations per input row, subtracts corresponding pairs, and transposes into the original Jacobian column layout. Epsilon, IK iterations, solve formula and limits are not changed. - Correct — capture/provenance: packing groups by exact device/dtype and uses blocking CPU transfer plus independently owned field storage (
T/packed_recording_v042.py:17–42). Both new modules are preloaded, source-bound and authority-bound; qualification precedes environment construction and its record participates in exact PREP/RUN verification (scripts/evaluate_cycle_functional_flow.py:68–69,118–124;source/SkillFactory/SkillFactory/legs/contact_cycle_sim/skill_binding_v4.py:15–16,46–53;scripts/skill_launch_v4.py:30–31). - Fixed: None; read-only review.
Finding — P1: sampled “bitwise” qualification uses numeric equality
Location: T/batched_kinematics_v042.py:32–36.
torch.equal(old, new) determines both all_bitwise_equal and whether the batched Jacobian is installed. It tests numeric equality, not representation equality: float32 +0.0 and -0.0 compare equal despite differing bits. Their absolute difference also records zero.
This contradicts the requested sampled-bitwise gate. It does not establish that actual FK samples currently differ; it establishes that the qualification cannot enforce its stated criterion.
Smallest fix: compare contiguous float32 representations using integer views, and add a signed-zero negative test plus qualification-fallback coverage. Retain the existing numeric maximum-difference report and explicit original-Jacobian selection.
Merge verdict: BLOCK the combined qualification run pending this correction. Other inspected seams are suitable for bounded runtime qualification, not final acceptance.
Validation and residual risks
- Inspected supplied
performance_v042/cpu-combined.logand XML: 55 passed, zero failures/errors/skips. These are supplied results, not tests executed by this reviewer. - Current
configs/contact_cycle/performance_v042.json:2selectssensor_epoch, notcombined. Freeze and authenticate the intended combined configuration before running; the current selection will not exercise the combined path. - No edits, tests, shell commands, Kit/GPU operations, installs or subdelegation were performed.
- Native combined trace equivalence, reset behavior, gates and performance remain unqualified. No all-input bitwise or new performance claim is approved.
- Protected-artifact hashes and historical receipt integrity were not independently recomputed.
watchdog_diffdoes not establish committed-range equivalence; review focused on the named candidate source seams and supplied artifacts.