diff --git a/crates/engine/src/measure_centre_tests.rs b/crates/engine/src/measure_centre_tests.rs index 1fbae18d7..3903512cb 100644 --- a/crates/engine/src/measure_centre_tests.rs +++ b/crates/engine/src/measure_centre_tests.rs @@ -278,3 +278,53 @@ fn step_round_trip_of_a_plate_with_holes() { assert!(close(&r["items"][0]["diameter"], 6.0, 1e-6) && close(&r["items"][1]["diameter"], 8.0, 1e-6), "{r}"); let _ = std::fs::remove_dir_all(&dir); } + +// A part ring cut by `solid.combine` (two prisms through its ends, a notch through its chamfer) +// measures what it encloses, wherever it is moved. The reference mesher left a crack where the +// notch meets the chamfer's cone; the volume beside it was left out (0.2 %), and integrated +// about the world origin the loss grew with the distance (7 % moved 1000 mm away). + +fn volume(s: &mut Session, body: &str) -> f64 { + run(s, "inspect.measure", json!({"bodies": [body]}))["total"]["volume_mm3"].as_f64().unwrap() +} + +fn prism(s: &mut Session, offset: f64, points: Value, distance: f64, name: &str) { + run(s, "sketch.create", json!({"plane": "XY", "offset": offset})); + run(s, "sketch.line", json!({"points": points, "closed": true})); + run(s, "sketch.finish", json!({})); + run(s, "solid.extrude", json!({"distance": distance, "operation": "new", "body_name": name})); +} + +/// A part ring (210° of a chamfered section) less two oblique prisms and a notch. +fn cut_ring(s: &mut Session) { + let (c, si) = (15f64.to_radians().cos(), 15f64.to_radians().sin()); + run(s, "sketch.create", json!({"plane": {"origin": [0, 0, 0], "x_dir": [si, c, 0], "y_dir": [0, 0, -1]}})); + let section = json!([[16.6, 0], [17.5, 0], [18.5, -1.0], [18.5, -7.0], [17.5, -8.0], [16.6, -8.0], [16.4, -7.8], [16.4, -0.2]]); + run(s, "sketch.line", json!({"points": section, "closed": true})); + run(s, "sketch.finish", json!({})); + run(s, "solid.revolve", json!({"axis": "Z", "angle": "210 deg", "body_name": "Ring"})); + let quad = |sy: f64| json!([[4.644832, 15.101839 * sy], [5.17399, 16.822301 * sy], [4.555215, 17.000295 * sy], [2.187187, 15.574386 * sy]]); + prism(s, -1.0, quad(1.0), 10.0, "T0"); + prism(s, -1.0, quad(-1.0), 10.0, "T1"); + prism(s, 7.1, json!([[-17.6, 0.45], [-19.5, 0.45], [-19.5, -0.45], [-17.6, -0.45]]), 1.9, "N0"); + run(s, "solid.combine", json!({"target": "Ring", "tools": ["T0", "T1", "N0"], "operation": "cut"})); +} + +#[test] +fn combine_cut_volume_does_not_depend_on_placement() { + let mut s = Session::default(); + cut_ring(&mut s); + let here = volume(&mut s, "Ring"); + // The 210° ring by Pappus less what the prisms and the notch take (a fine grid quadrature + // of each, independent of the kernel's meshes): 1005.489 − 2 × 5.639 − 0.287. + let want = 993.924; + assert!((here - want).abs() <= 2e-4 * want, "at the origin: {here} vs {want}"); + let mut moved = Vec::new(); + for by in [[100.0, 0.0, 0.0], [900.0, 0.0, 0.0], [-1000.0, 100.0, 0.0], [0.0, 0.0, 10000.0], [0.0, -10000.0, 0.0]] { + run(&mut s, "solid.move", json!({"bodies": ["Ring"], "translate": by})); + moved.push((by, volume(&mut s, "Ring"))); + } + for (by, v) in moved { + assert!((v - here).abs() <= 1e-6 * here, "after a move by {by:?}: {v} vs {here} at the origin"); + } +} diff --git a/crates/kernel/src/measure.rs b/crates/kernel/src/measure.rs index febcf6f79..71299aa7e 100644 --- a/crates/kernel/src/measure.rs +++ b/crates/kernel/src/measure.rs @@ -22,15 +22,21 @@ pub struct BodyMeasure { pub merged: TopoCounts, } -/// Per-face sums: area, 6 × signed volume and 24 × first moments (divergence theorem, origin 0). -fn face_sums(m: &Mesh, nf: usize) -> Vec<(f64, f64, Vec3)> { - let mut out = vec![(0.0, 0.0, Vec3::ZERO); nf]; +/// Per-face sums: area, 6 × signed volume and 24 × first moments (divergence theorem), taken +/// about `o` (the moments relative to it), and the sum of the area vectors (zero over a closed +/// surface). Over a closed surface the volume does not depend on `o`; over one that leaves a +/// gap, the gap is closed by a cone to `o`, so `o` near the body keeps that cone small. +fn face_sums(m: &Mesh, nf: usize, o: Vec3) -> Vec<(f64, f64, Vec3, Vec3)> { + let mut out = vec![(0.0, 0.0, Vec3::ZERO, Vec3::ZERO); nf]; for (t, f) in m.triangles.iter().zip(&m.tri_face) { let (Some([a, b, c]), Some(slot)) = (m.tri(t), out.get_mut(*f as usize)) else { continue }; + let n = (b - a).cross(c - a) * 0.5; + let (a, b, c) = (a - o, b - o, c - o); let d = a.dot(b.cross(c)); - slot.0 += (b - a).cross(c - a).len() * 0.5; + slot.0 += n.len(); slot.1 += d; slot.2 += (a + b + c) * d; + slot.3 += n; } out } @@ -152,7 +158,13 @@ fn mass(b: &Body, topology: bool) -> Result<(MassMeasure, Option)> { None => None, }; let nf = b.face_count(); - let (sf, sm, sc) = (face_sums(&fine, nf), face_sums(&medium, nf), face_sums(&coarse, nf)); + // About the box's centre when the meshes leave only a crack: see `face_sums`. A body that is + // open on purpose (a surface, or a cup whose lid is still a separate sheet) has no volume of + // its own; it keeps the origin, so such bodies still compare with each other when the centre + // of their boxes moves (a crowned lid rises, the open cup under it doesn't change). + let (surface, gap) = face_sums(&fine, nf, Vec3::ZERO).iter().fold((0.0, Vec3::ZERO), |s, f| (s.0 + f.0, s.1 + f.3)); + let o = Some(fine.bounds().center()).filter(|c| c.is_finite() && gap.len() <= 0.01 * surface).unwrap_or(Vec3::ZERO); + let (sf, sm, sc) = (face_sums(&fine, nf, o), face_sums(&medium, nf, o), face_sums(&coarse, nf, o)); let close = |x: f64, y: f64| (x - y).abs() <= 0.01 * x.abs().max(y.abs()) + 1e-9; let (mut area, mut v6, mut mom) = (0.0, 0.0, Vec3::ZERO); for ((f, m), c) in sf.iter().zip(&sm).zip(&sc) { @@ -168,6 +180,13 @@ fn mass(b: &Body, topology: bool) -> Result<(MassMeasure, Option)> { v6 += pick.1; mom += pick.2; } + // The moments back about the origin. A gap the meshes leave (a crack where a trimmed face + // meets a hole cut into it) is closed by a cone to the box's centre, which keeps it small + // (a crack of 0.3 mm² moved a part ring's volume by 7 % about the origin 1000 mm away; about + // the centre, by 0.1 %). Every body is measured by the same meshes this way, so a body and the + // pieces a boolean cuts it into add up: a closed display plan measured instead would mesh + // some faces more coarsely than the sums do and break that. + let mom = o * (4.0 * v6) + mom; let volume = v6 / 6.0; let centroid = if v6.abs() > 1e-12 { mom / (4.0 * v6) } else { fine.bounds().center() }; Ok((MassMeasure { volume, area, centroid, bbox: coarse.bounds().union(&fine.bounds()) }, topo)) @@ -197,4 +216,121 @@ mod tests { assert!((got - want).abs() < 1e-3 * want, "{got} against {want}"); assert!(measure(&ring).unwrap().merged.faces > 0); } + + /// A 10 mm cube at `at`, each side in n × n squares of two triangles, one face per side; + /// without its first `open` triangles. + fn cube(at: Vec3, n: usize, open: usize) -> Mesh { + let mut m = Mesh::default(); + let s = 10.0; + for axis in 0..3 { + for side in [0.0, 1.0] { + for i in 0..n { + for j in 0..n { + let corner = |a: usize, b: usize| { + let mut c = [0.0; 3]; + c[axis] = side * s; + c[(axis + 1) % 3] = a as f64 * s / n as f64; + c[(axis + 2) % 3] = b as f64 * s / n as f64; + at + Vec3::new(c[0], c[1], c[2]) + }; + let k = m.positions.len() as u32; + m.positions.extend([corner(i, j), corner(i + 1, j), corner(i + 1, j + 1), corner(i, j + 1)]); + m.triangles.extend(if side > 0.0 { [[k, k + 1, k + 2], [k, k + 2, k + 3]] } else { [[k, k + 2, k + 1], [k, k + 3, k + 2]] }); + m.tri_face.extend([(2 * axis) as u32 + side as u32; 2]); + } + } + } + } + m.triangles.drain(..open); + m.tri_face.drain(..open); + m + } + + /// The summed per-face sums of `m` about `o`, with the moments about the origin (as + /// `measure` passes them on). + fn sums(m: &Mesh, o: Vec3) -> (f64, f64, Vec3, Vec3) { + let (area, v6, mom, normal) = + face_sums(m, 6, o).iter().fold((0.0, 0.0, Vec3::ZERO, Vec3::ZERO), |s, f| (s.0 + f.0, s.1 + f.1, s.2 + f.2, s.3 + f.3)); + (area, v6, o * (4.0 * v6) + mom, normal) + } + + /// A cube 1000 mm from the origin with one 0.5 mm² facet left out: about the box's centre + /// the sums miss a cone of that facet to the centre (0.08 %), where about the origin they are + /// 17 % over. Closed, it measures the same about either. + #[test] + fn a_mesh_left_open_is_measured_about_its_centre() { + let at = Vec3::new(1000.0, 1000.0, 1000.0); + let (closed, open) = (cube(at, 10, 0), cube(at, 10, 1)); + let centre = at + Vec3::new(5.0, 5.0, 5.0); + for o in [Vec3::ZERO, centre] { + let (area, v6, mom, normal) = sums(&closed, o); + assert!((area - 600.0).abs() < 1e-9 && (v6 / 6.0 - 1000.0).abs() < 1e-6 && normal.len() < 1e-9); + assert!((mom / (4.0 * v6) - centre).len() < 1e-6 * at.len(), "{o:?}"); + } + let (_, v6_origin, _, normal) = sums(&open, Vec3::ZERO); + assert!((normal.len() - 0.5).abs() < 1e-9); + // The facet faces the origin: leaving it out adds its cone to the origin, 167 mm³. + assert!((v6_origin / 6.0 - (1000.0 + 0.5 * 1000.0 / 3.0)).abs() < 1e-3, "{}", v6_origin / 6.0); + let (_, v6, mom, _) = sums(&open, centre); + assert!((v6 / 6.0 - (1000.0 - 0.5 * 5.0 / 3.0)).abs() < 1e-6, "{}", v6 / 6.0); + assert!((mom / (4.0 * v6) - centre).len() < 0.01, "{:?}", mom / (4.0 * v6)); + } + + // A body's measured volume does not depend on where it sits: the same revolved ring of cones + // and cylinders, moved far from the origin, measures what it measures at the origin. + use crate::{revolve, transform}; + use solidcraft_geom::{Loop2, Plane, Region2, Vec2}; + use std::f64::consts::{PI, TAU}; + + /// Ring cross-section in (radius, height): cones top and bottom, cylinders inside and out. + const PROFILE: [(f64, f64); 6] = [(5.0, 0.0), (9.0, 0.0), (11.0, 2.0), (11.0, 6.0), (8.0, 8.0), (5.0, 8.0)]; + + /// Pappus: 2π × the section's first moment about the axis. + fn ring_volume() -> f64 { + let mut moment6 = 0.0; + for (i, &(x0, y0)) in PROFILE.iter().enumerate() { + let (x1, y1) = PROFILE[(i + 1) % PROFILE.len()]; + moment6 += (x0 + x1) * (x0 * y1 - x1 * y0); + } + TAU * moment6 / 6.0 + } + + fn revolved(plane: &Plane, pts: &[Vec2]) -> Body { + let region = Region2 { outer: Loop2::polygon(pts), holes: vec![] }; + revolve(plane, &[region], Vec2::ZERO, Vec2::Y, TAU).unwrap().pop().unwrap() + } + + fn rel(a: f64, b: f64) -> f64 { + (a - b).abs() / b.abs() + } + + #[test] + fn ring_volume_does_not_depend_on_placement() { + let pts: Vec = PROFILE.iter().map(|&(r, z)| Vec2::new(r, z)).collect(); + let base = revolved(&Plane::XZ, &pts); + let at_origin = measure(&base).unwrap(); + assert!(rel(at_origin.volume, ring_volume()) < 1e-4, "{} vs {}", at_origin.volume, ring_volume()); + for d in [100.0, 1000.0, 10000.0] { + for axis in [Vec3::X, Vec3::Y, Vec3::Z, Vec3::new(1.0, 1.0, 1.0)] { + let m = measure(&transform(&base, axis * d, Vec3::ZERO, Vec3::Z, 0.0).unwrap()).unwrap(); + assert!(rel(m.volume, at_origin.volume) < 1e-6, "moved {d} along {axis:?}: {} vs {}", m.volume, at_origin.volume); + let off = m.centroid - at_origin.centroid - axis * d; + assert!(off.len() < 1e-6 * d, "centroid moved {d} along {axis:?}: off by {off:?}"); + } + } + } + + #[test] + fn cylinder_and_cone_volumes_far_from_the_origin() { + let (r, h) = (7.0, 12.0); + // A frustum, radii 7 and 3, height 10: πh/3 (R² + Rr + r²). + let frustum = [Vec2::new(0.0, 0.0), Vec2::new(7.0, 0.0), Vec2::new(3.0, 10.0), Vec2::new(0.0, 10.0)]; + let cone_volume = PI * 10.0 / 3.0 * (49.0 + 21.0 + 9.0); + for at in [Vec3::ZERO, Vec3::new(5000.0, -3000.0, 8000.0)] { + let cyl = measure(&cylinder(at, Vec3::Z, r, h).unwrap()).unwrap(); + assert!(rel(cyl.volume, PI * r * r * h) < 5e-4, "cylinder at {at:?}: {}", cyl.volume); + let cone = measure(&revolved(&Plane { origin: at, ..Plane::XZ }, &frustum)).unwrap(); + assert!(rel(cone.volume, cone_volume) < 5e-4, "frustum at {at:?}: {} vs {cone_volume}", cone.volume); + } + } } diff --git a/tests/robustness/goldens.json b/tests/robustness/goldens.json index bb62b4d58..e0b1dc74a 100644 --- a/tests/robustness/goldens.json +++ b/tests/robustness/goldens.json @@ -15,13 +15,13 @@ "11": {"area":7858.300481,"bodies":1,"edges":33,"error":null,"faces":13,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","hole","rectangular pattern","fillet"],"unsupported":0,"volume":34605.048259}, "12": {"area":4668.773162,"bodies":1,"edges":59,"error":null,"faces":25,"outcome":"ok","rejected":0,"shells":2,"steps":["extruded profile","chamfer","join cylinder","join box","cut cylinder","circular pattern"],"unsupported":3,"volume":11874.973223}, "13": {"area":2112.846954,"bodies":1,"edges":99,"error":null,"faces":39,"outcome":"ok","rejected":1,"shells":1,"steps":["revolved section","cut cylinder","join box","rectangular pattern","cut cylinder","cut box","fillet","hole"],"unsupported":0,"volume":2410.783741}, - "14": {"area":10554.182993,"bodies":1,"edges":43,"error":null,"faces":20,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","cut cylinder","shell","fillet"],"unsupported":0,"volume":10371.646072}, + "14": {"area":10554.182993,"bodies":1,"edges":43,"error":null,"faces":20,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","cut cylinder","shell","fillet"],"unsupported":0,"volume":10317.362887}, "15": {"area":2312.730168,"bodies":1,"edges":39,"error":null,"faces":15,"outcome":"ok","rejected":2,"shells":1,"steps":["revolved section","cut box","rectangular pattern","cut sphere","cut cylinder","cut sphere","join cylinder"],"unsupported":0,"volume":5728.661237}, "16": {"area":8872.878228,"bodies":1,"edges":49,"error":null,"faces":23,"outcome":"ok","rejected":0,"shells":3,"steps":["box","join cylinder","circular pattern","hole"],"unsupported":0,"volume":44953.407975}, "17": {"area":6022.921702,"bodies":1,"edges":48,"error":null,"faces":19,"outcome":"ok","rejected":0,"shells":1,"steps":["revolved section","cut box","shell","cut cylinder"],"unsupported":0,"volume":2981.269959}, "18": {"area":5969.14407,"bodies":1,"edges":131,"error":null,"faces":53,"outcome":"ok","rejected":0,"shells":4,"steps":["extruded profile","join cylinder","circular pattern","cut cylinder","hole","cut cylinder","hole","circular pattern"],"unsupported":0,"volume":20696.295391}, "19": {"area":3440.869757,"bodies":1,"edges":42,"error":null,"faces":16,"outcome":"ok","rejected":0,"shells":1,"steps":["revolved section","chamfer","cut sphere"],"unsupported":0,"volume":5909.174021}, - "20": {"area":5729.705185,"bodies":1,"edges":116,"error":null,"faces":45,"outcome":"ok","rejected":1,"shells":1,"steps":["extruded profile","fillet","cut box","cut cylinder","hole","circular pattern","cut box"],"unsupported":0,"volume":17157.584515}, + "20": {"area":5729.705185,"bodies":1,"edges":116,"error":null,"faces":45,"outcome":"ok","rejected":1,"shells":1,"steps":["extruded profile","fillet","cut box","cut cylinder","hole","circular pattern","cut box"],"unsupported":0,"volume":17175.653386}, "21": {"area":5814.791707,"bodies":1,"edges":56,"error":null,"faces":22,"outcome":"ok","rejected":0,"shells":1,"steps":["revolved section","join box","hole","fillet","hole","cut box"],"unsupported":1,"volume":19153.734422}, "22": {"area":4634.445571,"bodies":1,"edges":138,"error":null,"faces":54,"outcome":"ok","rejected":0,"shells":2,"steps":["revolved section","join box","join box","join box","rectangular pattern","cut cylinder"],"unsupported":0,"volume":7855.557174}, "23": {"area":1795.692727,"bodies":1,"edges":16,"error":null,"faces":7,"outcome":"ok","rejected":0,"shells":1,"steps":["revolved section","cut sphere"],"unsupported":0,"volume":3198.694598}, @@ -41,7 +41,7 @@ "37": {"area":11714.822253,"bodies":1,"edges":44,"error":null,"faces":18,"outcome":"ok","rejected":1,"shells":1,"steps":["box","cut cylinder","join cylinder","cut sphere","circular pattern","fillet","circular pattern","rectangular pattern"],"unsupported":2,"volume":75556.602064}, "38": {"area":11769.375811,"bodies":1,"edges":30,"error":"offset: a corner whose faces don't meet the same way after t","faces":12,"outcome":"failed","rejected":1,"shells":1,"steps":["box","hole","cut cylinder","shell"],"unsupported":0,"volume":78261.020975}, "39": {"area":1892.051593,"bodies":1,"edges":27,"error":null,"faces":11,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","chamfer","cut sphere","rectangular pattern"],"unsupported":1,"volume":4040.619835}, - "40": {"area":15549.121775,"bodies":1,"edges":49,"error":"offset: a corner whose faces don't meet the same way after t","faces":22,"outcome":"failed","rejected":0,"shells":1,"steps":["extruded profile","cut cylinder","shell","cut cylinder","join cylinder","shell"],"unsupported":0,"volume":16541.530092}, + "40": {"area":15549.121775,"bodies":1,"edges":49,"error":"offset: a corner whose faces don't meet the same way after t","faces":22,"outcome":"failed","rejected":0,"shells":1,"steps":["extruded profile","cut cylinder","shell","cut cylinder","join cylinder","shell"],"unsupported":0,"volume":16538.74573}, "41": {"area":7295.282884,"bodies":1,"edges":93,"error":null,"faces":32,"outcome":"ok","rejected":1,"shells":1,"steps":["box","cut sphere","shell","fillet","cut cylinder","rectangular pattern","fillet","cut sphere"],"unsupported":0,"volume":5185.221068}, "42": {"area":5486.877622,"bodies":1,"edges":51,"error":null,"faces":20,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","cut box","cut cylinder","rectangular pattern"],"unsupported":0,"volume":19095.106157}, "43": {"area":3492.988343,"bodies":1,"edges":72,"error":null,"faces":26,"outcome":"ok","rejected":2,"shells":1,"steps":["extruded profile","cut cylinder","rectangular pattern","fillet","hole","rectangular pattern","join cylinder"],"unsupported":1,"volume":7528.548742}, @@ -56,13 +56,13 @@ "52": {"area":8628.608654,"bodies":1,"edges":45,"error":null,"faces":18,"outcome":"ok","rejected":0,"shells":1,"steps":["box","shell","cut cylinder","chamfer","join cylinder"],"unsupported":1,"volume":9001.505742}, "53": {"area":17463.451761,"bodies":1,"edges":116,"error":null,"faces":48,"outcome":"ok","rejected":0,"shells":4,"steps":["extruded profile","cut cylinder","shell","fillet","join cylinder","circular pattern"],"unsupported":0,"volume":16954.551768}, "54": {"area":7075.531663,"bodies":1,"edges":81,"error":"offset: a corner whose faces don't meet the same way after t","faces":35,"outcome":"failed","rejected":0,"shells":4,"steps":["extruded profile","join box","circular pattern","cut cylinder","cut box","join cylinder","shell"],"unsupported":2,"volume":16028.147251}, - "55": {"area":6795.599353,"bodies":1,"edges":60,"error":null,"faces":23,"outcome":"ok","rejected":0,"shells":1,"steps":["box","fillet","cut sphere","circular pattern","rectangular pattern","cut sphere"],"unsupported":0,"volume":24743.737783}, + "55": {"area":6795.599353,"bodies":1,"edges":60,"error":null,"faces":23,"outcome":"ok","rejected":0,"shells":1,"steps":["box","fillet","cut sphere","circular pattern","rectangular pattern","cut sphere"],"unsupported":0,"volume":24743.500149}, "56": {"area":4453.31728,"bodies":1,"edges":33,"error":null,"faces":13,"outcome":"ok","rejected":0,"shells":1,"steps":["box","cut box","chamfer"],"unsupported":0,"volume":11829.375}, "57": {"area":4671.095724,"bodies":1,"edges":66,"error":null,"faces":24,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","cut sphere","circular pattern","chamfer","cut sphere","cut sphere","cut cylinder"],"unsupported":2,"volume":16017.21038}, "58": {"area":4197.049258,"bodies":1,"edges":42,"error":null,"faces":16,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","fillet","cut sphere"],"unsupported":0,"volume":12543.173591}, "59": {"area":7770.5632,"bodies":1,"edges":36,"error":null,"faces":15,"outcome":"ok","rejected":0,"shells":1,"steps":["box","join box","join cylinder"],"unsupported":0,"volume":29735.209746}, "60": {"area":3443.328607,"bodies":1,"edges":39,"error":null,"faces":15,"outcome":"ok","rejected":0,"shells":1,"steps":["revolved section","cut sphere"],"unsupported":0,"volume":11779.204543}, - "61": {"area":5020.413153,"bodies":1,"edges":36,"error":"boolean Cut: the operation failed: no result","faces":15,"outcome":"failed","rejected":0,"shells":1,"steps":["extruded profile","cut cylinder","shell","rectangular pattern"],"unsupported":0,"volume":4906.628538}, + "61": {"area":5020.412837,"bodies":1,"edges":36,"error":"boolean Cut: the operation failed: no result","faces":15,"outcome":"failed","rejected":0,"shells":1,"steps":["extruded profile","cut cylinder","shell","rectangular pattern"],"unsupported":0,"volume":4906.555871}, "62": {"area":8771.003732,"bodies":1,"edges":60,"error":null,"faces":23,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","cut cylinder","circular pattern","cut box","cut box","join cylinder"],"unsupported":2,"volume":40107.001728}, "63": {"area":4316.842909,"bodies":1,"edges":100,"error":null,"faces":38,"outcome":"ok","rejected":0,"shells":3,"steps":["revolved section","join box","cut cylinder","hole","cut cylinder","join box","rectangular pattern"],"unsupported":3,"volume":8229.233195}, "64": {"area":4088.335645,"bodies":1,"edges":36,"error":null,"faces":14,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","fillet","join cylinder"],"unsupported":0,"volume":8495.235267}, @@ -87,7 +87,7 @@ "83": {"area":8632.834978,"bodies":1,"edges":95,"error":null,"faces":35,"outcome":"ok","rejected":0,"shells":2,"steps":["box","join box","rectangular pattern","shell","cut sphere","join box","fillet"],"unsupported":2,"volume":6339.218896}, "84": {"area":4906.192237,"bodies":1,"edges":67,"error":null,"faces":25,"outcome":"ok","rejected":2,"shells":1,"steps":["extruded profile","fillet","hole","hole","cut cylinder","cut box","fillet"],"unsupported":0,"volume":14219.865875}, "85": {"area":3309.210936,"bodies":1,"edges":57,"error":null,"faces":24,"outcome":"ok","rejected":1,"shells":2,"steps":["revolved section","fillet","cut sphere","circular pattern","join cylinder","hole","join box"],"unsupported":0,"volume":6904.455565}, - "86": {"area":7580.468361,"bodies":1,"edges":66,"error":"offset: a corner whose faces don't meet the same way after t","faces":30,"outcome":"failed","rejected":0,"shells":3,"steps":["extruded profile","join cylinder","join cylinder","circular pattern","hole","rectangular pattern","shell"],"unsupported":1,"volume":20437.482684}, + "86": {"area":7580.468361,"bodies":1,"edges":66,"error":"offset: a corner whose faces don't meet the same way after t","faces":30,"outcome":"failed","rejected":0,"shells":3,"steps":["extruded profile","join cylinder","join cylinder","circular pattern","hole","rectangular pattern","shell"],"unsupported":1,"volume":20442.860492}, "87": {"area":4853.708989,"bodies":1,"edges":24,"error":null,"faces":10,"outcome":"ok","rejected":0,"shells":1,"steps":["extruded profile","cut box","rectangular pattern"],"unsupported":0,"volume":18568.611108}, "88": {"area":3947.799648,"bodies":1,"edges":18,"error":null,"faces":8,"outcome":"ok","rejected":0,"shells":1,"steps":["box","hole"],"unsupported":0,"volume":12788.04706}, "89": {"area":2512.5,"bodies":1,"edges":12,"error":null,"faces":6,"outcome":"ok","rejected":0,"shells":1,"steps":["box","cut box"],"unsupported":0,"volume":5906.25}, @@ -146,6 +146,7 @@ {"reason":"A join whose coincident faces were pushed apart now trims the slab beyond the plane by editing faces when the boolean cut of it fails (a prism whose edge in the plane lies in the end face of a slab with rounded corners). Seed 70: the shell of a body in two lumps, refused before, now builds; its volume matches an independent offset of the profile (4120.90 vs 4120.67 mm3, the gap is the unshelled profile's own tessellation).","seeds":[70]}, {"reason":"#1648: a face whose boundary touches itself within the tolerance is triangulated through the touching point instead of across the face, so faces that meshed with triangles missing or outside them now mesh whole. Seeds 20 and 55 build the same designs (same steps, faces, edges and shells); only the measured area, and for seed 55 the volume, of their final bodies move. Seed 55: replaying it with the old and the new triangulation gives the same final body; two curved faces measured 442.14 and 325.42 mm2 with the old triangulation at a fine tolerance, 436.29 and 305.83 mm2 with the new one, which agrees with their coarser meshes, and its volume moves from 24740.93 to 24744.18 mm3, against 24743.58 mm3 from a mesh at 1e-4 mm. Seed 20, as main now builds it, moves only in area, from 5726.92956 to 5727.102692 mm2 (3e-5 relative). Recorded from the fork CI output (Linux).","seeds":[20,55]}, {"reason":"A cut no longer comes out empty where a shell of one body meets nothing of the other (a sealed void, a body clear of the tool): truck placed such faces by their surfaces alone, which a turned body's reversed faces and a void's inward shell got wrong. Seeds 0, 45 and 77 each had a cut refused as empty that now takes what it should, and the generator builds different steps after it: seed 0 a sphere clear of the body (removes nothing), seed 45 a hole on the axis of a shelled turned body (widens its bore from r 2.5 to r 4 over 17.5 mm: 536.0 mm3), seed 77 a hole inside a turned body's bore (removes nothing; a later pattern copy drills r 1.5 through 27.5 mm: 194.4 mm3). Every step passes the validity and volume-direction checks.","seeds":[0,45,77]}, - {"reason":"Trimmed faces of display meshes stay on their surfaces (#1653): seeds 1, 23, 55, 64 and 86 end with bodies whose trimmed faces were meshed off their surfaces; measured on the corrected meshes their area and volume move slightly (seed 86 most: area +9.6 mm2, volume -41.4 mm3, 0.2 %). Steps, outcome and counts are unchanged; recorded from Linux CI on main at the time of the rebase. The slow seeds 14, 20 and 40 (run only by the merge queue) move too: 14 area +0.92 mm2 / volume +2.64 mm3, 20 area +2.60 mm2 / volume +14.8 mm3, 40 area +0.61 mm2 / volume -2.25 mm3, from merge-group run 39450833424.","seeds":[1,14,20,23,40,55,64,86]} + {"reason":"Trimmed faces of display meshes stay on their surfaces (#1653): seeds 1, 23, 55, 64 and 86 end with bodies whose trimmed faces were meshed off their surfaces; measured on the corrected meshes their area and volume move slightly (seed 86 most: area +9.6 mm2, volume -41.4 mm3, 0.2 %). Steps, outcome and counts are unchanged; recorded from Linux CI on main at the time of the rebase. The slow seeds 14, 20 and 40 (run only by the merge queue) move too: 14 area +0.92 mm2 / volume +2.64 mm3, 20 area +2.60 mm2 / volume +14.8 mm3, 40 area +0.61 mm2 / volume -2.25 mm3, from merge-group run 39450833424.","seeds":[1,14,20,23,40,55,64,86]}, + {"reason":"measure (#2069): a body whose meshes leave a crack is summed about its box's centre instead of the origin, so the crack is closed by a cone to a point inside the body. Seeds 14, 20, 40, 55, 61 and 86 end with such a body; their volumes move from main's by -0.52 %, +0.11 %, -0.017 %, -0.001 %, -0.0015 % and +0.026 %. Steps, outcomes, counts and areas (to 3e-7 relative) are unchanged. Recorded on Linux.","seeds":[14,20,40,55,61,86]} ] }