Render output: Effects and Check sections, Size presets panel and the Check chip (#6281) (#7233)

* Render output: Effects and Check sections, Size presets panel and the Check tool chip

* Render output: Sampling, Effects and Check editors as child rows under Output

* fix: restrict legacy Output controls to test builds

* fix: cover status controls and reveal Effects test targets

* fix: include shared quality reviews in copied check reports

* fix: remove the obsolete Effects GPU guard after Wear integration
This commit is contained in:
Nathan Dane
2026-10-29 04:39:34 +00:00
committed by GitHub
parent c1925bb219
commit bd8cb4e6d6
23 changed files with 2149 additions and 418 deletions
+27 -14
View File
@@ -119,16 +119,16 @@ anisotropy, area lights and spot cones remain API capabilities without panel edi
Its independent image device requires Vulkan; the live viewport may use another backend.
When no compatible Vulkan device is available, GPU settings remain editable and
saveable, while Check and Start explain why GPU execution is unavailable.
The panel exposes progressive sample counts from 1 to 4096 and an Advanced section
for maximum path depth (1–16), random seed and exposure (−32 to +32 EV). One setup
Sampling > Path tracing exposes progressive sample counts from 1 to 4096,
maximum path depth (1–16) and random seed. Exposure (−32 to +32 EV) lives in Shot. One setup
exposure field controls the selected image method. Switching methods retains their
local numeric drafts while submitting and saving only the active method. Reloading
or choosing another setup replaces those drafts with the saved numeric intent.
The live product preview keeps its fixed studio response and does not apply image
exposure, environments, lens or material overrides.
The GPU Advanced section also exposes Reinhard / ACES fitted tone mapping, optional
final edge-aware denoising, and a thin-lens depth-of-field control. Positive aperture
Effects > Tone exposes Reinhard / ACES fitted tone mapping. Sampling > Path tracing
owns optional final edge-aware denoising; Shot owns thin-lens depth of field. Positive aperture
requires a perspective product camera. Denoising preserves raw accumulation but can
soften detail; glass and sharp specular first hits bypass its final spatial filter.
@@ -493,17 +493,30 @@ remains deferred.
The Output stage offers size, format, quality and a Check summary in the stage bar's
second row. Its lower-left Size presets card offers Preview (1280 × 720), Full HD,
4K, Square and Custom. Presets outside the selected executor's limits stay visible
with a disabled explanation. Custom retains the current size and reveals its fields.
Numerical size edits and presets use `render.output.size`; they never save a shot
or start a job.
with a disabled explanation showing the selected method's dimension/pixel limits and
largest fitting size. The default raster limit is 4,194,304 pixels, so 4K exceeds it;
methods with larger resource profiles can admit 4K. Custom retains the current size
and reveals its fields through `render.output.size`. Numerical size edits and preset
clicks patch width and height with `render.settings.set`, as one undo step. Opening
the panel never applies a preset or starts a job.
Selecting Output in the Browser shows one editor with Image, Effects and Check
sections, without page navigation or pinned job actions. Image retains size/aspect,
format, sampling, method, transparency and export destination controls. Effects owns
tone, bloom, grading and regrade. Check retains the preflight list, freshness checks,
installed backend/status metadata and expandable diagnostics. Named quality presets
and EXR settings remain unavailable with their existing reasons. Destination selection
uses the existing completed-image export picker.
Selecting Output in the Browser shows a short editor with Renderer, Image,
Destination and Render sections. Sampling, Effects and Check are child rows under
Output, each with a summary and its own editor. Sampling owns Quality, GPU Path
tracing, Adaptive, Glass transport and CPU ray tracing. Method-specific controls
stay visible and faded with their reason on other methods. Effects owns Tone,
Creative looks, Lens effects, Finishing and Regrade, in that order; its controls
need GPU path tracing. Effect edits patch the saved job with `render.settings.set`;
opening an editor never saves or switches methods. Check owns the preflight notes,
This request, Renderers and collapsed Under the hood diagnostics. The legacy
Effects, Output and Diagnostics pages call the same editors.
The stage bar's Check chip and Output's note count open Check. Check now runs the
read-only `render.preflight` without admitting a job. Notes offer links to their
owning editor. Copy report and diagnostic JSON use `render.preflight.copy` and the
platform clipboard queue; headless calls only validate and echo bounded text.
Named quality presets, EXR export and rendering all shots remain faded with their
existing reasons. Destination selection uses the completed-image export picker.
Render and Cancel stay in the stage bar. Active jobs also show a single-row progress
pill with Cancel. The result viewer retains Copy, export, close, Fit/100% and shared
+5
View File
@@ -7,6 +7,11 @@ The row keeps supplied order and anchors to the top centre of the free viewport.
Its presentation state only remembers which key card is open. The `ui.status_fixture`
control method provides named specimens for UI scenarios and live visual review.
| Component | Use |
| --- | --- |
| `method_section` | Section with a GPU/CPU tag; unsupported contents stay faded with a readable reason. |
| `read_only_text` | Bounded, selectable code box for read-only diagnostic JSON. |
`crates/ui-egui/src/ui_kit/` contains the tokenised controls used by feature dialogs,
preferences, manager cards, prompts, context menus and the sketch palette. Import through
`crate::ui_kit::{...}`. Most controls are crate-visible; the container API is public so platform apps use the same hosts.