Layer split stage 1: the B-rep record, native body file and Vec/Plane come from solidcore-record (#11496)
* Kernel: the B-rep record and the native body file come from solidcore-record SolidCraft's portable B-rep record (`solidcraft_geom::brep`: brep.rs, topology, history, envelope, part, curve2) and the native body file (`solidcraft_kernel::native`: the tagged binary codec and the container) move to solidcore's `solidcore-record` crate: geometry as data, with structural validation and no maths (solidcore's docs/layers.md, stage 1). Every caller uses `solidcore_record::brep` and `solidcore_record::native`; the old copies are deleted. What computes from coordinates stays with the kernel, in geom's `brep`: - `brep::check`: the record's geometric checks (orthonormal frames, non-degenerate planes, unit revolution axes, non-singular placements). `check::validate` and `check::validate_built` are the record's validation and these together, and every caller of `Brep::validate` uses them, so what is accepted is unchanged; - `brep::label`: a surface's natural ranges (a cone's apex), `curve_interval`, `edge_curve_interval` and `form_turns`; - `brep::pcurve::eval`: a pcurve's point; - `geometry::check`, `placement::moved` and `split_edges` become functions on the record. The kernel's native module keeps the conversion between a body and its saved record (metadata.rs) and checks the decoded record's geometry. `native/analytic.rs`, which no module declared, is deleted. solidcore-record is pinned to its rev on solidcore's `layer-record` branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Geometry: Vec2, Vec3, Plane and the profile types come from solidcore-record The plain data of vectors and points, sketch planes and planar profiles (`Seg2`, `Loop2`, `Region2`) moves to `solidcore-record`, with its constants and component-wise operators only (owner decision, solidcore layer split). Their geometry stays in geom as traits: `Vec2Geom`, `Vec3Geom`, `PlaneGeom`, `Seg2Geom`, `Loop2Geom`, `Region2Geom`, `Seg2ArcFit`, `Loop2ArcFit` and `Region2ArcFit`, in scope with `use solidcraft_geom::prelude::*`. Every caller names the types from `solidcore_record`; geom no longer defines or re-exports them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Kernel: pin solidcore-record to solidcore main f5e8e9a29 solidcore-record is merged on solidcore main (tangency-labs/solidcore#2519); its crate there is identical to the rev pinned before but for its clippy configuration. The lock is regenerated against the merged rev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -16,7 +16,7 @@ The pictures live on the `pr-media-kernel-smlib` branch.
|
||||
- edges with intervals, and vertices;
|
||||
- tolerances per body, per edge and per vertex.
|
||||
|
||||
Names follow STEP's B-rep vocabulary. Analytic curves and surfaces are unbounded; their bounds live in the edge interval and the face domain. A validator enforces one **canonical order** of faces, edges and vertices, which persistent names depend on. The history types moved beside it, to `solidcraft_geom::brep::history`. The contract is in docs/native-brep.md and tangency-labs/solidcore#342.
|
||||
Names follow STEP's B-rep vocabulary. Analytic curves and surfaces are unbounded; their bounds live in the edge interval and the face domain. A validator enforces one **canonical order** of faces, edges and vertices, which persistent names depend on. The history types moved beside it, to `solidcore_record::brep::history` (solidcore's record crate). The contract is in docs/native-brep.md and tangency-labs/solidcore#342.
|
||||
|
||||
truck bodies round-trip through schema 4 exactly, and the model cache stores it. Every corpus design, sample and imported assembly reopens from the cache with bit-identical volumes, areas and face names:
|
||||
|
||||
|
||||
+4
-3
@@ -1,7 +1,8 @@
|
||||
# Native B-rep, schema 4
|
||||
|
||||
This is SolidCraft's geometry data model in `solidcraft_geom::brep`. It has no
|
||||
modelling-backend dependency. It is the body encoding of a design's model cache
|
||||
This is SolidCraft's geometry data model in `solidcore_record::brep` (solidcore's
|
||||
record crate: geometry as data, no maths). It has no modelling-backend dependency;
|
||||
its geometric checks and evaluation are the kernel's (`solidcraft_geom::brep`). It is the body encoding of a design's model cache
|
||||
([the container format](design-container.md#model-cache)); it is not a STEP
|
||||
replacement for external interchange. The container reader, binary codec and
|
||||
kernel adapters are separate layers. The truck adapter writes it exactly: a body
|
||||
@@ -260,7 +261,7 @@ and one fixture per defect, without a kernel.
|
||||
## History
|
||||
|
||||
The runtime history types (`FaceOrigin`, `Change`, `FaceProv`, `Side`,
|
||||
`EdgeOrigin`, `EdgeProv`, `History`) live in `solidcraft_geom::brep::history`, so
|
||||
`EdgeOrigin`, `EdgeProv`, `History`) live in `solidcore_record::brep::history`, so
|
||||
a backend can report history without the kernel crate. Indices are canonical face
|
||||
and edge indices; operands are numbered by each operation. An operation returns
|
||||
history beside the B-rep. A backend that cannot report it returns none and never
|
||||
|
||||
Reference in New Issue
Block a user