main
450 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
ee02080a25 |
Two-distance chamfers of free-form rims: a test on the SMLib kernel (#4332) (#4333)
* claim: #4332 * Two-distance and distance-angle chamfers of free-form rims: a test on the SMLib kernel (#4332) A spline, Bézier or text outline's rim used to be refused by the two-distance and distance-angle chamfers. The SMLib kernel (#11351) chamfers it along the rim; this test pins that down on a four-Bézier oval, picked as its tangent chain the way a pick takes it: the volume taken off is the analytic one for two distances (both ways round) and for a distance and an angle. |
||
|
|
fabeaa329a |
Desktop app: closing a design stops its kernel work, and designs build the same on any kernel (#11771)
* Desktop: closing a design stops its kernel work; same result on any kernel A design's jobs now run under a stop token that closing or replacing the design fires: an operation under it refuses to start, and one running ends at solidcore's next check. The kernel it ran on is not used again. Calls that answer from a body itself always finish, since a stopped call can leave what it borrows half-changed, and what fills a body's shared cells is not stopped. Every kernel call starts clean (the same random rays, no stations from earlier calls), so a design builds the same on any kernel of the pool, down to its B-rep records. The pool is bounded: at most 8 kernels wait between calls, and at 256 running calls a new call fails rather than grow or wait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Stop tokens: a copy never stops its design; a stopped job can't decide a refusal A copy replacing its own design stopped the token it shares with the design it came from, so that design's later work would be refused. Only the design itself stops it now. Which face a refusal names no longer depends on whether the job that found it had been stopped: the refusal is kept with the body, and a stopped job's probes were all refused, which named the wrong face. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
f74c6605c4 |
Fillet: Mitre or Swept corners where two rounds meet (#11498)
* SMLib wrapper: a swept or mitred turn for constant rounds (Turn) Brep::blend_dropping takes a Turn: Mitre (the default, as before) or Swept, which sets solidcore's FilletSession::set_swept_turns before the corners are made. A swept turn solidcore refuses at CreateFilletCorners comes back as Error::TurnRefused with its reason and place (NoRoom at a concave side edge, else CornerUnsupported). Swept is for Blend::Round only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel: fillet rounds turn in a mitre or swept (FilletTurn) fillet_removing, fillet_max, fillet_max_each and fillet_each take a FilletTurn and hand it to SMLib, through the reblend of earlier rounds at a later corner too. A swept corner solidcore does not build is refused as invalid input with its reason and place: no smaller radius builds it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Design: a fillet saves its turn, mitre (default) or swept FeatureKind::Fillet gets `turn` (FilletTurn: mitre, the default and not saved, or swept), one pending format file. Evaluation hands it to the kernel, pattern copies included, and refuses a swept turn with a style, fit, corner or setbacks the kernel's swept corner does not take (SWEPT_TAKES). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * solid.fillet: the turn parameter, and the command's input and output schemas `turn: mitre|swept` on solid.fillet, refused when unknown or with options a swept corner does not take. solid.fillet now has its contract (FilletParams) and reply type (FilletResult), registered with checked!, and leaves schema/unconverted.txt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Fillet dialog: a Turns choice, Mitre or Swept A Constant radius fillet's Turns row sends `turn: swept`; choosing a narrowed radius or a curvature corner puts it back to Mitre, and Swept puts those back. Its tooltip says what each does where two rounds turn round a corner edge. New strings in a pending locale file (en, de, ja, ko, zh); glossary entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Fillet turn: the schema tests' fixes and the complete catalogs' strings The no-contract example in the schema tests is solid.chamfer now that solid.fillet has one; the reply test checks the mid-radii form against the contract (solidcore refuses that law's corner yet, #430) instead of building it; Arabic, Hebrew and Vietnamese, complete catalogs, get the new strings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Fillet schema test: variable and spline forms checked against the contract solidcore fails a variable round on a box edge at this pin (status 1001, as variable_radius_on_a_box_edge), so the reply test checks those forms against the contract instead of building them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Fillet turn: the swept rig cases pass; the MCP no-contract example is solid.chamfer cov-fillet-turn-swept-boss-base-r1 and cov-fillet-turn-swept-pocket-sharp-corner-refused-r1 pass now that solid.fillet takes `turn`: off the rig's known-failing list. The MCP bridge test's example of a command without a contract was solid.fillet, which has one now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e12afd11cc |
Ellipse and spline extrudes make one wall; coplanar faces never lose their names to a budget (#11687)
* Planar sources: decide coplanar faces by support group, no budgets that drop sources map_planar_sources kept two budgets, `metadata` (2 MB) and `identity_bytes` (16 MB), charged by each face's source descriptor and by every extra candidate on its plane. When one ran out, faces silently lost their source and with it their persistent name: a 300-hole plate whose top a comb of grooves cuts into 62 strips lost the cap source from strip ~47 on. The budgets bounded the real cost: each result face looked at every candidate on its plane, faces x candidates when many faces are coplanar. The candidates are now grouped by support once (`same_support` against each group's first plane, through the existing PlaneIndex), each group's chosen source, ambiguity and inner flag decided once, and the faces without a role together with the competing tool faces grouped the same way. Each result face then looks up its plane's few groups. The decision is the old one: blocked by an unknown or competing support, else the first candidate on the plane unless another candidate there has a different plane, source or role. Work: grouping looks at each candidate's index window once per group (each candidate is assigned on its group's first look), and each face looks at the group representatives near its plane, so the planes looked at grow with faces + candidates. A counter (`looked`) checks it: n pieces of one cap and n faces on its plane take exactly 2n looks (n*n before), 3n with n blocking supports. Tests: the holed plate keeps the cap source on all 62 strips and the bottom (fails on the old code: face 352 lost its source); the existing planar source tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Extrude: an ellipse or a spline sketch curve sweeps one wall An extruded ellipse had four side faces (`F2:side:e1#1` to `#4`), one per conic quarter, and a spline one per span: the profile holds such a curve as several exact segments and SMLib got each as its own curve. The Extrude feature's builder (`extrude_whole_sides`) now takes a `one_curve` test from the caller. Each run of free-form segments of one degree that it says are one curve goes to SMLib as one B-spline: the Béziers' control points in a row, knots repeated the degree times at each joint, each span as long as keeps the speed through the joint the same (so the curve is C1 there and SMLib makes one face over it, as it would not over a C0 parametrisation), weights scaled to meet. Exact: the same curve, reparametrised. A loop starts at a run's start, so no run wraps round it. The wall's history lists every piece, and its construction source is its first piece's (as joined collinear lines). The document says which segments are one curve: ExactSketchCurves now also holds each free-form sketch curve's exact segments (`find_free_form`: a segment that is one of them, either way round), and the profile roles use it, so the wall is named `side:<curve>` from its history rather than by the curve nearest its mesh centre. Saved designs rebuild with these walls renamed (`F2:side:e1#k` -> `F2:side:e1`); accepted, no alias kept. Tests: kernel `pieces_of_one_curve_extrude_into_one_wall` (an ellipse in four conics is 3 faces, its volume pi a b h to 1e-6, the wall generated by all four pieces; a 3-span spline closed by lines is one wall; the same solid as a face per piece); doc `an_extruded_ellipse_or_spline_is_one_wall_named_by_its_curve` (one `F2:side:e1`, no piece names, the same names on a second build and after reopening). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Tests: a tray's far rim name is checked on the exact B-rep face The tray test took the point `sheet:...:rim.far` finds as right when it lay within 1e-3 mm of the strip z = 30, 199 <= y <= 200: a slack sized to the mesh. It now asserts on the face the name finds, on exact geometry: the point's distance to that face's surface (FaceSurface::nearest) is within rounding at the part's scale (1e-12 x its size), and the point is inside the face's boundary, counted by crossings of its record edges (each asserted to be a line, the rim being planar). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Tests: delete tests/naming/, the records no test reads since the naming corpus stopped comparing against them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Viewport test: smooth wall joins drawn from eight G2 spline walls The PR extrudes each spline or ellipse sketch curve as one wall, so the offset-ellipse ring the test built has no joins between faces any more. The test now extrudes a circle drawn as eight cubic splines: eight walls meeting with one curvature along eight upright edges (24 edges in all). It still checks that those joins are left out of the shaded view, drawn in the wireframe and selectable as edges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel ladder: 009 and 012 record the one-wall extrude (an extruded spline or ellipse sweeps one wall) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
dc38349cbf |
Layer split stage 1: the B-rep record, native body file and Vec/Plane come from solidcore-record (#11496)
* Kernel: the B-rep record and the native body file come from solidcore-record SolidCraft's portable B-rep record (`solidcraft_geom::brep`: brep.rs, topology, history, envelope, part, curve2) and the native body file (`solidcraft_kernel::native`: the tagged binary codec and the container) move to solidcore's `solidcore-record` crate: geometry as data, with structural validation and no maths (solidcore's docs/layers.md, stage 1). Every caller uses `solidcore_record::brep` and `solidcore_record::native`; the old copies are deleted. What computes from coordinates stays with the kernel, in geom's `brep`: - `brep::check`: the record's geometric checks (orthonormal frames, non-degenerate planes, unit revolution axes, non-singular placements). `check::validate` and `check::validate_built` are the record's validation and these together, and every caller of `Brep::validate` uses them, so what is accepted is unchanged; - `brep::label`: a surface's natural ranges (a cone's apex), `curve_interval`, `edge_curve_interval` and `form_turns`; - `brep::pcurve::eval`: a pcurve's point; - `geometry::check`, `placement::moved` and `split_edges` become functions on the record. The kernel's native module keeps the conversion between a body and its saved record (metadata.rs) and checks the decoded record's geometry. `native/analytic.rs`, which no module declared, is deleted. solidcore-record is pinned to its rev on solidcore's `layer-record` branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Geometry: Vec2, Vec3, Plane and the profile types come from solidcore-record The plain data of vectors and points, sketch planes and planar profiles (`Seg2`, `Loop2`, `Region2`) moves to `solidcore-record`, with its constants and component-wise operators only (owner decision, solidcore layer split). Their geometry stays in geom as traits: `Vec2Geom`, `Vec3Geom`, `PlaneGeom`, `Seg2Geom`, `Loop2Geom`, `Region2Geom`, `Seg2ArcFit`, `Loop2ArcFit` and `Region2ArcFit`, in scope with `use solidcraft_geom::prelude::*`. Every caller names the types from `solidcore_record`; geom no longer defines or re-exports them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT * Kernel: pin solidcore-record to solidcore main f5e8e9a29 solidcore-record is merged on solidcore main (tangency-labs/solidcore#2519); its crate there is identical to the rev pinned before but for its clippy configuration. The lock is regenerated against the merged rev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9c65a30265 |
Kernel rig: export each case's kernel operations as a corpus for solidcore's rig
`cargo xtask kernel-cases [--ladder] --export DIR` runs the rig with the kernel's operations traced (`smlib::trace`) and writes one entry per case: the operation, or chain of operations, that made the bodies the case ends with; each operand that came in as a record, as that record; the parameters, with every pick by points also given as the topology index it picked; the fix set; the case's expected values and the rig's result. A case no kernel operation alone accounts for is written too, marked not expressible with its reasons. DIR/manifest.json counts them per area. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
55a5f86e2e |
Kernel test: the 851 middle point's y written at f64's shortest digits (clippy excessive_precision)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
47c685d471 |
rustfmt on the pin's changes
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
c7c28515ce |
Kernel test: the tabbed plate's rim and corner arc take off the rim's closed form
The rim alone was pinned to 7.958674274526857, the marched end rib's value; its closed form, the spandrel (1 - pi/4) r^2 revolved about the disc's axis outside |x| < 4, is 7.958672911836132, which the rim's End (fillet_blend_corner) builds to 5e-8. With the corner arc's Pappus volume the two take off 8.117808752; solidcore 8ddce9016 removes 8.117808800. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
ac3e6e0105 |
A panic solidcore's guard catches reaches the engine as EngineError::Internal
smlib's run() catches a solidcore panic and replaces the kernel (kept: the app does not die natively), returning Error::Internal; the kernel turned it into KernelError::Failed and the engine into Other, so hostile_params_never_panic and the fuzzer no longer saw kernel panics. Now the kernel's wrapper errors go through KernelError::smlib, which keeps Internal; a body the wrapper could not take because of a panic is Internal too. A feature whose evaluation hit it records the result as internal (not cached: the kernel was replaced), and the command that made it, or any command whose kernel call returns it, fails with EngineError::Internal under its own id. Crash reports mark a panic inside a solidcore call recovered (kernel::guarded), and the crash test's kernel mode panics inside a solidcore call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
440fdaed13 |
Kernel work runs on threads with solidcore's 8 MiB stack
solidcore's algorithms recurse (subdivision, intersection, filleting) and its README asks for 8 MiB, a native main thread's stack; Rust starts other threads with 2 MiB, and only the web build set more. kernel::KERNEL_STACK is 8 MiB and kernel::kernel_thread a thread builder with it. The kernel's parallel map runs on a pool of its own with that stack (on a worker of a pool already, as in map_with_local_pools, it stays on that pool as before), the one-thread mesh pools and map_on_threads' helpers have it, and so do the engine's interference worker and the evaluator's plan-mesh thread. A test recurses 5 MiB deep on each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
ae45cc6623 |
smlib and kernel: solidcore's refusal reasons carried through as typed errors
A shell, offset or thicken solidcore's one construction refuses because a face's offset folds (SolidError::ShellRefused, ShellRefusal::Fold) is Error::WallFolds with the largest wall it names; the kernel says "the wall is thicker than a face curves, so the face's offset would fold; the largest wall that works is 10 mm". A blend too large carries solidcore's NoRoomReason as Error::TooLarge's RoomReason, worded in its message before the largest size that fits: a collapsed offset (solidcore#2431) says the ball is as wide as the face it rolls on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
a3f06a4f94 |
Tests: a wall that folds names the largest wall that works, a collapsed offset says why
A thicken of solidcore#2350's parabolic sheet past its apex's radius of curvature is refused by solidcore's one construction (ShellRefused, Fold, naming 10); the wrapper passed it on as "solidcore: ..." with no words of its own. A round at the radius of the round it rolls on beside the 851 part's arc wall is refused as a collapsed offset (NoRoomReason::OffsetCollapses, solidcore#2431); the message named the size but not why. Both fail until the reasons are carried through. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
8a730c6273 |
Fillets on solidcore: the largest size that fits is still the one the search builds; the kernel's names the edge
solidcore's fit is the largest size less a margin (34.99 where the L bracket's bend builds 35, 4.29 where #3435's ring builds 4.3), so the feature's search keeps naming the size, and solidcore's is the answer only where the search finds none. The refusal keeps its words, "larger than the faces beside its edges allow", with the edge after them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz |
||
|
|
881899bee1 |
Fillets on solidcore: a blend too large names the largest size that fits and its edge, from the kernel; the crossing-rails mixed corner is not supported (solidcore#2256)
solidcore sizes a blend it refuses as too large (the session's fit, SolidError::FilletRefused under fillet_gn_section_generator). The smlib crate gives it as Error::TooLarge with the size, what it sizes and a point halfway along its edge (an equal chamfer's ball radius turned back into its distance); the kernel words it as the fillet feature's search does (largest_fit_note), and the feature runs no search when the refusal names it. The 3x2 mixed corner whose rails cross, which solidcore refuses (fillet_refuse_mixed_corner_crossing_rails), is not supported yet, citing solidcore#2256. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz |
||
|
|
c5ccb9201d |
Wave 43/45: smlib: rustfmt after the C++ kernel's removal (and 1 more)
2 commits, squashed; the originals stay reachable from branch jyviko/merge-main-develop-solidcore (#11360). - 19db2d7c0 jyviko: Docs and comments: solidcore is the kernel - f1ee045de jyviko: smlib: rustfmt after the C++ kernel's removal Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
28e983e191 |
Wave 39/45: diagnostics.kernel takes a typed contract, as main's other diagnostics commands do
1 commits, squashed; the originals stay reachable from branch jyviko/merge-main-develop-solidcore (#11360). - 7ad1d3e12 jyviko: diagnostics.kernel takes a typed contract, as main's other diagnostics commands do Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ |
||
|
|
ea772a0438 |
Merge develop into main: SolidCraft on the SMLib kernel (v1.1.0-alpha) (#11351)
* UI: rim and wall picking tests for a circle of arcs that is one wall A circle drawn as two half arcs now extrudes to one full-turn wall with its seam edge, and each rim is one closed edge (tangency-labs/smlib#67). The tests keep their intent on that body: a rim clicked once is one item, measured and highlighted whole and picked from either side; a wall picked either side of its seam is the same surface, lit whole, and toggles off from the other side; every face is its own patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillets: a later round at a corner where earlier rounds meet blends them again with it The owner's ruling of 2026-10-30: a later fillet on an edge at a vertex where earlier rounds already meet in a mitre makes the corner rounding all of them at once makes, one smooth patch, the mitre gone. A body made by constant-radius rounds keeps what they were made on and which edges they rounded at which radius; a later round reaching such a corner blends the earlier rounds' edges (from the earliest of those meeting there on) with the new edges in one SMLib blend of the body before them. The result's history is put over the body the later round was given: an earlier round's face is that face trimmed anew (its name kept), the corner patch and the new rounds are the later fillet's. A picked mitre seam has no round of its own: it is refused unless a new edge of its radius meets it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: a later r3 round at an r2 mitre, through the Fillet feature, makes the all-at-once corner Two box edges rounded r2 in one fillet, then the upright edge at their mitre r3 in a second fillet (tangent chain on, so the seam comes with it): 10 faces, 7928.743041 mm³ as fillet_radii of the box gives, the r2 rounds' names kept, the r3 round and the corner patch the second fillet's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel: a body's record of rounds goes with its history, and can be read back The rounds that made a body are over the body its history is over: a new history (an operation carrying a step's result back to its own operands) leaves the record out, so a later round never reads one history against another body. Body::rounds gives the record and Body::with_rounds_of takes one back, checked (edges of the body before them, a fillet's radii, the body's history over that body), for a saved model to keep it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Model cache: a body made by rounds keeps them, so a later round blends them the same after opening A design gave another body when opened from its model cache: the rounds a body was made of lived only in memory, so a later round at their mitre was built sequentially (or refused, as too large) after opening and blended with them when evaluated anew. The saved model now records, per kernel body made by rounds, the body they were made on (a place in the bodies, stored once though no state holds it) and the edges with their radii; reading it attaches them back down each chain, and a thinned model keeps those bodies with the bodies made from them. Model cache format 7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: a corner patch of rounds 2/3/4 takes no more than the strips leave in its block three_rounds_at_a_corner bounded the patch's extra cut at 3 mm³ beyond the strips, a figure with no derivation; SMLib's all-at-once body at radii 2, 3, 4 takes 3.099 (V 7878.579574 against strips 7881.678). That body is the strips' outside the block its patch lies in: its rounds are the strips' cylinders ending at a's section y = rc, b's x = 20 − rc and c's rails where they meet a's and b's (the patch's four corners, now asserted), so the patch takes at most what the strips leave in that block (11.86 at 2/2/3, 32.69 at 2/3/4). The lower bound is that block; the upper one, at most the strips' volume, stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: the io crate's hand-built saved models list their rounds, as format 7 records do Model cache format 7 (f3cf0c4f3) records a `rounds` list in every saved model, and reading one without it is refused ("saved model: rounds"), as is a model without any of its other lists: the states, the preview and the thinned model all came back empty. The io tests' saved_model and timeline_model wrote format-6 records, so six tests (the round trip, the repeated part stored once, and the four too-big-for-the-file cases) read nothing. Their bodies are none made by rounds: the list is empty, and every expectation stays as it was. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * SMLib: pin eaa998a (tangency-labs/smlib#68, #69, #70) Batch 4: drafts and loops, mitre corners, rim chamfers, rulings, tight box, stitch, point classification, eased corners. Batch 5: a face's tight box divides its cells at the surface's knots (thread boxes exact); a cylinder, cone, sphere or torus is extended along its own circles. Batch 6: a revolution's extension closes its turn; a dropped point's foot is the converged one. The C API is ABI 5 (smlib_blend_dropping and smlib_brep_classify_point are new; nothing existing changed), so the binding expects 5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: a strip's tangent and curvature run-offs are the distance long across the surface SMLib measures an extension's distance across the surface (smlib_extend_sheet corrects CreateExtendedSurface until the parameter line through the side's middle is that long), so each run-off of the cylinder strip, swept 20 along z, adds 5 x 20: 10 pi/2 20 + 100 = 414.159 for both. The parabola-length formula (418.18) was truck's. Ruling d2 (2026-10-30). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * kernel: one smooth angle, and a round too small to change the part is refused The blend's tangent angle is the shaded view's half degree (smooth_edges::ANGLE), one value for smooth. A constant round lies r (sec(d/2) - 1) inside the crease it replaces (about r d^2/8); below the edge's tolerance it changes nothing and is refused before SMLib (which answered SM_ERR_INVALID_INPUT), naming the smallest radius that rounds, tolerance / (sec(d/2) - 1). d is the least turn along the edge (tangent_edge::least_angle_along, at tangent_all_along's stations). Ruling d3 (2026-10-30). The block's tolerance is 2e-5 mm, not 0.1 um: at 1 deg the smallest radius is 0.526 mm, so R2 and R20 reach SMLib, which still calls an edge within 2 deg smooth (SmEdge::GetBlendEdgeuse); that test is ignored until SMLib uses 0.5 deg. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillet rig: the knife-edge chamfers name SMLib's cause, a cusp's ball radius of 0 smlib_chamfer turns the distance into a ball radius d sqrt((1 - c)/(1 + c)), c the faces' binormals' dot (capi chamfer_radius); at #851's cusp the binormals agree, the radius is 0 and the call is SM_ERR_INVALID_INPUT before the fillet executive runs (gdb: chamfer_edges sees radius 0; the dump's why is empty). SolidCraft hands every chamfer to SMLib, so the ball-contact chord (the ball of radius d: 3.822 wide at d = 2, 159.2365 removed) is SMLib's to build. Ruling d4 (2026-10-30). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * kernel tests: a corner round wider than its faces overflows and takes the corner's other edges R21 on a 20 mm cube's edge builds (6107.529370, closed form, to 2e-12). With R5 on the corner's other edges the R21 takes the faces they lie on, so the body is R21's alone; SMLib fails that blend (status 1001, fillet error 4, Unable to Trim Rail Curve) and the test is ignored until it builds. It replaces the refusal test that expected TooLarge. Ruling d8 (2026-10-30). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: a 1 degree crease rounds, and the knife edge's chamfers build, on SMLib smlib-batch-4-rulings With SMLib's smooth limit at half a degree (422e6f1) the 1 degree crease rounds R2 and R20 (the test is no longer ignored), and with a cusp's chamfer the ball of radius d (d231547) the The 0.5 one stays, for its own cause (the chamfer face left apart from the body). Two corner cases the same SMLib (replay/1.0.1 and those commits) builds come off too. Needs SMLIB_REV at that SMLib once it is pushed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * kernel, doc: an overflowing round goes first; an edge it removes is gone, and the fillet says so SMLib (smlib-batch-4-rulings 0e83cca, SMLIB_ABI_VERSION 5) rounds the edges whose rounds overflow their faces first and then what is left of the others; smlib_blend_dropping says which picks' edges the overflow removed whole. The smlib crate binds it (Brep::blend_dropping), the kernel returns those picks (fillet_removing), and a fillet notes them as its warning: "the edge at (0, 0, 10) was removed by the larger round, so it is not rounded" (a 50 x 50 x 20 block, R21 on its bottom front edge with the front left upright: the block is R21's alone, in closed form). Ruling d8: [21, 5, 5] on a 20 cube builds as R21 alone (6107.529370); the test is no longer ignored. R25 with R2 at a corner (blend_corner) builds the same way, R25's alone in closed form, where it was refused. The rig's 1080 notched block outline at R8 builds now and comes off the known-failing list. Needs SMLIB_REV at that SMLib once it is pushed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillet rig: the knife edge's 0.5 chamfer builds SMLib's trim took a fillet meeting its face at more than 78 degrees for one with no side (smlib-batch-4-rulings 971e567); the chord of the knife edge's 0.5 chamfer meets the flat face at 81 degrees. The case comes off the known-failing list. Needs SMLIB_REV at that SMLib once it is pushed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: a 15° tapered text builds, every letter grown, exact where its outline gives it Owner ruling d6: the letter t of "tres long" was drafted inward by SMLib (its loop's normal, summed from the cross products of its chords, pointed down; fixed in SMLib). With the fix every letter grows, and the join builds at 3° and 15° by the Round rule and by the default rule (tangent for spline outlines), where before 15° was expected to be refused. Exact where the outline derives it: a letter's section at height z is its outline offset by e = z tan a, by the Round rule of area A + P e + C e² while the offset trims nothing (Steiner; C half each loop's turning less tan(t/2) - t/2 at each reflex corner), so the letter is A h + P k h²/2 + C k² h³/3. Each extruded alone, the t at 3° and s, l and o at 3° and 15° are checked to 1e-6 (SMLib measures them within 1.3e-9; its mass properties integrate to 1e-8). The concave joins of r, n, g and e are tighter than e already at 3° (their swallowtails trimmed: r 1.1e-3 under the formula), the t's by 15° (9.9e-5 over), and on the block the letters grow into each other, so the whole word is checked for what holds exactly: one closed body with the block, and half-way up every point of each straight letter's outline inside the solid (the t drafted inward failed that). With SMLib's fix (smlib-batch-4-text-loops 82133b2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: a sloped basin's mitred rim rounds are checked tangent along their contact lines 1080-fillet-sloped-basin-1-mm-rim-r0-5-4-edges asked G1 at every blend seam. Its front wall leans 19 over 20 and the others 10 over 20, so at each rim corner the two mitred rounds meet the sloped corner edge at different heights (0.155625 and 0.276393 below the top): the deeper round runs on past the corner edge and is cut by the plane of the other's wall, a crease by construction, the gap below the shallower round filled on that plane. The check now measures the rounds' contact seams, on the top and on each wall, where the rounds are tangent. The volume is unchanged. With SMLib smlib-batch-4-mitre (1c15364): the case passes (V 144530.427946 against 144530.427909, 15 faces, sound); before it, only the four corner creases failed the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * smlib: Brep::classify_point says exactly where a point lies against a body Binds the fork's smlib_brep_classify_point (SmBrep::Point3DClassify at the body's own zone tolerance): inside, outside, or on the boundary within that tolerance of a face, an edge or a vertex. A box and a cylinder just off its curved wall in measure's tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs * kernel: Body::classify_point decides inside, outside or on the boundary exactly SMLib's point classification at the body's own tolerance, on the exact faces and edges, in place of a mesh at a chord of 2e-3 of the body's size (about 0.4 mm on a 200 mm part). A point within the tolerance of a face, edge or vertex is OnBoundary, never decided by a ray. A mesh body's triangles are its exact shape: on them within the record's tolerance, else by ray crossings. The kernel's own probes move to it; Body::contains goes once its last callers have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs * doc: a hole decides whether it exits at its drill point's shoulder exactly Material past the depth needs a body with the point inside, air before it needs every body to have it outside; a point within a body's tolerance of the exit face is neither. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs * engine tests: probes ask for the exact point class Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs * ui, cli tests: probes ask for the exact point class Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs * kernel: Body::contains, the mesh test, is gone Every caller asks Body::classify_point now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NvoxKQ2rEZvcXNQnhE3Sgs * kernel tests: the rim chamfers running off their rims build, on SMLib 737c392 chamfer_wider_than_sloped_basin_rim_builds and a_rim_loop_chamfer_running_off_its_rim_builds waited for SMLib to build the cliff overflow (CloseRemovalRegion refused it, SM_FILERR_NO_ROOM). The pinned SMLib builds it (eddf0ede4, bba9914b6): both pass on aarch64 Linux and are no longer ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillet rig: the cases SMLib 737c392 builds come off the known-failing list The gate on aarch64 Linux reports 16 fillet cases FIXED with the pinned SMLib: the sloped and equal-slope basin rim chamfers and rounds past their rims (1080-*, 5835-*), the pocket rim chamfer past the floor, and the three pocket rim rounds now mitred at the pocket's corners (every-pocket-*). No other area's gate reports a case fixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * kernel: the re-blend's removed picks formatted as rustfmt lays them out Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * kernel: blend_smlib laid out by the 2024 edition's rustfmt Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Skills: the tests skill's unit-test example stays under the 3600-character limit Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillet: the radius-too-large choice in plain nouns "If too large: Stop and say so / Largest that fits / Narrow where needed" becomes "Face limits: Exact radius / Largest radius / Narrowed radius", in every language of the catalog, with the error and the tip that name them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * kernel: a round that would cut through its wall into a hollow is refused The owner's rule of 2026-10-30: a round running past a rim of its faces into open air builds; one whose section would remove material through to a hollow behind its edge (a slit into the hollow, a cut through the part) is refused as too large, so the fillet names the largest radius that fits. Decided exactly in the section of a straight convex edge between planar faces: the round's centre is at depth r below both planes, and it opens where its arc uncovers a boundary point strictly inside the wedge with no material beyond it toward the centre (the body's exact point classification). Looked at: straight edges parallel to the round's (a hollow's corner), cylinders about parallel axes (a rounded corner), and a picked concave parallel edge's own round, which fills the corner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillet rig: 1668's R7 past the inside corner is refused at 4 + 2 sqrt2 The round's centre (32 - r, 42 - r) leaves the hollow's corner (30, 40) outside its circle, opening the wall, where sqrt2 (r - 2) = r: the case expects the refusal naming 6.828. 2852's R30, refused naming 25.24, now passes too: both come off the known-failing list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * xtask: known-failing grades a nextest junit report against tests/KNOWN_FAILING_TESTS `cargo xtask known-failing --junit PATH` reads nextest's junit (a file, or every .xml under a directory, so all of a run's junit artifacts at once) and fails on a test that failed and the list does not name, and on a listed test that passed (FIXED: take its line off, as the kernel rig's gate does). A listed test that did not run is neither, since a pull request tests only the packages it touches. The list has the rig's KNOWN_FAILING format (`<test> <cause>`, sorted, the rig's own parser), with `<test>` nextest's `<binary id>::<test name>`; `cargo xtask lists` checks it is sorted. The list starts empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * CI: the test jobs grade their junit against tests/KNOWN_FAILING_TESTS Native Linux tests and the GPU path test shards no longer fail on any failed test: nextest's "tests failed" exit (100) goes to `cargo xtask known-failing --junit`, which fails on a failure the list does not name and on a listed test that passes. Any other nextest exit (a build error, a bad filter) still fails the step at once. The tests skill says to list a failing test with its cause, in place of ignoring it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: the known-failing list takes develop's 10 failing tests Develop 38fd4a4f6 (CI run 41157648345, after the SMLib eaa998a pin) fails 10 cargo tests; each is listed with the cause its failure message gives. Seven are SMLib refusals or results off their derived volumes (fillet, chamfer and shell), the cli action matrix and naming corpus among them; the two corner_g2 tests are the fitted G2 corner patch bulging past the box, which the explicit G2 corner fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Reference tests: the eight cases that fail on SMLib eaa998a name their cause as known failures Develop 38fd4a4f6's Reference tests fail 34, 35, 77, 78 and 81 (STEP export finds fillet edges 4.6e-5 to 6.1e-5 off their surfaces against 2e-5), 37 (the apex blend 0.193 off), 80 (the taper-to-fit area) and 83 (thicken status 1001). Each expected.json names its cause in known_failure, which the oracle already reads: a known failure that passes fails the job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sweep path: a curve of several pieces is turned round whole The path chain oriented its first piece, not its first curve: a first curve of several exact pieces (a fit spline, an ellipse, a projected free-form edge) was never turned round, so a path whose next curve meets it at its start was refused as "not connected end to end". The chain now orients curve by curve: the first runs toward the second where they meet at one end only (else from the end nearest the profile), each next one starts where the previous ended, with one joint tolerance for both questions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * SMLib: pin 2fc375f (tangency-labs/smlib#71, #72, #73) A sheet's side is extended exactly the distance asked, or the call says it cannot (#71); NVIDIA's -Werror build passes again (#72); a body splits by a sheet of several faces as it is, smlib_split_body_by_sheet (#73). The C API is ABI 6 (the new entry), so the binding expects 6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * kernel: Extend grows a surface of several faces face by face A surface body of more than one face (a fit-point spline's spans extruded, #3830) was refused. Each face with a picked edge is now extended alone by SMLib's extension of its surface, and the faces are sewn back together, each the face it was. A side that lengthens onto a face meeting it tangent takes that face along, past its edge continuing the picked one; across a crease the neighbour grows only when its edge is picked too, otherwise the extension is refused. Faces whose lengthened sides no longer meet are refused. Up to a target keeps the pieces every grown face lies in. 3830's extensions now build; its split still fails (the tool point picks one span, and a face tool cuts with that face's surface alone), so it stays on the list with that reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * kernel: Split Body by a face of a smooth sheet cuts with the whole sheet A face tool cut with that face's surface alone, so a face of a surface body made of spans joined tangent (a fit-point spline extruded, #3830) cut nothing where its span ends inside the body. Split Body by a face of a surface body now takes the faces joined to it tangentially (the exact check Extend uses, within the one angle for smooth) and slices with them as they are, through SMLib's slice by a sheet (smlib_split_body_by_sheet, tangency-labs/smlib 7a01f1b), its sides those of the picked face. A sheet that only nicks the body cuts nothing, as before; a lone face, or a face of a solid, still cuts with its surface extended. 3830 comes off the booleans list. Its answer counted the two halves of the cup and not the surface that cut it, which stays as a body of its own (4879 removes its surface for that reason): three bodies, the volume unchanged. Needs SMLib 7a01f1b pinned (SMLIB_REV, prebuilt; its SMLIB_ABI_VERSION 6, which crates/smlib now expects) to link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: a cylinder strip's run-offs are 100 pi + 100 to 1e-6, SMLib's exact area The tangent and curvature run-offs of the quarter cylinder r 10 strip, 5 across the surface, are its section swept 20 along z: exactly 10 pi/2 20 + 5 x 20 = 414.159265. measure is SMLib's integration on the exact surface (1e-8), not a mesh, so the run-off check is 1e-6 relative and the 'measured on meshes' notes go. Red until SMLib's extension is solved to its distance (smlib-extend-converges 590d8a1): eaa998a's curvature run-off is 4.986 long, area 413.882. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * kernel: an extension SMLib cannot make exact says so, naming the length asked Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: a control spline can carry its own knots and weights A sketch spline over control points was always the clamped uniform B-spline over them, so a free-form edge whose knots are not evenly spaced (or whose weights are not 1) could only come into a sketch as one curve per Bezier span. A control spline now may save `nurbs`: its clamped knots and its weights. Its points, polyline, exact pieces (one a knot span; conics for a rational quadratic), the solver's distance and curvature, links, parallel re-projection and inspect.sketch all read them; a loaded design's are checked. One pending format file (spline-knots). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch projection: a free-form edge comes in as the one exact spline it is A projected spline edge of several Bezier spans came into the sketch as one curve per span (#1508), so a G2 round's bottom edge was 16 curves and a path naming the corner named one span of it (#3604). The kernel now reads such an edge (a spline, or an elliptical arc of several spans) as the one clamped B-spline it is over the edge's interval, its knots and weights its own, and the sketch takes it as one control spline whose ends sit on the edge's vertices. Planar regions still read edges span by span. The 3604 case builds with its original path and leaves KNOWN_FAILING. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillet rig: blends past an outer rim of their faces build, on SMLib smlib-blends-past-rims The owner's ruling: a round or chamfer that runs past an outer edge of its face into open air builds, tangent where it has room and cut by the face beyond where it runs out. SMLib's branch smlib-blends-past-rims builds them by the rig's analytic answers. Off the known-failing list: the disc's rim past its 2 mm wall (190), the hole's top rim R12 past the plate's bottom, the chamfer past the cylinder's bottom (2893), each closing on the wall continued as itself, and 926's chamfer ending on the boss's wall, which now builds to its answer too. The sloped basins' R4 rim rounds (1080, mitred rounds built together where one overflows) build to their analytic volumes (to 6e-9), and stay listed with that reason: their continuity check (g1 at every blend seam) takes in the mitres' creases, G0 by the mitre ruling. 2893-chamfer-two-distances-elliptical-rim is graded as a solid (the owner: it builds) and stays listed, waiting on the ruling on unequal chamfers along a rim whose angle varies. 5158-fillet-round-just-past-a-10mm-face stays listed with its cause found: the round passes 5e-6 under the box's top back edge, inside the body's tolerance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Naming: test that a round of a round's end has no seam with that round's faces The r1 round of a block's top edge, chained onto the end curve of the r2 round of its arc at a cylinder (rig fillets/every-block-cylinder-crease- top-edge-after-arc-round-r1), ends where it runs into the cylinder. That edge is no seam of the r1 round: the cylinder is a face of the r2 round, not of the r1. blend_seams takes it for one today (the r2 round's name F3:blend:F1:+z|F2:side holds a | of its own), and the rig reads it as a contact seam at 60 degrees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Naming: a blend's seams split its edge's name at the | between its two faces A blend face's name holds the edge it replaced, <face>|<face>, and a side of that edge can be a blend face whose own name holds a |. Whether a face is a contact of the blend was read as the edge's name starting or ending with the face's name next to a |, so the r2 round's own face F2:side read as a contact of the r1 round F4:blend:F1:+y|F3:blend:F1:+z|F2:side. The edge's name is now split into its two faces, a blend side read whole as the two faces of its own edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fillet rig: five refused blends build, off the known-failing list 926 (the chamfer ending on the boss's wall), the oblique cut's r0.1 round, the every-block r1 round (its seam with the cylinder is no contact seam, after the blend_seams fix), the up-down squares' concave chamfers and the shelled box's lip chamfer build with SMLib branch smlib-blend-refusals (f8650b8 and later). 1207 r0.5 passes SMLib's check on its rails now and stays listed for the next cause: its end rib on the boss, which starts where the round and the boss are tangent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the trough and the pocket whose floors fall to a drain build SMLib now offsets a vertex where four faces meet (two walls and two facets at the floor's corners, four facets at the drain) to two vertices joined by a new edge (tangency-labs/smlib branch smlib-shells). Both volumes match their closed forms. The pocket's lining, hanging from the top's rim round the pocket, stands apart from the slab's outer walls with the cavity rising between them to the open top: the case says two shells in the one body. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the plate with a hole through its arc side shells open at its far end SMLib's merge now intersects the offsets of an edge's faces where they could not be mated along it (the hole's offset poking out through the half-round side's; tangency-labs/solidcore#1795): one closed valid solid with the one face open, as the owner ruled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the ring cut frame and the up-down join shell SMLib's inset now keeps only the regions that are cavity, not the one the offsets close where they overlap (between the two faces of #545's 0.5 floor, round the up-down join's two empty octants). The frame's core under the recess is hollowed to a sealed void, so the case says two shells and its closed form, 21044 mm³. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: #616's lid shells open at a rib's side, with the 0.15 lip SMLib keeps the skirt top's offset where its loops wind the other way under the opening, the cavity's floor (the owner's ruling of 2026-10-31: build it; a lip thinner than the wall is no break-through). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Known failing tests: the action matrix's shells and chamfers as they fail with SMLib batch 7 The ring cut frame's and the up-down join's shells build now, and so do the up-down join's and modern-plastic's chamfers (SMLib smlib-blend-refusals). #616's lid in the corpus still fails SMLib's loop check, the shelled box shelled again at an inner wall is unchanged, and the oblique cut of a cylinder's fillet still fails SmSurfOfRevolution's Test #7: 3 actions of 7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * SMLib: pin 26cc451 (batch 7: rounds past a rim, blend refusals that build, shells) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Known failing tests: the shell after a cut whose end touches an arc side builds on SMLib batch 7 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Surface fair test: the energy falls strictly, the face moves, and the edges are read after the fair Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch scaling test: the first dimension sets l1 to 40 and scales both joined rectangles about the origin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames tests: a pick on a moved component or an instance removes the exact round and bore volumes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Issue 1080 tests: the rib's rounds and the mitred corner chamfers and rounds have their exact volumes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Engine tests: lip_after_boss checks each lip's and groove's exact band, hole_as_deep_as_the_plate each hole's exact bore Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Robustness tests: lip_after_boss and hole_as_deep_as_the_plate live once, in the engine's tests.rs with exact volumes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Engine tests: loft_cut goes; loft_spacing's hollow elbow covers its section counts and more Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel loft test: the square-to-circle loft has the oracle's exact ruled volume, without printing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tessellation lens test: the lens's triangles fill exactly the rhombus through its arcs' midpoints Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Pattern test: six chamfered holes take exactly five more holes' bore and chamfer rings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel pocket floor fillet test: the corner rounds and the floor loop round add their exact volumes, by Pappus at the corners Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Shell regression: the saddle-corner shell opened on the top box's side has its exact volume Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * SMLib history test: every operand's order is the identity on its record's faces and edges Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Boolean history tests: the SMLib module's box-minus-sphere, box-minus-cylinder and box-union-box copies go; the top-level ones check more Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Modify history tests: shell, offset and thicken are one test each through the public API, with the volumes, refusals and history the SMLib copies checked Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Chamfer history test: the chamfer after each box cut is exactly one face on the painted block too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Grid test: a pole side's face is the five triangles fanned from its one grid node, none degenerate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel tests: the twelve ignored print-only debug tests and surveys go; coplanar_curved_booleans checks the flush-capped cylinder cuts and unions they printed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel: the #883 board fixture generator is an example, not an ignored test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * STEP import test: a seam sphere whose meridian stops short of the pole imports as the whole 2 mm ball Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Material tests: the nine copies in material_properties go; the persistence file checks the library copy's card and formats 20 and 21 in one loop Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sample test: one loop checks every sample builds cleanly and without a panic; the robustness copy goes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Known failing: the non-antipodal seam sphere import, refused for a loop of no (u, v) area Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: rustfmt the board fixture example and the coplanar asserts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the two 3871 cone cases were byte-for-byte the 258 cases; the 258 cases carry their sources Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: a volume or area can be graded as a hand-derived range where analysis only bounds it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: fillets keeps one case per regime; 17 replications of a case in the same regime go The sloped-basin chamfers and rounds at 0.5 mm rims repeat the 1 mm rim's regimes; two of the three knife-edge chamfer tips, the r1 and box r3 curvature corners, the r1 tangent corner, the 1 mm pocket-rim and hole-rim chamfers short of the floor and the r1 together-round each repeat a kept case's regime and grades. #854 moves to 851-chamfer-arc-top-edge-9-5, and the cases that cited a dropped one cite the kept one or state its formula. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: five cases outside fillets repeat a kept case's regime and go A square cut is the slanted plane's ordinary crossing; the cam's half turn is the quarter turn's contact at a symmetric angle; the r15 slab stands inside the same coincidence tolerance as the r10; the 90 degree unfold and the 40 degree flange repeat the 72 degree and 20 degree cases' formulas. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 3243 rim and tooth join graded on its volume (rim plus the trimmed tooth less their 0.01 mm overlap) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 3782 emboss on a cylinder graded on its volume, area, faces and box (the wrapped 4 x 5 badge raised 1 mm) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 3604 G2 swept-tool cut graded on a volume range (filleted box minus the swept corner section) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 4505 coil joined through a cylinder wall graded on its volume, area and box (cylinder plus the wire's screw-swept segment outside r 76) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 4879 window cut through a thickened spline revolve graded on a volume range and its faces Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 4623 join of crossing pleated loft skins graded on its volume and box (both skins less their overlap) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 831 tapered glyph extrude graded on a volume range and box (the font's S drafted in by 10 deg) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 2357 ring of 90 cylinder segments graded on its volume and box (the segments less their 90 joint overlaps) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 4542 fluted wall joined on a revolved base graded on its volume and box (the base by Pappus plus the fit-spline ring) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 1985 and 2243 STEP-export enclosures graded on their volume and box (the outline less the cavity, plus gusset and standoffs) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: both 4092 loft, ribs and pad unions graded on their volume and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 1525 graded on its volume (the convex body's exact 2 mm inward offset), faces and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 1494 graded on its volume (box and cylinder less the 1 mm-offset cavity, sharp to rounded concave edges) and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 4492 graded on its box and a volume range (the face's 19 mm sweep added, within the block's sides) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 745 graded on its volume (the end moved 1 mm plus the spline boss's exact area), faces and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 4567 graded on its volume (the revolved spline less its revolved 2 mm offset), faces and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the up-down squares shell graded on its volume (the columns less the 0.346 mm-offset cavity, sharp to rounded concave edges) and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 545 graded on its volume (the frame less its 0.5 mm-offset cavity, sharp to rounded concave edges), its sealed pillar void and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the shell-again case graded on its volume (the shelled box less the 0.5 mm-offset cavity in its walls) and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the arc-sided plate shell graded on its volume (sharp to rounded at the hole's bottom), faces and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 616 graded on its volume (the lid less its 0.5 mm-offset cavity, sharp to rounded concave edges) and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 391 graded on its volume (the shelled housing, sharp to rounded at the flange, less the letters' 0.6 mm deboss) and box Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: shell/3576 was the ladder's drafted box with rounds shelled, recipe for recipe; the ladder case grades it and carries #3576 and #3573 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the two 851 chamfers of 2 graded on their volume (the cone's sweep, and its union with the front edge's prism) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the chamfered corner of the lipped shell graded on its volume (the chamfer's triangle through the wall) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the concave round into the peg's cylinder graded on a volume range (the torus it must add, the band it can't leave) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the two folded 72 degree trays graded on their volume (flat area x thickness) and the walls' reach Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the flanged rhombus graded on its volume (flat area x thickness, all four reliefs cut) and its walls' ends Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the base with two adjacent flanges and a hole graded on its volume (base, bends and panels folded) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the flange beside the ledge graded on a volume range (the flange's two readings of its length) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the two G0 window patches graded on the box the part they close keeps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the hub's six swept grooves graded on its volume (the revolved hub less each tube's part inside it) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the cut mirrored loft graded on the box its sections pin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the three modelled-thread joins and the fine M48 graded on their volume (the basic profile's groove, Pappus) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the oblique-cut round graded by its seams (tangent, not curvature-continuous); the flanged rhombus says what it tests (its reliefs stay apart at 60 mm) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 3841 is 168's rim touching its coin along a circle, and 4092's reduced recipe is its report less a flange clear of the failing join; the kept cases carry their sources Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the oblique-cut round keeps its old grade until the new blend algorithm lands Its seams grade needs the continuity check to skip the body the round is not on. Fillet cases wait for the new algorithm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: 1985's enclosure is 78 x 77 (74 and 73 inside, 2 mm walls); its volume 38063.827 by hand Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the three spline walls' face counts wait for the one-wall decision; their volumes grade them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * STEP import: a face bounded by seams alone runs its loop the other way, never turns over A loop that uses each of its edges once each way (a whole torus within its tube and ring seams) is the same set of uses run backwards, so it says nothing of the face's side. One written clockwise in (u, v) turned the face over, against its same_sense: the torus came in inside out with a warning. Such a loop is now reversed and the face keeps its side. Test: seam_only_torus_imports_as_a_whole_ring, both orders of the two seams, volume 2π²Rr². Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * STEP import: a face bounded by a slit alone is the whole of its closed surface A loop that runs out along a chain of edges and straight back (a meridian from a sphere's pole stopping short of the other, out and back) encloses no (u, v) area, yet on a closed surface it bounds all of it less a cut of none. The reader only read such a face when the slit already ran pole to pole (and moved the sphere's frame onto it only then), so the 2 mm ball whose meridian stops at 2.5 rad was refused for its empty loop. The slit is now made the face's seams, so its loop bounds the surface's whole domain: on a sphere, a revolution whose profile ends on its axis, or a spline closed round u that collapses at both ends, the slit's meridian is run on to both poles, out and back (a sphere's frame put on the slit first, whichever two points it joins); on a torus, the circle the slit lies along is closed and the other circle through its start is the second seam. The seams on a sphere are its own meridians (angle 0 on the equator), so their pcurves are exact lines on its form. Tests: non_antipodal_seam_sphere_imports_as_a_whole_ball passes (its known-failing line goes); seam_only_torus_imports_as_a_whole_ring adds a torus bounded by a slit along its tube. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rig: the test-peg's concave arc and front top edge rounded together stay within the body's box A new fillet case, report-fillet-concave-arc-and-front-top-edge-together-solver-residues: the reported part's bar (with the sketch solver's residues) whose sides run tangent into the cylinder, its concave arc and front top edge rounded r2 together. The plane of the front face bounds the whole body, so every blend lies within the unblended body's exact box (SMLib's tight box); graded to 4e-5, the corner patch's own tolerance. On SMLib 2fc375f the corner patch stands 0.0374 out of the front face (box y min 0.0205): listed in KNOWN_FAILING. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rig: the test-peg corner at r5 and r7 Two more fillet cases, the reported part's concave arc and front top edge rounded together at r5 and r7, with the same exact-box containment check (graded to 4e-5, the corner patch's tolerance). On SMLib 2fc375f the corner patch stands 0.128 (r5) and 0.230 (r7) out of the bar's front face (box y min -0.0699 and -0.1723): listed in KNOWN_FAILING. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rig: blends that end where their face runs tangent into another Fifteen fillet cases on the test-peg's shape with clean numbers: a bar 40 x 16 x 10 whose far end is a half disc R8, a disc R8 standing 10 on its top, joined, so the front face runs tangent into the cylinder along x = 40 and the front top edge (convex) meets the concave arc of the top tangentially there. Each blend ends on a face tangent to the one it rolls on. - Rounds: both edges together at r2 and r5; one after the other in either order at r2, and at r1.5 and r3; the front edge alone as a curvature round, whose end on the cylinder is a semicubical cusp. The containment invariant (the unblended body's exact box, to 4e-5) and G1 seams, or the analytic volume where the blend has a closed section. - Chamfers: the front edge alone and the concave arc alone (analytic volumes: the section along x up to the wall, the cone's spandrel ring clipped by the sides), both together, and one after the other (1 then 2). - STEP: the peg written to STEP and read back, its front edge rounded (analytic) and both edges rounded together. - A cone: the peg drafted 5 deg, whose front face runs tangent into a cone along a generator, its front edge alone and both edges together. The quadratures are tanh-sinh, converged to 1e-13; SMLib's own volumes of the passing analytic cases agree to 4e-9. A sphere is left out: a plane meets a sphere tangentially at a point, not along a seam, so it is not this ending. On SMLib 2fc375f eight fail, listed in KNOWN_FAILING: every chamfer that ends tangent (status 1001, SmFilletNx1Corner), the two rounds together (the corner patch 0.0374 at r2 and 0.128 at r5 out of the front face, and the rounds meeting with normals 180 degrees apart where their contact lines on the top cross), the same on the STEP-read peg (status 1001) and on the drafted peg (its corner refused as unsupported). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rig: fillet corners graded curvature-continuous, the default to be Six fillet cases that pick their edges with no type, so they take the fillet's default, which the owner has ruled is to be curvature-continuous (G2) at every corner, with circular rounds kept as an option. Each grades every seam of the rounds and of the corner patch G2, on one valid body: - an oblique convex corner (a block drafted 15 deg); - a four-edge and a five-edge apex corner (pyramids lofted to a point); - a pocket's concave corner; - a mixed corner (a step: one concave edge, two convex); - a corner beside a cylinder (the top corner of a half cylinder). All six fail on SMLib 2fc375f, listed in KNOWN_FAILING: today's default is the circular round, whose seams jump in curvature by 1/r. On the five-edge apex the corner patch also meets two rounds at 8.45 degrees (G0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rig: the test-peg's front chamfer builds With the SMLib fork's smlib-tangent-ends (a rail's end on its side edge is the rail/edge crossing), report-peg-front-chamfer-d2 passes. Its line leaves KNOWN_FAILING, for the pin that carries that fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rig: the curvature-continuous corner cases pick the curvature fillet The six corner cases added in 3a854104a took the fillet's default type, on the premise that the default would become curvature-continuous. The default stays the circular round, so each case now asks for the curvature fillet itself (type curvature: curvature-continuous sections and corner patches) and keeps its grading: every seam of the rounds and of the corner patch G2, one valid body. They are renamed from cov-fillet-g2-default-* to cov-fillet-g2-*. The oblique three-edge corner (a block drafted 15 deg) and the pocket corner pass. Four fail, as KNOWN_FAILING now says: - the corner beside a cylinder: the curvature fillet builds its sections only between planar faces; - the four- and five-edge apex corners: refused because the default setback is shorter than where the rounds' contact lines meet (3.90 and 3.51 mm from the apex); - the mixed corner: SMLib sets back a corner only where its edges are all convex or all concave. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Rig: the test-peg's concave chamfer, alone and after the front chamfer, builds With SMLib's tangent end as an event of the fillet's trace (blend-end-event 6d73e4f), the concave chamfer's rail on the cylinder ends where it crosses the seam along which the front face runs tangent into the cylinder, continued past the vertex, and its end rib on the front face is built from there. report-peg-concave-chamfer-d2 and report-peg-front-chamfer-d1-then-concave-chamfer-d2 pass and leave KNOWN_FAILING. The two chamfers together still fail, now at the mixed-convexity corner where they meet: its line says so. Rig against SMLib 0cc48bd: no area regresses (963/993 pass, 961 on a87c502), ladder 168/168, kernel lib only its listed failures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: constant rounds of the exact classes, and a tee's round A plane cutting a cylinder or a cone at an angle, a sphere or a cone coaxial with the other face, a cone and a cylinder touching one ball, two pipes touching at a point: their rounds' centre lines are rational, so the rounds are rational surfaces of degrees fixed by the construction ((4, 2), (2, 2) revolved, (6, 2), (12, 2)). The tee's centre line is not rational; its round is graded on its volume. Volumes from the divergence theorem over the exact pieces, at rel 1e-6. The six that SMLib 0cc48bd traces are listed in KNOWN_FAILING with what they come out as. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the exact-class rounds pass on SMLib's classified exact rounds The rounds now come as the rational surfaces their classes give, closed ones as two faces split at their seams, the touching pipes' as four: one splines entry a face, each of the class's degrees. Their KNOWN_FAILING lines go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * SMLib: pin 7ac037e (the new blend's tangent-end event, zero-speed G2 ends, and its exact-class rounds) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the fillets known-failing list is the 22 cases that fail on SMLib 7ac037e Twelve listed cases build on the new blend's end event and exact classes, or were already built on develop: they come off the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: #316's bottom rounds as large as the wall, or larger, shell with a step wall at the opening, not refused Where the round meets the open bottom the cavity's wall steps down along the bottom's normal, so the round meets it at 90 degrees and the opening is exactly the picked face. The cases are renamed and graded on the exact volumes, and come off the shell known-failing list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Merge fixes: every crate and test target compiles on the merged tree, but for crates/geom's hlr world_state, view::bounds, home_camera and scene return Result on develop; new main code takes that with ? or session_world. New fixtures carry the spline's nurbs. ForeignCopy::of returns Result. occurrence_placement_with walks the path with its moves, since the placement index holds pending_moves only. The hlr port is separate and still to come: this commit does not compile as it stands in crates/geom/src/hlr. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * Drawings hidden lines: read develop's B-rep records Edges come from the record's edge list, cut to their interval (C3::of_edge), and faces from its face list; a cylinder, cone, sphere or torus chart takes its bounds from where its NURBS form lies on its label (S3::of_face). A rigidly placed revolution has main's revolution chart; other placements stay refused. Moving a body to its centre goes through Brep::moved. Loops are read against the natural normal of the face's parameters where a chart wraps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * Hidden-line fixtures: build develop's records from the fixtures' data Fixtures keep their bounded curves and surfaces and their own edge numbers; a private builder makes the canonical record, and the local prepare puts the edges back in the fixture's numbering. Assertions are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * Hidden lines: tests of the bounded edges, face charts and placed revolutions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * drawing-hlr doc: what is drawn and refused on develop's records Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * hlr tests: a placed revolution is refused when its placement is not rigid The new model has one record for main's Revolution, which was drawn, and its PlacedRevolution, which was refused. An identity placement is now the former, so this test's fixture takes a non-rigid one. The refusal it asserts is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * Hidden lines: a traced intersection is drawn only where its spline lies on both surfaces A leader off either surface is refused like a curve with no spline to follow. Tests: a traced rim drawn on the circle and plane within tolerance, the same leader 1 mm off refused, and kernel bodies with arcs through the production prepare against closed forms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * Hidden lines: kernel bodies through the production prepare against closed forms Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * Tests from main: the world state is a Result here Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * A blend's pick measures close edges on their curves, not their polylines A polyline can be a chord off its edge, more than two edges are apart near a tangent point. A pick exactly on a ball's rim took the straight edge the rim is tangent to, and solidcore built a chamfer of that edge with a clean check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk (cherry picked from commit c786db6bf49804fb83a02f0eb7f83bd9f82fa643) * Merge fixes from the first SMLib test pass Model cache key covers the crates develop's kernel adds under doc (profile, smlib, step). A piece taking a name also takes the feature that made it: SMLib lists a cut's pieces in another order, and the swap left the name on a piece of the wrong feature. A replaced analysis keeps its status slot. A command with no world picks does not place the model first, so assembly.mass_properties answers for a flattening placement. FeatureCommon loses the touching key the merge added; only the contracts that read it take it. Two of main's tests listed as failing on SMLib, with why. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * Merge fixes from the ui test pass and the gates Main's thread.direction keys go with develop's thread hand, which replaced them. Vietnamese for the messages develop added while main made vi a complete catalog. CGA and 1-bit themes set develop's comb and section hatch colours. A ribbon button with a persistent effect is pressed only while its tool runs, so persistent_ribbon_pressed alone decides how its effect is shown; other analyses stay pressed while on. Two of main's ui tests listed as failing on SMLib, with why. Gates: fixed thread tables become slices, one collapsed if, rustfmt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * A silhouette takes its facing from the surface's normals A flat triangle beside the outline can tip the other way from the surface it approximates, and its edges joined the outline. On SMLib's sphere that made 192 segments instead of the equator's 64, 100 curves and 95 profiles from the tight fit of #7989. Each corner's normal is used where it is close to the triangle's own; a mesh without such normals (none, zero, not numbers, or averaged across creases) keeps the triangle's normal, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * Clippy and rustfmt on the merged tree Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MNXLXkZLQ6T7TSi4wswcmk * Stepwise open checks every feature under the session's mode OpenSteps::start evaluated under the default check mode, and finish kept those results under the session's mode: an each_step or off session opened in steps recomputed nothing. start now takes the mode (the app passes its session's), and a mode that changed before finish evaluates the design again under the new one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * Clippy without SMLib: the planar-sheet edge reader is built only with it Its one caller is in the smlib-only sheets module, so without the feature it was dead code and clippy -D warnings refused the kernel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * SMLib: pin d01d7b0 (the new blend's one Gⁿ section generator: the chord, circle and curvature sections, and the variable rounds as the union of their balls) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the section orders, chord, circle and curvature section, on planes and against a cylinder Eight fillet cases for the blend's cross-section by its order of contact with the faces, each graded on its analytic volume at rel 1e-7 and its exact continuity (the order, and not the next): - a box's top back edge chamfered 3 (G0), rounded r3 (G1) and curvature-rounded 3 (G2): the areas cut off the corner s^2/2, (1 - pi/4) s^2 and 113/756 s^2, the last by the default thumbweight's definition; - a pipe R10 dipping into a plate, its concave edge chamfered 2 (the chord between the contacts of the ball SMLib rolls for that setback, radius 1), rounded r2 and curvature-rounded 2, each section's added area by Green's theorem along the plate, the section and the pipe's arc; the order-2 section is built from the faces' feet of the point at distance d from both, which on the pipe are not linear in d; - a boss root curvature-rounded 2, the square corner's section revolved (Pappus); - a variable round r1 to r5 along a box edge (rel 1e-5): the balls' envelope is a circular cone, and the volume is the cone's sections integrated along the edge. Three fail today and are listed: the two curvature rounds whose faces are not a square corner of planes (SMLib's quintic blend curve, not the order-2 section: rel 6.5e-7 and 1.2e-5) and the variable round (great circles, not the envelope's: rel 4.8e-5). The other five pass on SMLib 7ac037e. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the curvature fillets' expected bodies from the order-2 section at thumbweight 0 SMLIB_BLEND_CURVATURE's section is now the order-2 G^n section at thumbweight 0. Between two planes square to each other it cuts A = 0.154192655384275 s^2 off the corner, its first moment about either face 0.0291753295725360 s^3 (Green's theorem on the section): the curvature cases built on that corner (862, 2708, every-box-edge, every-hole-top-rim, every-l-bracket, every-block-cylinder-crease, the three-edges-at-bar-corner reports, 3604's fillet) take their volumes from it by their own methods, the peg's front blend 23.3237146876 (its section along x up to the wall). Between planes the section's t^3 term vanishes (their feet are linear in the distance): the box edge case is exactly G3. The boss root is a certified fit, G3 to the plate and G2 to the wall at Continuity Analysis's tolerances: at least G2. The boss root and the pipe on the plate pass on SMLib's section and leave the known-failing list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Curvature fillets: the section's default thumbweight is equal area, so the round's volumes are the circle's On the round's rails the order-2 section takes off what the ball's circle does: (1 - pi/4) s^2 at a square corner, first moment 0.0474559669443 s^3 (w = -0.5252123889). The kernel and engine tests and the curvature rig cases take their volumes from it by their own methods; the pipe on the plate from its own wedge (70.52878 degrees, w = -0.8544103493). The G2 corner patch's seam test is listed until the corner step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: four G2 corners wait for the corner step: their patch meets the new section's rounds G1 at one face seam Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the turn at a corner of two rounds, Mitre (the default) and Swept, at a pocket's floor and a boss's base, by exact volumes A round's spandrel A = (1 - pi/4) r^2 and its first moment about its wall M = r^3 (5/6 - pi/4): Mitre adds L A -+ 2 M per edge (cut at, or run on to, the corners' bisector planes), Swept turns the section about a convex corner's edge, (pi/2) M a corner, and refuses a concave corner rounded less than the ball. The pocket's tangent chain round its R3 corners is a torus each. Graded to 1e-7, where Mitre and Swept differ by 6.6e-6. The Swept cases are listed until solid.fillet takes a turn. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: a junction family: oblique wedges 30 to 150 degrees rounded and chamfered (exact), bosses upright and tilted, pipe tees and a Y junction Four are listed with their causes: the equal-pipe tee (its exact conic-pair rounds meet at the ellipses' crossings in a corner the old corner code cannot join), the tilted bosses (1001, before the blend rework too) and the Y junction (refused for room at its triple points). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Variable rounds: graded by the union of their balls (their envelope), not the balls' great circles The smlib crate's laws and ladder 005, 006, 007 and 012 take the volumes the balls' envelope removes; the law with a corner is its own test, listed as failing until the corner step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel tests: variable rounds graded by the union of their balls, the removed volume to 1e-4 of itself removed_by_balls integrates, in each plane square to a right-angled edge, the corner the union of the balls leaves (by rays from the edge, the least entry over the balls), cut to the body's section. The law with a corner through a middle point is its own test, listed as failing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel tests: a spline radius whose balls fold over one another at its peak is refused Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: the variable round on its cone passes (the round is the balls' envelope) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Tests: three rounds of different radii at a corner listed: the corner's transition kinks with the balls' touch circles Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Ladder: the variable rounds graded to 1e-6 by the union of their balls; 012 by its law going on past the edge At the default 1e-3 the great circles' volumes (4e-6 off) passed too. SMLib builds each within 1.6e-7. The golden takes the new volumes and areas; counts unchanged. The G2 corner test listed as failing passes on SMLib's step 3 and leaves the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Reference tests: the variable rounds 77, 78 and 81 pass on SMLib d01d7b0; their known-failure marks come off The new section builds their edges on the surfaces, so STEP export no longer finds them 4.6e-5 to 6.1e-5 off. develop's Reference tests (60393a718) report all three as passing while marked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * STEP import: a ball's halves whose seams are off each other's quarter lines each form within one turn A sphere split into two halves along a circle about its axis, each half covering a pole with no seam, gets a seam per half from the first vertex of its loop to the pole. The circles between the halves group their frames so they turn together, and when the two seams are not a whole number of quarters apart no one turn fits both: the group kept its frames, a half's form ran past one turn, SMLib's trim (SMLib and solidcore alike) across the form's end crossed the face, and the mesh folded over the ball (a rotor's ball showed torn; its half had 196 times its area in triangles). When no one turn fits the group, each spilling face is now turned on its own to start on a quarter line. On the rotor file this also clears three other faces that were filled leniently and a 0.076 mm edge gap; regression test in step_in/tests.rs with the area and volume of each half. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz (cherry picked from commit b3188e005d427043b918267449c2336a1777e54f) * SMLib: pin 5e8c9c1 (the new blend's corners: Ball and End/Join; exact fold and room checks with fit sizes; overflow in place; the round as its definition) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel tests: a law's dip shows its corner ball's sphere, a peak's two rounds cross (the reasons had them swapped) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Reference tests: the variable rounds 77, 78, 80 and 81 expect the union of their balls A variable round is the envelope of the balls rolled along the edge, which takes less than a quarter round in each section. The expectations are now that union, the law continued past the edge's ends along its end slopes, integrated by Gauss-Legendre panels in x and t; 2, 4 and 8 panels agree to 1e-9 of the body's values, and 77's removed volume matches a brute-force union of balls to 2.5e-10. The nearest-ball search now scans the balls the ray meets around ball x (|x - s| < r(s) sqrt(sin 2t)) on their own, which near the faces and where 78's radius closes to 0 are narrower than the global scan's step. Regenerating keeps each case's known_failure. 79, a constant radius, is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Known failing: the law corners' kernel and crate tests and rig 1207 pass on SMLib 48ea616 SMLib builds a variable round's law corners as its balls' union (the corner ball's zone at a dip, the sides' crossing at a peak): the kernel's corner through a middle point (39.5410) and the crate's 4 -> 2 -> 4 law (39.5421) pass. Rig 1207 (the bar's top edge rounded after the boss's arc, r0.5) builds and grades on the same SMLib; it failed on c820346. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel rig: every fillet and chamfer case rounds its tangent chain The owner's ruling of 2026-11-01: the rig and the ladder round with tangent_chain true, how a user's default pick behaves. The 38 fillets-area recipes and the ladder's 07-fillets/016 and 018 that passed false now pass true. The shell recipes keep theirs: a shell's tangent_chain is its open-face chain, a different feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: the partial-selection cases kept as -partial-chain copies, tangent chain off Where a case's point is one edge of a tangent chain rounded alone, a copy keeps tangent_chain false as its own case (SMLib rounds exactly the picked edges, ending at the smooth vertex); their expectations stay as they were, to be re-derived: - fillets/1207-fillet-box-end-edge-into-unblended-round-partial-chain; - fillets/every-fillet-after-fillet-curvature-front-then-side-r3-partial-chain; - fillets/1207-fillet-bar-top-edge-after-boss-arc-round-partial-chain, renamed from ...-no-tangent-chain: with the chain on it is exactly 1207-fillet-bar-top-edge-after-boss-arc-round, which the rig already has; - ladder/07-fillets/020 and 021, the r5/r3/r7 and r5/r3/r2 corners (016 and 018) with the r3 on its edge alone: with the chain on, the r3 runs on along the r5 round's end arc and down the vertical edge the third round was to take. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: the concave arc between the block's tangent sides kept with tangent chain off fillets/every-block-cylinder-tangent-concave-arc-r2-partial-chain: the pick takes one piece of the concave half circle, which SMLib splits; with the chain off its other pieces are left out, and the blend is refused at the piece's end (the base gate's outcome). With the chain on the case rounds the whole half circle. The copy keeps its expectation, to be re-derived. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: two chains that now build graded by their exact volumes With the tangent chain on, two cases round more than the edge they pick, and their old expectations were the single edge's: - 1207-fillet-box-end-edge-into-unblended-round: the r1 chain is the end face's top edge, the r3 round's end arc and the back upright; 34 A + (pi/2) A (3 - c) by Pappus on the arc: V = 7953.139216 (it built 7953.139216, the old 7957.505 passed only inside 1e-3), 10 faces. - 851-fillet-top-front-then-front-left-upright: the upright's chain runs up the first round's end arc on x = 0 and along the left top edge, so the corner becomes the R2 ball's eighth: V0 less the first round's spandrel to the wall (35.344727) less 27 (4 - pi) + 2 pi/3: V = 9530.777979 (built 9530.777987), 10 faces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: a curvature chain round a round's end refused for its size; the concave half circle builds - every-fillet-after-fillet-curvature-front-then-side-r3: the side edge's chain runs round the first curvature round's end curve, whose radius of curvature has a weighted mean of 3 (its setback) and is unbounded at the ends, so somewhere below 3: the size-3 blend's contact line folds back on itself. Refused, "larger than the faces beside its edges allow", as ladder 07-fillets/016's r7 on the r5 arc. (It was solid or refused for running on tangentially.) - every-block-cylinder-tangent-concave-arc-r2-no-tangent-chain: the chain takes every piece of the half circle and ends at the convex edges it runs on into; it builds the analytic 19091.9620, so the outcome is solid (the refusal alternative was the chain-off one's). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Known failing: two 851 chains whose corner piece is a ball of tube-centre radius 0 851-fillet-arc-then-top-front and 851-fillet-top-front-then-upright: with the tangent chain on, each R2 chain runs along the end curve of an R2 round on a curved face (the arc round's end on the front face; the first round's end on the wall), where the rolling ball sits on that round's own centre line, so the piece is the ball about (39.2538, -19, 8): the three-edge rolling-ball corner. SMLib fails with status 1001; the same piece on a plane end arc builds (front-left upright). Expectations unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Ladder: 016 and 018 refused, their r3 chain takes the vertical edge; 020 and 021 recorded With the tangent chain on, 016's and 018's r3 runs on along the r5 round's end arc and down the vertical edge, so the third pick (60, 40, 8) is 3 from both of that round's contact lines and names no edge: refused, asking for a point along one edge. The corners they were made for are 020 and 021 (the r3 alone), whose golden entries are 016's and 018's (021 measured on f12a101). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel tests: three rounds at a box corner end on one rational patch on the ball's sphere, not an analytic sphere SMLib's Ball corner is always the rational patch exactly on the sphere (owner ruling, blend design §23), so the corner counts as an 'other' face beside the three cylinders and six planes. The removed volume still checks the corner against r³ − πr³/6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: the curvature round on a pipe on a plate is listed: a seam grades G3 where exactly G2 is wanted Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel tests: the box-and-fillet wire fixture records the round's cylinder frame as SMLib now keeps it The round's cylinder keeps the frame it was made on when it is turned (SMLib's SwapUV no longer re-derives it): its origin sits at x = −20 on the same axis line, (x, 2, 8) along x, radius 2. Same cylinder; one number in the record moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Known failing: two kernel tests' reasons as they fail on SMLib 5e8c9c1 (a partial selection running into an unblended tangent edge) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: two curvature rounds get 600 s, past the 180 s default, while G2 certification is slow (tangency-labs/smlib#96) On the CI runners the boss root and the hole rim, both size-2/size-1 curvature rounds, build correctly but take more than 180 s: the order-2 section's span certificate and the round's definition are evaluated station by station. The per-case limit is the one the thread cases use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Lid ring sketch test: find the ring under the pick, not by main's kernel's name On SMLib the lip join's exact history names the lid underside's ring a piece of the lid's own start (F14:start#[...]), as the naming rule says for a face that came from the feature's input; main's kernel named it after the case's top it rests on (F2:top). The test looked the ring up by that name and so stopped before the attachment it guards. It now takes the underside piece under the pick point, which the cap certificate attaches on either kernel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * Viewport culling test: each box's triangles from its mesh, not 12 SMLib meshes a 10 mm box in 108 triangles, so the hard-coded 12 a box stopped the test before it reached the culling. The expected counts are now each body's span in the scene. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * Timeline chip test: a fillet that really reduces The R20 fillet with fit reduce on one top edge of a 10 mm box builds on SMLib without a reduced-radius warning, so the fixture had no warned feature. It now rounds the four vertical edges at R6, reduced to the full round (5), as the copy-warning test beside it does, and checks the warning says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * Oracle: 34-chamfer-then-fillet and 35-fillet-curved-curved pass on SMLib 5e8c9c1 (their STEP edges are on their surfaces) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Known-failing: the shell of a fully rounded box opened at one face fails on SMLib 5e8c9c1 (tangency-labs/smlib#102) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Known-failing: the action matrix's oblique cylinder cut fillet passes on SMLib 5e8c9c1; two shells still fail Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: the boss root's curvature round gets the rig's 1800 s cap: on the CI runners, 8 cases at a time, its G2 certification passed 600 s (tangency-labs/smlib#96) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: a case's continuity can ask for an order per seam (seams: [{order, edges, exact}]) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: the pipe on a plate's curvature round meets the plate G2 and the pipe G3, 40307.8856312 (option B's order-2 jets, tangency-labs/solidcraft#10845) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Edge names: a seam names its one face once; the curve-id test reads every edge kernel-neutrally A seam's two sides are the same face, and edge names list each face an edge bounds once, so SMLib's extruded circle names its side's seam F2:side:c1, with no separator. The name grammar now says one face also means a seam. The #5858 test no longer counts one '|' an edge: every part of every edge name is a whole face name of the edge, one per face it bounds, two for the rims and one only for the side's seam (checked to run bottom to top on the circle). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * rustfmt on the merged tree Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * Known failing on SMLib: two of main's new tests assume truck's box mesh and fillet torus Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * SMLib: pin f916a8d (a round on a definition face is its definition; the G1 setback fill certified convex, setbacks too short refused naming the least; the G2 certificate halves a span no level can certify at once) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Fillet: a setback too short for its corner is refused naming the least that builds (smlib_blend_fit_size) SMLib's setback corner takes a G1 fill only once certified convex, and refuses a setback too short for that as SMLIB_ERR_NO_ROOM with SMLIB_FIT_SETBACK_AT_LEAST, the smallest setback that builds. The kernel reads it (solidcraft-smlib binds smlib_blend_fit_size) and names it; the Fillet dialog says it in plain words. Other room refusals keep their words. The r5 box corner set back 5.5 is refused naming 5.962, which builds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel tests: three rounds of different radii at a corner meet in SMLib's setback corner Each round runs whole to its section square to its edge at its setback (the owner's rule, at least 1.5 r, scaled to the least at which the G1 fill is certified convex), and the hole is the setback split: one patch per round and the triangle in three quadrilaterals, 15 faces, G1. Outside the box the sections span the body is the three strips', so its volume is theirs within that box's. A later r3 round at the mitred corner makes the body all three at once make (7928.142563938, 15 faces), as the engine and the model-cache tests have it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel tests: SMLib's own corner between curvature rounds is curvature continuous, as the G2 patch is Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: the boss root's and the hole rim's curvature rounds take the default timeout again (37 s and 34 s on the box under the rig's parallel load, tangency-labs/smlib#96) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Agents: model decisions use exact geometry; a mesh is for display, export, previews and mesh bodies Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * xtask: mesh-decisions, model decisions use exact geometry; today's 176 mesh decision sites are listed and the list only shrinks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Sheet metal: cuts and holes pass over sheets and bends by their exact boxes, never a mesh's A primitive cut skips the sheets kernel::apart (exact bounds grown by the record tolerance) finds clear of its tool; the bend check leaves the clear case to kernel::boolean, which answers it from the same exact boxes with no intersection work. The mesh-box helpers are gone, and their four lines leave xtask/mesh-decisions.txt (172 sites left). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Agents: AGENTS.md loses a stray merge-conflict marker line at its end Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Locales: Vietnamese for the setback-too-short refusal, now that vi is a complete catalog Main made vi a complete catalog; develop's new message (ui.fillet_error_setback_short) had no vi entry, so every_complete_catalog_carries_every_english_message failed on the merged tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: exact volumes for 1213's bent-tube round and 4782's bar round, rel 1e-6 1213: the loft is a cubic skin through the five sections (ellipses between them), not a torus; its volume 131601.597487935 by quadrature less the exact rolling-ball removal 233.662461919 gives 131367.935026 (was a Pappus estimate on a torus, 131360.148, at rel 5e-4). 4782: the section's area in closed form, 25 pi/3 - 5 sqrt(75) + 25, so V = 630.2934873 (was a grid estimate, 630.293125). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * Kernel rig: the boss root's and the hole rim's curvature rounds take 600 s again: under CI's parallel load they pass the 180 s default (develop 820b7b6) They take 37 s and 34 s alone on the box, but CI runs 8 cases at once on slower runners. Their G2 certificate cost is the open item (tangency-labs/smlib#106, moved to solidcore#2344). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * After the merge: clippy's auto-deref, and the mesh-decisions list for the merged tree Develop's list was taken on develop alone. Main's code (tap-marking reach, cut and hole box checks, join pieces, print faces, placed measuring, selection items, imported mesh payloads) and the branch's own exact_edges and named_vertex use meshes too; three listed functions were renamed by main (face_outline and plate_recesses into FaceSlice, paste into build). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * After the merge: main's new tests on the SMLib kernel - Cut To the far side of a curved wall (#8634): the tool stops past the first crossing of the face ahead of the profile; SMLib's whole bore is one face that a line crosses twice, so the single-crossing rule found none and the cut took nothing. - Clearing view analyses goes through refresh_display, as main's #10687 made the others, so an open feature editor keeps OK and Cancel after Zebra. - vi, a complete catalog on main, gets the setback-too-short message. - fillets/KNOWN_FAILING: 4782's cause is now its continuity check (SMLib f916a8d builds the expected volume). - Known failing, as main's tests assume truck: the spline wall's spans as one mesh patch, a hole touching an edge at a point leaving one body, and a copy of a copy's triangles matching a fresh mesh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEu4Lr3moCCisdZShKz * Twisted sweep: circles about a straight path are exact cylinders (solidcore#2184) A twist about a straight path maps a profile circle centred on the path's line onto itself, so its swept wall is exactly the cylinder. The skin through the stations stayed within 3.9e-9 of it (6.6e-9 on the outer wall), and a boolean with another body on that cylinder failed with status 1001 (solidcore#2184; the kernel's handling of a B-spline face lying on a cylinder stays open there). sweep_controlled now builds those walls exactly when the path is lines along the profile's normal and there is no end scale or rails: a profile whose every loop is such a circle is swept untwisted, and such holes in another outer loop are cut as exact cylinders from the skinned sweep of the rest. Other loops, and an axis-centred arc inside a loop of other curves, are skinned as before; a failed cut falls back to skinning all. Regression test in smlib_sweeps_tests.rs: #2184's tubes joined at 10, 16, 18, 20 and 30 degrees give one closed body of 11.5625 pi with cylinder walls; a twisted hexagon with the bore keeps a cylinder bore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdcgEtwSrdwZxqTQp5MfnU * After the merge: a hole that misses is found by exact boxes; a face is a one-face patch; main's mesh-box helpers gone - `hole_misses` (main's #10701, through brett's branch) decided from the targets' mesh boxes. It now uses their exact boxes (`Body::exact_bounds`). An unknown box still leaves the hole not known to miss. - With #10303's two shortcuts and `hole_misses` off the mesh, `body_box`, `mesh_box` and `padded_box` have no caller left, and are deleted. - `project`'s intersection link passes its one face to `meeting_edges` as a one-element patch. This branch picks one face, not #9009's mesh patch. - xtask/mesh-decisions.txt drops the six sites that no longer use a mesh here: `apply_traced_with`, `cut_end_past_face`, `beyond_cylinder_reach`, `hole_misses`, `body_box`/`mesh_box`/`padded_box`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * After the merge: split_move's Result reaches its callers; to_local's duplicated move check goes `frames::split_move` returns a Result on this branch: an unplaceable model is an error, not a silent no-split. - Move/Copy of a component (main's #9914) propagates it, as its other calls do. - `to_local` had the solid.move check twice after the merge (brett's Option one and ours). Ours stays, after the no-picks/not-placed return. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * After the merge: main's two new tests take world_state's Result, as the rest of their files do Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Native B-rep: a ball patch is its own surface kind, read from and written to SMLib's flat kind 6 SMLib's flat arrays now carry the corner of three equal rounds as `SURFACE_BALL_PATCH` (kind 6): its net as a NURBS face's block, with its sphere's centre and radius as its definition (ids 36 and 166). The record reads it as `ball_patch {center, radius}`, a label like the analytic kinds, with the net as its `nurbs`. A plain sphere with a form won't do: the net is not a piece of SMLib's sphere NURBS, so SMLib's `IsNurbSurfaceSphere` would refuse it. Written back, a ball patch is kind 6 with the same definition, which SMLib takes once its net is certified on that sphere. Elsewhere: - Offsets classify it as its sphere, so its offsets stay exact and collapse at the centre. - Face kinds count it as a sphere: fillet_three_edges_at_a_corner's corner is now `sphere`, no longer `other`. - STEP, which has no ball-patch entity, gets the net as the face's B-spline surface, pcurves included. - Iso curves and SSI of the label are refused; the face's form is what evaluates. Test: a_rounded_cubes_ball_patches_go_round_with_their_spheres. The cube's eight corners are ball patches about the corners pulled in by r. Points of each patch lie on its sphere to 1e-12. The patches are kind 6 again after import, with the same definitions bit for bit, and the closed-form volume holds. Format: pending/ball-patch-faces.rs. Docs: docs/native-brep.md and the rig README's `surface_types` (`ball_patch`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * SMLib: pin v1.1.0-alpha (a18bbe5): the generic blend's step-4 corners, the Ball's sphere patch through the flat arrays, all-target CI Since f916a8d: - #120: every target again, plus the warnings fix; - #121: the Ball's patch as flat kind 6 with its sphere, read by the previous commit; - #122: tests gated on counts; - #123: the Mixed corner; - #124: the End at a smooth vertex; - #125: four or more rounds, and open setbacks; - #126: the equal-area thumbweight guard; - #127: the trunk merge. The SMLIB_PREBUILT checksums are from the release prebuilt-a18bbe5…, written by `scripts/fetch-smlib.sh --pin`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * smlib export tests: rustfmt's line for the rounded cube's edge midpoints Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: the fillet and ladder results on SMLib v1.1.0-alpha, the new failures recorded with their reasons Fixed (off the known-failing list): the Mixed corner's peg cases and the concave arc with the front top edge (smlib #123), and the 40° boss junction (smlib #124). Eight cases in all. New failures, recorded as they are, each with its reason. They passed on f916a8d. - **Six cases grade a blend seam G0 where G1 (or G2) is wanted,** at the end of the round's contact seam, after smlib #124's End at a smooth vertex. Two of them also shift in volume. - **Four cases come back unsupported** after smlib #125, which leaves setbacks to the Setback's corners only. - **Ladder 07/012** makes 9 faces, 20 edges and 13 vertices, where its golden had 8, 18 and 12. Its golden entry is the new result, with the reason added. Whether each change is by design or a defect is being established. A defect is fixed in solidcore, where the End and the Setback are being brought over (#2364, #2365), not in the frozen SMLib. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel ladder: 07/021 and 06/018 recorded as they are on SMLib v1.1.0-alpha, each with its reason Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel ladder: a golden case marked unstable is gated on its status, and 06/018 is marked On SMLib v1.1.0-alpha, 06/018 makes 597 or 594 edges from the same input: the union's post-process keeps pointers to edges it has deleted. A golden entry's `unstable` reason makes the gate compare that case's status only and name it in its output; recording keeps the reason, and only an edit of the golden removes it. v1.1.0-alpha.1 fixes the cause and removes the mark. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * After the merge with main: its new code on develop's exact bounds, types and thread fields - The sheet cut's cull (#10301) and the tapped wall's (#10227) use each body's exact box (`exact_box`), not its display mesh. - model.threads replies with develop's thread fields: form, hand (right, left or both) and starts. - surface.boundary's schema checks a network curve's continuity as the handler does, and words a list entry's error as it does. - Main's new tests take develop's Hole fields and world_state's Result. - mesh-decisions: contact_sweep's triangle check is now `depth` (main split `hits`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Known failing: the 14 cargo tests SMLib v1.1.0-alpha fails, with what each sees; two cases that pass now Develop's CI after the a18bbe5 pin (run 41522001173) fails 14 tests that passed on f916a8d, and passes two listed ones. Each new line says what the test sees on v1.1.0-alpha; v1.1.0-alpha.1 fixes the setback hole's cause. shell_tangent_chain_that_opens_every_face_explains_how_to_keep_walls and oracle 37-pyramid-apex-blend pass and leave their lists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Cargo.lock: develop's profile, smlib and step crates at main's 0.30.1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: main's six new sketch-only commands are exempt from a kernel case sketch.construction_line (and its horizontal and vertical forms) and sketch.spline.insert_point, remove_point and reverse change only the 2D sketch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Cuts leave the bodies their tools can't reach, by exact boxes (#10225 on exact geometry) - The per-target cut loop skips a body whose exact box lies clear of every tool's, as main's version did with mesh boxes. The sheet culls (#10226, #10301) and this one now leave the far sheets and bodies alone: a_cut_leaves_bodies_it_cannot_reach_as_they_were passes and leaves the known-failing list. - a_cut_still_runs_where_its_tool_touches_grazes_or_meets_a_curved_face: a tool 0.5 µm clear of the block is now left out (exact boxes; 0.5 µm is far past the bodies' tolerances); touching and 0.1 mm in still cut. - Known failing, with reasons: main's edge lookup by a stored point (#11286, on the display mesh) is not taken; SMLib refuses the wrong-way chamfer for its tangent chain first. - EXEMPT: main's eight new sketch-only commands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: main's new view, rendering, appearance and settings commands are exempt from a case 62 of the commands main added change no geometry: the view and render panes, rendering lights and results, appearance tools, settings profiles, point clouds (drawn as points, never a body), the selection, two sketch edits, component links and History bar visibility, edit.repeat, timeline.play, inspect.compare_picture (a picture against the outline), and component.paste_from_design, which pastes the app's cross-window clipboard that no command fills. Each joins EXEMPT's first section under its family's reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: construct.plane.axis_point gets construction cases The plane through a box edge and its far corner, graded against its closed-form normal (0,-2,3)/sqrt(13) through the origin, and the refusal of a point on the axis. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: assembly cases for mass properties, align, find limits and moving items between parts - assembly.mass_properties: two boxes (2 g/cm3) in a rigid group: mass 0.006 kg, centre (18.333,5,5), inertia diag(0.1, 1.0333, 1.0333) kg mm2 by the parallel-axis theorem. - occurrence.align: a block's end face onto a base's top face: a quarter turn about y, centre (70,20,20), box (65,15,10)-(75,25,30). - joint.find_limits: a slider between two stops: min -20, max 10 mm. - component.move_features, browser.reparent and component.move_sketches.to_parts: items moved into a turned and moved part keep their world place (volumes, centres and boxes by hand). The mass case assigns a material it creates, so material.create and material.assign leave EXEMPT. PATHS names the new command modules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ * Kernel rig: export and print face cases in the import area - file.export_step, export_stl, export_3mf, export_obj: a 30x20x10 box written and read back (the meshes converted to a solid): V 6000, A 2200, 6 faces, box (5,-10,0)-(35,10,10). - file.export_urdf: a hinged arm on a grounded base: 3 links, 2 joints, and the base's mesh, written in metres, reads back as the 1 x 0.5 x 0.2 box (V 0.1, A 1.6). - body.print_face: a cylinder's flat end is accepted, its side refused. PATHS adds the URDF writer and the print face modules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: brett19 <brett19@gmail.com> |
||
|
|
28e26209f3 |
Assembly Move: drag allowed joint freedoms (#6679) (#6904)
* feat: add joint-aware assembly Move handles and live motion readouts * test: improve render job failure diagnostics * fix: preserve assembly Move compatibility and viewport theme colors * ci: skip default label sync for fork PRs * fix: keep Windows CI checks portable after main rebase * test: cover RTL assembly strings and stable refraction job * i18n: cover assembly Move in Vietnamese * i18n: cover assembly Move in French * fix: complete CGA palette for assembly motion handles * fix: complete Assembly Move palettes and Turkish strings * fix: retain assembly move cache answers and toolbar help * style: format merged assembly Move navigation guard * fix: align Assembly Move preferences and tests with main * Fix offline update fixture synchronization and clipped prism intersections Wait for all v5 manifest requests before deploying v6. Intersect hole-free prism sections over their common height, retaining the established B-rep path for newly clipped perforated sections. Preserve the failing property seed and add closed-form and cap-boundary regressions. |
||
|
|
7734ba2300 |
Offset Face: split a periodic face off its seam first, as booleans already do (#6226) (#6227)
* claim: #6226 * Offset Face: split a face off its seam and try again, as booleans do (#6226) A hole's wall arrives from a STEP file as one whole turn bounded by one wire that runs along its seam twice, where SolidCraft builds the same wall as two halves. Offset Face heals the body before it moves anything, and healing such a face fails inside truck with `This wire is not simple`, so the panic guard turned the whole operation into a kernel internal error. Since importing is how a part with a hole usually arrives, Offset Face did not work on imported parts with holes at all. `seam_faces` already answers this for booleans: split every such face in two along a plane through its axis, run the operation, and compose the history back over the body as it was given. This gives the offset path the same retry. - `seam_faces::one_body` is `boolean`'s answer for an operation that takes one body, with `needed_one` beside `needed`. - `offset_faces` now does its healing, its face picking and its offset inside one closure, so the retry runs the whole of it on the split body; the first attempt is guarded, so the failure is an error the retry can act on rather than an unwind. The faces are picked per body, because the pieces are numbered differently once a face is split — the points do not move, so they pick the same surface either way. The regression test is in `seam_faces_tests.rs`, beside the boolean ones: a 20 x 20 x 10 block with a 6 mm hole, read back from STEP, whose top moves 2 mm and lands on the same volume as moving the built body's top, with its history intact. Checked against `main` before and after: the three kernel tests that fail here (`blend::…seam_twice`, `step_in::…parallel_body_preparation`, `tests::a_box_cut_round_a_small_hole…`) fail the same way without this change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: CarlosKeese <dudukeese@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|
|
743accca7a |
Triangulation: split a crossing boundary segment ourselves, never in spade's assert (#4031) (#5409)
* claim: #4031 * Triangulation: split a crossing boundary segment ourselves, never in spade's assert (#4031) A trimmed face's boundary segment that crosses a constraint already in the triangulation went to spade's add_constraint_and_split, which asserts (cdt.rs:978, `!previous_region.is_empty() || from == final_vertex`) when a split lands so near another vertex or constraint that the piece up to it is blocked. The kernel guard caught it, but the whole operation failed and a crash report was written; a STEP body imported empty or not at all (#4598, also #4293, #4478, #5068, #5229). PolyBoundary::add_constraints now adds every segment that can be added, then splits each blocked one itself: a vertex at each crossing, inserted from the crossed edge's own vertex, and the pieces between added where they can be. A segment with crowded or very many crossings, or a face with more than four blocked segments (a rim that runs back and forth across itself), leaves them out, as truck did before #1653, so the face meshes slightly off instead of not at all. Pinched faces (#1648) still split where they cross. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
30b01e8d79 | A spherical shell revolves into a solid with a void, and cuts and joins with hollow tools work (#451) (#4182) | ||
|
|
f422bb1263 |
Intersection edges divide at 1e-6 when asked for less, instead of panicking (#4623) (#4650)
A join failed with the kernel's internal error "tolerance must be no less than 1e-6" at vendor/truck-geometry/src/decorators/intersection_curve.rs:172: IntersectionCurve::parameter_division asserted truck's minimum tolerance, and the guard turned the panic into a failed operation. A tolerance below truck's TOLERANCE, or one that is not a number, now divides at TOLERANCE: the curve's points are only found to within it anyway. The test divides the intersection edges of a hole cut through a B-spline face at 5e-7, 1e-12, 0, -1 and NaN: each gives the division at 1e-6. Without the fix it panics with the reported message at the reported line. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
edf57cec29 |
Stand up Y-up STEP and IGES files from SolidWorks automatically (#5191)
* claim: #5150 * Stand it up: don't offer it for SolidCraft's own STEP files (#5150) STEP replies from file.insert_step and doc.open now carry the file's originating system, and the window skips the stand-up offer when it is exactly SolidCraft, as SolidCraft's STEP export writes it. * Stand up Y-up STEP and IGES files from SolidWorks automatically The STEP header (originating system, preprocessor version, FILE_DESCRIPTION) and the IGES global section's native system ID say which program wrote a file. A SolidWorks header means Y up: the import's component is stood up as it opens, as one undo step, and the message offers Undo. SolidCraft's own files are left alone; an unknown exporter keeps the offer. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Ray <raykholo@users.noreply.github.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
b0048a6104 |
Mesh bodies: measure their size once, when made (#4662) (#4663)
`Body::size` walked a mesh body's vertices on every call, and it is asked for every frame. A mesh body's triangles never change after `mesh_body` or `mesh_transformed` makes it, so both now measure it then (`TriMesh::span`) and `size` returns it like a B-rep body's. `ModelBody::mesh` returns a mesh it already has before working out the display tolerance. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> |
||
|
|
688124937d |
Chamfer: a cutter that would reach into a nearby wall is not used (#4539)
* Chamfer: a cutter that would reach into a nearby wall is not used A straight chamfer's cutter reaches several times the chamfer's size out from its edge, and further on a larger part. On a pin standing in a socket, that far side lands inside the socket's walls, and the cut took bites out of them. A cutter whose far side is inside the part is now refused, as one whose ends are, and the chamfer is built locally instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Robustness goldens: seed 9 re-recorded for the chamfer cutter check A chamfer in seed 9 was refused because its result changed more of the part than a chamfer can. With its cutter refused, it now builds locally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
2fdc105d87 |
IGES import: separate lumps of one part are separate solids (#3928) (#3972)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
93a2922c5e |
Display plans and the model cache for large STEP assemblies (#2814) (#4021)
* STEP import: mesh band faces that wrap around a closed surface correctly Fixes two related bugs that caused SolidCraft to fail to mesh a face wrapping all the way around a closed, non-periodic surface (a revolved ridge band, or a tube-shaped B-spline surface): a missing face, a folded/self-overlapping triangulation, or a hole in the rendered body. 1. Ring edges that run slightly off their surface. STEP files write a surface and the curves bounding it to the file's own declared uncertainty, so a ring edge can legitimately sit a few micrometres off the surface it bounds. The code finding where a ring edge crosses the planned split line compared against the edge's raw (off-surface) point using a hardcoded tolerance far stricter than the file's own precision, rejecting a valid cut. Now matches against the point on the surface directly below the ring crossing, respecting the file's declared tolerance. 2. Closed B-spline surfaces, their slits and their slivers. truck only treats the rotation of a revolved surface as periodic; a face on a B-spline surface whose control net closes on itself (a tube) wasn't recognized as wrapping around at all. This produced a folded face, a hole (a boundary loop landing a full period away from where it should cut), and one near-zero-width sliver face costing the entire body its tessellation plan. Adds periodicity detection for closed B-spline surfaces, period- aware hole-loop alignment, dropping of zero-width slit boundaries, and isolating a too-thin-to-triangulate face so it no longer takes the rest of the body down with it. The GPU shader's periodic wrap mirrors the CPU math so the two don't drift apart. Regression tests: band_faces_split_when_ring_edges_run_off_their_surface, band_face_with_a_zero_width_slit_is_still_meshed, a_sliver_face_too_thin_to_triangulate_does_not_cost_the_body_its_plan. Ablation-tested: disabling either mechanism in (2) reproduces its target test's original failure message while leaving the other test unaffected. * STEP import: mesh the band's split faces, not just split them jyviko asked whether a band wall missing from the interactive app's render was a shading issue or a genuinely missing face. It was missing: the ring- edge split fix made the band's topology correct, but plan_face still produced zero triangles for the two new sub-faces. Two causes, both in plan_face (crates/kernel/src/tess/mod.rs): 1. The tolerance for how far an imported boundary may lie off its surface was tied to the requested mesh's chord tolerance instead of to the body's own size. A finer display tolerance could then reject a boundary a coarser one had just accepted, so the face would drop out exactly when zooming in on it. 2. Near a sharp corner of this flat-panelled band, several boundary points that are legitimately a few micrometres apart (within the STEP file's own declared precision) all projected onto the same surface point. The boundary loop then repeated a point in (u, v), which a triangulator can't follow, so the face's plan failed outright. One face without a plan costs the whole body its plan, and the fallback mesher can't handle a closed B-spline surface either, leaving both halves of the split band with no triangles at all: present in the topology, invisible in every renderer, and absent from the body's volume. Fix: scale the off-surface tolerance to the body's own extent (new Rules::extent), and collapse a run of boundary nodes that land on the same surface point to one (drop_collapsed) before triangulating. Regression test additions to band_faces_split_when_ring_edges_run_off_their_surface: the body's volume now matches the analytic pentagon prism (was a third of it - only the top cap - before this fix); display_plan leaves no face without triangles from coarse to fine tolerance; and the actual tolerance and facet angle the viewport draws with gives the split band its full lateral area on both halves. Confirmed on review_band_big.step, the fixture behind the review screenshots: volume's relative error against the analytic pentagon prism drops from 1.4e-4 to 4.1e-6, and the band wall now occludes the floor grid behind it in a snapshot the same way the top and bottom caps always did. Full kernel suite: 739 tests, 0 failed. * STEP import: hold an imported boundary to the file's own tolerance, not the part's size jyviko: the off-surface acceptance added in the last commit (rules.extent * OFF_SURFACE) scaled with the part, so a 2 m part silently accepted a boundary 2 mm off its surface while a 20 mm copy of the same part accepted only 0.02 mm. A STEP file's own declared uncertainty does not grow with the part, so the bound shouldn't either. Body gains boundary_tol: Option<f64>, Some(file's declared tolerance) for a body read from STEP (crate::step_in::Units::tol, already used by the ring-split fix in split.rs), None for anything this kernel built. It's set before the import's own unmeshed-face check runs, and carried over by the two face-split operations that re-cut an imported surface (splitface.rs, outline.rs), since the file's uncertainty still describes those boundaries afterward. plan_face's accept now reads: the file's own tolerance when the body declares one, or the old chord-tolerance/extent bound otherwise. The old bound's tol * 10.0 term had to go too, not just the extent term: at a 2 m part's typical display tolerance that term alone is ~20 mm, nearly ten times the extent bound jyviko objected to, so keeping it would have left the exact 2 m/2 mm example still silently accepted. Two new tests in step_in/tests.rs: - band_faces_split_when_a_scaled_copy_runs_off_its_surface: the same band fixture at a realistic 2 m scale with the same absolute slop and declared uncertainty as the small one, meshes the same way at every chord tolerance from coarse to fine. - off_surface_budget_follows_the_file_not_the_part_size: the actual regression. The same off-surface error is accepted or refused the same way whether the part is 20 mm or 2 m; a 2 mm error against a 1 µm declared uncertainty is refused at both sizes now (accepted at 2 m under the old bound, refused at 20 mm - that asymmetry was the bug). Checked at both a coarse and a fine display tolerance. Known gap, not fixed here: a STEP-imported body saved into a .solidcraft design and reopened loses boundary_tol (native.rs's decoder has no field to read it from) and falls back to the old extent-based bound on reload. Today's design format has no concept of this value at all; persisting it is a real format change, out of scope for this fix. Full kernel suite: 776 tests, 0 failed. clippy -D warnings clean. * Display plans for STEP threads and pointed ends (#3847) Three faces cost a threaded or pointed STEP part its whole display plan, so it was drawn from the reference mesh: cracked, faceted, and never refined up close. - A loop through a pole (a cone's apex on the boundary) seemed to wind around the surface: the jump at the apex, unwrapped to the nearest copy, was arbitrary. The loop is turned to end where it leaves the pole, so the step that closes it is an ordinary one (`seam::close_through_pole`). - Projection onto a spline with hundreds of spans (a helical flank) restarted from a 16 x 16 grid and settled on another turn; it now starts from two points per span, capped. - Sag refinement no longer inserts a point exactly on a boundary side, which split the side and failed the face. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * tess: a refused face's edges are divided finer and it is planned again (#2814) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * tess: sliver faces plan empty; a face no method plans is filled flat from its nodes (#2814) A face whose boundary runs out and back along itself (two edges between the same vertices, a rounding apart, as STEP files write slivers) encloses nothing and is planned with no triangles. A face still refused after its edges are divided finer (a cusp, a sliver whose sides sag across each other, a small cap at a pole) is filled flat from its shared boundary nodes, so the rest of the body keeps its display plan instead of falling back to the reference mesh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * display mesh tests: a rim the chord tolerance leaves a line is divided again (#2814) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * portable B-rep: up to 8192 control points along a spline direction (#2814) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * solidcraft-cli: --debug logs what the engine reports to stderr Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * STEP import: a spline written over a tiny parameter range is read over one (#2814) Some writers parameterize splines over a few millionths (a humanoid robot's edges span 5.4e-6). The kernel tells parameters apart only to 1e-6, so over such a range it evaluated the curve's end wrongly, and trimming an edge to its vertices dropped a control point: the bodies could not be stored exactly and the whole model cache was left out of the design. The knots are now stretched to span one; the curve is the same and edges are trimmed by their vertices, so nothing read from the file refers to the old parameters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * model cache: a body keeps its file's declared accuracy (#2814) A body restored from the cache dropped the accuracy the file it was read from declares, so the planner held its boundaries to the kernel's own bound and a reopened design drew differently from the import. It is stored with the body's runtime values, and only when there is one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * tess: a boundary within a hundredth of its body lies on its surface, at every quality (#2814) #1721 held a body read from a file to the accuracy the file declares. A writer declares what it aims for, not a bound its edges keep: a 251-body robot assembly declaring 0.01 µm has boundaries 10 to 30 µm off their surfaces, and 95 of its bodies lost their display plans. The bound is a hundredth of the body again, what Normal quality always allowed, and now the same at every quality, so zooming in still never drops a face (#1721's point). A file declaring more raises it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * STEP import: keep faces whose edge vertices sit slightly off their curves Some exporters write an edge's vertex beside the end of its curve, further off than the accuracy the file declares (a surface export declares 0.01 mm and puts a vertex 0.19 mm off two spline ends). The reader refused such edges and left the face, and with single-face bodies the body, out. A vertex may now sit up to the file's tolerance or 1/1000 of the model's size (the diagonal around its VERTEX_POINTs), whichever is larger, never more than the existing 1 mm ceiling. Spline and open-conic edges have the end control point moved onto the vertex, so every such edge meets its vertices exactly. The file's declared accuracy still governs closed-curve, seam and circle checks. * tess, io: review clean-ups (#2814) - A sliver face is one whose loops are all slit: drop_slits finds it in the retry after a failed plan, so the pre-check on every face (folded) is gone. - The flat fill uses cdt::triangulate (a lenient fill that leaves out sides crossing one already kept) and its flood-fill inside test, and the plane from geom::Plane. - Refinement only builds its indexes when a face was refused, takes the faces to plan again from edge_faces, and re-samples edges on the pool; Rules::finer for the finer rules. - One PackageWriter::fits for the model cache, the preview and the thumbnail. - The band split's ring tolerance lives in split.rs; comments say what the off-surface bound is now. - The CLI logger prints Level::as_str(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM --------- Co-authored-by: David Lackovic <lackovicdavid1234@gmail.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Ray <raykholo@users.noreply.github.com> |
||
|
|
e94900933d |
IGES import: close small gaps between trim pieces (#3845) (#3846)
Consecutive pieces of a trim loop can miss each other by micrometres to a tenth of a millimetre, past the file's resolution, so the loop did not close and the face was dropped. Faces are now read first and sewn after: each small gap's ends, and the other piece ends at them, move to one vertex. Gaps over 0.1 mm or not small next to their pieces stay open; the sewing tolerance stays the file's. The stated accuracy covers how far a vertex moved, so the STEP reader keeps those edges. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
79a843c963 |
Transform: refuse a matrix that is not an affine placement (#3900)
transform_matrix took any finite 4x4 matrix. A perspective entry in the last row, or a singular linear part, was built into faces that mesh to nonsense: a revolved ring placed with such a matrix measured hundreds of millions of mm3, and a boolean on it ran for over half an hour before failing with "no result". Matrices come from design files and command parameters, so they are refused with KernelError::Invalid instead. |
||
|
|
1bcc3602b4 |
STEP export: a merged cylinder or cone face's loop starts on the side its angle grows from (#3394) (#3557)
* claim: #3394 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * STEP export: a merged cylinder or cone face's loop starts on the side its angle grows from (#3394) A whole-turn cylinder or cone face is written as one loop: ring, seam, ring, seam reversed. Readers lay the ring that follows the seam's first use out from the surface's angle 0, so that ring must turn the way the angle grows (anticlockwise about the written axis). Three of the four tapered legs in #3394 came out the other way and other readers dropped their sides. When the second ring turns against the angle, the loop now starts with it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
63cb48a4ee |
Measure: a body whose meshes leave a gap keeps its volume wherever it is (#2069)
* Measure: a body whose meshes leave a gap keeps its volume wherever it is
A part ring cut by solid.combine (two prisms through its ends, a notch
through its chamfer) measured 992.03 mm3 at the origin, 999.17 moved
100 mm and 1063.48 moved 1000 mm; it encloses 993.92. The reference
mesher leaves a crack where the notch meets the chamfer's cone: the
volume beside it is left out, and the divergence-theorem sums, taken
about the world origin, close the crack by a cone to the origin, so the
error grows with the body's distance from it.
A closed surface's area vectors sum to zero. When the picked meshes'
sum could move the volume by more than 1e-5 within the body's size, and
the display plan (which shares every edge's nodes between its faces) is
closed, the body is measured on the plan, about its box centre. Every
other body measures exactly as before.
Tests: the cut ring at the origin and moved by up to 10000 mm, against a
grid quadrature of the cut; a revolved ring of cones and cylinders moved
100/1000/10000 mm along each axis (1e-6); a cylinder and a frustum far
from the origin against hand values. Robustness seed 64 moves by 1.4e-6
and is recorded.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* Measure: a gap the display plan can't close is measured about the box's centre
When the meshes leave a gap and the display plan isn't closed either, the
sums used to fall back to the origin-based volume, which drifts with the
body's distance from the origin (7 % at 1000 mm for the part ring). The
per-face sums are now taken about the fine mesh's box centre, which closes
the gap by a cone to a point inside the body; over a closed mesh nothing
changes. The gap decision moves into gap_closed, and a unit test with a
cube left open by hand covers closed vs open meshes, the closed plan, and
the fallback with an open plan or none.
Seeds 14, 20, 40, 55 and 61 end with such a body and are recorded with
ROBUSTNESS_GOLDENS_BLESS (volumes move by -0.51 %, +0.16 %, +1.9e-4,
+9.0e-5 and -1.5e-5; steps, outcomes and counts unchanged).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* Record robustness seed 86 after measuring bodies whose meshes leave a gap
Seed 86 was added on main by #2387 after this branch's goldens were recorded. Its last
body leaves a gap in its meshes, so the measure change here moves its volume by -0.27 %
and its area by +0.13 %; steps, outcome and counts are unchanged. Seed 86 passes
unchanged on main
|
||
|
|
316b49cd84 |
Extrude from a whole face rounded by fillets: join, and cuts whose walls only touch (#2040) (#2041)
* Extrude: a join from a whole face rounded by fillets sweeps the face itself (#2040) A face's sketch fits an edge that is no line or arc (the quarter-ellipses where fillets meet a slanted face) as splines a hair off the body's edges, so a join from the face touched the body along a face it did not match and failed with "boolean Union: no result" after minutes. When the profile is a whole planar face of the one target, the join now sweeps the body's own face, which shares its edges and is sewn on along it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Extrude: a cut into a whole face keeps the walls that cut and moves the others off (#2040) A cut from a whole planar face sweeps walls from each of its edges. Where the face beside an edge turns away from the sweep (n_N . -n_P >= 0) the wall only touches the body along that edge, or lies in the face beside it, and the boolean failed on it with "no result". The cut now keeps the walls that go into the body, exactly (the body's own edges), runs the outline round the others well outside the body, and starts a little out from the face. A cut whose walls all only touch takes a slab beyond its depth plane. Not covered: a cutting wall tangent to the face beside a touching one (a round's wall meeting an end face, as in the issue's part); the boolean still fails there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Extrude: leave a whole face outlined by lines and arcs to the profile's own tool Only a face whose outline the projection had to fit needs the body's own face as the tool. A square drawn over a box's top already meets the body exactly, and the swept face lost the names a sketch on the new top attaches to (stacked_face_tests, #489). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Run the whole cut tool from a face under the kernel guard (#2040) Review: `builder::vertex`, `builder::line`, `Face::try_new` and `builder::translated` ran outside `crate::guard`; only the sweep was guarded. `cut_tool` now runs all of it under one guard. Adds an end-to-end test of a cut into a face the body stands out past below it (the block's top strip between its rounds): it takes only what lies over the face. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: the slab cut of whole_face_tool, on a spline prism (#2040) A prism on a closed spline standing on a wider plate, cut 3 into its whole top face: the slab takes the face's area times the depth and leaves the plate alone. A test-only counter asserts the slab was the tool, so the test cannot pass through the profile's own tool. Shortens the name of the rounded block's top-face cut test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Kernel: the face's outline as a Vec now that polyline returns a closed chain (#2040) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
26c0c19ef7 |
Preserve imported part names and IGES assembly structure (#1609)
Build on #1426's import components and nested STEP assembly instances. Replace placeholder solid labels with meaningful part or instance names. Translate IGES groups and subfigure instances through the existing STEP component path, preserving nesting and placements and sewing surfaces within each group. Bound assembly walks and reuse work buffers. Related to: - tangency-labs/solidcraft#1386 - tangency-labs/solidcraft#1426 Co-authored-by: Codex <noreply@openai.com> |
||
|
|
2f43ad5c5b |
Loft: a circle lofted to a non-star-shaped profile is split once round (#2570) (#3670)
* claim: #2570 * Loft: a circle lofted to a non-star-shaped profile is split once round (#2570) A circle section was split at the lead section's vertex directions, kept in the lead's order and forced to increase by whole turns. A non-star-shaped lead (a C, a comb) turns back on itself, so the circle wound round many times and closed with a negative arc: self-crossing walls and a huge mesh (which froze the web build while meshing it). The circle is now split exactly once round: at the lead's directions when they go round once in order (clockwise on a plane facing the other way), otherwise at the lead's perimeter fractions, evenly as the fallback. Every arc is finite and positive and they total one turn; the unbounded loop is gone. Section preparation is split out as loft_section_loops so the resampled sections can be checked. |
||
|
|
6a8604c55d |
Fix lofts through sections turning past 90 degrees (#2847) (#3452)
* claim: #2847 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * loft: keep sections turned past 90 degrees facing the same way (#2847) The loft oriented each section by the sign of its normal against the first section's, so on planes turning about an axis every section beyond 90 degrees was reversed and the side faces folded. Follow the facing neighbour to neighbour instead. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
d2188fb7ab |
IGES import: a B-spline curve over a tiny knot span keeps its faces (#3885) (#3886)
A curve written over a knot span of 1e-7 or less was refused on the STEP side
("knot vector consists single value"), and both faces it bounds were lost. Its
knots are moved and scaled onto (0, 1), which leaves its shape as it is.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
438abbcf82 |
STEP conformance sweep: the cones to a point read right now (#258) (#3901)
cone_point and cone_point_vertex join the sweep now that #3871 reads a cone bounded only by its base circle up to its point. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
94bd8719aa |
STEP import: a void reads as a cavity whichever way its shell flag points (#3730) (#3872)
A BREP_WITH_VOIDS void's faces face into the cavity, so it encloses volume of the opposite sign to the outer shell. Its ORIENTED_CLOSED_SHELL flag alone doesn't tell: SOLIDWORKS writes .F. over a shell already facing into the cavity, SolidCraft .T., and flipping by the flag added the cavity's volume. A void enclosing volume of the outer shell's sign is now turned inside out. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
fc3dedfd5c |
STEP import: regression sweep over the step-conformance parts of known shape (#3880)
* STEP import: regression sweep over the step-conformance parts of known shape Fifteen generated parts from step-conformance (CC0): plain, NURBS, seamed, placed, inch and far-away cylinders, domes, a grooved shaft, a plate with 100 holes, a 3.6 m disc, a 0.5 mm pin, a B-spline half-torus and a washer. Each reads back with its exact volume, its box and its face count. The half-torus on a TOROIDAL_SURFACE and the cones to a point are left out until they read right. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * STEP conformance sweep: the pin's volume as FRAC_PI_8 (clippy) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5638259737 |
STEP import: a cone bounded only by its base circle reaches its point (#258) (#3871)
A cone face written with no vertex at its point has the base circle as its only loop (or that circle and a VERTEX_LOOP at the point, which has no edges). Its surface was spanned over the circle alone, a sliver, so a solid cone came in as a flat disc. Such a face is now spanned to the apex, and its circle is joined to the apex by a seam line out and back, as a cone with a seam is written. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
090119a5c5 |
Boolean: a small hole in a large body's face stays a hole when the face is divided (#2579) (#2580)
* Boolean: a small hole in a large body's face stays a hole when the face is divided
A boolean divides faces at a tolerance that follows the larger operand (a few
millimetres on a part a few metres long). A small hole's rim, two half circles
when read from STEP, then became two chords: its polygon in the face's
parameters had no area, and the sign that tells a hole from a face piece came
out at random. The hole became a face of its own, inside out, and the face it
was cut in stayed whole. A box cut round such a hole gave a piece without it,
and the shared part of that piece and a pin in the hole came out negative
("malformed") or the boolean failed.
divide_face now divides a loop whose polygon is flat again, finer (down to a
hundredth of the loop's own size), before reading its sign. Only the polygon
that places the loop changes; loops that have an area are untouched.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* Kernel: the long-plate hole test in tests.rs; a flat loop's size from its box
Review: the test moves into the kernel's test file (no file of its own),
and finer_if_flat takes the loop's size from the diagonal of the box round
its sample points instead of the largest distance between any two.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Aac7mP9rthK3WsPpPRvCsF
---------
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
||
|
|
5ba8c815a6 |
IGES import: trim curves with reversed pieces no longer drop their faces (#3358) (#3359)
* claim: #3358 * IGES import: trim curves with reversed pieces no longer drop their faces A curve on a surface (142) gives each trim loop twice: B in the surface's parameter space and C in model space, running the same way. Some exporters write C as a composite curve (102) whose pieces are in order but some of them end to start. The reader passed those pieces on as they were, so the loop did not close and the STEP reader left the face out ("face boundary is not a closed loop"). The pieces of C are now turned to run head to tail, starting at S(B(start)), the point where the parameter-space curve begins on the surface. That keeps the loop's sense from the file, so holes still run against the outer loop. A piece whose ends are one vertex at the sewing tolerance keeps its direction. On a 9,276-face trimmed-surface car model, 7,887 faces now import instead of 3,882. |
||
|
|
687caad24c |
IGES import: a revolved arc is a cap, not a whole sphere (#3806) (#3813)
A surface of revolution (120) wrote its arc generatrix as a whole STEP circle, which turns into a whole sphere twice over when the arc is centred on the axis; the trim could not pick the cap out of it and the face meshed as the full ball. An arc in a plane through the axis now comes in as a sphere or torus, any other arc as an exact rational B-spline of just the arc. |
||
|
|
932d8d6b4f |
Tessellation: trimmed faces of display meshes stay on their surfaces (#1653)
* Tessellation: trimmed faces of display meshes stay on their surfaces Display meshes triangulate a trimmed face in parameters scaled by the surface's speed along each, so a strip stretched along one parameter is not fanned across, and every boundary segment stays a constraint: one that crosses another is split where they meet. Boolean meshes keep truck's way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * Tessellation: one boundary rule for every mesh; drop the #1648 retry A boundary segment that crosses one already added is split where they meet in Boolean meshes too, which keeps a pinched face (#1648) whole without the snap-and-retry. Faces whose segments all go in mesh as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * Robustness goldens: seeds 1, 23, 55, 64 and 86 re-recorded on current main for #1653 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT * Thread preview test: wait for the stale fit error to clear before the next preview After switching back from M6x1.3 to M8x1.3, wait_feature_preview stopped at the M6 error still on screen when the new preview started a few frames later (seen on Linux CI with #1653's meshing). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT * Robustness goldens: the slow seeds 14, 20 and 40 re-recorded for #1653 from the merge queue Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QWhMwdqJYQKQq8RCLSL1LT --------- Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e98e065584 |
Open saved designs from the model they were saved with (#3053) (#3102)
* WIP: adopt the saved model on open (#3053) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * WIP: tests * WIP: bench-open opens as Open does * docs: opening from the saved model * Tests: an edit after opening evaluates from the feature it changes * clippy * Read SOLIDCRAFT_NO_MODEL_CACHE through the env helper * Open: no picture from the model when the model itself opens; cancel test evaluates * Saved model: bodies passed through found without writing their record; states list runs of bodies * Adopted results go into the evaluation cache: an undone edit, or the marker rolled forward, takes them again * Model cache size guard: the saved model's writer --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
c64a611818 |
Boolean: fail an unverifiable intersection instead of keeping what it should trim (#3244) (#3344)
* claim: #3244 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fail an unverifiable intersection instead of keeping what it should trim (#3244) When every route of the general boolean fails, it falls back on the sampled answer (one body whole, or nothing) with a "not verified ... that part is ignored" warning, even when the bodies' facets cross well past their faceting error. For an intersection that keeps exactly the material it was asked to trim: teeth standing 0.27 mm out of a trimming cylinder came back untrimmed, and `solidcraft-cli run` exited 0 with a part 16.918 mm in radius. An intersection whose sampled answer is contradicted by facets crossing by more than twice the depth the warning reports (6 x the check mesh tolerance, three times the faceting error of two meshes) now fails, and the model is kept. Cuts and unions keep the fallback: shelling a body in two pieces relies on it (a cavity tool grazing the other piece), with the same depth and ignored volume as this case. Fixes #3244 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Leave an empty unverified intersection as it was (#3244) Only a doubted intersection that keeps one body whole is refused. An empty one ("the bodies are apart") stays a result reported unverified: the clearance and interference checks rely on it, and main's new a_pin_through_a_d_bore_of_its_size_still_overlaps_the_flat (#2714) expects it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
47108fa063 |
Open: show a design as its bodies are meshed (#3053) (#3178)
* Open: show the design as its bodies are meshed, off the UI thread (#3053) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Open: hold screenshots until the design is meshed; profile lines * Tests: time-bounded opens * Open: a Loading parts n/N note while bodies are meshed * Open: frame the design from outlines while it goes into the window * Outline bounds: vertices and edges only; test * Frame watch: the window thread's frame times by open phase (SOLIDCRAFT_PROFILE_FRAMES) * Open: the picture grows in mesh order and stays once complete; refreshes pace themselves; named frame steps; watchdog test * Open: outlines measured on the file worker and kept per body * Open: draw the Home picture under the opened file's own key once meshed * Format the open wait --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ca9ebb44db |
Sheet metal: refuse a flat pattern that no longer matches the body (#3324) (#3325)
* claim: #3324 * Sheet metal: refuse a flat pattern that no longer matches the body A feature that is not sheet metal can change a sheet body's material without its sheet model knowing: a mirror combined into it, an extrude joined onto it, a fillet or chamfer on a corner. The flat pattern, the DXF and the bend table then wrote the sheet as it was before, a part other than the one in the design, with no warning. The evaluator now notes, per sheet, the first such feature: one that changes the body's shape while its sheet model stays the same. That feature warns, and sheet.flat_pattern, sheet.export_dxf (also with per_body) and sheet.export_bend_table refuse with "not supported yet", naming it. A sheet metal feature, or machining the sheet keeps as cut-outs, rebuilds the body from the model: it clears the note and warns that the change is not kept. Moving the body, splitting its faces and cosmetic threads leave the flat pattern as it is. * Sheet metal: a modelled thread is refused in the flat pattern too Only a cosmetic thread leaves a sheet body's material as it is. A modelled thread cuts the thread profile into the hole, which the flat pattern does not have, and a later sheet metal feature dropped it without a word. It now marks the sheet like a fillet does: it warns, the flat pattern, DXF and bend table refuse naming it, and the feature that rebuilds the body says the thread is not kept. |
||
|
|
e44dd4ff9e |
Loft: refuse consecutive sections that lie in one plane (#3412)
A loft through two sketches on the same plane built a flat body of zero volume and reported success, so the mistake surfaced later, if at all (a measure of 0, or a boolean that did nothing). `loft_wires` now checks each pair of consecutive sections: parallel planes with the second section's centroid in the first's plane are refused with "loft sections i and i+1 lie in the same plane (no volume between them)". The tolerance scales with the section's distance from its plane's origin. Test: two circles on XY; the loft fails with that message and leaves no body. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |