Commit Graph

1337 Commits

Author SHA1 Message Date
bherbruck 59ffd38019 Timeline: selecting a joining extrude no longer lights round walls an earlier feature made (#11263) (#11286)
A join that reports no history names faces by comparing the meshes before and
after. When the join makes the body bigger, round walls are meshed differently
and miss their old mesh at the naming tolerance, so they were named as the new
feature's faces. A curved face with no match now looks again within the two
meshes' chord tolerances. An edge name saved while a wall had the wrong name
falls back to the edge at its stored point.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 19:40:17 +00:00
semmelrinde 5e54681c80 Sketch: instances stepped in from an arc stop where the arc runs out, not turn round (#11068)
* Sketch: instances stepped in from an arc stop where the arc runs out, not turn round

Each instance after the first takes its side from a point one more step
past the last one. Stepping toward an arc's centre past an arc smaller
than the distance, that point lands beyond the centre, and the side was
read by comparing the point with the two offsets at the full distance:
the one toward the centre doesn't exist there, so the other won and the
next instance went back out onto an earlier one. The side is now read a
hair from the curve, where both offsets exist, and the point stops
halfway to the centre. The arc then runs out of room and the command is
refused there, as for a ring.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Offset side: read off the picked line or arc itself

A tiny step compared at large coordinates rounds away, and an arc left
smaller than that step by an earlier instance still has no offset toward
its centre: both turned the side round. A line's side is now its
half-plane and an arc's inside or outside its circle, as a circle's
already was; other curves compare both offsets' distance as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 19:40:16 +00:00
Mateusz Sych 7bdaec8f4d Joints: large assemblies with many closed loops no longer leave a new joint in conflict (#9687) (#11146)
* claim: #9687

* Joints: Edit Joint and Unsuppress meet a conflicting loop joint as Joint does (#9687)

joint.create (#10371) turns an angle a half turn when a new loop-closing joint
comes out as a conflict, so a second planar joint whose faces point the same way
meets. joint.edit never did, so a design saved before that (the report's rail on
two planar joints) kept the conflict however the joint was edited, and a joint
unsuppressed after its part was turned away stayed one too, though Move's hint
says to edit the conflicting joint.

An edit that places the joint again (type, offset, angle, flip, a side, or
unsuppressing it) now tries the same half turns. A rename alone moves nothing.

* Joints: a loop group over the solver's values still moves the loops that need to (#9687)

A frame held by many planar joints (the report's printer: six planar joints
between two profiles, and more) ties its loops into one group through the
shared values. Past MAX_LOOP_VALUES (64) such a group was only checked, so a
new joint closing a loop in it (Joint35, the rail on the 450 mm profile, which
took the group from 63 to 69 values) stayed a conflict, and nothing in the
group could be driven or dragged any more.

Such a group now moves the values of the loops that need to move, those open
at the start or reading a held value that moves, when they are few enough,
while every loop of the group stays a residual, so the others stay closed.
Groups within the cap solve as before.

* Joints: closed loops through a moving value follow on their own closing joint (#9687)

In a loop group over the solver's values, a closed loop that runs through a
value the open or driven loops move (a part slid on one planar joint and held
by a second) kept its closing joint's values, so its gap opened and the solve
failed. Those closing joints' values move too: they are on no tree path, so
freeing them pulls in no further loop.

* Joints: loops a motion link ties to a following closing joint follow too (#9687)

A followed closing joint whose value a motion link sets moves the value its
link chain starts from; closed loops through that value now follow on their own
closing joints as well, until no more do or the values pass the solver's cap.

* Joints: say what the narrowed loop solve does not find (#9687)

* Joints test: measure the peg's 30 degree turn from where the loop left P0 (#9687)

---------

Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com>
2026-11-02 19:38:17 +00:00
semmelrinde 861fb8ad56 Hole: a countersink cuts nothing outside its diameter above the face (#5041) (#8261)
The countersink tool was a cone started at the run-on height above the
face, so above the face it was wider than the countersink and kept
widening: a wall or step just past the rim was notched. The tool is now
one revolved profile: the cone from just above the face down into the
hole, and above it a cylinder of the countersink's own diameter. The cone
is the profile's first segment, so its face keeps the name csink:side:0.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:55:37 +00:00
leValdemar19 f7d66d2b5b Sketch Break: break at a shared point separates the curves that meet there (#7410) (#7950)
* claim: #7410

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Sketch Break: break at a shared point separates the curves that meet there (#7410)

Two lines drawn as one chain share their corner point. There was no way to pull them apart:
Break there said "nothing to break at there", and deleting the point deleted both lines.

sketch.break aimed at a point where the picked curve ends and another curve also meets now
gives the picked curve its own end there (`<curve>.start` or `.end` when that id is free), at
the same place: both curves stay where they are and are no longer joined. The Break tool
snaps a click on the corner to that point, so clicking it works the same way.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:53:04 +00:00
austin62jake 780c1163f9 Typed schemas for the crash report commands (#10909) (#10910)
* claim: #10909

* Crash report commands: input and output schemas (#10909)

diagnostics.crash_reports, diagnostics.crash_report,
diagnostics.crash_reports.clear and diagnostics.crash_test get typed
contracts and reply types in schema/diagnostics.rs and leave
unconverted.txt. Strict now refuses an `id` that isn't text on clear,
which the handler reads as no id and so deletes every report.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:45:04 +00:00
austin62jake fa1eb57e3b Typed schemas for the standard views and Normal To (#10898) (#10899)
* claim: #10898

* Standard views and Normal To: input and output schemas (#10898)

view.front, view.back, view.left, view.right, view.top, view.bottom,
view.isometric and view.normal_to get typed contracts (an optional
`camera`, read by the new shared CameraParam type with the commands' own
reader) and a CameraReply output, and leave unconverted.txt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:44:40 +00:00
semmelrinde 6602ab823f Typed schemas for Undo, Redo and the checkpoints (part of #2829) (#10945)
edit.undo, edit.redo, edit.checkpoint and edit.restore_checkpoint get
input and output schemas in schema/edit.rs: the first three take no
keys, the last takes `checkpoint` (with the handler's message for a bad
id) and `forget`. The handlers build their replies from the reply
types. Their lines leave unconverted.txt.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:44:14 +00:00
PapaEcho ccdb470e01 Sheet metal rules: typed input contracts and replies (#6581) (#10921)
* claim: sheet rule contracts (#6581)

* feat(engine): add typed sheet-rule contracts (#6581)
2026-11-02 18:43:19 +00:00
austin62jake a54d0517f7 Typed schemas for the local library commands (#10938) (#10939)
* claim: #10938

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Library commands: input and output schemas (#10938)

library.inspect, library.export and library.apply get typed contracts
and reply types in schema/libraries.rs and leave unconverted.txt. The
handlers' own serde parameter types move there and become the
contracts, so the contract is exactly what each handler reads; the
catalog, provenance and apply result schemas are written by hand, since
solidcraft-io doesn't use schemars.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:43:07 +00:00
austin62jake 7015c296ea Typed schemas for List Edges, List Faces and List Threads (#10942) (#10943)
* claim: #10942

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* List Edges, List Faces and List Threads: input and output schemas (#10942)

model.edges and model.faces take a typed `body`; model.threads takes no
parameters. Their replies are built from ModelEdges, ModelFaces and
ModelThreads in schema/inspect.rs, with the same JSON as before, and the
three commands leave unconverted.txt.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:41:09 +00:00
austin62jake b73eb6c243 Typed schemas for the curvature comb, minimum radius, isocurve and centre of mass commands (#10949) (#10950)
* claim: #10949

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Curvature comb, minimum radius, isocurve, centre of mass: schemas (#10949)

The four analysis commands get typed contracts and reply types in
schema/sketch_inspect.rs and leave unconverted.txt. Each point list has
its own type with its handler's messages and reads only as many points
as the handler does; `count`, `density` and `scale` read numbers as
params::num does. The replies are built from the types, with the same
JSON as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:40:25 +00:00
austin62jake 38cc3507db Typed schemas for the configuration table, rules, activate and preview commands (#11059) (#11060)
* claim: #11059

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Configuration table, rules, activate and preview: schemas (#11059)

config.table, config.rules, config.activate and config.preview get typed
contracts and reply types in schema/config.rs and leave unconverted.txt.
A new `table` builds the table from ConfigTable; show and the activation
build their replies from it, so the unconverted config commands still
return the same JSON.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:40:10 +00:00
austin62jake 90e30126ea Typed schemas for Boundary Surface (#11083) (#11084)
* claim: #11083

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Boundary Surface: input and output schemas (#11083)

surface.boundary gets a typed contract in schema/surface_boundary.rs and
the shared FeatureResult as its output, and leaves unconverted.txt. One
struct holds both forms; each key reads as the handler reads it, with
its messages, and `u` and `v` check their items where the handler does
without the design, index included.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:39:56 +00:00
austin62jake e3bbd8258a Typed schemas for Loose Ends and Tie Loose Ends (#10959) (#10960)
* claim: #10959

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Loose Ends and Tie Loose Ends: input and output schemas (#10959)

sketch.loose_ends and sketch.loose_ends.tie get typed contracts and
reply types in schema/sketch_ends.rs and leave unconverted.txt.
SketchTarget reads `sketch` as sketch_store::target does and PointIds
reads `points` as the tie does, each with the handler's messages. The
replies are built from the types, with the same JSON as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:39:20 +00:00
austin62jake 0f8b971ef0 Typed schemas for Bill of Materials (#11075) (#11076)
* claim: #11075

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Bill of Materials: input and output schemas (#11075)

assembly.bom gets a typed contract and reply types in schema/bom.rs and
leaves unconverted.txt. Each key reads as the handler reads it, with its
message; the reply is built from Bom, BomRow and BomChild, in the old
field order, so the reply and the files it writes are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 18:38:30 +00:00
NOWN-DEV 9432cdfee8 Sheet metal: material joined in the plane of a panel is kept (#6843) (#6855)
* claim: #6843

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PsiqyXWBFGTCX9J51bhysc

* Sheet metal: material joined in the plane of a panel is kept (#6843)

An extrude join through sheet metal went through the generic boolean:
the body grew, but the sheet model didn't, so the flat pattern, DXF and
bend table were refused, and the next sheet feature (a refold) dropped
the material ("what ... changed is not kept").

An untapered extrude join one sheet thick in the plane of a panel (the
base or a flange's panel, unfolded or folded) now joins the sheet model:
each region of its sketch becomes part of the one panel it is one piece
with, apart from every bend zone and the other panels, so the flat
pattern, its DXF and a refold keep it, and it follows its sketch's
parameters as a cut made there does. Cut-outs it covers are filled. A
join of another depth, out of every panel's plane, touching a bend zone
or another panel, or over a pocket, label, bore or perforation keeps the
generic path and its warning.

The extrude records its sketch plane and depth for a join too (its
profile grows into the material it joins, so it never counted as
untrimmed). The test that refused a joined tab beside a plain base now
refuses a block standing on the sheet instead; the tab is kept.

Fixes #6843.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:31:33 +00:00
Mateusz Sych dadefec702 Joint dialog: Find Limits fills the limits from where parts collide (#5968) (#7047)
* claim: #5968

* Joint dialog: Find Limits fills the limits from where parts collide (#5968)

joint.find_limits sweeps each value of a joint both ways from where it is,
on a copy and with its own limits left out, and answers where the parts it
moves first touch another part, where a closed loop stops closing, or that
nothing is met within a turn (angles) or the parts' reach (distances).
Edit Joint's Limits section gets a Find Limits button that runs it on the
joint as the dialog has it, off the window thread, and fills the rows.

joint.sweep now tells touching bodies apart from the other bodies of the
same two parts: on the Hinge Assembly sample the pins touch where it starts,
and the plates used to pass through each other unnoticed.

* find_limits: read the session only

* find_limits: a joint with nothing to meet, edits during a search, tiny ranges

* find_limits: keep touching at the start per pair of parts

Per body, the Hinge Assembly sample's plates, which only come flush in
the end plane the two leaves share, stopped the search. The leaves never
pass into each other: the sample's answer is a whole turn.

* find_limits: touching boxes cost no collision work; stale results and rounding

* find_limits: each pair of bodies of resting parts held to its own depth; loops without bodies

* find_limits: a 32-bit budget it can pass, a repaint with the result, a bad form says so first

* find_limits: each pair of resting bodies gets its own margin

* find_limits: Arabic, Hebrew and Vietnamese strings (complete catalogs on main)

* find_limits: search the joint with Edit Joint's side picks

Edit Joint now keeps the joint's sides as picks in its inputs, and its OK
commands compare them with what it opened on. Built without them, the
commands Find Limits applies first asked for the sides again, so every
search failed.

---------

Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com>
2026-11-02 18:28:28 +00:00
kaltenbrunnermarkus 686056e4de Opening: a design saved by 0.24 opens with its sketches in later versions (#8151) (#10379)
* claim: #8151

* Opening: a design saved by 0.24 keeps the body a Join To Object runs to (#8151)

Since 0.24.1 a Join extrude To Object also joins the body it runs to
(#6424). Designs saved by 0.24.0 and earlier were built without that,
so on 0.25 the reported box swallowed its lid: the lid's sketch, the
holes, the cut and the moves after it failed.

An extent may now save `to_body_apart: true`, which leaves that body
apart. One pending format change sets it on every Join extrude To
Object of a design of format 39 or older as it opens; designs of
format 40 and later keep the join. Editing the extrude keeps the field.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:13:04 +00:00
semmelrinde d7ad69e64f Pattern and Mirror: a hole placed by edge distances can be copied (#8055) (#8231)
A pattern or mirror replays its source hole's definition, so a hole with
reference edges finds its centre again from them. That happens after the
hole is drilled: through the part, the centre is then in the opening, and
the check that the centre lies on the face refused every copy. The replay
now skips that check; placing the hole itself still makes it.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 17:16:51 +00:00
Ray f6e932f61a Rounded Rectangle: corners take parameter expressions, as a 2-point rectangle's do (#10956)
`sketch.rectangle.rounded` read `p0` and `p1` with `req_vec2`, so a corner typed as an
expression (`["W / 2", "H / 2"]`) was refused with "`p0` must be a point [x, y]", although the
2-point rectangle it hands the corners to already places expression corners and keeps them
following their parameters. The corners are now read with `corner_arg`, as the 2-point and
center rectangles read theirs; the worked-out values still check the radius against the sides.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 14:10:17 +00:00
NOWN-DEV e33b8cfb07 Sheet metal convert: trays made in SolidCraft convert back (#7529) (#7580)
Convert to Sheet Metal refused a tray made with SolidCraft's own sheet metal, exported and
imported again: its walls run on past each bend's end (notch, tear and round corner reliefs), so
the edges beside the bend cylinder's edge never reach the other face's plane and the face could
not be trimmed ("a face beside a chamfer picked as a bend does not reach the face across it").
Where that edge is round or runs on along the bend's line, the face now keeps its corner and
steps down square to the other plane, a step the bend's setback takes up again; the inset drops
an edge the setback leaves shorter than the tolerance.

Test: trays_of_its_own_sheet_metal_convert_back (notch, tear and round, the walls made in one
flange feature, and notch and round with the short walls in a second one): the volume, the flat's
size and outline area and every bend's length are the source's.

Fixes #7529.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 14:04:39 +00:00
Dahak Builds 768dc253dd Fix mirror/pattern feature copy dropping bottom slice on hollow parts (#6452) (#7994)
* claim: #6452

* Engine: a pattern or mirror copy of a join keeps its ends as drawn (#6452)

The copy's tool is rebuilt against the current state, which already holds
the source feature's own material; the embedded-join-end trim (#2059)
read that material as the target already filling the copy's bottom band
and trimmed it away before the copy matrix was applied. Mirroring or
patterning a join on a hollow part silently lost the floor-level slice.
Copies now skip the trim: their ends are where the source drew them.

* chore: re-trigger duplicate PR check

---------

Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
2026-11-02 14:03:53 +00:00
dudedagger42 1d98b59883 Sketch Break: a length becomes the distance between the old ends; no piece of no length (#6826) (#6834)
Breaking a dimensioned line left the length on the first piece, which the solver stretched
back to the whole length, skewing the line. A cut on (or a hair from) an end, as where a tangent
arc meets a line, made a zero-length piece with its coincident and collinear ties every time
Break was clicked there.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 14:03:42 +00:00
Homero Thompson 6649cf4cfe Project: a refusal that names no body names the kind alone (#10626) (#10859)
The refusal of sketch.project ended in "face of " with nothing after the
"of" when the reference named no body: a picked face, edge or vertex is
found by its geometry, so the body it belongs to is not in the reference.

LinkSource::describe() now drops the "of <body>" when there is no body to
name and names the kind alone ("face", "edge", "vertex", "spun
profile", "isoparametric curve"). A source that names a body keeps its
name.

Only the text changes: the command refuses exactly what it refused before.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-11-02 13:49:26 +00:00
semmelrinde 9b431fea16 Hole: on a cone or torus face, drill along the face's normal, not a facet's (#10698) (#10885)
A hole placed on the side of a cone with no direction drilled along
the nearest display-mesh triangle's normal, up to 2.6° off the
surface's normal and sideways. Planes, cylinders and spheres already
gave their exact normal; cones and tori now do too, from the surface
the kernel reports for the face.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 13:48:20 +00:00
Colin Faulkingham 2339510e41 Sketch Trim: keep endpoint tangency on the surviving arc (#10851) (#10853)
* claim: #10851

* Sketch Trim: keep endpoint tangency on the surviving arc (#10851)
2026-11-02 13:47:26 +00:00
semmelrinde ac9d4e8a1d Move to Component: a sketch on a face inside the moved part goes along (#11063) (#11072)
* Move to Component: a sketch on a face inside the moved part goes along (#11063)

A face attachment stores the placement path it was found through. Moving
the placement into another component changes that path, the stored one
no longer starts at the design, and the move was refused as breaking
the sketch. Face attachments of sketches and construction planes, and
an emboss's face, now follow the move as the session's paths already do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Move to Component: attachments made through any placement of the old parent follow

A parent placed more than once is one definition: a face attachment made
through another placement of it than the one named also ran through the
moved placement and broke. Every stored path through the moved placement
now runs through its new place. A path that would grow past the 64
placements a design keeps is refused instead of saved unreadable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 13:46:12 +00:00
Christian Glombek 39163148d9 Sheet metal: an edge flange on part of a stepped outline spans that part (#11034) (#11046)
A flange picked on one segment of a stepped base outline ran the base
face's whole length: trimming the picked edge back to the bend line
merged it with the outline's own edge on that line beyond the step, and
the flange took the merged edge. It now stays off the base's edges that
already lay on the bend line, so it spans the segment picked, with no
relief there: the base is already back at the bend line. The same
outline made by cutting notches into a rectangle gave the right flange
already.

Assisted-by: LLM
2026-11-02 13:45:56 +00:00
semmelrinde 3ca311f922 Sketch: a dog bone's outline outside it meets outside both notches (#10984) (#11000)
* Sketch: a dog bone's outline outside it meets outside both notches (#10984)

Where two tangent arcs touch at a cusp, the copies of the two arcs cross
twice, both crossings as far from the cusp, and rounding chose one: on
one side of a dog bone the outline ran both copies on and drew a loop
into the bone. Such a tie now takes the crossing that cuts both copies
short.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Dog bone test: the outline goes outside, away from the picked bottom line

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 13:45:56 +00:00
Colin Faulkingham b978eeddcd Sketch: preserve short reference-line directions when dimensioning (#11001) (#11117)
* claim: #11001

* fix(sketch): keep short infinite references aligned
2026-11-02 13:45:36 +00:00
Colin Faulkingham 3c806394b0 Edit Sketch: restore timeline and undo state when finishing (#10691) (#10791)
* claim: #10691

* Fix sketch edit completion history (#10691)
2026-11-02 09:37:38 +00:00
Dahak Builds ef939b52eb Parameters: one meaning for value in every reply; round reported numbers (#10747) (#10812)
* claim: #10747

* Parameters: value is mm/degrees in every reply; round reported numbers (#10747)

---------

Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com>
2026-11-02 08:26:24 +00:00
momysnow c1612e9234 Move / Copy with Copy on a component copies the component (#9914) (#9930)
* claim: #9914

Co-Authored-By: Claude <noreply@anthropic.com>

* test: Move/Copy copy of a picked component (#9914)

Tests for a component picked in Move/Copy with Create Copy: it is copied as an
independent component placed with the move, the original stays, one undo removes
the copy; a body picked with Create Copy stays a body copy; a component picked
without Create Copy moves its bodies as before.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: Move/Copy copies a picked component as a component (#9914)

With Create Copy ticked and the component pick mode on (or a Browser component
row), a picked component is copied as an independent component (Paste New,
component.paste_new) and the copy moves by the move's transform (occurrence.move
in the world). Bodies picked still copy as bodies; without Create Copy a component
still moves its bodies. The copy and the bodies are one undo step.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: solid.move copies of components reply like a move and roll back (#9914)

A copying move with components replies as a solid.move does: the bodies' feature reply,
with the copies listed in occurrences. The bodies are mapped to their frame before any
copy is made. The solid.move help documents occurrences. A copy that fails part way
changes nothing and leaves no undo step.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: Move/Copy takes a picked component whether or not Create Copy is ticked (#9914)

A component picked in the component pick mode, or a Browser component row, goes into
the Move bodies input as a component, so Create Copy can be ticked after picking it.
Without Create Copy the component still moves its bodies. Not while editing an
existing move. The Browser model tests read the bodies the command would move.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: Move/Copy preview draws a copied component where the copy lands (#9914)

The fast preview took the component's bodies from the listed occurrences as well as the
bodies, drawn moved by the move, so a component copy previews at the moved place
instead of the scratch design's unplaced states. Test: a component-only copy and a
mixed copy preview where the copy lands.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: a copying move refuses bodies that are not a list (#9914)

With components, a bodies value that is not a list was ignored; without components it
is refused. It is refused now, before anything is copied.

Co-Authored-By: Claude <noreply@anthropic.com>

* test: an edited move never takes a component pick, through the click (#9914)

Clicks the component in component pick mode while an existing move is edited: the pick
stays a body. Fails when the editing condition is dropped.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: Move/Copy preview takes components only for a copy, and the mixed test can fail (#9914)

The engine refuses `occurrences` without `copy`, so the preview leaves
such params to the full preview too. The mixed-copy test now gives the
component a taller box, so its height shows the component was drawn.

Co-Authored-By: Claude <noreply@anthropic.com>

* docs: component_pick no longer needs Create Copy ticked (#9914)

Co-Authored-By: Claude <noreply@anthropic.com>

* test: a component picked with its parent is copied once (#9914)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 07:56:22 +00:00
semmelrinde 29a6bbdb43 Hole: say when a hole removes no material, or all of a body (#10701, #10702) (#10836)
* Hole: a hole moved off the material says it removes no material (#10701)

A hole whose position, parameter or sketch point moves it off the part
cut nothing and said nothing: the feature had no warning, and a
parameter sweep listed the value as fine. A hole whose tool is clear of
every body it cuts now warns "the hole removes no material" ("1 of 2
holes remove no material" for several), as a pattern does of its
copies. The check compares boxes only, from the meshes the hole already
found its face on, so a large hole pattern costs no extra booleans.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Hole: a hole wider than the part says it removes all of it (#10702)

A through hole wider than the part removed the whole body with no
message, also when a parameter widened it later. The hole now warns
"the hole removes all of Body1" when a body it cuts is gone after the
cut.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 07:13:00 +00:00
kaltenbrunnermarkus 073bbc3f00 Assemblies: a construction axis follows its component when the component rotates (#10127) (#10212)
* claim: #10127

* Assemblies: a construction axis follows its component when the component rotates (#10127)

A construction axis or point built on a body now goes with that body when
Move/Copy moves or turns it. Each construction records the bodies its picks
lie on; the Move feature (not a copy) carries along every construction whose
bodies it all moved, with the same transform in the construction's component
frame. One that also reads something fixed stays where it is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 06:40:58 +00:00
alfonsotames 9e5e143ac3 Sheet metal: a fold crosses slanted or curved edges of any panel (#10621) (#10922)
sheet.fold refused any fold whose bend zone wasn't a rectangle. It now
crosses the sheet's own outer edges, slanted or on any curve: the outline
is cut exactly across the zone, the panels keep their real outlines, and
flanges and other folds still go on them. The flat pattern's DXF keeps the
curve as drawn. A sharp corner in the zone stays refused.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 05:24:50 +00:00
bherbruck 5d6a80ff35 Control token file: no file in a custom folder when icacls times out (#10958)
On Windows the token file is restricted with `icacls`, which may not finish in time (#6145). That
counted as success everywhere, and is safe in the default folder, the user's own local app data.
A folder picked with SOLIDCRAFT_CONTROL_DIR may be readable by others, so there a timeout now
removes the still empty file and returns an error. The default folder behaves as before. The
decision is a small function of its own, tested without running icacls.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 04:08:13 +00:00
dudedagger42 96509412e9 Extrude: a Cut To the far side of a curved wall takes the wall (#8634)
A Cut To Object on a curved face ran the tool through the target and kept
the tool less the body, the piece at the start. From outside a curved wall
to its inside face that piece is the air before the wall: the cut took
nothing, or the tool lay in the curved face and the boolean failed on the
coincident faces.

Where the target's material ends at the picked face under the whole
profile (rays over the profile cross it once, material before, none
after), the tool now ends flat halfway across the gap beyond the face. It
takes what lies before the face and meets no face of the body. Otherwise
the trim is as before.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 02:01:42 +00:00
froglemonade2 f2ffd8d233 Save As: refuse a name that opens as another kind of file (#9745) (#9752)
* Save As: refuse a name that opens as another kind of file (#9745)

file.save and file.save_as wrote a design container under any name, so a
design saved as part.step was refused when opened again and part.stl opened
as a broken mesh. A name doc.open reads as a STEP/CAD exchange file, a mesh,
a 2D drawing, a point cloud or a SolidCraft drawing is now refused, pointing
to .sc and, for export formats, to file.export. Names that open again as the
design (.sc, legacy extensions, .json, anything else) save as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Save As: check the folder scope before the design name (#9745)

A path outside an agent's folders is refused for that first, whatever its
extension, as before; the design-name check runs after it in `write`. Fixes
solidcraft-mcp tests::tool_calls_stay_inside_the_agents_folders, which saves
`x.step` outside the agent's folders and expects the scope refusal.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 01:51:19 +00:00
kaltenbrunnermarkus 1885fa739b Assemblies: a second planar joint can be added (#10331) (#10371)
* claim: 10331

* Assemblies: a second planar joint turns its part a half turn to meet (#10331)

A second planar joint between two boards that mates faces pointing the
same way needs the board turned a half turn on the first joint. The loop
solve starts exactly turned away, finds no way round, and left the new
joint as a conflict; Move then said the part has no movable joint axis.

A new loop-closing joint now tries its own angle, each angle on the
joint path between its two parts, or one of each, a half turn round, as
the first joint of a chain moves its part into place, and keeps the
first that closes the loop without a new conflict. Faces that can never
meet stay a conflict and nothing moves.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Move test: give the blocked part faces that can never meet (#10331)

The blocked-Move test from #10509 used two boards whose second planar
joint mates two faces pointing the same way. That joint now closes its
loop with the board turned a half turn, so the scenario no longer
conflicts. Mate the yellow front against the red top instead, which no
turn on the first joint can bring together.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 01:29:29 +00:00
raykholo e91f5d73bd Joints: a typed joint that closes a loop starts where its parts are (#6061) (#10336)
A relation given no values already started from where its parts sit
(relation_values), so the part moves no further than it must. A typed joint
(planar, revolute, cylindrical ...) added between parts another joint
already relates started its values at 0 instead, so the loop solver began
far from the current placement and could report a conflict for a joint that
agrees with how the parts are placed.

Seed every loop-closing joint, typed or relation, from the current
placement when no values are given. Joints in an open chain and joints with
explicit values keep their initial values as before.
2026-11-02 00:24:33 +00:00
Daniel Katz 3231f049d0 Insert Part: ASME/ANSI inch hex cap screws, hex nuts and SAE/USS washers (#10316) (#10335)
* claim: #10316

* Insert Part: ASME/ANSI inch hex cap screws, hex nuts and SAE/USS washers (#10316)

Part of #10316. New standard-part families, tabled in inches as the
standards give them and built in millimetres: hex cap screw (ASME
B18.2.1) and hex nut (ASME B18.2.2), 1/4 to 1 in UNC and UNF from the
thread catalogue, and plain washers SAE and USS (ANSI B18.22.1 Type A).
Cap screws take the standard inch lengths, 1/2 to 8 in, defaulting to
the first at or above 2.5 d.

Lengths read as fractional inches in Insert Part, Change Part Size, part
names and part numbers. Insert Part gains a Unit system list (Metric,
Inch) above Type; it opens on Metric. parts.library reports each
family's system.

Inch parts get no cosmetic thread: solid.thread takes only metric
designations (#9571), and the old path would have made a wrong metric
mark. 9/16 waits for the thread catalogue; split lock washers and
carriage bolts follow in later PRs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 00:21:21 +00:00
semmelrinde a22ea76ab6 Feature editor: a section, an analysis or the selection changed while it is open leaves OK and Cancel working (#10687) (#10822)
The editor accepts revision changes that only changed what is shown,
counted by the display revision, but only hiding and showing counted
there. Section Analysis, the surface analyses, continuity, the
selection, the status pill catching up and view.render_select bumped
the revision alone, so turning a section off with an editor open made
OK refuse ("the design changed while the feature editor was open") and
Cancel leave the timeline rolled back. They now go through
refresh_display, as visibility changes do.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 00:18:00 +00:00
austin62jake a735620aa8 Circular pattern: the axis origin takes length expressions and follows them (#10852) (#10855)
* claim: #10852

* Circular pattern: the axis origin takes length expressions and follows them (#10852)

solid.pattern.circular with axis {origin, dir} kept its origin as plain
numbers, so a pattern about a parameter-driven point stayed where the
point was when the pattern was made: the seed moved with the parameter
and the copies did not. Expressions were refused (#248).

The pattern's origin is now a point of expressions, as a Mirror plane's
origin is: numbers or length expressions, evaluated on each rebuild, and
renamed with their parameters. Plain numbers are saved as numbers, as
before. timeline.edit sets pattern.origin as expressions, and editing the
pattern in its dialog keeps them. One pending format change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-11-02 00:17:15 +00:00
rugbymauri 059119b345 solid.move: an inserted part moves in world space beside another body (#9660) (#9683)
* claim: #9660

Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>

* Move bodies of differently turned components in the world together (#9660)

A Move feature moves each of its bodies in the body's own frame by one
vector and one turn. `solid.move` mapped the world vector and axis into
the frame of the first body listed only, so a body in a frame turned
otherwise (a part inserted with a non-default direction, moved together
with a block of the root) moved along its own axes.

When the bodies listed lie in frames that turn differently (or, for a
turn, also sit in different places), the move is now split into one
Move feature per frame, each with the vector and axis mapped into that
frame, in one undo step. Bodies sharing a frame still make one feature.

Fixes #9660

Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>

---------

Signed-off-by: Maurizio Monticelli <maurizio@whatwedo.ch>
2026-11-02 00:16:56 +00:00
jeromehzl e016c40f43 Sketch Intersect: picked faces meet as their whole surface, not the span under the pick (#9009) (#9107)
A surface extruded from a fit-point spline is one B-rep face per span,
joined by hidden seams; the viewport picks and highlights it as one face
(Mesh::surface_patch). sketch.intersection_curve turned a face pick into
the single nearest face, so the curve stopped at that span's ends.

project3d::mesh_of now returns the picked face's surface patch and
mesh_intersection keeps the triangles of every face in it. Body sources
and Project to Surface are unchanged.
2026-11-02 00:16:06 +00:00
kaltenbrunnermarkus a277839236 Section Analysis: tilting the plane rebuilds the outline index once, not on every drag frame (#10373)
* claim: sectiontilt

* Section Analysis: tilting the plane no longer rebuilds the outline index every frame (#10373)

The section outline cut through an index of slabs along one normal, rebuilt
whenever the normal changed: tilting a Section Analysis rebuilt it every
drag frame (about 0.15 s on a 2.5 million triangle part). The index is now a
grid of cells holding each triangle by where its box sits, with the box
around each cell's triangles, so it serves every normal. It finds the same
segments, in the same order and to the bit, as cutting every triangle.

The viewport keeps one index per shown body mesh, no longer per normal.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Markus Kaltenbrunner <kaltenbrunnermarkus@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 00:15:29 +00:00
cronos b5d931ff4c Preserve offset distances when trimming their source line (#10391) 2026-11-02 00:15:27 +00:00
Christian Glombek d7a17de3d9 Sheet metal: a perforation field bounded by a sketch's outline (#732) (#10754)
`sheet.perforate` takes an optional `sketch` (and `profiles`): the field's
outline. Holes go only inside its closed profiles, out of their inner loops,
`margin` clear of its edges, on a grid from the outline's lower-left corner.
On a folded sheet the outline maps through each panel the sketch lies on and
is clipped to it, so it never reaches a flange in the flat; a sketch on no
face of the sheet is refused. A mirrored copy mirrors the outline, and an
edit that names no sketch (the Perforate dialog has no outline) keeps it.
Without a sketch the field covers the whole sheet as before.

The feature saves `sketch` and `profiles`, a sheet's perforation its outline
in flat coordinates: one pending format note, no migration.

Assisted-by: LLM
2026-11-02 00:14:41 +00:00