7ad059aec90fe71f044a4ea514bdd48ef205cce6
2742 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
9acff62422 |
Sketch trim and extend refuse an offset's ends instead of undoing silently (#3918)
An offset's output curves have their ends recomputed from the source curves on every solve. Trimming a piece off one reported success and left the curve whole, because the refresh pulled the new end straight back. Extending one was refused as "connected to other geometry", which does not say why. Both now refuse with the reason and the way out: edit the source curves, or break the offset association first. Trimming away a whole offset curve, which removes it from its association, still works. |
||
|
|
915ee8a178 |
Fuzzer: a chamfer may add material, as a fillet may (#3868)
The fuzzer chamfers randomly picked edges and expected every chamfer to shrink the body, so a chamfer of a concave edge, which fills the corner, was reported as a wrong volume: 53 of the 6,000 designs of a run (seed 7100465: a box, a shell, a chamfer of an inside edge). Fillets already expect any volume change for the same reason; chamfers now do too. The regression test checks both directions on a shelled 20 mm box (an inside-edge chamfer of 1 mm adds 8 mm³, an outside one takes 10 mm³ away) and that seed 7100465 is no longer a volume finding. Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ac1768e08b |
Center circle through a snapped point stays on it (#3099) (#3277)
* claim: #3099 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Centre circle: a second click snapped to a point keeps the circle on it (#3099) The tool sent the centre's snap reference but only a radius for the second click, so a circle drawn from a line's midpoint through its end was left free to change size. sketch.circle.center takes through: a point reference, kept on the circle (PointOnCurve), and the tool passes it when its second click snapped to a point. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e1daf0a8b6 |
Clicking a parameter suggestion inserts it (#3257) (#3260)
* claim: #3257 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Clicking a parameter suggestion inserts it (#3257) A press on a suggestion took the focus from the expression box before the list could see the click: the list stopped drawing, the click never landed, and the box gave up what was typed. The rows are kept from the frame before; a press on one picks it and gives the box its focus back (again on the release, which the box takes as a click away). The rows are no longer focusable. The completion tests' frames now drop their texture updates on purpose, so they run where egui checks that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
57c3e94df6 |
Parameters: a new parameter's expression starts blank, and Tab selects a field (#2919) (#3096)
* claim: #2919 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Parameters: a new parameter's expression starts blank, and Tab selects a box of the add row (#2919) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Parameters tests: the add row's blank expression in the manage dialog tests (#2919) The two inventory tests typed a name and pressed Enter, counting on the 10 mm the expression used to start with; they now type it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5e05d925e0 |
Tapped Hole: keep Custom selection and edit nominal diameter (#2440) (#2441)
* claim: #2440 * feat: choose ISO metric tapped-hole sizes and derive the drill diameter * fix: label the tap drill and hide the unused diameter editor * test: cover tapped hole catalogue and drill sizing * fix: omit coarse metric pitch from generated designations * Keep custom tapped-hole nominal diameter and pitch editable Preserve Custom as dialog state, derive the existing metric designation from numeric inputs, and refuse invalid drafts without applying the last valid size. Retain manual text editing, physical tap-drill geometry and saved-design compatibility. * fix(i18n): register custom tapped hole labels in source catalogs * Adapt tapped-hole Custom fields to the current form kit * fix: preserve tapped designation focus with dynamic custom rows |
||
|
|
50313d147f |
solid.mirror: copies join their source's component; follow the saved placement (#1938)
* solid.mirror: copies join their source's component; follow the saved placement Three follow-ups to mirroring bodies of placed components: - A copy joins the component of the body it mirrors (or, when that component is placed more than once and a copy there would show at every placement, the innermost component around it placed once), so checks that group bodies by component see it beside its source. - The saved placement path, not the body's name, says which component a mirrored body is in: inserting the same file again reuses the body names, and the copies of the first insert vanished. - The mirror is evaluated again only when its own placements or its component's frame change, not on every occurrence move: each later command paid for one more mirror evaluation. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * solid.mirror: a saved placement must still lead to the body's component A stale or edited placement path that leads to another component's occurrence mirrored the body silently where that other component is placed. The mirror now reports that the placement no longer exists. The body's component comes from the evaluated body where a transfer recorded it, else from the component its name is recorded in or its feature's. When a later insert of the same file has taken over the name (the recorded component lies outside the components the body's own feature made), the placement has to lie inside those components instead, so mirrors of the first insert keep working. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * solid.mirror: the copies' component change is a pending format change v26 shipped in 0.15.0, so its mirror-placements note stays as released; the change of where a Mirror with placements puts its copies is noted in a new pending file instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> |
||
|
|
728f753b80 |
Release 0.18.4 (#4362)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
f22a026c27 |
3D mouse: choose which motion drives each axis (#2782)
* 3D mouse calibration: find each axis from a guided recording (#1463) A recording of the cap at rest and moved along each axis both ways gives which raw axis is which, which way it runs, where it rests, how much it wanders at rest and how far it goes each way. Hands aren't exact: on our SpaceMouse Pro, sliding the cap right moved Ry further than X. So each raw axis is picked by the one-to-one assignment that best explains all six motions together, each raw axis scored against its own range so a wider one doesn't win through cross-talk. Each direction is scaled on its own, so a device that goes further one way still reaches full scale both ways; a direction under a twelfth of the furthest axis counts as not having responded. A small state machine walks the user through it and moves on by itself once the cap has been held out for 0.4 s in one go and let go. "Held out" is the least the solver accepts, twice an axis's own rest wander, so whatever the solver would accept can be recorded and a noisy axis doesn't hold up a quiet one. A calibration also carries a dead zone the user sets, a share of full deflection taken off the bottom of the travel, with full deflection still reading full scale. Serde support is behind an optional feature, so the crate still needs nothing by default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse calibration in Preferences, saved per device (#1463) Preferences > Navigation gets a 3D mouse calibration row: whether the device being read is calibrated, Calibrate... and Forget calibration. The window asks for each motion in turn and saves what it found under the device (hid, web, spacenavd or 3dxware, with vendor and product ids), so switching devices or turning spacenavd on doesn't apply the wrong mapping. A calibration is saved for the device it started with, and ends if another one is read instead. navigate_frame puts the reading through the device's calibration before the driver mapping, so the per-axis Invert and speed and everything after them are unchanged. While the window is open the reading goes to it and the view stays put; it closes with Preferences. Restore Defaults on the Navigation page keeps calibrations, since they describe the device. The web app hands over the gamepad's readings as they are, so calibration sees where the cap rests; navigate_frame now leaves a reading inside the dead zone alone after calibration, so a cap resting just off zero still doesn't keep redrawing. Whether the cap is moving is asked of the calibrated reading there, in the web page's idle waker and in both wheel filters. Those run before the frame, so they keep the last frame's calibration with its device and use it only for that device. On the desktop, an axis with nothing fresh (timed out, or not reported since the device connected) reads as the device's calibrated rest, so a device resting off zero doesn't drift. A saved calibration that can't be read or used (a hand edit) is dropped on its own when the preferences load, with a log line. The window shows the device's raw readings live and has a dead zone slider, a share of full travel on top of the measured noise; it's saved with the calibration and adjustable in Preferences afterwards. New strings are in all 14 catalogs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse: choose which motion drives each axis (#1463) After calibrating, which motion of the cap should drive which view axis is partly a matter of taste: rolling and twisting swapped, say, or Y and Z. Each axis row in Preferences > Navigation now has a "driven by" choice next to Invert and speed. Picking a motion another axis uses swaps the two, so each motion always drives exactly one axis, and Reset axes puts them back. The choice applies after the device's calibration and before the driver mapping, so Invert and speed stay with the view axis rather than moving with the motion. It's a preference, not part of a device's calibration, and stays in force when recalibrating; the calibration window says so while one is set. A saved assignment that doesn't drive each axis once loads as the default. New strings are in all 14 catalogs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse: axis choice review follow-ups (#1463) - An axis's speed, like its Invert, stays with the view axis when a motion is reassigned; tested. - Calibrating records the device's own reading, before the axis choice, so a saved swap isn't baked into a new calibration and then applied twice; tested through a whole calibration. - A settings file without the axis choice, or with one of the wrong length, loads with the default and keeps every other setting; tested. - Each axis row says "driven by" in sight before its choice, which otherwise only explained itself on hover (no help on a touchscreen or the web). - "Reset axes" is now "Reset axis assignment", so it doesn't read as forgetting the calibration just below it; the "driven by" tip reads more clearly in English. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse: name axis rows by what they do, and motions without a device in mind (#1463) The axis rows and the "driven by" choices showed the same names, "Push left / right" and so on, which read as one thing mapped to itself, and they described a cap that springs back to centre, which a trackball or a knob that stays put isn't. Each row is now named for what it does to the view: Pan left / right, Zoom, Pan up / down, Orbit up / down, Orbit left / right or Roll, or Off. The name comes from the driver mapping navigation used last frame, so it stays right where the mapping swaps axes (object mode swaps the last two). Before navigation has run there's no mapping to read, and a row is named for its own motion instead of a guessed effect. The choices are the device's calibrated motions: Translation X / Y / Z and Rotation X / Y / Z, under a header row, and the calibration window names a motion that barely moved the same way. This renames #1814's existing rows, which had no translations; every new name is in all 14 catalogs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse: rows never fall back to a motion name (#1463) Without a driver mapping, a row was named for its own calibrated motion, which is also what its dropdown lists. It now takes the default mapping's view axis, so the two sides never share a name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse: grey out Invert and speed on rows the driver turns off (#1463) A row the driver profile turns off says so on hover, and its Invert and speed are greyed out, since they do nothing there. Its motion choice stays live so a motion can still be swapped out. The column header is shorter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse: unmapped rows say Axis 1-6, and the off-row tip explains the swap (#1463) Without a driver mapping, a row is now just "Axis n" rather than the default mapping's view axis, which would be a guess there. The tip on a row the driver turns off says that a motion swapped into it stops moving the view, and a test swaps one in and back out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3D mouse calibration: a device that stops short of rest after a release (#2778) Through spacenavd, a relative-axis device like the Space Navigator never reports its return to zero, so the reading stays at its last small report after every release. The wizard never saw the cap let go, and once calibrated, the stuck value crept the view. A reading that stays exactly the same, close to rest, now counts as let go, and where the cap settled after each step goes into the calibration: such a device rests at the middle of where it settled, with a dead zone out to the furthest of them. A device that comes back to rest calibrates as before. * 3D mouse calibration: a steady hold through spacenavd stays a hold (#2778) * 3D mouse calibration: stopping short of rest only counts from spacenavd and 3DxWare (#2778) Recentring on where the cap settled kept the rest stage's wander radius but not its offset, so a rest extreme could fall outside the dead zone; the radius now grows by how far the centre moved. A reading that stops changing close to rest only ends a step from a source that sends nothing at rest, so HID and web devices calibrate exactly as before. * 3D mouse calibration: settling off-centre counts on any device (#2778) A drifting stick settles off its rest after a release just as spacenavd's stuck reading does, but it keeps reporting, noisily. A step now ends once the reading stays steady, each raw axis within twice its rest wander (so exactly still from a silent source), close to rest, on any device. The dead zone takes that wander on top of the furthest settle point. * 3D mouse calibration: steadiness by the run's spread, settled on the step's own axis (#2778) An axis that read flat at rest may dither once off-centre, so steady readings may spread at least 2 units and a 50th of the furthest any step went. Steadiness is the spread of the whole run, not distance from its first reading. Close to rest is judged on the axis that set the step's peak, since a device's axes may have different ranges, and the settle point is the middle of the steady run. * 3D mouse calibration: readings close to rest never count as held (#2778) * 3D mouse calibration: the dead zone reaches every reading of each release (#2778) Saving one reading of each release and padding it by the rest wander could miss a reading seen in the same steady run. Each release now keeps the whole run, and the dead zone is centred on and reaches everything read at rest and after the releases. * 3D mouse calibration: settle for half a second before a step counts as let go (#2778) A hand held still close to rest is less likely to end a step early; a device that comes back to rest never waits for it. * 3D mouse calibration: show the dead zones as a game controller tester would (#2778) Once calibrated, the window, and Preferences under the Dead zone slider, show three pads: slide, press and twist, and tilt. Each has a circle for the full travel, the dead zone shaded inside it with each direction its own size and the user's dead zone on top, and a dot where the cap is now, lit once the view moves. * 3D mouse calibration: settle through cross-talk, per-axis steadiness floor (#2778) The axis that went furthest in a step needn't be the one asked for: cross-talk can move another raw axis further. A step now counts as let go once the furthest axis is at least halfway back and some axis that moved about as far is within a quarter of its own peak; a hand still holding the push keeps the furthest axis out. The steadiness floor follows each axis's own reach, and each stage's steadiness starts with its own readings. * 3D mouse calibration: steady readings may dither ±2 on any axis (#2778) * space-mouse: make the settle check's near band match the steadiness spread, test the 4-unit floor near() measured distance from the settled run's middle against the whole tolerance, so it accepted twice the band the steadiness check does. Use half. Add a short-range test where only the .max(4.0) floor lets a +-2 dither settle, and one where dither the spread check rejects is also not skipped as untouched. * space-mouse: settle on the middle of the steady run so a lopsided dither isnt movement near() allows half the steadiness spread around the settled point, but the point was the run mean. A dither that is mostly one value with an occasional far one (10, 10, 10, 14) is steady, yet the far reading sat 3 from the mean and started a hold in the next step. Use the middle of the run range instead. Adds a lopsided-dither test and a test pinning the documented cross-talk limit ([100,300] then [5,90] stays open). * Judge an untouched cap by the settled run's spread, not a rounded midpoint Rounding the midpoint to i16 could leave one end of an odd-width run more than half the tolerance away, so the cap read as touched while sitting at the end of the run it settled on. Keep the run itself and ask whether one more reading keeps its spread within tolerance. * space-mouse: pin the wider skip band of a narrow settled run and a single-reading settle * space-mouse: keep a step held while a lesser axis stays out as the larger one relaxes Settling needed one axis furthest and returned, and one axis about as far and settled, which a single relaxed cross-talk axis satisfied alone. Every axis that moved at least half as far as the furthest now has to be back by RETURNED_SHARE of its own peak too. * 3D mouse: the calibration tests run in a focused window, as the focus check now requires * 3D mouse: the axis tests run in a focused window, as the focus check now requires * 3D mouse: the calibrated-rest test runs in a focused window, as the focus check now requires * Settle a spacenavd reading that is nearly at rest (#3523) spacenavd sends a record only when the values change and nothing when the cap springs back, so the last small leftover of a release was held forever and the view kept drifting. A held reading now reads as rest once every axis is within 150 raw units of the device rest and no record has arrived for 0.5 s. A firmer push stays as long as it lasts, and so does a small value next to a large one. 150 is the smallest round number above the worst leftover in the issue (129 on one axis). * Choose which 3D mouse driver to read on Linux When both spacenavd and the device itself (hidraw) are there, Preferences now has a "3D mouse driver" choice: Automatic, spacenavd or Direct. Automatic is what it always was, spacenavd when it runs and the device otherwise, so nobody's setup changes. If the chosen one isn't available the other is read and the log says so once. Each driver keeps its own calibration, as before. To switch without a restart both reads now wake up when idle and look at the choice: spacenavd with a 250 ms read timeout, hidraw opened non-blocking and polled every 5 ms when it has nothing. A record that arrives is read as before, and one split across a timeout is kept. The reader also publishes which of the two exist, which is what shows the combo box; with only one it says which one is in use. * Build the 3D mouse row header from existing labels --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
4b37c046e4 |
Sketch tools come back in the variant used last (#4308)
* Sketch tools come back in the variant used last, and it is kept in preferences Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Scenario: a new design keeps the remembered sketch variant Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
54072b7014 |
Start page: sample pictures and the existence check of recent files run off the window thread (#4349)
A sample picked before its picture arrives still opens; the language test waits for the file check. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
cb3cabeda1 |
Remove camera animation: every view change and orbit applies at once (#4296)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
775e5155bb |
Main green: revert the start page change (#4295) and fix the format 28 test (#4335)
* Revert "Start page: sample pictures and the existence check of recent files run off the window thread (#4295)"
This reverts commit
|
||
|
|
e570c0b4eb |
Windows: a restored window that is out of reach is fitted to the monitor's work area (#4299)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
d9059d8da5 |
Start page: sample pictures and the existence check of recent files run off the window thread (#4295)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
463cea0615 |
Windows: ask for the foreground once, when the first frame is on screen (#4284)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
0225e4d2a5 |
Startup: the first frame no longer waits for the system CJK/Hangul/Thai font search; SOLIDCRAFT_PROFILE_STARTUP prints startup steps (#4283)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
034aa60d47 |
Release 0.18.3 (#4270)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
971b223246 |
Thread: turn a shaft thicker than a modelled thread down to its major diameter (#4256)
* Thread: turn a shaft thicker than a modelled thread down to its major diameter A modelled external thread on a shaft thicker than the thread no longer refuses: the shaft is turned down to the major diameter over the threaded length (run past a free end of the face), then the thread is cut as before. The turned face is named F<n>:turned and the step it leaves F<n>:shoulder:start/end. A shaft the part goes on around is refused rather than cut into, shafts under the minor diameter and cosmetic threads on thicker shafts are still refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Thread preview test: an 8 mm shaft is turned down for M6; M10 still refused Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
8c861f9f46 |
Face names: pieces of a split face keep their numbers across evaluations (#3902) (#3991)
* Face names: pieces of a split face keep their numbers across evaluations (#3902) Pieces sharing a name were numbered in the kernel's order, or by the index of the operand face they came from. A boolean can list its result's faces in another order on the next evaluation, and an operand made by one (a closed sweep tool) carries that order into the indices, so the #1/#2 of a split face could swap between two evaluations of the same design. Pieces that nothing else tells apart are now numbered along the spread of their centres (as edge pieces already were), and pieces from different faces of one operand by kind, then by place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Face names: older designs keep the piece numbers they were saved with Numbering pieces by place renumbers split faces in many existing designs, and a stored name matched exactly would then land on the other piece. Features of a design saved before this change are marked `kernel_piece_order` by a pending format step and number their pieces as before; features added afterwards number by place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e04a016e7c |
Align takes planes and the origin (#4248)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
93a2922c5e |
Display plans and the model cache for large STEP assemblies (#2814) (#4021)
* STEP import: mesh band faces that wrap around a closed surface correctly Fixes two related bugs that caused SolidCraft to fail to mesh a face wrapping all the way around a closed, non-periodic surface (a revolved ridge band, or a tube-shaped B-spline surface): a missing face, a folded/self-overlapping triangulation, or a hole in the rendered body. 1. Ring edges that run slightly off their surface. STEP files write a surface and the curves bounding it to the file's own declared uncertainty, so a ring edge can legitimately sit a few micrometres off the surface it bounds. The code finding where a ring edge crosses the planned split line compared against the edge's raw (off-surface) point using a hardcoded tolerance far stricter than the file's own precision, rejecting a valid cut. Now matches against the point on the surface directly below the ring crossing, respecting the file's declared tolerance. 2. Closed B-spline surfaces, their slits and their slivers. truck only treats the rotation of a revolved surface as periodic; a face on a B-spline surface whose control net closes on itself (a tube) wasn't recognized as wrapping around at all. This produced a folded face, a hole (a boundary loop landing a full period away from where it should cut), and one near-zero-width sliver face costing the entire body its tessellation plan. Adds periodicity detection for closed B-spline surfaces, period- aware hole-loop alignment, dropping of zero-width slit boundaries, and isolating a too-thin-to-triangulate face so it no longer takes the rest of the body down with it. The GPU shader's periodic wrap mirrors the CPU math so the two don't drift apart. Regression tests: band_faces_split_when_ring_edges_run_off_their_surface, band_face_with_a_zero_width_slit_is_still_meshed, a_sliver_face_too_thin_to_triangulate_does_not_cost_the_body_its_plan. Ablation-tested: disabling either mechanism in (2) reproduces its target test's original failure message while leaving the other test unaffected. * STEP import: mesh the band's split faces, not just split them jyviko asked whether a band wall missing from the interactive app's render was a shading issue or a genuinely missing face. It was missing: the ring- edge split fix made the band's topology correct, but plan_face still produced zero triangles for the two new sub-faces. Two causes, both in plan_face (crates/kernel/src/tess/mod.rs): 1. The tolerance for how far an imported boundary may lie off its surface was tied to the requested mesh's chord tolerance instead of to the body's own size. A finer display tolerance could then reject a boundary a coarser one had just accepted, so the face would drop out exactly when zooming in on it. 2. Near a sharp corner of this flat-panelled band, several boundary points that are legitimately a few micrometres apart (within the STEP file's own declared precision) all projected onto the same surface point. The boundary loop then repeated a point in (u, v), which a triangulator can't follow, so the face's plan failed outright. One face without a plan costs the whole body its plan, and the fallback mesher can't handle a closed B-spline surface either, leaving both halves of the split band with no triangles at all: present in the topology, invisible in every renderer, and absent from the body's volume. Fix: scale the off-surface tolerance to the body's own extent (new Rules::extent), and collapse a run of boundary nodes that land on the same surface point to one (drop_collapsed) before triangulating. Regression test additions to band_faces_split_when_ring_edges_run_off_their_surface: the body's volume now matches the analytic pentagon prism (was a third of it - only the top cap - before this fix); display_plan leaves no face without triangles from coarse to fine tolerance; and the actual tolerance and facet angle the viewport draws with gives the split band its full lateral area on both halves. Confirmed on review_band_big.step, the fixture behind the review screenshots: volume's relative error against the analytic pentagon prism drops from 1.4e-4 to 4.1e-6, and the band wall now occludes the floor grid behind it in a snapshot the same way the top and bottom caps always did. Full kernel suite: 739 tests, 0 failed. * STEP import: hold an imported boundary to the file's own tolerance, not the part's size jyviko: the off-surface acceptance added in the last commit (rules.extent * OFF_SURFACE) scaled with the part, so a 2 m part silently accepted a boundary 2 mm off its surface while a 20 mm copy of the same part accepted only 0.02 mm. A STEP file's own declared uncertainty does not grow with the part, so the bound shouldn't either. Body gains boundary_tol: Option<f64>, Some(file's declared tolerance) for a body read from STEP (crate::step_in::Units::tol, already used by the ring-split fix in split.rs), None for anything this kernel built. It's set before the import's own unmeshed-face check runs, and carried over by the two face-split operations that re-cut an imported surface (splitface.rs, outline.rs), since the file's uncertainty still describes those boundaries afterward. plan_face's accept now reads: the file's own tolerance when the body declares one, or the old chord-tolerance/extent bound otherwise. The old bound's tol * 10.0 term had to go too, not just the extent term: at a 2 m part's typical display tolerance that term alone is ~20 mm, nearly ten times the extent bound jyviko objected to, so keeping it would have left the exact 2 m/2 mm example still silently accepted. Two new tests in step_in/tests.rs: - band_faces_split_when_a_scaled_copy_runs_off_its_surface: the same band fixture at a realistic 2 m scale with the same absolute slop and declared uncertainty as the small one, meshes the same way at every chord tolerance from coarse to fine. - off_surface_budget_follows_the_file_not_the_part_size: the actual regression. The same off-surface error is accepted or refused the same way whether the part is 20 mm or 2 m; a 2 mm error against a 1 µm declared uncertainty is refused at both sizes now (accepted at 2 m under the old bound, refused at 20 mm - that asymmetry was the bug). Checked at both a coarse and a fine display tolerance. Known gap, not fixed here: a STEP-imported body saved into a .solidcraft design and reopened loses boundary_tol (native.rs's decoder has no field to read it from) and falls back to the old extent-based bound on reload. Today's design format has no concept of this value at all; persisting it is a real format change, out of scope for this fix. Full kernel suite: 776 tests, 0 failed. clippy -D warnings clean. * Display plans for STEP threads and pointed ends (#3847) Three faces cost a threaded or pointed STEP part its whole display plan, so it was drawn from the reference mesh: cracked, faceted, and never refined up close. - A loop through a pole (a cone's apex on the boundary) seemed to wind around the surface: the jump at the apex, unwrapped to the nearest copy, was arbitrary. The loop is turned to end where it leaves the pole, so the step that closes it is an ordinary one (`seam::close_through_pole`). - Projection onto a spline with hundreds of spans (a helical flank) restarted from a 16 x 16 grid and settled on another turn; it now starts from two points per span, capped. - Sag refinement no longer inserts a point exactly on a boundary side, which split the side and failed the face. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * tess: a refused face's edges are divided finer and it is planned again (#2814) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * tess: sliver faces plan empty; a face no method plans is filled flat from its nodes (#2814) A face whose boundary runs out and back along itself (two edges between the same vertices, a rounding apart, as STEP files write slivers) encloses nothing and is planned with no triangles. A face still refused after its edges are divided finer (a cusp, a sliver whose sides sag across each other, a small cap at a pole) is filled flat from its shared boundary nodes, so the rest of the body keeps its display plan instead of falling back to the reference mesh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * display mesh tests: a rim the chord tolerance leaves a line is divided again (#2814) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * portable B-rep: up to 8192 control points along a spline direction (#2814) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * solidcraft-cli: --debug logs what the engine reports to stderr Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * STEP import: a spline written over a tiny parameter range is read over one (#2814) Some writers parameterize splines over a few millionths (a humanoid robot's edges span 5.4e-6). The kernel tells parameters apart only to 1e-6, so over such a range it evaluated the curve's end wrongly, and trimming an edge to its vertices dropped a control point: the bodies could not be stored exactly and the whole model cache was left out of the design. The knots are now stretched to span one; the curve is the same and edges are trimmed by their vertices, so nothing read from the file refers to the old parameters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * model cache: a body keeps its file's declared accuracy (#2814) A body restored from the cache dropped the accuracy the file it was read from declares, so the planner held its boundaries to the kernel's own bound and a reopened design drew differently from the import. It is stored with the body's runtime values, and only when there is one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * tess: a boundary within a hundredth of its body lies on its surface, at every quality (#2814) #1721 held a body read from a file to the accuracy the file declares. A writer declares what it aims for, not a bound its edges keep: a 251-body robot assembly declaring 0.01 µm has boundaries 10 to 30 µm off their surfaces, and 95 of its bodies lost their display plans. The bound is a hundredth of the body again, what Normal quality always allowed, and now the same at every quality, so zooming in still never drops a face (#1721's point). A file declaring more raises it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM * STEP import: keep faces whose edge vertices sit slightly off their curves Some exporters write an edge's vertex beside the end of its curve, further off than the accuracy the file declares (a surface export declares 0.01 mm and puts a vertex 0.19 mm off two spline ends). The reader refused such edges and left the face, and with single-face bodies the body, out. A vertex may now sit up to the file's tolerance or 1/1000 of the model's size (the diagonal around its VERTEX_POINTs), whichever is larger, never more than the existing 1 mm ceiling. Spline and open-conic edges have the end control point moved onto the vertex, so every such edge meets its vertices exactly. The file's declared accuracy still governs closed-curve, seam and circle checks. * tess, io: review clean-ups (#2814) - A sliver face is one whose loops are all slit: drop_slits finds it in the retry after a failed plan, so the pre-check on every face (folded) is gone. - The flat fill uses cdt::triangulate (a lenient fill that leaves out sides crossing one already kept) and its flood-fill inside test, and the plane from geom::Plane. - Refinement only builds its indexes when a face was refused, takes the faces to plan again from edge_faces, and re-samples edges on the pool; Rules::finer for the finer rules. - One PackageWriter::fits for the model cache, the preview and the thumbnail. - The band split's ring tolerance lives in split.rs; comments say what the off-surface bound is now. - The CLI logger prints Level::as_str(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM --------- Co-authored-by: David Lackovic <lackovicdavid1234@gmail.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Ray <raykholo@users.noreply.github.com> |
||
|
|
ff8b09c225 |
Kernel paused: label new kernel issues, PRs and discussions for a maintainer to answer (#3994)
While a new geometry kernel is evaluated, a workflow labels new issues, pull requests and discussions about kernel work kernel-paused, so a maintainer finds them and answers in person. A pull request counts when it changes crates/kernel/ or vendor/truck*, anything else when its title names a kernel operation. Crash and data-loss reports and anyone who can push are left alone. CONTRIBUTING.md says so. Claude-Session: https://claude.ai/code/session_01LGeCa5jWWdroMWvXxN3LLM Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
975a08c992 |
ui-egui tests: hold OK's evaluation where a test checks it is computing (#4040)
Two OK-off-the-window-thread tests checked that OK was computing right after Enter without holding the evaluation. The preview's evaluation is in the cache, so the worker was usually in before OK's zero wait was over and OK applied at once: cancel_while_computing_applies_nothing failed in most runs (5 of 5 in a debug build, 4 of 5 with the ci profile). Both now hold the evaluation with the test gate, as their neighbour does, and let it go once the computing state is checked. |
||
|
|
55587f4ac4 |
View keys: a held arrow turns the view at a steady rate, one tween at most (#4090)
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
e94900933d |
IGES import: close small gaps between trim pieces (#3845) (#3846)
Consecutive pieces of a trim loop can miss each other by micrometres to a tenth of a millimetre, past the file's resolution, so the loop did not close and the face was dropped. Faces are now read first and sewn after: each small gap's ends, and the other piece ends at them, move to one vertex. Gaps over 0.1 mm or not small next to their pieces stay open; the sewing tolerance stays the file's. The stated accuracy covers how far a vertex moved, so the STEP reader keeps those edges. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
776541b081 |
Agent commands compute off the window thread, so the window stays live (opt-in) (#1989) (#3340)
An agent's design changes over the control channel (engine.execute, engine.batch) are evaluated ahead on a copy of the session on an `agent` worker, then run on the window thread reusing every feature computed there (doc::KeptResults, whatever the bounded evaluation cache dropped); the worker also makes the display meshes of the bodies they end with. Exports run on a copy. While a change computes, or the agent cursor acts one out, ui.*, inspection and screenshots answer; later design changes wait their turn. A chip names the command with Stop. A person's edit meanwhile goes first; a replaced design refuses the request. Preference: Preferences > AI, agent_off_thread, off by default. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
79a843c963 |
Transform: refuse a matrix that is not an affine placement (#3900)
transform_matrix took any finite 4x4 matrix. A perspective entry in the last row, or a singular linear part, was built into faces that mesh to nonsense: a revolved ring placed with such a matrix measured hundreds of millions of mm3, and a boolean on it ran for over half an hour before failing with "no result". Matrices come from design files and command parameters, so they are refused with KernelError::Invalid instead. |
||
|
|
1bcc3602b4 |
STEP export: a merged cylinder or cone face's loop starts on the side its angle grows from (#3394) (#3557)
* claim: #3394 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * STEP export: a merged cylinder or cone face's loop starts on the side its angle grows from (#3394) A whole-turn cylinder or cone face is written as one loop: ring, seam, ring, seam reversed. Readers lay the ring that follows the seam's first use out from the surface's angle 0, so that ring must turn the way the angle grows (anticlockwise about the written axis). Three of the four tapered legs in #3394 came out the other way and other readers dropped their sides. When the second ring turns against the angle, the loop now starts with it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
93684a4728 |
Expressions: a leading decimal comma such as ,5 is accepted (#2966) (#3797)
* claim: #2966 * Expressions: a leading decimal comma such as ,5 is accepted (#2966) In a comma-decimal locale `,5` means 0,5, but the lexer only started a number on a digit or a point. A comma now starts a number outside parentheses when a digit follows and an operand is expected (at the start or after + - * / ^). Commas after an operand keep their meaning, so function arguments and the existing error cases are unchanged. |
||
|
|
9db39f3d7d |
Holes from a sketch on a body's face drill that body (#2882) (#3770)
* claim: #2882 * Holes from a sketch on a body's face drill that body (#2882) A multi-point hole from a sketch attached to a body's face chose its side and moved its points onto whichever body lay along the direction, then cut every body, so points on a front body's face could drill the body behind it. `targets` was accepted and ignored. - solid.hole: holes at the points of a sketch on a body's face store that body as their participant (the lookup a face-sketch Join uses); `targets` sets the bodies to drill, `["*"]` every body; explicit participants still override. - Evaluation: for sketch-point holes with participants, the drilling side, the surface each point moves onto and pattern copies are found on those bodies only. Sketches on planes, position and Single holes, and saved holes without participants recompute as before; no design-format change. |
||
|
|
29369a0bb5 |
Extrude to an edge or corner ends at the requested plane (#3729) (#3748)
* claim: #3729 * Fix extrusion targets at planar face boundaries (#3729) |
||
|
|
5a9e771cc9 |
io: the 3MF and DXF budget tests do not check wall-clock time (#2998) (#2999)
* claim: #2998 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * io: the 3MF and DXF budget tests do not check wall-clock time nested_fan_out_of_empty_objects_is_bounded spends about 20 million visits reaching the work budget: 1.5 s alone, up to 40 s and more when every test binary runs at once, past its 30 s limit. The time checks run only after the reader returns, so a missing budget hangs these tests with or without them; the error, the empty geometry and the three vertices per placement are what show the budgets work. CONTRIBUTING.md: a test must not depend on wall-clock timing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: kezmdor <15539254+kezmdor@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
63cb48a4ee |
Measure: a body whose meshes leave a gap keeps its volume wherever it is (#2069)
* Measure: a body whose meshes leave a gap keeps its volume wherever it is
A part ring cut by solid.combine (two prisms through its ends, a notch
through its chamfer) measured 992.03 mm3 at the origin, 999.17 moved
100 mm and 1063.48 moved 1000 mm; it encloses 993.92. The reference
mesher leaves a crack where the notch meets the chamfer's cone: the
volume beside it is left out, and the divergence-theorem sums, taken
about the world origin, close the crack by a cone to the origin, so the
error grows with the body's distance from it.
A closed surface's area vectors sum to zero. When the picked meshes'
sum could move the volume by more than 1e-5 within the body's size, and
the display plan (which shares every edge's nodes between its faces) is
closed, the body is measured on the plan, about its box centre. Every
other body measures exactly as before.
Tests: the cut ring at the origin and moved by up to 10000 mm, against a
grid quadrature of the cut; a revolved ring of cones and cylinders moved
100/1000/10000 mm along each axis (1e-6); a cylinder and a frustum far
from the origin against hand values. Robustness seed 64 moves by 1.4e-6
and is recorded.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* Measure: a gap the display plan can't close is measured about the box's centre
When the meshes leave a gap and the display plan isn't closed either, the
sums used to fall back to the origin-based volume, which drifts with the
body's distance from the origin (7 % at 1000 mm for the part ring). The
per-face sums are now taken about the fine mesh's box centre, which closes
the gap by a cone to a point inside the body; over a closed mesh nothing
changes. The gap decision moves into gap_closed, and a unit test with a
cube left open by hand covers closed vs open meshes, the closed plan, and
the fallback with an open plan or none.
Seeds 14, 20, 40, 55 and 61 end with such a body and are recorded with
ROBUSTNESS_GOLDENS_BLESS (volumes move by -0.51 %, +0.16 %, +1.9e-4,
+9.0e-5 and -1.5e-5; steps, outcomes and counts unchanged).
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* Record robustness seed 86 after measuring bodies whose meshes leave a gap
Seed 86 was added on main by #2387 after this branch's goldens were recorded. Its last
body leaves a gap in its meshes, so the measure change here moves its volume by -0.27 %
and its area by +0.13 %; steps, outcome and counts are unchanged. Seed 86 passes
unchanged on main
|
||
|
|
36c732ddb7 |
Shell: show the tangent-chain face selection and explain full-body removal (#209) (#3809)
* claim: #209 * Shell: show tangent-chain faces and explain full-body removal (#209) |
||
|
|
fdec948abc |
Control channel: control.running lists what the app is running, across connections (#3654) (#3689)
* claim: #3654 * Control channel: control.running lists what the app is running, across connections (#3654) control.pending answers only for the connection that asks, so a second client, the MCP bridge after a reconnect or a script saw {"pending": null} while the app was busy. control.running answers for the whole app, the same on every connection and at once (the connection's own thread answers it, also while it is busy with a timed-out request): every request the app has been sent and not answered yet, oldest first, with its connection, id, method, command id (or a batch's step count), seconds since it arrived and whether it still waits its turn. A timed-out request stays listed until the app answers it, also after its connection closed. Parameters are never shown. The window marks a request started when it takes it (ControlRequest.started), which tells queued from running. The MCP server gets a read-only `running` tool. --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> |
||
|
|
7803b3968f |
Fix main: a test built Applying without the new seen field (#4001)
#3609 added Applying::seen; dialogs_sketch_tests' apply_keeps_the_panel_open_after_asynchronous_evaluation still built the struct without it, so ui-egui's tests stopped compiling on main. The test stands for a job that is already being shown, so seen is true (the behaviour it had before). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
cbac4eab3f |
OK off the window thread: a job that has just started waits a frame (#2929) (#3609)
* claim: #2929 Co-Authored-By: Claude Code <noreply@anthropic.com> * OK off the window thread: a job that has just started waits a frame (#2929) The off-thread evaluation of a feature dialog was taken up in the same frame it started, so a job whose worker had already finished was applied at once and the dialog never said it is computing. Under load the window thread is held up between starting the job and the check, and the feature appears where the computing state belongs - which is what made `apply_off_thread_tests::cancel_while_computing_applies_nothing` fail with `assertion failed: h.app.applying.is_some()`. A job that has just started now waits one frame: its result is taken up from the next one, so the dialog says it is computing before the feature appears. The app waits APPLY_AT_ONCE (150 ms) for the evaluation before it lets the window go on, so a job only exists when the evaluation took longer than that: the change shows the computing state for a frame in the 150-151 ms window, and nothing else moves. Co-Authored-By: Claude Code <noreply@anthropic.com> --------- Co-authored-by: jeremymiribung-blip <jeremymiribung-blip@users.noreply.github.com> Co-authored-by: Claude Code <noreply@anthropic.com> |
||
|
|
08eff4f9dd |
Sketch on a face: project from the model's own body, not a copy that meshes it again (#3981)
A sketch attached to a face is evaluated in the face's frame. When that frame is the body's own, the body was still rebuilt as a new ModelBody with empty mesh cells, so projecting the face's edges display-meshed a throwaway copy and the next cut or join meshed the same body a second time. On a body whose cut edges are slow to mesh this added about a second to each feature after a sketch on a face. In place, the anchored body is now the model's own clone and shares its mesh. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9b80163421 |
Extrudes from a nested STEP part's face join and cut it with the imported root active (#3223, #2872) (#3852)
* claim: #3223 * Extrudes from a nested STEP part's face join and cut it with the imported root active (#3223, #2872) Opening a STEP assembly leaves its root component active, and the root owns no body: its parts are components inside it. A profile sketched on such a part's face was therefore treated as outside the active scope. Join made a separate body instead of joining the part, and the automatic operation saw no material and offered New Body in either direction; an automatic extrude that came out as a cut found nothing to cut. A component with no body of its own now works on the bodies of the components inside it whose geometry lies in its own frame (as an import places them): Join targets the body whose face the sketch is on, the automatic operation looks at those bodies, and an extrude whose own operation is Cut or Intersect takes part in every body as an explicit cut already did. |
||
|
|
164554edba |
3MF import: production extension review follow-ups (#2089) (#3628)
* claim: #2089 (3MF production extension: review follow-ups) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * 3MF import: production extension review follow-ups (#2089) Follow-ups from the review of #2127: - Only the root model's build is read; other parts' build sections are ignored as the spec asks (a slicer's child build pointing at a thumbnail no longer matters). - A model part that can't be read fails only the placements that need it; the package-wide caps (part names, 1 GB of model XML) still refuse the package. The root XML is dropped once parsed and each part is read against the remaining budget. - Loops are reported apart from depth, keyed by (part, object). - Messages name parts as written; objects are kept in id order so parts are read in the same order every run; %XX escapes in part names are decoded; the model unit is a local of the parser. - Tests: a component without p:path stays in its part (T1), the same id in two parts is no loop (T2), a slicer-shaped project (T3), the placement budget across parts (T4), a loop through three parts and a chain past the depth cap (T5), broken parts and child builds (T6), escaped names; the hostile-parts test asserts its messages; the mutation test also mutates the parts' XML and zips it again. - Guide: what slicer-only data is not read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Tyler Chiriboga <18270301+Tyler-Chiriboga@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
453c6bcb14 |
Split schema contracts per command file and add shared field types (#2829) (#3558)
* Split the schema contracts into one module per command file `schema/commands.rs` becomes `schema/features.rs` (solid.box, solid.extrude, FeatureResult) and `schema/inspect.rs` (engine.describe), each with its own tests file holding its `schemas_and_the_key_check_agree` key lists and its `strict_keeps_todays_errors` cases, so conversions of different command files touch different files. The shared loops become helpers in `schema/tests.rs`; the assertions are unchanged. `engine.describe` gains a key-list test, and `schema_defaults_are_valid` now covers every command with a contract. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Add shared schema field types for the next conversions For the feature commands to be converted next, each deciding acceptance with the reader the handlers already use: - `FaceRef` and `FaceRefs` (`face::face_ref`, `features::face_points`) - `EdgeRef` and `EdgeRefs` (`features::edge_points`) - `SketchRef` (`features::sketch_id`) - `FeatureCommon`: `name`, `body_name`, `body_names` and `participants`, which `add_feature` reads for every feature, flattened into a contract with `deserialize_with = "feature_common"`, which keeps the key in the message and the issue's path. The shape checks of `face_ref`, `edge_points` and `sketch_id` (and `feature_sketch`) move into pure helpers (`face_ref_form`, `edge_ref_form`, `sketch_key`) that the handlers and the types share; the handlers behave as before. Tests check that each type and its schema accept what the reader accepts (apart from a face name's byte cap and an index written `1.0`), that the contract's messages match the handlers' errors, and that the handlers still look picks up one at a time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
f44ff18ca4 |
Split Body: each piece can be renamed on its own (#3510) (#3527)
* claim: #3510 * Split Body: each piece can be renamed on its own (#3510) A split named its new pieces after the split body every time (`Top (1)`), so renaming a piece did nothing, and renaming the split body renamed the other piece too (and broke the features that used it). The pieces now take the names body.rename stores, and a rename keeps the names later features derive from the renamed body. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
98cd67f029 |
Joins, cuts and intersects meet their tools where they are shown, across placed components (#3383) (#3384)
* claim: #3383 * Combine: tools from another component meet the target where they are shown (#3383) Bodies are evaluated in their own component's frame and an occurrence's placement is applied only for display. Combine passed tool bodies to the boolean untouched, so a tool in a component placed differently from the target's was read as if its coordinates were in the target's frame: a join that overlapped on screen gave two separate shells, and cuts and intersects missed the same way. Any placement difference did it, a turn or a plain move, in either direction. Combine now moves each tool by the inverse of the target's placement times the tool's own, the same placement used to show the body, keeping face lineage. A tool placed exactly like the target is left untouched, so combines within one component give the same result as before. Moving an occurrence now re-evaluates a combine that depends on it. * Joins, cuts and intersects draw their tools where they are shown (#3383) A primitive, extrude, revolve, loft, sweep, pipe or coil that joins, cuts or intersects bodies draws its tool in its own component's frame, but each body is kept in its own component's. A target in a component placed differently (an occurrence moved or turned, or a body moved into it) met the tool as if the tool's coordinates were in the target's frame: a join that overlapped on screen gave a separate lump 100 mm away, and cuts missed the same way. While such a feature evaluates, the tool now goes into each body's frame (the inverse of the body's placement times the feature's component's) wherever the join, cut or intersect meets it, and a body joined into one placed differently is moved into its frame. Bodies placed as the feature is are left untouched, so results within one component are unchanged. Features that name the bodies they change re-evaluate when an occurrence moves. This also settles the moved-fastener cut of #439 (Combine, earlier commit). * Through all and an extrude's contact tests see targets where they are shown (#3383) An extrude or revolve measured its through-all length, and tested where its tools meet the targets (a profile on a target's face, coplanar growth, holes over empty space, taper run-on), on the targets as stored in their own component's frame. With the tool now moved into a target placed differently, a through-all cut drawn from the root under a cube in a component moved 100 mm up was cut only as far as the cube is tall in its own frame, and missed it. These features now see the bodies they change that are placed differently moved into their own component's frame, the same moves the tools are taken back through, so the length reaches the target where it is shown. Bodies placed as the feature is are read as before. |
||
|
|
d9d6af51c6 |
Sheet metal: mirrored and copied sheet bodies stay sheet metal (#3353) (#3354)
* claim: #3353 * Sheet metal: mirrored and copied sheet bodies stay sheet metal Mirroring a sheet metal body into a new body gave a plain solid: the opposite-hand bracket had no flat pattern, DXF or bend table ("`Body1 (2)` is not a sheet metal body"). Copies from a body pattern or Move with copy lost their sheet model the same way. A copy now takes the sheet model with it (SheetBody::copied). A rigid copy moves the flat frame. A mirror moves the frame with its x axis turned round, so the thickness side stays, and mirrors everything in flat coordinates (x -> -x): base, flange bend lines (run from their far end, with their end extensions, slopes and tears swapped), panel shapes, cut-outs, pockets, bores, letters and base sketch lines. Arcs stay exact and loops keep their sense. A perforation field of a mirrored copy runs its grid from the right, so its holes are the mirror image too. The flat length, bends and K-factor are unchanged, and the copy takes further sheet metal features of its own. Mirror with combine is unchanged: the joined body has no single sheet model yet. Mirroring or patterning flange features is still refused. Sheet models are derived from the timeline, so no design format change. * Format: note the saved from_right of a mirrored sheet's perforation field The new `from_right` flag is saved in the design, so it gets a pending format note. No migration: a field without it runs from the left as before. |
||
|
|
38c710e72e |
Save designs with large STEP imports: compress the STEP part (#3221) (#3285)
* claim: #3221 * Save designs with large STEP imports: compress the STEP part (#3221) A STEP between 256 and 512 MiB imported fine but could not be saved: a design stored the STEP text uncompressed, and a design part is capped at 256 MiB. STEP sources are now always Deflated (level 2), may be as large as an import accepts inside the file, and an import that could not be saved even compressed is refused with a clear message. Reading stops at a part's declared size, so a decompression bomb is refused early. |
||
|
|
5b5b051e02 |
Delete in Edit Joint deletes that joint, and a refused joint delete says why (#3749) (#3776)
* claim: #3749 * Edit Joint: deleting the joint being edited closes the dialog and deletes it (#3749) A joint delete was dropped without a word while any dialog was open, and Edit Joint is a dialog. Deleting only the joint Edit Joint edits now cancels the dialog first (as its Cancel does) and goes through the usual selection.delete dry run; Delete with nothing else selected in Edit Joint targets that joint. Every other refusal (another dialog, a tool, a computing history, a loading file) now says why in the status bar. |
||
|
|
686576e368 |
Section Analysis: Edit reopens the dialog where the section was left (#3617)
Edit Section Analysis (its menu item, or a double-click on its browser row) opened the dialog at distance 0 with no plane, so moving the cut on by a millimetre meant picking the plane and typing the whole distance again. OK now keeps the dialog's plane pick, distance and flip with the cut they made, and Edit starts from them while the section shown (or hidden) is still that cut. The toolbar still starts a new section afresh, and a section made some other way (a command, an agent) opens the dialog as before. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
68e4186080 |
fix(ai-chat): replay with reasoning_effort none when OpenAI refuses tools (#3798) (#3817)
* claim: #3798 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix(ai-chat): replay once with reasoning_effort none when tools are refused (#3798) Newer OpenAI models answer HTTP 400 to function tools on /v1/chat/completions unless reasoning_effort is "none". On that exact refusal the request is sent again once with it, and later requests of the chat carry it directly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
b66ad0a9c9 |
Move shortcut respects the selected component (#3580) (#3588)
* claim: #3580 * fix(ui): move the selected component from its shortcut (#3580) |