84016f036e43baca088b0c1bd182a2d93da45c4e
858 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
84016f036e |
Redefine: the reply reports the features it rebuilt (#5694) (#8244)
* claim: #5694 * Redefine: the reply reports the features it rebuilt (#5694) timeline.redefine builds the edited feature and the features after it in its trial session; the session's own evaluation then only takes those results from what the trial kept, so the reply reported that second evaluation and read as "nothing was rebuilt" although the geometry changed. Report the trial's rebuild, plus anything the session still had to compute itself, as timeline.edit reports the same change; `restored` keeps counting only genuine reuse of earlier results. Tests: redefining_reports_the_features_it_rebuilt fails before the change with {"feature": 2, "recomputed": 0, "restored": 2} and passes after it; redefining_computes_the_later_features_once still guards the single computation (the reply doubles if the kept results are lost). |
||
|
|
9bcb2ffe68 |
Drawings: first landing from the drawings branch (#8249)
* Drawing sheets: sizes, the ISO 5457 border and its marks (#3875) (#5108) * Drawing sheets: sizes and the ISO 5457 border (#3875) A sheet is a paper size and an orientation: ISO A0 to A5, Letter, Legal, ANSI A to F, architectural A to E1, or a custom size (finite, above 0 and at most 5,000 mm a side), landscape by default and either way for every size. A border profile is the rule for its border, and layout() works it out for a sheet: the frame inside the margins, and the reference fields with their labels. The ISO profile has a 20 mm filing margin on the left and 10 mm elsewhere, a 0.7 mm frame, fields of 50 mm out from the centre lines with the corner fields taking what's left, rows lettered from the top without I and O (AA, AB and on past Z), columns numbered from the left, and an A4 sheet labelled on its top and right only. A profile can divide the frame equally instead, or have no grid. The records sit in geom, next to the section records, so saving, rendering and export can all use them. Nothing is saved or drawn yet: there is no command and no format change. Margins that leave no drawing space, values that aren't finite, fields outside 1 to 1000 mm, more than 200 equal fields and unknown JSON fields are refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: ISO 5457's centring and trimming marks (#3875) A drawing border profile now also holds the grid reference border and the centring and trimming marks, either of which can be left out. The ISO profile follows ISO 5457:1999 (read in its identical adoption, IS 10711:2001): - the grid reference border 5 mm outside the drawing border on every side, with the field labels between the two; - four centring marks on the sheet's centre lines, from the grid reference border to 10 mm inside the drawing border; - at each corner a trimming mark of two overlapping 10 x 5 mm rectangles, in the margin outside the grid reference border. The labelled sides are now a rule worked out for each sheet: ISO 5457's (the top and right of A4, all four sides of the others) or fixed sides. So one profile labels every size correctly. validate() checks what doesn't depend on the sheet, for when a profile is read; layout() calls it, then checks the rest against the sheet. Refused: - a grid reference border that isn't finite, is negative or is wider than a margin; - a centring mark that isn't above 0, would reach past the sheet's centre lines, or is on a drawing border those lines miss; - a trimming mark that isn't above 0, is wider than it is long, is wider than the margin left outside the grid reference border, or is longer than half the sheet's shorter side. The grid rule's JSON is now externally tagged ("none", {"from_centre": {"field_mm": 50}}), as the sheet size is, so an unknown field is refused in every form; the internally tagged "none" ignored one. Nothing is saved yet, so the shape change costs nothing. The names follow the glossary, and ISO 5457's "drawing sheets": the module is drawing_sheet (was sheet, which means sheet metal elsewhere here), DrawingBorderProfile and SheetLayout (were BorderProfile and BorderLayout), sheet_border and drawing_border (were paper and frame), and Sheet::size_mm (was paper_mm). The first part of S1 is still a draft, so the renames are made here rather than in a commit of their own. The extra centring marks ISO 5457 asks for on sheets larger than A0 aren't here yet. Still nothing is saved or drawn. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: a lighter built-in border, the filing margin a choice (#3875) Cameron's decisions after seeing the sheet in the app, 2026-10-23: - No trimming marks in the built-in profile: the filled corner blocks take a lot of ink. trimming_mark_mm stays, so a profile can still ask for them. - Centring marks stop at the drawing border: from the grid reference border to the drawing border, never into the drawing area (on A4 they crossed the tables). centring_mark_mm keeps its meaning, how far a mark reaches inside the drawing border, and now takes 0, the built-in value, as grid_border_mm already takes 0 for "on the drawing border". A mark of no length (a reach of 0 with no grid reference border) is refused. - Margins of 10 mm all round. ISO 5457's 20 mm filing margin on the left, for drawings that get bound, is a named choice: filing_margin, off when not given. On, it stands in for margins.left_mm, which is kept, and still checked, for when it's off again. The 20 mm is FILING_MARGIN_MM, and validate() and layout() both take the margins from one helper, laid_out_margins(). A3 landscape is now 400 x 277 at (10, 10), with eight 50 mm columns. With the filing margin it is 390 x 277 at (20, 10) again, the same as a 20 mm left margin set by hand. A profile with all three choices on (ISO 5457's full border) lays out exactly as the built-in profile did before, and the tests keep the old hand values for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing W23a workshop plate oracle fixtures (#4950) (#4962) * test(oracle): reviewer-aligned parameterized workshop plate fixtures (#4950) Independent analytic W23 expected values and seven verified models, including four R10 corners and the 2 mm tangent top chamfer. Document accepted Drawing states and commit regenerated docs/oracle.md from successful workflow run #29 (90/90 pass). * fix(oracle): correct W23 chamfer centroid and clarify drawing session ownership * Paper scene: plain records of what is drawn on a sheet (#4890 A1) (#5513) geom::paper holds what a sheet shows as plain data: groups of strokes and fills, each group tagged with the object that drew it (an opaque id) and its kind, with one validation pass over a bounded record count. Seg2's checks and the coordinate rule move into profile.rs so section and paper share them, and drawing_sheet takes its side and line limits from paper, so each limit is written once. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: centring marks across the whole margin (#3875) (#5554) The built-in sheet's centring marks now run from the trimmed sheet's edge to the drawing border. From the grid reference border, as before, a mark was the same length as a grid field mark, and on A3 it sat on one (the sheet's centre falls on a field edge), so it no longer read as a mark once the grid reference border's outline is left out (Cameron, after the prototype on #3875). - DrawingBorderProfile.centring_mark_start: sheet_edge (the built-in's, and when not given) or grid_border (ISO 5457's figure 5); ISO's full border in the tests asks for grid_border. - A mark still needs a length: one that stops on the drawing border needs room outside it on the side it starts from, every margin for sheet_edge, the grid reference border for grid_border. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing sheets: no centring or trimming mark longer than the largest sheet's side (#3875) (#6410) A border profile capped every length at 5000 mm (the largest sheet's side) but two: a centring mark's reach inside the drawing border and a trimming mark's length. A file could give either a huge whole number, such as 18446744073709551615. The read's number check passes whole numbers, so the profile took it as 1.8e19 mm, and saving wrote it as a decimal the next read refused: a drawing that saved but didn't open again. K2's fuzz test of drawing files (#3890) found it. Both now take the cap the margins have, `MAX_SIDE_MM`, in `validate`, so the file is refused when it's read. Layout's own checks against the sheet are unchanged, so a 5000 mm mark still validates and is refused only on a sheet too small for it. Tests: the hostile-profile test refuses 5000.000001 mm and 1.8e19 mm for each mark, and takes 5000 mm on its own; 4 planted faults (each cap removed or made one short) are all caught. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials types: phantom, reference, purchased and inseparable (#3874) (#5107) * Bill of materials types: phantom, reference, purchased and inseparable (#3874) A component's bill of materials type is a part property (`bom_type` in its metadata, set with component.metadata.set and read by component.metadata, as part_number is), so older releases keep it and no format change is needed. It isn't a design property: the Design Properties dialog doesn't list it and document.metadata.set refuses it. A word this build doesn't know reads as normal and is kept. assembly.bom counts by type: a phantom has no row and what it holds counts where it is placed, in the same rows as the same parts there; a reference counts nowhere, and nothing inside it does; purchased and inseparable components are one row, and in parts only an inseparable component's purchased parts are listed too. Rows of one part number but different types are different rows. Rows and children carry bom_type. With no types set the rows are as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Glossary: bill of materials and bill of materials type (#3874) The bill of materials types are a new idea, so the glossary gets their term, with the five types, and "normal" gets its fourth meaning in the table of words with more than one meaning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials types: a plain line for each (#3874) The guide's table and the glossary entry say what each type is for in plain words: something you make, something just to group, something to use as a reference, something you buy, something made as one piece. The names stay the five standard ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bill of materials: kits fold together only when their contents' types match (#3874) With group_children, two kits with one part number share a row when what they hold reads the same. That reading (kit_key) compared each child by part number and count, but not by its bill of materials type, though rows themselves are told apart by type. So a kit holding a made bolt and a kit holding a bought one, both KIT, folded into one KIT x2 row listing the first kit's bolt twice: the other type was lost, and which one depended on creation order. 0xlillith found it in review of #5107. kit_key now includes each child's type. Equal part number, type and contents still fold. Test: two KIT kits each holding a BOLT fold into one row of two; once one bolt is purchased they are two rows, each listing its own bolt. Planted fault (the type left out of the key): caught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing files: a drawing saved as a container or as plain JSON, never read as a design (#3890) (#7098) * File format families: drawings share the design format's versioning (#3890) The format code works for a family of files: its own tag, its own numbers and its own folder of change files, with one reading of a file's format, one refusal of a file a newer build saved and one upgrade for every family. Designs (solidcraft/N) are one family and keep everything they had: FORMAT and FORMATS are as they were, and pending_names, format_string, version_of and read mean what they did. Drawings (solidcraft-drawing/N) are the other, with format 1 as their first record and each later change one file in crates/doc/src/drawing/format/pending/, as design changes are. Nothing saved changes. A design tag never reads as a drawing's or the other way round, and a file that names no format is a design from before format strings, never a drawing. Every refusal names its family; a design's read word for word as before. A design listing a pending change this build doesn't have is now refused as a newer build's before its content is checked, as a newer number already was, so a newer build's fields never read as damage. The list reader is take_names(v, key, noun), the shape #4811 uses for its own list. For the maintainer, the release step changes: scripts/fold-format-pending.sh now folds every family that crates/doc/build.rs lists (FAMILIES), each into its own next number: designs into crates/doc/src/format/v<N>/ as before, drawings into crates/doc/src/drawing/format/v<N>/ from 2. With nothing pending in a family it says so and moves nothing. Its test folds a drawing change into v2 beside the design changes. docs/releasing.md, CONTRIBUTING.md and AGENTS.md say so. build.rs lists each family's changes from its own folder, each folder's versions contiguous from its own base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing record: format 1 of the drawing family (#3890) A drawing is now a record of its own (crates/doc/src/drawing.rs): its name, the designs it draws (sources: an id and the design file's path, relative to the drawing's folder as a linked design's is), its properties under the design metadata's rules, its units (each design's own, or one length unit of the expression unit table), its content language (a BCP 47 tag) and its sheets. A sheet holds its paper, a copy of its drawing border's profile, the resolution its pictures are rendered at (300 dpi unless it says, 25 to 2400), the component it documents and whether it is left out of the sheet count or of printing. This is format 1 of the drawing family; each later kind of record adds one file in crates/doc/src/drawing/format/pending/. The rules: one id counter for every object, raised above the largest id when a file is read and never rewound; every reference is an id that must resolve, or the file is damaged and refused, never patched; 1 to 1,000 sheets, at most 64 sources, names of 1 to 256 bytes, paths of 1 to 4,096 bytes without NUL. The same drawing always saves as the same bytes. Drawing::from_json reads at most 16 MiB of text, then runs the family's format check, the number check, the upgrade, the typed record (unknown fields refused everywhere) and Drawing::validate. The number check is now one function every family calls, Family::check_numbers, told which field holds other tools' data; a design's refusals read as before. Nothing saves or opens a drawing yet: the container is the next step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing ids: random and collision-free from format 1 (#3890) A drawing's objects now take random ids, the form jyviko chose on #3890 from #1017: no counter, so objects added on two branches never share an id and never edit one line. The allocator is one module for drawings now and designs later (#626 Phase 3), crates/doc/src/ids.rs: an IdSource gives nonzero u64s by splitmix64 from a seed, each checked against the ids in use and drawn again when it is one, or when it is 0. A run never draws a number twice, so at most one draw per id in use comes before a free one, and a seeded run over a file the same seed made still gets a new id. IdSource::seeded gives the same ids for tests and replays; IdSource::from_entropy seeds a session from the standard library's hash keys, the time and a count, with no new dependency. In a file an id is 13 characters of Crockford base32, lowercase (0000000000001 to fzzzzzzzzzzzz): ids::encode writes it and ids::decode reads only that spelling, case-sensitive, so an id has one form to search for. Anything else, 0 included, makes the drawing damaged. The drawing loses next_id (a file that holds one is refused), and Drawing::new and allocate_id take the IdSource. Messages name ids as the file writes them. The component a sheet documents stays its design's own number until designs move over. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing record: a drawing too large to reopen isn't saved (#3890) from_json reads at most MAX_DRAWING_BYTES (16 MiB), but to_json had no limit. Other tools' properties are kept as they came, and indenting them can grow a drawing read in at about 4 MB past 16 MiB (two million zeros in one array), so the next read refused what the save had just written. 0xlillith found it in review of #3891. to_json now returns a Result and refuses JSON longer than a read takes ("drawing too large to save (at most 16 MiB)"), so every drawing saved opens again. Nothing writes drawing files yet, so the error reaches the future file writer before it publishes anything. Test: that case is refused, and a smaller compact drawing saves and reopens unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing files: a drawing saved as a container or as plain JSON, never read as a design (#3890) K3 of the drawing storage plan (W11.2): the file a drawing is saved in. Nothing writes one from a command yet; opening and saving come with K5. - A drawing container is a design container holding `drawing.json` (Deflate, as `document.json`) in place of `document.json`, and `container.json` says so: {"content": "drawing", "format": "solidcraft-container/1"}. A design's `container.json` is as it was, with no `content`. The plain JSON form is the drawing's own text. Both give the same bytes every save, so a drawing can live in version control as text. - `io::file_kind` tells a design from a drawing by `container.json` or by the JSON's format. The design reader refuses a drawing ("this file is a SolidCraft drawing, not a design: open it as a drawing") and the drawing reader a design; plain JSON only asks when it isn't a design, so reading a design costs nothing more. A container's content this build doesn't know, or a drawing container that also holds a design's `document.json`, is refused. - `read_drawing` (bytes, either form), `read_drawing_file` (one seekable handle, the design reader's checks) and `write_drawing_container`; `DRAWING_EXT` (`scdwg`) and `is_drawing_path` beside the design's. - The container writer's set-up and finish, the file opening and the container sniffing move into one function each, which designs and drawings both use. The container's own checks (budgets, entries, the ZIP directory) are the design container's, word for word. Tests: a drawing round-trips through both forms byte for byte, and the container holds exactly `container.json` and `drawing.json`; `file_kind` on both forms of both kinds; each reader refuses the other's file; unknown content, a stray `document.json`, a missing drawing, an unknown container version and a damaged drawing refused; both forms from disk, and a directory refused; mutation fuzz of both forms (an error or a drawing, never a panic). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Paper scene: SVG of a sheet, its lines, arcs, cubics and fills (#4890 A3a) (#7032) The first export of a paper scene, as SVG first (jyviko and 0xlillith on #4890), from the research in the plan's §16. A3b adds ellipses, hyperbolas and Béziers above degree 3, which this refuses as "not supported yet". - `geom::paper::Prepared`: writers read a scene through `Scene::prepare`, which checks it first, so none reads one unchecked. Clipping goes there too, once (A8). - `geom::paper::arc_pieces`: an arc's ends in pieces of at most a quarter turn, the last its own end. A half turn drawn from its ends is ill-conditioned: rounded to the nanometre (six decimals of a millimetre) its centre moves up to 1e-2 mm, where a quarter turn's stays under 1e-6 mm. - `io::paper::paper_svg`: one user unit a millimetre, the size in mm on the root; y flipped by writing the height less y, so the file's numbers are page coordinates and an anticlockwise arc has sweep flag 0; lines `L`, arcs `A` (never large-arc), cubics `C`, parabolas `Q`; fills black and even-odd; one path per item; groups as `data-object` and `data-kind` (object ids can't be XML ids). No background, so cutters see only the marks. - Numbers are whole nanometres (six decimals of a millimetre): no exponent, no "-0", the same bytes every time. They are the writer's own state too, so a joint is written once and a closed path ends exactly on its first point. Numbers are written straight onto the document, with no text made per number. A width under half a nanometre is written as one, and a piece too short for the grid is merged into the next, both counted in the report; a path's last piece has no next, so it is kept however short (unless it has no length). Output over 64 MiB is refused. Tests: the A3 drawing border's whole document; quarter, 270°, clockwise and whole-turn arcs, and a circle of two halves giving the same four quarters; the quarter-turn boundary both sides; cubics and parabolas, and the conics refused; the number format; a closed path whose start and end round apart; a sliver merged; an open path's short last line and arc kept, and one of no length dropped; read back through our own SVG reader (lines exactly, the arc as an arc); the scene's JSON mutated into the writer (never a panic). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing W17a: view definitions as data (#4816) (#4817) * claim: #4816 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing views as data: named views, scales and the map onto paper (#4816, W17a P1) What a drawing view is, before anything draws it (geom::drawing_view): - NamedView: the six principal views and the isometric views from the four upper corners, each an exact basis (a Plane whose normal points back at the viewer), never taken from a camera, whose pitch clamp would tilt a top view, with no -0 to write out; `iso` reads as the front-right one. - basis_looking: any other view from its direction, an up and an origin (paper x = direction x up, paper y = x x direction), refusing a zero direction, an up along it, or an origin that isn't finite or within 1e12 mm. W07's {direction, up, origin} view reads through it. - Scale: paper : model as two positive numbers, read and written as "1:2", from 1:100000 to 1000:1; Scale::fit picks the largest ISO 5455 preset (50:1 to 1:10000) at which a view fits a space (W07's "fits the page" default), compared as size x paper <= room x model so an exact fit at a reduction isn't lost to rounding. - ViewFrame: a view's basis, scale and place on paper, the point of its plane at `centre` landing at `position_mm`. Its paper map moves the view's curves and their accuracy onto paper (paper error = scale x model error); `boundary` maps a box of its plane onto paper from its four corners. In geom, where Seg2 lives: - Similarity2 and Seg2::similar (new): scale, turn and shift a segment exactly, an arc staying an arc. Similarity2::new refuses a scale that isn't above 0 and works the turn out once, not per point; - Seg2::map_controls: a segment's control points mapped by any function. It was doc's sheet::map_controls; its four callers in doc use the method now, unchanged. CurveAccuracy::scaled gives a curve's accuracy at another scale. Tests: each named view's basis and viewer side, and the same bases from a direction and up; a 50 mm cube in every principal view at 1:1 and 1:2, and in isometric (edges 50 x sqrt(2/3), outline 50 x sqrt(2)); the view's centre on its position (W07's 100 x 20 front view on A3 at 2:1); scales read, written and refused; the fitted scale, an exact fit at 1:5 and ISO's smallest; no -0 in any named view's axes; an origin refused by its own message; hostile bases, centres and positions; every segment kind moved by a similarity, and the similarities refused; scaled accuracy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Drawing views: the bottom view pinned, square near parallel, bounded scales and boxes (#4816) From DevonHope's review of #4817: - The tests pin all six principal views exactly. The direction-and-up test uses literal ups, so a bottom view turned half round now fails it. - basis_looking squares x to the direction before normalising. Near the 1e-9 threshold the normal was up to 8.8e-9 rad off; now it is about 1e-16. - Scale::fit fits nothing for a size or room that is negative or not finite. A size of 0 still sets no limit that way. - Each side of a scale is 1e-6 to 1e6, so a scale writes at most 49 characters. - ViewFrame::boundary returns a Result. It refuses a box that is inside out or not finite on paper, instead of dropping a corner. - paper_map, boundary and seg_to_paper say which coordinates they take. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing W18 S2: title blocks as data (#3875) (#3877) * Title blocks: what a cell shows and where its text goes (#3875) geom::cell holds a title-block cell's content: parts of text and fields (component, drawing, sheet, revision or prompt, by key, with an optional unit and decimals kept as written for the resolver to check), at most 64 parts and 4096 bytes of text, with no control character but a line break. Beside it are a resolved value (live, overridden and drifted, or missing, with "-" for each part that couldn't be read and why), an override with the value it replaced, and the projection a drawing's views use (first or third angle), which the title block's symbol will read. A fit warns and never cuts: a count of characters, not bytes, with its own count for text in Chinese, Japanese, Korean or Yi characters. The cell text rule places a label and a value: the label's baseline 1 mm plus its cap height below the cell's top, the value box under it inset by 1 mm, one line centred in the box, and wrapped or several lines down from its top at the font's pitch, with a warning when the last falls below the box. Wrapping by width, width warnings and glyphs a font lacks need the text measured, so they wait for the paper scene's text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Title blocks: definitions and their place on a sheet (#3875) geom::title_block holds a title block's definition: its size (1 to 1000 mm a side), its outline and cell line widths, and up to 64 cells. Each cell has a snake-case name of its own, a rectangle measured from the block's lower-right corner, an optional one-line label with its cap height, and a value: text from cell content, with its cap height, alignment and fit, or the projection symbol, which reads the drawing's projection and is never fixed in the block. validate() checks a definition on its own, as when one is read: cells inside the block and not overlapping (touching is fine), label and value cap heights that fit, and the content's own limits. layout() puts the block on the drawing border's lower-right corner of a sheet, refusing one that doesn't fit, and gives each cell's rectangle, its label's place and its value box by the cell text rule. On A3 landscape a 180 x 54 mm block runs from (230, 10) to (410, 64); it fits A5 landscape and every larger sheet, but not A5 upright. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cell text: a value box lies within the paper's coordinates (#3875) place_lines took any finite, ordered value box, but centring one far out (min x 1e308, max x 1.1e308) overflows: the anchor came back infinite, with no warning. 0xlillith found it in review of #3877. The paper scene already bounds every coordinate it holds by MAX_COORDINATE_MM (twenty times the longest sheet side). That limit is now public, and place_lines keeps its box inside it, so its anchor is always finite: one rule for what a paper coordinate may be. Tests: the hostile-box test refuses both overflow cases from the review and a box just past the limit on each side, and places lines in a box the size of the whole paper limit. The fuzz test's numbers now include values past the limit (1.1e5, ±1e308). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Title blocks: padding from the lines' inner edges, one label rule, nothing unread (#3875) A cell's text is padded from the inner edge of its lines: each side of a cell moves in by half the line drawn on it (the outline's on the block's edges, a cell line's inside), so a wide outline never covers the text. Before, the padding ran from the line's centre. The label's one-line rule lives with the cell text rules (`cell::check_label`), where parts lists will find it. The cell types nothing read yet (`Override`, `Resolved`, `State`, `Problem`, `Reason` and `MISSING`) wait for the resolver that will read them. The tests check the exact thresholds inside the lines (a label that leaves no room, a value that just fits), pick each of the lines, alignment and wrapping on their own so every combination comes up, and lay fuzzed blocks out on every standard sheet, either way, with and without the filing margin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Title blocks: the drawing border's line, descenders, room where the block sits (#3875) From DevonHope's review of #3877: - Each cell's lines are clamped to the inner edge of the drawing border's line. That line runs along the block's right and bottom edges, and along any other edge it reaches, as when the block fills the border. Aabb2::intersection, the 2D twin of Aabb3's, does the clamping. - layout checks each cell's room again where the block sits (place_cells, which validate runs at the origin), so rounding at the real corner can't turn a cell inside out. - The cell text rule counts descenders, at 3/10 of the cap height (ISO 3098's lettering B). They may reach into the padding under a value box, never past it to a line. place_lines warns Height when they would, and validate asks it whether one line fits. - The module doc no longer links to a private function. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Drawing W06a: exact orthographic hidden lines for the analytic subset (#2455) (#2457) * Drawing W06a: exact orthographic hidden lines for the analytic subset (#2455) crates/geom/src/hlr (L0): prepare once per body, then hidden_lines for a scene of placed bodies. Edges and face silhouettes are projected from their exact curves, split where projections cross, and each piece is classified by rays toward the viewer against the trimmed faces: visible, hidden or explicitly uncertain, never guessed. Planes, cylinders, cones, spheres and tori are supported whether stored as analytic records, revolutions or spline patches; freeform faces are reported and make what they could hide uncertain. Screen geometry is Seg2 with the W01a accuracy vocabulary: exact lines and conic arcs where the projection is exact, bounded chords otherwise. docs/drawing-hlr.md holds the contract and its limits. * geom/hlr: handle the brep records main gained in #3093 Main's exact model storage (#3093) added Curve::SurfaceIntersection, Surface::PlaneThrough and Surface::PlacedRevolution, and the HLR matches on the records no longer compiled. A plane through three points is a plane: it is trimmed and intersected as one, and a box stored that way draws the same bits as one with axis-stored planes. The procedural intersection curve and the placed revolution (whose affine placement may scale it unevenly) are refused by prepare as not supported yet, until the kernel adapter handles them. The records' positions move with the body's centre like the others. * geom/hlr: pad plane faces' boxes, so a plane record off by rounding still hides Plane faces took the box of their boundary chords unpadded, flat along the normal. When the plane record and its edges disagree by rounding (a unit cube's top plane one ulp above its edges, a 100 mm cube's 1e-11), the ray toward the viewer reached the plane just outside that box, the slab test culled the hit, and the back edges came out Visible with no doubt. Every face's box is now padded by 1e-6 of its size, as curved faces' boxes already were. Reported by DevonHope on #2457. * geom/hlr: limits from review: trim samples, scene extent, crossing pairs, surface groups From DevonHope's review of #2457: - Options::trim_samples must be 1 to MAX_TRIM_SAMPLES (4096). - Placed bodies must stay within MAX_COORDINATE (1e12 mm, as section and brep bound stored numbers). Placements 1e200 apart made the scene's size infinite and every tolerance taken from it with it, so everything came out Visible. - The crossing search counts its candidate pairs before it starts and meets each pair only in the first grid cell the two segments share, instead of keeping a set of the pairs met, which could outgrow wasm's 4 GB before the 500 million pair budget tripped. The same pairs in the same order. - prepare groups faces on one quadric or torus by comparing each face with the faces of its kind whose size agrees to the tolerance (sorted), not with every face; at most 50 million comparisons. prepare_cancellable polls a cancel callback between edges, faces and comparisons. * geom/hlr: boundary chords on a grid, and no fine pass over coincident curved chords The cost items of DevonHope's review of #2457: - Every ray hit asked how far it lies from its face's boundary by scanning all of the face's chords (4096 per circle; a plate's face with 256 holes has about a million). The chords are now bucketed on a uniform grid over the boundary's box, cells at least as long as the longest chord, and the test looks only at the cells around the point. It finds exactly the chords the scan finds. - Chords of two curved curves that lie on each other end to end (aligned holes seen along their axes) were cut into 16 by 16 pieces and intersected, to find crossings that are only noise within the curves' tolerance. They are now skipped; visibility changes where a coincident run starts or ends, and chords that only partly overlap still find those. - Fixtures: a plate with holes, coaxial cylinders seen along their axis, and 300 placements. * geom/hlr: pad boxes by the body's coordinates too; coincident chords only to rounding Review of the previous commits found two holes: - The padding grew with the face's size, but rounding grows with where the body was modelled: a 0.001 mm cube 1e7 mm out, its top plane one step (1.9e-9 mm) above its edges, still had its hit culled. The pad now adds 1e-12 of the body's offset. - Two chords were taken for coincident when their ends lay within each other's sag, which in a coarse scene can hide real crossings: an arc can bulge across a line 1 mm off its chord twice. Only chords that coincide to rounding are skipped now; identical projections, the costly case, still are. * geom/hlr: coincident curves meeting at shared sample points do not cross Timing the review's scenes showed that skipping coincident chords was not enough: chords of two coincident curves also touch end to end at every sample point they share, and each touch was a crossing to refine and split at. 64 coaxial cylinders seen along their axis gave 8.3 million crossings (19 s), 64 cylinders one behind another along the line of sight 4.2 million (214 s; before these commits the crossing budget refused it). A touch at a shared sample point is now dropped when the two curves also coincide, to rounding, on both sides of it. Where a coincident run starts or ends one side differs, and the touch is kept. * geom/hlr: the own-face margin allows for rounding where a body was modelled The far 0.001 mm cube of the previous commit showed a second effect of records rounded at large coordinates: its top plane, one ulp (1.9e-9 mm) above its edges, hid the top edges themselves, because a ray leaving an edge met its own face 3.2e-9 mm along, past the own-face margin of 1e-6 of the face (1.4e-9). The margin now also covers 1e-14 of the body's offset (about 45 ulps of its coordinates), which only matters for parts far smaller than their distance from the origin. * geom/hlr: no parity test for a hit on the boundary, where it is uncertain anyway * docs/drawing-hlr: the fixtures of the review's second round --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> --------- Co-authored-by: CamWight <91156642+CamWight@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Benny1496 <163034806+Benny1496@users.noreply.github.com> Co-authored-by: Mateusz Sych <151755914+SychPL@users.noreply.github.com> Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> |
||
|
|
d6b1d03695 |
Browser: an exact body name wins over a case-only sketch match (#6967) (#7004)
* claim: #6967 * Browser: an exact body name wins over a case-only sketch match (#6967) |
||
|
|
387e86729c |
Sketch: the rounded rectangle completes from a vertex like the plain one (#7878) (#7943)
* claim: #7878 * Sketch: the rounded rectangle completes from a vertex start point (#7878) |
||
|
|
64ff25f380 |
Fix sketch drag breaking midpoint-constrained line solver (#7635) (#7810)
* claim: #7635 * Keep the drag cursor on the manifold of an ill-conditioned sketch (#7635) A construction line collapsed to zero length makes its angle row's entries on that line ~1e7 while the same row's entries on the measured line are ~1. Dragging an endpoint of the midpoint-pinned line then failed two ways: the null-space rank analysis, which scaled rows only, hid the small (physically meaningful) entries below its pivot tolerance and let the measured line rotate freely; and the cursor's refinement, which demanded a TOL-tight correction the ill-conditioned system cannot deliver, gave up entirely and let the drag leave an unsolvable step placed - breaking the perpendicular and angle constraints. Equilibrate the null-space Jacobian on both sides (columns by their largest entry, then rows) so one row's entries share a scale, and let the cursor keep working from a pose the solver itself calls solved (residual below ACCEPT) when refinement stalls above TOL, accepting corrected trials at the same tolerance the final validation uses. --------- Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com> |
||
|
|
1e3cb3e36e |
Motion interference: a check cut short is not clear, and budget_s gives it time (#7855) (#7934)
* claim: #7855 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019FAWPuFoh9qxn2uS2j53QZ * Motion interference: a check cut short by its work budget is not clear (#7855) motion.interference stops when its work budget runs out (truncated) but answered clear: collisions.is_empty(), so a check that reached only the first steps read as a pass: a gear pair checked for 14 of 61 samples was "clear". clear is now true only when every sample was checked and none collide. The budget is an argument of interference_within, so a test can cut a check short: B slides up to touching A, a full check is clear, and the least work that checks a first step stops after 1 of 16 samples with clear: false (it was clear: true before). The guide and the mechanisms skill say the same. The issue's second request, a budget_s on motion.interference, is not here. Refs #7855. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019FAWPuFoh9qxn2uS2j53QZ * Motion interference: budget_s gives a check the time it needs (#7855) The work budget is fixed, so a gear pair drawn in detail was cut short after a few samples, or refused before its first one. motion.interference now takes budget_s (seconds, above 0, at most 86400, as inspect.interference allows): the check then runs until that time instead of the work budget, looked at before each sample, and echoes budget_s in its answer. Without budget_s nothing changes. The refusal before a first step now names the budget that ran out and suggests budget_s. Tests: given a time, the smallest work budget (which checks no step) no longer stops the check, through motion.interference too; budget_s 0, -1, 1e9 and "soon" are refused. Fixes #7855. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019FAWPuFoh9qxn2uS2j53QZ --------- Co-authored-by: Claude <noreply@anthropic.com> |
||
|
|
d56dc310b0 |
Browser: Collapse All keeps the clicked row open (#8032) (#8033)
Collapse All from a component or placement row folds everything under that row and leaves the row itself open, matching the whole-tree Collapse All, which already keeps the design row open. |
||
|
|
59faca3850 |
Canvas and Decal: send the picked face, so a large design takes the image (#5592) (#5593)
* claim: #5592 * Canvas and Decal: send the picked face, so a large design takes the image (#5592) A click with Canvas or Decal sent only the point, so the engine searched every face of every body for it and gave up on a large design ("face capture work limit exceeded"). Send the picked body, face index and path as Create Sketch does; canvas.decal takes that face pick too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Canvas and Decal test: drop the check that a point alone gives up On upstream main a sketch on a face by its point alone no longer gives up on this design, so the test keeps only what the picked face has to do: both images land on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b86c75544e | Appearance: read the look chain and replace a look everywhere in one undo step (#6428) | ||
|
|
0b2efd60b9 | Render browser: scene tree with Environment, Lights, Shots and Objects rows, resolved appearances and a Browser selection (#6427) | ||
|
|
54f613e4dd |
Preserve linked component materials and appearances (#7609) (#7616)
* Fix linked component materials and appearances (#7609) * Linked components: the cached link read carries the source properties Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Update Links: a link without recorded inherited properties is read again Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Preserve authored linked-face overrides and apply cached source properties --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
18fe82ab26 | Render workspace: focus view, compact docks, a Browser chip at narrow widths and a localisation pass (#7376) | ||
|
|
1781b4d323 | Render workspace: move the Inspector or Browser dock to either side with view.render_dock and a header menu (#7230) | ||
|
|
110efa3598 | Render: allow picking in the product view with a Body, Face or Component filter and outline the selection in the product pass only (#6426) | ||
|
|
2cdfe050db |
Extrude to Object: a Join leaves the body it runs to alone when that body is in another component (#7975)
#6471 joined the body a To Object extent runs to into the tool, whatever its component. A connector's boss extruded up to an enclosure's face (each in its own component) merged the enclosure into the connector, and features referencing the swallowed body failed after it. The body it runs to now joins only when it is in the feature's own component, or when the feature names it as a target. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
00e31c24fd |
Sketch: Delete on a picked profile deletes the curves around it (#7107) (#7120)
* claim: #7107 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: Delete on a picked profile deletes the curves around it (#7107) While a sketch is being edited, a profile picked by clicking inside a shape stands for the curves of its outer loop, so Delete removes the shape instead of failing with "a profile goes with its sketch". Holes inside it are shapes of their own and stay. Outside the sketch a profile still goes only with its sketch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Delete a picked letter's whole text, not just its outline (#7107) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
03b8f4138b |
New designs save as .sc; .solidcraft files still open (#7325)
* claim: new designs save as .sc Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * New designs save as .sc; .solidcraft files still open and keep their name on Save DESIGN_EXT is now "sc"; DESIGN_EXTS lists sc, solidcraft and solvecraft and every open path (dialogs, drag-drop, recent files, CLI, MCP, links, the web picker) accepts all three. Save of an opened .solidcraft file writes that file; Save As, autosave, recovery and crash reports use .sc. Windows, macOS and Linux register .sc alongside the older extensions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Update UI tests for the .sc default extension Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
7fad8dbec0 |
Fix feature creation at timeline end (#7620)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
ca75f86947 |
Sketch: deleting a dimension in a rolled-back history no longer rebuilds the features after the marker (#7253) (#7425)
* claim: #7253 * Sketch: deleting a dimension in a rolled-back history no longer rebuilds the features after the marker (#7253) The check before a delete evaluated the whole history twice when the timeline was rolled back. Removing a sketch constraint changes the later features' cache keys, so on a long history Delete on a dimension took minutes. When the design differs only in sketch constraints (and model parameters nothing uses any more) and each changed sketch solves to the same geometry, profiles and ends, the features after the marker see the same inputs: compare the live models only. Anything else still gets the full check, so the report is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ebdc0bc07e |
Assembly: deeply nested body selection no longer stalls the window (#7502) (#7694)
* claim: #7502 * Assembly: name placed bodies from a per-design index, reveal the Browser from the body's path, evict cache entries singly (#7502) * Release the placement index before in-place document edits so pinning body names stays in place --------- Co-authored-by: Dahak Builds <dahakbuilds@users.noreply.github.com> |
||
|
|
98abb249c4 |
Cylinder: place by distances from reference edges, like Hole (#6380) (#6381)
* claim: #6380 * Cylinder: place by distances from reference edges, like Hole (#6380) A Cylinder standing on a flat face can take up to two straight edges of that face as references, each with the distance of its base centre from the edge's line, measured in the face's plane, as a Single hole does (#37). `solid.cylinder` takes them as `references: [{edge, distance}]` with a numeric `base`; the edges are found again by their persistent names, else their points, so the cylinder follows them when the part changes, and each distance is a parameter (an input of Inspect Feature). A cylinder without references stays at its base, as before. In the Cylinder window, started on a picked face, Reference 1 and 2 take the edges, each with its Distance measured from the pick, so it works with the mouse alone; the canvas shows each distance with a box to type it in, and Edit Feature picks the edges again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder: Edit Feature shows each reference edge input once (#6380) A face selected when Edit Feature opened the window had already added the reference inputs; the edit added them a second time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder references: the measured-once cost test's cylinder has none (#6380) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder: pick the face it stands on in its window, then the edges (#6380) The Cylinder window took its place only from a face selected before it opened, so started first it stood at the origin and offered no reference edges. It now has a Face input before Reference 1 and 2, as the Hole window does: start Cylinder, click the face, click the edges, OK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Glossary: reference edge, and "Reference" among the words with more than one meaning (#6380) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder edge references: the Cone dialog (#6250) gets the references field too The Cone primitive landed on main after this branch began; its dialog initialisers lacked the `refs` field the Primitive kind gained here. The dense form check for Cylinder fills only its fields: its face and reference edges place it, which the reference tests cover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Cylinder: declare references in its contract; reference-placed cylinders are not placement-independent Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
295d04932f |
Render workspace: stage bar, aligned floating docks and the Shots strip host (#6281) (#6296)
* claim: #6281 * Render workspace: stage bar, aligned floating docks and the Shots strip host |
||
|
|
c8c5c882de |
Sketch: name = value in a drawing tool's value box defines the parameter (#7567) (#7660)
* claim: #7567 * Sketch: a drawing tool's value box takes `name = value` (#7567) While drawing, a value box (circle diameter, line length, rectangle width and height, slot, arc, polygon) now accepts `name = expression` and `#name = expression`, as the Dimension tool already does: the shape is drawn at the expression's size and its dimension defines and uses the user parameter `name`, in one undo step. - sketch.draw.dimensioned checks a definition's right-hand side, read as the new parameter will hold it (a bare number in the design's unit), and passes the text on to sketch.dimension; the reply lists `defined`. - The value boxes size the preview and validate by the right-hand side, refuse a definition in a box that is not a dimension (polygon sides, rounded rectangle corner radius, conic rho), and the status line names the parameters defined. - Guides: parameters and sketching. Fixes #7567 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e2d409e6ed |
Save: a design changed while it is written stays unsaved, and scripts wait for it (#6003) (#7619)
* claim: #6003 * Save: a design changed while it is written stays unsaved, and scripts wait for it (#6003) Two of the gaps @raykholo found in #6003 were still open on main: - `engine.script` ran while the window's Save was being written: it calls the session directly, past `SolveApp::run`'s file-operation guard, and `drain_control` did not hold design-changing requests for a save. They now wait for the save like they wait for a file being loaded or picked. - `adopt_save` marked whatever the session held when the save finished as saved. It now takes up the state the save wrote (`done.saved`, and its visibility), so a change made meanwhile stays unsaved instead of being lost on close without a prompt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FN5eEMrqWWXqi65FcK8GXq --------- Co-authored-by: sascha2101 <221609842+sascha2101@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
d139e415e4 |
Sketch: switch a circle or arc dimension between radius and diameter (#7499) (#7729)
* Sketch: switch a circle or arc dimension between radius and diameter (#7499) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch: Toggle Radius / Diameter for a circle's or an arc's dimension (#7499) New command sketch.toggle_diameter, with input and output schemas, and a context-menu item on a single selected radius or diameter dimension. The circle keeps its size: the dimension's parameter is halved or doubled (a plain value is rewritten, an expression is wrapped). Refused, with nothing changed, when anything else uses that parameter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Phanoob <phanoob@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
d14dbe5e39 |
Move: a copying Move can be edited from the History (#7741) (#7761)
* claim: #7741 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Move: a copying Move can be edited from the History (#7741) Editing a feature runs its command on a scratch session with the marker right after it. For the last feature that marker sits at the end of the timeline, and place_feature pushed the new feature after it, rolled back, so a copying Move found no copies and refused the edit. A marker right after the last feature now moves on past a feature added there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
98658142c0 |
Delete: deleting one instance of a component takes its joints with it (#7749) (#7782)
* claim: #7749 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Delete: deleting one instance of a component takes its joints with it (#7749) Deleting an occurrence while its component had other instances dropped only the occurrence: the joints on it, their motion links, joint origins, contact set places and exploded moves stayed, so a joint stayed in the Browser naming an occurrence that was gone. The clean-up that remove_component_tree did is now Document::remove_occurrences, used by both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
28b27aac8f |
Saved model: kept only when every body decodes to itself (#6760) (#6761)
The native codec gave one body back with other topology: a pattern copy cut by an automatic extrude, 10 faces, 18 edges and 10 vertices, came back with 12 vertices, so the design opened with another body than it was saved with. Encoded::of now decodes each body it encodes and keeps the model only when every body comes back with the same face, edge, vertex and shell counts; otherwise the design is saved without its model, as when the encoder refuses a body, and opening it evaluates it. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
4515af3eb9 |
Update Links reads again only the linked designs that changed (#5606) (#5674)
* Update Links reads again only the linked designs that changed (#5606) Update Links read, evaluated and STEP round-tripped every linked design on every run. Remember a digest of each linked file, of the STEP it gave and of its face names, and skip a link whose file, bodies and face names are all unchanged. Read a linked design through its saved model when the file has one, as opening it does. * Drop an import the rebase left unused Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
35913ced46 |
Fix flaky dielectric_preflight_and_start test: render a view that does not hit a box edge (#7722)
The default view sends the single pixel's ray through a box edge, which the raytracer rejects as an ambiguous interface normal. The job then ended Failed whenever the render thread got ahead of render.cancel (about 7% of runs under load), and the test only accepted Cancelled or Completed. Render off-axis so the outcome no longer depends on that race, and print the phase and error if it ever fails again. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5bd8387cf7 |
Repeat Last Command in the command palette, with a key you can change (#7077) (#7353)
* claim: #7077 * Repeat Last Command in command search, with a key you can change (#7077) Shift+R already started the last tool or dialog again (#3045), but it was a key the app kept for itself: command search could not find it and Keyboard Shortcuts could not change it. It is now the command edit.repeat, with Shift+R as its default key. A call through the engine is refused, because only the app has a tool to start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Locales: Arabic and Hebrew for the new strings ar and he are complete catalogs on main now (#3458): every new message needs them. The pending-messages test compares right-to-left messages in display order once #7532 lands (#7527). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Locales: Vietnamese for the new strings Vietnamese became a complete catalog on main (#5823), so every new English message needs it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ec877315c3 |
Sketch: add points to an existing spline (#6533) (#7384)
* claim: #6533 * Sketch: add points to an existing spline (#6533) A spline could not take more points after it was drawn. The new command sketch.spline.insert_point inserts a fit point on the curve where it passes nearest a spot, between its neighbours, or adds a new first or last point. Existing points keep their indices, so constraints stay. A right-click on a fit point spline offers Add Spline Point at the clicked spot. Control point splines are refused for now: with uniform knots one more control point would reshape the whole curve. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Locales: Arabic and Hebrew for Add Spline Point ar and he are complete catalogs on main now (#3458). The pending-messages test compares right-to-left messages in display order once #7532 lands (#7527). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Locales: Vietnamese for the new strings Vietnamese became a complete catalog on main (#5823), so every new English message needs it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
04e4e72ea1 |
History: delete a folder with its features, and suppress a whole folder (#7219) (#7220)
* claim: #7219 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * History: delete a folder with its features, and suppress a whole folder (#7219) `timeline.delete` and `timeline.suppress` take `groups: [timeline folder ids]`: every feature in those folders and their nested folders, in one undo step. A delete takes the folders themselves too; `timeline.ungroup` still keeps the features. The History on the left offers Suppress/Unsuppress Selected Folders and Delete Folders and Features… (asking first, like Delete Selected Features…, when something outside needs them); a folder whose features are all suppressed is drawn faint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * History folder actions: Arabic, Hebrew and Vietnamese strings (complete catalogs) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
2151bc0497 |
Drive Joints: say why a rigid joint can't be driven and offer Edit Joint (#6981) (#7051)
* claim: #6981 * Drive Joints: say why a rigid joint can't be driven and offer Edit Joint (#6981) Drive Joints opened on joint 0 when no joint moved, and its preview ran joint.drive on that rigid joint, so the dialog showed a red "a rigid joint does not move" with a Create Issue button. The dialog now says a rigid joint holds its parts still and how to let them move (Revolute to rotate, Slider to slide, Cylindrical for both), with an Edit Joint button that turns it into Edit Joint on that joint. Its commands refuse a rigid joint, so nothing is previewed and OK stays off. A rigid joint picked in the browser opens Drive Joints on it to say the same; the joint box lists only joints that move. joint.drive's own refusal names the types that move and joint.edit. * Drive Joints: the rigid joint message in Arabic, Hebrew and Vietnamese (#6981) Main now delivers ar, he and vi complete, so every new message needs them. --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> |
||
|
|
1a9c4cd99d |
Sketch: a circumscribed polygon stays regular when dragged (#7395) (#7438)
* claim: #7395 * Sketch: a circumscribed polygon stays regular when dragged (#7395) Circumscribed Polygon held its sides equal and tangent to the support circle only. Equal sides round one circle leave every other corner free (a rhombus round a circle), so a hexagon had 9 degrees of freedom instead of 4, and dragging its centre or a corner pulled it out of shape (radius 10 became 8.02, angles 174/66 degrees). Its corners now also lie on a construction circle concentric with the support circle, which makes it regular as an inscribed polygon is, and one side is tangent to the support circle, which sets its size: dof 4 (centre, size, turn). One tangent rather than all of them, so no constraint is redundant. Test in sketch_ux_tests: 4, 5 and 6 sides, dragged by the centre and by a corner, stay regular with their sides on the support circle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
b1cf66b628 | Fix stored world-axis inputs for revolve (#7179) (#7406) | ||
|
|
f5bfd6d1f2 |
Sheet metal: a base or contour flange hides its sketch (#6804) (#7151)
* claim: #6804 * Sheet metal: a base or contour flange hides its sketch (#6804) Only an Extrude or a Revolve counted as using its sketch, so the sketch of a base flange stayed shown. Its line on the plate's bottom edge lies exactly on that edge and took the Flange dialog's click: a sketch line makes a contour flange, a separate flat wall with no bend whose Flip moves it into the plate. A base or contour flange now uses its sketch as an Extrude does: hidden unless shown on its own, and shown while its feature is edited. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FN5eEMrqWWXqi65FcK8GXq * Sheet metal: test that a click on the bottom edge makes an edge flange (#6804) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FN5eEMrqWWXqi65FcK8GXq --------- Co-authored-by: sascha2101 <221609842+sascha2101@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ae530bff44 |
Typed contracts for the cylinder, sphere, torus, cone, pipe, bounding solid and scale (#2829) (#7145)
* Typed contracts for the cylinder, sphere, torus, pipe, bounding solid and scale Contracts for solid.cylinder, solid.sphere, solid.torus, solid.pipe, solid.bounding_solid and solid.scale, with `FeatureResult` output, and the shared types `AxisDir` (calling `cmd::axis_dir_form`, split from `axis_dir_param`), `NumberExpr` and `ScaleFactors`. The descriptions say what the evaluation does: the limits it enforces, the real default scope of `targets`, and where `participants` overrides a key or has no effect. Scale makes no body, so it declares `name` and `participants` itself. Box's descriptions get the same corrections. The reply test runs every form in Warn and checks for no `param_warnings`; the guide lists the new types and adds lessons from the conversion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Typed contract for the cone `solid.cone`, added on main beside the primitives this PR converts, gets its contract and `FeatureResult` output: the cylinder's keys plus `top_radius` / `top_diameter`, with the evaluation's limits in the descriptions (a radius above 0, a top radius of 0 or more, a height that is not 0 and may be negative, sizes within 1e7 mm). A `null` top radius stays the handler's to refuse, since the handler takes it beside a `top_diameter`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ad749d3399 |
Joints: the model is evaluated for the placements a solve leaves (#7084) (#7085)
Session::refresh evaluated the model and then solved the joints, which writes the solved placements into the design. A feature that reads where a part is placed kept the result made for the placement before the solve: a mirror of a jointed part's body, made from the root, ended up 4 mm below the part after a move the slider took back. When the solve moves parts, the model is now evaluated again for the placements the design holds, and the joints solved for that model, at most three rounds. Features that don't read placements come from the cache. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
0f8593b180 |
Sketch: a tangent at an end the line and the round share keeps its side (#7428) (#7447)
A tangency at a point the two curves share (or a line's end held on the round) is solved as a block of its own, and the orientations a solve keeps left it out. When a point placed by parameters moved far, the line could land on the other tangent from its far end (its mirror image) with every constraint met and no warning. It now keeps the round's side of the line, as a tangency away from the ends already does: kept where the move can be walked there, reported as a flip where it can't. Fixes #7428. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
7e8ccad341 |
Browser: a body's name hides the body, not a sketch of the same name (#7206) (#7604)
* claim: #7206 * Browser: a body's name hides the body, not a sketch of the same name (#7206) `browser.visibility` looked a key up as a feature first, so when a sketch had exactly the name of a body (a sketch named after the body it makes), the body's eye in the browser hid and showed the sketch instead, and the body could not be hidden at all. The browser names a sketch by its id and a body only by its name, so a name that is exactly both now names the body. The sketch still hides and shows by its id; matches that differ only in case are left as they are (#6967, #7004). Fixes #7569 too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FN5eEMrqWWXqi65FcK8GXq --------- Co-authored-by: sascha2101 <221609842+sascha2101@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
46552bdc3a |
Profiles: explain public selection forms in parameter errors (#7180) (#7491)
* claim: #7180 public profile selection diagnostics * fix(engine): explain public profile selection forms |
||
|
|
17339cf65c |
Redefine: the features after the edited one are computed once (#7076)
timeline.redefine evaluated every later feature in its trial session, then again in the session: the evaluation cache keeps only the last few states of a design with large bodies, so the trial's results were gone by then. The trial keeps them in the session's kept results (or its own), and the session's evaluation takes them from there. EvalCache::with_budget gives tests a small cache. |
||
|
|
531fc04db8 |
Inspect: center of mass measures the world state, as Measure does (#5246) (#5268)
* Inspect: center of mass measures the world state, as Measure does (#5246) inspect.center_of_mass read the model state, so in an assembly a moved occurrence was measured where its bodies were made, a second placement was left out, and a placed copy's world name was "no such bodies". It now reads the world state, as inspect.measure does, and agrees with component.properties' mass centre at uniform density. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Center of mass test: unground the placed part before moving it Upstream now grounds a design's first part when it is made. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
4afd93331f |
Patterns: a body of a moved component is copied where it is shown (#4763) (#4969)
* Patterns: a body of a moved component is copied where it is shown (#4763) A pattern of bodies made outside the bodies' component (a screw's body patterned from the root) moved each body's stored geometry, which is in its component's frame, by transforms in the pattern's frame. The copies landed where the body sits before its component is placed: near the origin, for every pattern kind. As Mirror does, each copy is now moved as the pattern moves the body in the world and kept beside its source, in its component. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Pattern test: unground the placed component before moving it Upstream now grounds a design's first part when it is made. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
6848c78424 |
Sketch Transform: one box with handles to scale, move and turn what is picked (#6004)
* Sketch Transform: scale, turn and move sketch entities in one command and one undo sketch.transform scales about a centre, turns about it, then moves; the window and its handles for existing sketch geometry build on it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Sketch Transform window: one box with handles to scale, move and turn what is picked Select curves and points in a sketch and press G (or Transform in the Modify panel or the context menu): the picks get a box with a handle at each corner to scale (the opposite corner stays), the box to move and a knob above it to turn (Shift snaps to 15 degrees). Position, Width, Height, Scale and Angle in the window are the same values, to type exactly; OK applies it as one step. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * Move the new message to a pending locale file Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch Transform: follow the sketch field of Sel::SketchCurve Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Nathalie Schönwetter <nathalie@cfw-ag.ch> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
4e07b6c4b7 |
Assembly: name placed bodies without rescanning the design (#7380)
Naming a placed body scanned every occurrence and body of the design, so the world state and every caller naming all placed bodies grew with bodies times design size. WorldNames indexes the design once and names each body in time proportional to its occurrence path; one naming routine serves both it and the single-body scan. Names are unchanged (a test compares them with the scanning implementation). Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> |
||
|
|
13f650b695 |
Engine: one module for the design-link path helpers (no behaviour change) (#5420)
* Move the design-link path helpers into one module `component_link.rs`'s path rules for links to other design files (base_dir, absolute, relative, stored, resolve, rebased) move, unchanged, into `cmd/design_link.rs` with their test, so other kinds of link (#3891's drawing files, linked parameters #5354, #5113's extract) share them instead of copying or re-exporting them. No change in behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * design_link: keep base_dir and relative private Only design_link.rs uses them; the module's surface is absolute, stored, resolve and rebased (review on #5420). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * component_link: import Document after the rebase Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Carel Theron <careltheron@Carels-MacBook-Pro.local> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> |
||
|
|
702f35ae6e |
Loft: keep hidden bodies out of automatic Join targets (#1988) (#6894)
* claim: #1988 * fix: preserve hidden bodies in automatic loft joins (#1988) |
||
|
|
b99761a3f7 |
Extrude: a cut made while bodies are hidden leaves them alone (#3961) (#5148)
A cut (or intersect) that names no bodies went through every body it met, hidden ones too: a body hidden to keep it out of the cut was cut anyway. When some of the active component's bodies are hidden, the cut now stores the shown ones as its targets, so the hidden bodies stay as they are, and stay so once shown again (the model never depends on what is shown). With nothing hidden it goes through every body it meets, as before. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |