674ef84b53
* claim: #3693 * Fix timeline playback to show each rebuilt feature * Move History playback into the Inspect ribbon * Refuse Play History up front when playback couldn't run Starting Play and the per-frame check that stops it were looking at different app state, so Play could be accepted during an apply, a delete check or queued history work and then stop silently on the next frame. Both now use one playback_blocked check. The UI also reads the engine's PlaybackAction as the typed enum instead of matching strings, so a bad reply is an error rather than a quiet toggle. * Put Play History in the History controls History now shows five controls in transport order: start, previous, play, next, end. Play runs timeline.play, so it turns into Stop while playback runs, same as the ribbon button and the shortcut. It's on by default (#3688, #3740, #4216). Anyone who wants the old four controls back can right-click them and pick Hide Play Button, or clear history_play_button under Preferences > Interface. In a named vertical History too narrow for five buttons beside its grip, Play is left to the ribbon rather than overlapping the grip. * Draw the History Play button as a plain play/pause glyph The Play button in the History controls now uses the same drawn glyphs as its neighbours: a filled triangle, and two bars while History plays. The triangle is bigger than the step arrows so it doesn't read as Forward. The ribbon command keeps its timeline_play and timeline_stop icons. * Keep the playback changes clear of PRs queued ahead Several PRs in the merge queue touch the same lines, so this moves ours aside without changing behaviour: - history_play_button and its reset-test row sit with the other History preferences, not beside view_confirm_corner (#7248 adds status_bar there). - History keeps main's history_transport_width() for four controls (#6430 and #7459 call it); the Play button's count uses history_controls_width. - A new or opened document stops playback after dim_view::cancel(), clear of the line #7819 adds after reset_chat. - The Play/Stop label swap moves from interactive_command_info, which #7906 rewrites, into the ribbon's command_info. * Stop playback after the command completes, clear of #6433 #6433 rewrites the session.execute line in execute_command, and our playback check sat right under it, so the queue couldn't merge the two. Checking the revision after command_completed does the same job a couple of lines later. --------- Co-authored-by: cfaulkingham <colin.faulkingham@gmail.com>