02ac56d12f
* claim: #6901 * Feature windows choose Join, New Body or Cut from what the material touches (#6901) Extrude, Revolve, Loft, Sweep, Coil and the Box, Cylinder, Sphere and Torus choose their operation by running the Join on a copy of the design off the window thread and counting the pieces: Join when the material makes one body with what it touches, New Body when it would be a separate piece, Cut when it lies inside a body (Revolve and the four primitives; Extrude keeps its own Cut). The choice changes only when a check is in, a pick in the Operation row (the shown option included) stops it for good, and OK waits for a running check. Hidden bodies take no part: with some hidden, the shown ones become the feature's targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Operation row: a pick in Extrude stops its own choice at once; ja/zh strings, gallery entry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Operation check: contact test first, mesh volumes for Cut, OK takes the evaluated Join Material touching no body is a New Body without running the Join (the contact test costs 0-240 ms where the Join costs seconds on a large body). Inside is told from display-mesh volumes instead of exact ones (8 s on a 400-hole plate). The check evaluates the Join through Session::ahead, and OK of the same commands takes it (Session::prime) rather than computing it again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Preference: Choose the operation automatically (on by default) Preferences > Design gets "Choose the operation automatically" (auto_operation, on by default). Off, feature windows don't choose Join, New Body or Cut from what their material touches: each keeps the operation it opens with (Extrude its own Join or Cut), no check runs and OK doesn't wait for one, as before Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Arabic, Hebrew, Vietnamese and Turkish strings for the operation choice and its preference Arabic, Hebrew and Vietnamese are complete catalogs now, and Turkish has a full catalog, so this change's three strings get them too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Operation check: a closed window's check stops; the icon audit doesn't choose A window's operation check kept running after the window closed, a Join on the design for nothing, and the test harness waited for it after every step: the icon audit, which opens every window, took ~30 min instead of ~1. The check now runs under a Progress, and closing the window (or one that doesn't choose) abandons it: its evaluation stops at the next feature and nothing waits for it. The icon audit turns auto_operation off, as it only looks at icons (75 s again). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Box placement test: the window keeps its New Body The test #6248 added places a box that overlaps Base and expects a second body; with #6901 the window would join or cut it. The test is about where the box goes, so it turns auto_operation off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Join pieces: read the target lists leniently after the rebase Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com>
120 lines
3.8 KiB
Rust
120 lines
3.8 KiB
Rust
//! The SolidCraft document: user and model parameters, and a parametric timeline of features
|
|
//! (sketches, extrudes, revolves, fillets, primitives, combines…). Evaluating the timeline with
|
|
//! the kernel produces the model (bodies and solved sketches). Evaluation is incremental: a
|
|
//! feature is recomputed only when it, a parameter it uses, or an earlier feature changed.
|
|
#![deny(clippy::unwrap_used, clippy::expect_used, clippy::panic, clippy::unimplemented, clippy::todo, clippy::unreachable)]
|
|
#![forbid(unsafe_code)]
|
|
|
|
pub mod appearance;
|
|
pub mod appearance_pack;
|
|
mod assembly;
|
|
mod body_transfer;
|
|
mod body_transfer_sheet;
|
|
pub mod pbr_appearance;
|
|
pub use body_transfer::{valid_transfer_matrix, validate_body_transfer};
|
|
pub mod canvas;
|
|
mod clipboard;
|
|
pub use clipboard::{clone_expression, remap_topology};
|
|
pub mod component_color;
|
|
mod component_removal;
|
|
pub use component_removal::RemovedTree;
|
|
pub mod config;
|
|
pub mod construct;
|
|
pub mod display_quality;
|
|
pub mod display_units;
|
|
mod document;
|
|
pub mod drawing;
|
|
mod eval;
|
|
pub mod expr;
|
|
pub mod face_anchor;
|
|
mod feature_geometry;
|
|
mod feature_refs;
|
|
pub use face_anchor::{FaceAnchor, FaceAttachmentStatus};
|
|
pub mod format;
|
|
mod format_offsets;
|
|
pub mod frame;
|
|
mod history_names;
|
|
pub mod hole_reference;
|
|
pub mod ids;
|
|
pub use format_offsets::whole_profile_selection_from_value;
|
|
pub mod joints;
|
|
mod lineage;
|
|
pub mod metadata;
|
|
pub use metadata::Metadata;
|
|
pub mod motion;
|
|
mod name_lookup;
|
|
mod names;
|
|
pub mod naming;
|
|
mod params;
|
|
pub mod persistent_name;
|
|
pub mod physical_material;
|
|
mod piece_names;
|
|
pub mod pipe_thread_catalog;
|
|
mod points;
|
|
mod profile_refs;
|
|
pub mod progress;
|
|
mod thread_catalog;
|
|
pub use thread_catalog::{TappedThread, TappedThreadFamily, parse_tapped_thread, tapped_thread_sizes};
|
|
mod walk;
|
|
pub use profile_refs::{capture_profile_selection, profile_fallback_notes, profile_selection_indices, profile_selection_indices_lenient};
|
|
pub mod plastic;
|
|
pub mod project;
|
|
mod project3d;
|
|
pub mod render_aging;
|
|
pub mod render_job;
|
|
pub mod render_optics;
|
|
pub mod render_resources;
|
|
pub mod render_settings;
|
|
pub mod render_surface;
|
|
pub use project3d::iso_grid;
|
|
pub mod sheet;
|
|
pub mod text_params;
|
|
|
|
pub use assembly::{
|
|
BomType, IDENTITY, MAX_PLACEMENT_DEPTH, MAX_PLACEMENTS, Mat, Occurrence, WorldNames, apply_point, apply_vector, is_identity, map_point_expr,
|
|
mat_inverse, mat_mul, rigid,
|
|
};
|
|
pub use document::*;
|
|
pub use eval::{
|
|
EdgeRef, FeatureResult, Model, ModelBody, ModelState, PlacedBodies, RevolveExtent, SavedModel, SolvedSketch, ThreadInfo, curve_pick_error,
|
|
edge_names_for, edge_refs, face_point_names, face_point_state, hole_direction_at, import_body_names, join_pieces_added, map_wire,
|
|
metric_thread_sizes, object_height, parse_metric_thread, pattern_matrices, revolve_extent, revolve_extent_with_convention, select_profiles,
|
|
sketch_hole_direction, sketch_line_plane, state_in_frame, state_in_frame_at, suggested_thread, tangent_face_chain, through_all_distance,
|
|
world_state, world_state_reusing,
|
|
};
|
|
pub use eval::{EvalCache, KeptResults};
|
|
pub use expr::Expr;
|
|
pub use names::{BodyName, FeatureId, FeatureName, SketchId, copy_name};
|
|
pub use params::{ParamRow, ParamUser, cycles};
|
|
pub use points::{Dir, FacePick, Position, plain};
|
|
pub use solidcraft_kernel as kernel;
|
|
pub use solidcraft_sketch as sketch;
|
|
|
|
#[derive(Debug, Clone, PartialEq, thiserror::Error)]
|
|
pub enum DocError {
|
|
#[error("expression: {0}")]
|
|
Expr(String),
|
|
#[error("{0}")]
|
|
Invalid(String),
|
|
#[error("unknown {0}")]
|
|
Unknown(String),
|
|
#[error(transparent)]
|
|
Sketch(#[from] solidcraft_sketch::SketchError),
|
|
#[error(transparent)]
|
|
Kernel(#[from] solidcraft_kernel::KernelError),
|
|
}
|
|
|
|
pub type Result<T> = std::result::Result<T, DocError>;
|
|
|
|
#[cfg(test)]
|
|
mod coil_tests;
|
|
#[cfg(test)]
|
|
mod feature_walk_tests;
|
|
#[cfg(test)]
|
|
mod named_projection_tests;
|
|
#[cfg(test)]
|
|
mod tests;
|
|
|
|
mod anchor_frame;
|
|
pub use anchor_frame::state_in_face_anchor_frame;
|