b289dc2421
* Sketch Dimension: `name = value` defines a user parameter (#2916) In a dimension's value (the D tool's box, and `sketch.dimension`'s `value` from scripts, the CLI, MCP and the control channel), `name = expression` adds the user parameter `name` with that expression and dimensions with `name`: typing `width = 40` on a line gives a 40 mm user parameter `width` and a dimension whose expression is `width`. A bare number is read in the design's unit, as a bare dimension value is; an angle's parameter is in degrees. The expression may be anything the parameter editor takes. It is one command: one undo removes the parameter and the dimension together, and a dimension the sketch refuses leaves no parameter behind. A taken name is refused with a hint (type the name to use it, or change it in Parameters), a reserved name with the parameter editor's message, and a left side that is not a name (`2 = 3`) still fails to parse as before. A driven dimension defines nothing. The reply carries `defined`, and the status line names the parameter. The splitter lives in the doc crate (`expr::definition`) so other value inputs can take the same form later; editing an existing dimension, the inline shape boxes and feature dialogs are follow-ups. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Sketch Dimension: say why a name is refused, in the command's own words (#2916) The dimension editor showed a refused definition raw, in the box and the status line: "invalid parameters for `sketch.dimension`: value: `mm` is a unit, constant or function name". It now reads "Sketch Dimension: `mm` is a unit name, so it cannot be a parameter name": the editor passes the command's errors through `friendly_error` like every other command, and drops the `value:` field tag, since the box is the value. The taken-name hint reads the same way: "Sketch Dimension: there is already a parameter `w`: type `w` to use it, or change it in Parameters". A reserved name says what kind of word it is and what that means (`param_name_problem`, shared with the Parameters dialog): a unit name, a function name, or a constant, "so it cannot be a parameter name"; `expr::reserved_kind` tells them apart. `friendly_error` translates the command label with the interface language (the engine's sentence stays English), so the prefix reads "Wymiar szkicu:" in Polish. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * Sketch Dimension test: keep the third line off the ribbon (#2916) On current `main` the ribbon floats over the top of the canvas, and the test's third line at sketch y = 50 projected under it: the click opened Parameters instead of picking the line. The line now goes below the first one. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com>