Files
makeCAD/crates/kernel/src/native/preview.rs
T
jyviko dc38349cbf Layer split stage 1: the B-rep record, native body file and Vec/Plane come from solidcore-record (#11496)
* Kernel: the B-rep record and the native body file come from solidcore-record

SolidCraft's portable B-rep record (`solidcraft_geom::brep`: brep.rs, topology, history,
envelope, part, curve2) and the native body file (`solidcraft_kernel::native`: the tagged binary
codec and the container) move to solidcore's `solidcore-record` crate: geometry as data, with
structural validation and no maths (solidcore's docs/layers.md, stage 1). Every caller uses
`solidcore_record::brep` and `solidcore_record::native`; the old copies are deleted.

What computes from coordinates stays with the kernel, in geom's `brep`:
- `brep::check`: the record's geometric checks (orthonormal frames, non-degenerate planes,
  unit revolution axes, non-singular placements). `check::validate` and
  `check::validate_built` are the record's validation and these together, and every caller of
  `Brep::validate` uses them, so what is accepted is unchanged;
- `brep::label`: a surface's natural ranges (a cone's apex), `curve_interval`,
  `edge_curve_interval` and `form_turns`;
- `brep::pcurve::eval`: a pcurve's point;
- `geometry::check`, `placement::moved` and `split_edges` become functions on the record.

The kernel's native module keeps the conversion between a body and its saved record
(metadata.rs) and checks the decoded record's geometry. `native/analytic.rs`, which no module
declared, is deleted.

solidcore-record is pinned to its rev on solidcore's `layer-record` branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT

* Geometry: Vec2, Vec3, Plane and the profile types come from solidcore-record

The plain data of vectors and points, sketch planes and planar profiles (`Seg2`, `Loop2`,
`Region2`) moves to `solidcore-record`, with its constants and component-wise operators only
(owner decision, solidcore layer split). Their geometry stays in geom as traits:
`Vec2Geom`, `Vec3Geom`, `PlaneGeom`, `Seg2Geom`, `Loop2Geom`, `Region2Geom`, `Seg2ArcFit`,
`Loop2ArcFit` and `Region2ArcFit`, in scope with `use solidcraft_geom::prelude::*`. Every caller
names the types from `solidcore_record`; geom no longer defines or re-exports them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT

* Kernel: pin solidcore-record to solidcore main f5e8e9a29

solidcore-record is merged on solidcore main (tangency-labs/solidcore#2519); its crate there is
identical to the rev pinned before but for its clippy configuration. The lock is regenerated
against the merged rev.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NvoxKMbMFSQU8tzRtoJhtT

---------

Co-authored-by: jyviko <2501648+jyviko@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 09:04:26 -05:00

46 lines
1.9 KiB
Rust
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
//! Bounded provisional display of a decoded body, before its edit mesh. The budget is taken
//! before meshing (at least one triangle per face) and charged with what the mesh used; the
//! planner bounds its own work per face, so hostile records cost a bounded amount.
use super::{Body, Result, invalid};
use solidcraft_geom::Mesh;
/// A coarse mesh of `body` (finer with `detail`, 1–8) charged to `remaining` triangles.
pub fn native_preview_mesh(body: &Body, detail: usize, remaining: &mut usize) -> Result<Mesh> {
if body.mesh.is_some() {
return Err(invalid("native preview requires B-rep"));
}
if body.face_count() > *remaining {
return Err(invalid("preview budget"));
}
let detail = detail.clamp(1, 8) as f64;
let chord = (body.size() * 0.01 / detail).max(1e-3);
let mesh = body.mesh(&crate::MeshTolerance::display(chord))?;
if mesh.triangles.len() > *remaining || mesh.positions.iter().any(|p| !p.is_finite()) {
return Err(invalid("preview budget"));
}
*remaining -= mesh.triangles.len();
Ok(mesh)
}
#[cfg(test)]
mod tests {
use super::*;
use solidcore_record::Vec3;
#[test]
fn native_preview_is_finite_and_budgeted_before_meshing() {
for body in [
crate::box_solid(Vec3::ZERO, Vec3::new(10., 20., 30.)).unwrap(),
crate::sphere(Vec3::ZERO, 10.).unwrap(),
crate::torus(Vec3::ZERO, 20., 4.).unwrap(),
] {
let body = crate::decode_native_body(&crate::encode_native_body(&body).unwrap()).unwrap();
assert!(native_preview_mesh(&body, 8, &mut 0).is_err());
let mut budget = 100_000;
let mesh = native_preview_mesh(&body, 8, &mut budget).unwrap();
assert!(!mesh.triangles.is_empty());
assert!(mesh.triangles.len() <= 100_000 - budget);
assert!(mesh.positions.iter().all(|p| p.x.is_finite() && p.y.is_finite() && p.z.is_finite()));
}
}
}