chenlin/Mujoco_WASM
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cache triangles, vertices and normals from the mesh outside of the triangle loop so we don't have to request them inside the loop.

Browse Source 
This is because each time we call mesh.triangles or similar, the data gets copied from the native memory to a c# structure.

PiperOrigin-RevId: 551851115
Change-Id: Ie7820f61639f0d727ecf9716044ce18b3277913b
This commit is contained in:
Google DeepMind
2023-07-28 07:50:15 -07:00
committed by Copybara-Service
parent 5f246ef210
commit 455a081ee7
1 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
unity/Editor/Importer/StlMeshParser.cs
+16 -9
View File
@@ -101,21 +101,28 @@ public class StlMeshParser {
writer.Write(_asciiFileTypeId);
writer.Write(new byte[_headerLength - _asciiFileTypeId.Length - 1]);
var numTriangles = mesh.triangles.Length / 3;
// Reading mesh.triangles etc causes a c# array to be instantiated each time to store a copy
// of the data that is owned by the native runtime. For this reason, it's important we do
// this once per mesh, and definitely not per triangle.
var triangles = mesh.triangles;
var normals = mesh.normals;
var vertices = mesh.vertices;
var numTriangles = triangles.Length / 3;
writer.Write((int)numTriangles);
for (var i = 0; i < mesh.triangles.Length; i += _verticesPerTriangle) {
for (var i = 0; i < triangles.Length; i += _verticesPerTriangle) {
// STL format uses face normals, while Unity Meshes use vertex normals. We need to convert
// one into another by calculating a mean of vertex normals.
var i1 = mesh.triangles[i];
var i2 = mesh.triangles[i + 1];
var i3 = mesh.triangles[i + 2];
var faceNormal = (mesh.normals[i1] + mesh.normals[i2] + mesh.normals[i3]).normalized;
var i1 = triangles[i];
var i2 = triangles[i + 1];
var i3 = triangles[i + 2];
var faceNormal = (normals[i1] + normals[i2] + normals[i3]).normalized;
writer.Write(ToXZY(faceNormal));
writer.Write(ToXZY(mesh.vertices[i1]));
writer.Write(ToXZY(mesh.vertices[i3]));
writer.Write(ToXZY(mesh.vertices[i2]));
writer.Write(ToXZY(vertices[i1]));
writer.Write(ToXZY(vertices[i3]));
writer.Write(ToXZY(vertices[i2]));
writer.Write((short)0);
}