update MJX with nvmax

PiperOrigin-RevId: 943836220
Change-Id: I7092b5ed005a48a10812f3280709c50691aa497e
This commit is contained in:
Taylor Howell
2026-07-07 05:31:57 -07:00
committed by Copybara-Service
parent 8df03f860c
commit 641c1cf11b
2 changed files with 31 additions and 5 deletions
+19 -4
View File
@@ -746,6 +746,7 @@ def _make_data_warp(
naconmax: Optional[int] = None,
naccdmax: Optional[int] = None,
njmax: Optional[int] = None,
nvmax: Optional[int] = None,
) -> types.Data:
"""Allocate and initialize Data for the Warp implementation."""
if not isinstance(m, mujoco.MjModel):
@@ -755,7 +756,14 @@ def _make_data_warp(
)
with wp.ScopedDevice('cpu'): # pylint: disable=undefined-variable
dw = mjwp.make_data(m, nworld=1, naconmax=naconmax, naccdmax=naccdmax, njmax=njmax) # pylint: disable=undefined-variable
dw = mjwp.make_data(
m,
nworld=1,
naconmax=naconmax,
naccdmax=naccdmax,
njmax=njmax,
nvmax=nvmax,
) # pylint: disable=undefined-variable
fields = _make_data_public_fields(m)
for k in fields:
@@ -845,6 +853,7 @@ def make_data(
naconmax: Optional[int] = None,
naccdmax: Optional[int] = None,
njmax: Optional[int] = None,
nvmax: Optional[int] = None,
keepalive_refs: Optional[Dict[int, Any]] = None,
) -> types.Data:
"""Allocate and initialize Data.
@@ -862,6 +871,7 @@ def make_data(
`naccdmax` argument to set the upper bound for the number of contacts
across all worlds, rather than the `nccdmax` argument from MuJoCo Warp.
njmax: maximum number of constraints to allocate for warp across all worlds
nvmax: capacity for compacted active DOFs per world
keepalive_refs: optional dict to store references to underlying MuJoCo
objects, preventing them from being garbage collected. Required for CPP
impl when passing a types.Model.
@@ -887,7 +897,7 @@ def make_data(
return _make_data_cpp(m, device, keepalive_refs=keepalive_refs)
elif impl == types.Impl.WARP:
_check_warp_installed()
return _make_data_warp(m, device, naconmax, naccdmax, njmax)
return _make_data_warp(m, device, naconmax, naccdmax, njmax, nvmax)
raise NotImplementedError(
f'make_data for implementation "{impl}" not implemented yet.'
@@ -1150,11 +1160,14 @@ def _put_data_warp(
device: Optional[jax.Device] = None,
naconmax: Optional[int] = None,
njmax: Optional[int] = None,
nvmax: Optional[int] = None,
) -> types.Data:
"""Puts mujoco.MjData onto a device, resulting in mjx.Data."""
with wp.ScopedDevice('cpu'): # pylint: disable=undefined-variable
dw = mjwp.put_data(m, d, nworld=1, naconmax=naconmax, njmax=njmax) # pylint: disable=undefined-variable
dw = mjwp.put_data(
m, d, nworld=1, naconmax=naconmax, njmax=njmax, nvmax=nvmax
) # pylint: disable=undefined-variable
fields = _put_data_public_fields(d)
for k in fields:
@@ -1189,6 +1202,7 @@ def put_data(
impl: Optional[Union[str, types.Impl]] = None,
naconmax: Optional[int] = None,
njmax: Optional[int] = None,
nvmax: Optional[int] = None,
dummy_arg_for_batching: Optional[jax.Array] = None,
keepalive_refs: Optional[Dict[int, Any]] = None,
) -> types.Data:
@@ -1204,6 +1218,7 @@ def put_data(
`naconmax` argument to set the upper bound for the number of contacts
across all worlds.
njmax: maximum number of constraints to allocate for warp
nvmax: capacity for compacted active DOFs per world
dummy_arg_for_batching: dummy argument to use for batching in cpp
implementation
keepalive_refs: optional dict to store references to underlying MuJoCo
@@ -1226,7 +1241,7 @@ def put_data(
)
elif impl == types.Impl.WARP:
_check_warp_installed()
return _put_data_warp(m, d, device, naconmax, njmax)
return _put_data_warp(m, d, device, naconmax, njmax, nvmax)
raise NotImplementedError(
f'put_data for implementation "{impl}" not implemented yet.'
+12 -1
View File
@@ -495,9 +495,20 @@ class DataIOTest(parameterized.TestCase):
if not mjx_io.has_cuda_gpu_device():
self.skipTest('No CUDA GPU device.')
m = mujoco.MjModel.from_xml_string(_MULTIPLE_CONVEX_OBJECTS)
d = mjx.make_data(m, impl='warp', naconmax=9, njmax=23)
d = mjx.make_data(m, impl='warp', naconmax=9, njmax=23, nvmax=8)
self.assertEqual(d._impl.contact__dist.shape[0], 9)
self.assertEqual(d._impl.efc__pos.shape[0], 23)
self.assertEqual(d._impl.nvmax, 8)
def test_put_data_warp_nvmax(self):
if not mjxw.WARP_INSTALLED:
self.skipTest('Warp is not installed.')
if not mjx_io.has_cuda_gpu_device():
self.skipTest('No CUDA GPU device.')
m = mujoco.MjModel.from_xml_string(_MULTIPLE_CONVEX_OBJECTS)
d = mujoco.MjData(m)
dx = mjx.put_data(m, d, impl='warp', nvmax=8)
self.assertEqual(dx._impl.nvmax, 8)
@parameterized.parameters('jax', 'cpp', 'warp')
def test_put_data(self, impl: str):