Automated g4 rollback of changelist 810355812.

*** Reason for rollback ***

mjv_makeScene does not call mjv_defaultScene directly.  Instead, it calls mjv_freeScene which calls mjv_defaultScene.  However, mjv_freeScene attempts to free pointers if they are not NULL and if you don't call mjv_defaultScene then you'll have garbage data in those pointers.

*** Original change description ***

Remove redundant mjv_defaultScene call since its called by mjv_makeScene

***

PiperOrigin-RevId: 810442645
Change-Id: Ica50493d6769a0afb086f9ead99d731cdf0d75d9
This commit is contained in:
Haroon Qureshi
2025-09-23 08:04:39 -07:00
committed by Copybara-Service
parent 33b09e0822
commit bb0878417e
+2 -3
View File
@@ -22,8 +22,6 @@
namespace mujoco::toolbox {
static constexpr int kMaxGeom = 2000;
Renderer::Renderer(MakeContextFn make_context_fn)
: make_context_fn_(make_context_fn) {
}
@@ -40,7 +38,8 @@ void Renderer::Init(const mjModel* model) {
}
make_context_fn_(model, &render_context_);
mjv_makeScene(model, &scene_, kMaxGeom);
mjv_defaultScene(&scene_);
mjv_makeScene(model, &scene_, 2000);
initialized_ = true;
}