c528dd268f
Include callable skill and live-GUI prerequisites, epoch sensor reads, packed snapshots, sampled bit-exact kinematics, and verified-tick rendering without changing the physical/control schedule. Record bounded analytic S1 GUI/headless qualification, original failures and CPU evidence (1557 passed, 6 skipped). Preserve accepted_skill=false and sub-real-time limitations. Exclude native authorities, caches, large media and local delivery copies; retain sealed artifact digest.
25 lines
2.9 KiB
Markdown
25 lines
2.9 KiB
Markdown
## Review
|
||
|
||
- **Correct:** Original safety and synchronous evidence finish before painting; physical/evidence failures suppress painting (`source/SkillFactory/SkillFactory/tasks/manager_based/contact_cycle_sim/live_cadence_v042.py:48–55`). Added-frame early close returns the literal abort cause before another step; final-tick completion is preserved (`:26–36`).
|
||
- **Correct:** Attachment is GUI-only, after `gui.start`; both combined modes receive runtime math qualification (`scripts/evaluate_cycle_functional_flow.py:122–125,270–272`). The new module is preloaded and source-bound; the amendment is included in approval sources (`:70`; `skill_binding_v4.py:18`; `scripts/skill_launch_v4.py:32–33`).
|
||
- **Correct:** Physics throughput and render-generation rate are reported separately, without claiming measured display-present FPS (`source/SkillFactory/SkillFactory/tasks/manager_based/contact_cycle_sim/performance_v042.py:90–94`).
|
||
|
||
### Finding: P1 — SDK-swallowed visualizer failures permit silent missing paints
|
||
|
||
**Location:** `source/SkillFactory/SkillFactory/tasks/manager_based/contact_cycle_sim/live_cadence_v042.py:28–36`.
|
||
|
||
The painter treats a returning `sim.render()` as successful, increments `additional_renders`, and checks only GUI/app closure. However, the installed SDK catches exceptions from `viz.step()`, closes/removes that visualizer, and returns normally:
|
||
|
||
- `/home/cen/IsaacLab/source/isaaclab/isaaclab/sim/simulation_context.py:829–839`
|
||
- `render_generation` still increments at `:776`; subsequent updates with no visualizers return immediately at `:793–794`.
|
||
|
||
Consequently, a Kit visualizer failure during an added paint can leave the app running, allow the next physical step, and count subsequent no-op renders as successful paints. This contradicts the new every-accepted-tick-paint contract. The direct render-throw test (`tests/test_contact_cycle_live_cadence_v042.py:78–83`) does not cover this SDK-swallowed failure.
|
||
|
||
**Smallest fix:** Retain and validate the expected Kit visualizer around added renders, failing closed if it is removed/closed. Check its health before subsequent physics as well, covering failures in retained interval20 renders. Add a negative case where rendering returns normally after removing the visualizer.
|
||
|
||
- **Fixed:** None; read-only review.
|
||
- **Merge verdict: BLOCK** — address this exception gap before spending the fresh full-S1 GUI qualification run.
|
||
|
||
### Qualification limits
|
||
|
||
The existing XML reports **68 passed, zero failures/errors**, including 12 presentation cases; nothing was rerun. CPU tests do not establish native acceptance. GUI/headless trace equivalence, measured presentation responsiveness/RTF, native early-close behavior, and renderer physical side effects remain empirical qualification work. In particular, SDK rendering invokes kinematic/fabric refresh (`simulation_context.py:800–801`; `physx_manager.py:329–335`), although the inspected path does not integrate another physics step. |