Wave 67/509: kernel-cases: sweeps skipped sources (72) (and 3 more)

4 commits, squashed; the originals stay reachable from tag archive/merge-main-develop.

- 75aa8acb6 Brennen Herbruck: kernel-cases: sweeps skipped sources (72)
- 678a70da2 bherbruck: kernel-cases: shells as a graded count, no SMLib verdict where it can't take the record, $OUT
- c24b066d2 bherbruck: kernel-cases: an outcome for geometry with no single manifold answer
- 8764a76ff Brennen Herbruck: kernel-cases: threads cases from #1995 and #3368 (finely faceted booleans), skipped #987 #3130 #3824

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
This commit is contained in:
Brennen Herbruck
2026-10-21 06:52:51 -04:00
committed by jyviko
parent dcab94fcd7
commit ed5bed8f00
24 changed files with 571 additions and 68 deletions
+44 -15
View File
@@ -14,14 +14,24 @@ fn kernel() -> String {
std::env::var("SOLIDCRAFT_BOOLEANS").ok().filter(|k| !k.is_empty()).unwrap_or_else(|| "default".into())
}
/// The case's commands: a script as is, or an oracle recipe translated; `$CASE` in a string is
/// the case directory (for input files such as `input.step`).
fn script(dir: &str, recipe: &Value) -> Result<Value, String> {
/// The case's commands: a script as is, or an oracle recipe translated. In a string, `$CASE` is
/// the case directory (input files such as `input.step`) and `$OUT` a scratch directory for files
/// the case writes (an export), outside the repository.
fn script(dir: &str, out: &str, recipe: &Value) -> Result<Value, String> {
let s = if recipe.get("commands").is_some() || recipe.is_array() { recipe.clone() } else { recipe::to_script(recipe)? };
let text = serde_json::to_string(&s).map_err(|e| e.to_string())?;
let dir_json = serde_json::to_string(dir).map_err(|e| e.to_string())?;
let dir_inner = dir_json.get(1..dir_json.len().saturating_sub(1)).unwrap_or("");
serde_json::from_str(&text.replace("$CASE", dir_inner)).map_err(|e| e.to_string())
let inner = |p: &str| -> Result<String, String> {
let j = serde_json::to_string(p).map_err(|e| e.to_string())?;
Ok(j.get(1..j.len().saturating_sub(1)).unwrap_or("").to_string())
};
serde_json::from_str(&text.replace("$CASE", &inner(dir)?).replace("$OUT", &inner(out)?)).map_err(|e| e.to_string())
}
/// A scratch directory for one case's output files.
fn scratch(area: &str, name: &str) -> Result<String, String> {
let d = std::env::temp_dir().join(format!("solidcraft-kernel-cases-{}", std::process::id())).join(format!("{area}-{name}"));
std::fs::create_dir_all(&d).map_err(|e| format!("{}: {e}", d.display()))?;
Ok(d.to_string_lossy().to_string())
}
/// An error that means "this kernel can't do it yet", not a wrong answer.
@@ -52,7 +62,7 @@ fn check_case(dir: &str) -> Value {
}
};
out["sources"] = want["sources"].clone();
let commands = match read_json(&format!("{dir}/recipe.json")).and_then(|r| script(dir, &r)) {
let commands = match scratch(&area, &name).and_then(|o| read_json(&format!("{dir}/recipe.json")).and_then(|r| script(dir, &o, &r))) {
Ok(s) => s,
Err(e) => {
out["status"] = json!("fail");
@@ -71,10 +81,15 @@ fn check_case(dir: &str) -> Value {
out["error"] = json!(format!("this build runs booleans on the {running} kernel, not {}", kernel()));
return out;
}
let refused = want["outcome"].as_str() == Some("refused");
// `refused`: only a clean refusal is right; `solid_or_refused`: a clean refusal, or a result
// graded as usual (where the geometry has no manifold answer, such as bodies touching along a
// curve only).
let outcome = want["outcome"].as_str().unwrap_or("solid");
let refused = outcome == "refused";
let may_refuse = refused || outcome == "solid_or_refused";
let mut s = solidcraft_engine::Session::default();
let ran = s.run_script(&commands);
match (ran, refused) {
match (ran, may_refuse) {
(Err(e), _) if crashed(&e.to_string()) => {
out["status"] = json!("crash");
out["error"] = json!(e.to_string());
@@ -92,12 +107,12 @@ fn check_case(dir: &str) -> Value {
out["error"] = json!(e);
return out;
}
(Ok(_), true) => {
(Ok(_), true) if refused => {
out["status"] = json!("fail");
out["error"] = json!("succeeded where the case expects a refusal");
return out;
}
(Ok(_), false) => {}
(Ok(_), _) => {}
}
// Every body in the world, imported components included.
@@ -105,6 +120,10 @@ fn check_case(dir: &str) -> Value {
let mut bodies = Vec::new();
let mut c = Checks { list: Vec::new(), pass: true };
let want_valid = want["valid"].as_bool().unwrap_or(true);
// Shells: the total where the case gives it (a body with a void, or several lumps in one
// body), else one per body.
let want_shells = want["shells"].as_u64();
let mut shells = 0u64;
for b in &world.bodies {
let m = match solidcraft_engine::kernel::measure(&b.body) {
Ok(m) => m,
@@ -118,13 +137,22 @@ fn check_case(dir: &str) -> Value {
"bbox": {"min": m.bbox.min, "max": m.bbox.max},
"faces": m.merged.faces, "edges": m.merged.edges, "vertices": m.merged.vertices,
}));
shells += m.shells as u64;
if want_valid {
// One closed shell, and every validity check this build has.
c.push("shells", json!(format!("{}: {}", b.name, m.shells)), json!(1), m.shells == 1);
// Closed shells, and every validity check this build has.
if want_shells.is_none() {
c.push("shells", json!(format!("{}: {}", b.name, m.shells)), json!(1), m.shells == 1);
}
let v = solidcraft_engine::kernel::validity(&b.body);
c.push("record_valid", json!(v.record.clone().err().unwrap_or_else(|| "ok".into())), json!("ok"), v.record.is_ok());
if let Some(sm) = &v.smlib {
c.push("smlib_check", json!(sm.clone().err().unwrap_or_else(|| "ok".into())), json!("ok"), sm.is_ok());
match &v.smlib {
Some(solidcraft_engine::kernel::SmlibCheck::Valid) => c.push("smlib_check", json!("ok"), json!("ok"), true),
Some(solidcraft_engine::kernel::SmlibCheck::Invalid(e)) => c.push("smlib_check", json!(e), json!("ok"), false),
// No verdict: the record can't be built in SMLib yet. Shown, not graded.
Some(solidcraft_engine::kernel::SmlibCheck::NotSupported(e)) => {
c.push("smlib_check", json!(format!("no verdict: {e}")), json!("ok"), true)
}
None => {}
}
}
}
@@ -142,6 +170,7 @@ fn check_case(dir: &str) -> Value {
}
};
count(&mut c, "body_count", got.body_count as u64);
count(&mut c, "shells", shells);
count(&mut c, "faces", got.faces);
count(&mut c, "edges", edges);
count(&mut c, "vertices", vertices);
+1 -1
View File
@@ -224,7 +224,7 @@ pub use sweep_path::{RailFit, SweepControl, SweepOrientation, sweep_path, sweep_
pub use topo::{CylinderFace, cylinder_end_at, cylinder_face, cylinder_face_at};
pub use topo::{TopoCounts, merged_topology, seam_flags};
pub use tspline::tspline_sheet;
pub use validity::{Validity, boolean_kernel, smlib_built, validity};
pub use validity::{SmlibCheck, Validity, boolean_kernel, smlib_built, validity};
pub use whole_face::{WholeFace, cut_takes_only_the_face, cut_tool, face_prism, matching_face};
#[derive(Debug, Clone, PartialEq, thiserror::Error)]
+26 -9
View File
@@ -10,12 +10,22 @@ pub struct Validity {
/// The record: structure, then geometry against topology within tolerances.
pub record: Result<(), String>,
/// SMLib's `check(All)` of the record; `None` in a build without SMLib.
pub smlib: Option<Result<(), String>>,
pub smlib: Option<SmlibCheck>,
}
/// SMLib's verdict on a body.
#[derive(Clone, Debug)]
pub enum SmlibCheck {
Valid,
Invalid(String),
/// The record can't be built in SMLib yet (a geometry kind the conversion doesn't take): no
/// verdict, and no fault of the body's.
NotSupported(String),
}
impl Validity {
pub fn ok(&self) -> bool {
self.record.is_ok() && self.smlib.as_ref().is_none_or(Result::is_ok)
self.record.is_ok() && !matches!(self.smlib, Some(SmlibCheck::Invalid(_)))
}
}
@@ -30,16 +40,23 @@ pub fn validity(body: &Body) -> Validity {
}
#[cfg(feature = "smlib")]
fn smlib_validity(body: &Body) -> Option<Result<(), String>> {
let checked = crate::smlib_body(body).map_err(|e| e.to_string()).and_then(|b| {
let r = b.check(solidcraft_smlib::CheckLevel::All).map_err(|e| format!("SMLib check: {e}"))?;
if r.is_valid() { Ok(()) } else { Err(format!("SMLib check: {r}")) }
});
Some(checked)
fn smlib_validity(body: &Body) -> Option<SmlibCheck> {
let b = match crate::smlib_body(body) {
Ok(b) => b,
Err(e) => {
let e = e.to_string();
return Some(if e.contains("not supported yet") { SmlibCheck::NotSupported(e) } else { SmlibCheck::Invalid(e) });
}
};
Some(match b.check(solidcraft_smlib::CheckLevel::All) {
Ok(r) if r.is_valid() => SmlibCheck::Valid,
Ok(r) => SmlibCheck::Invalid(format!("SMLib check: {r}")),
Err(e) => SmlibCheck::Invalid(format!("SMLib check: {e}")),
})
}
#[cfg(not(feature = "smlib"))]
fn smlib_validity(_: &Body) -> Option<Result<(), String>> {
fn smlib_validity(_: &Body) -> Option<SmlibCheck> {
None
}
+5 -3
View File
@@ -43,7 +43,8 @@ Each case has:
- `recipe.json`: an engine command script (`{"commands": [...]}`, as `solidcraft-cli run`
takes) or an oracle recipe (`tests/oracle/*/recipe.json`). `$CASE` in a string is the case
directory, for an input file such as `$CASE/input.step` (written by hand from the STEP or IGES
specification, never a user's file).
specification, never a user's file), and `$OUT` a scratch directory outside the repository for
files the case writes (an export).
- `expected.json`: the right answer, graded by `solidcraft-cli kernel-cases`.
Each area also has `skipped.json` (or several, `skipped-<part>.json`, where an area is triaged in
@@ -74,8 +75,9 @@ parts): every issue and PR looked at that did not become a case, with one line e
| `what` | One line: the geometry that went wrong. |
| `source` | `analytic` (numbers worked out by hand; `method` gives the formulas) or `invariants` (no number is known: only the outcome, validity and counts are graded). |
| `method` | How the numbers were derived, or which invariants hold and why. |
| `outcome` | `solid` (default: the script succeeds) or `refused` (the right answer is a clean error, never a panic or a hang). |
| `valid` | Default `true`: every body is one closed shell that passes the record's structure and geometry checks and, in builds with SMLib, SMLib's `check(All)`. `false` only where the result is legitimately not a solid. |
| `outcome` | `solid` (default: the script succeeds), `refused` (the right answer is a clean error, never a panic or a hang), or `solid_or_refused` (either a clean error or a result graded as usual, where the geometry has no single manifold answer, such as two bodies touching along a curve only). |
| `valid` | Default `true`: every body is one closed shell (or `shells` in all) that passes the record's structure and geometry checks and, in builds with SMLib, SMLib's `check(All)`. `false` only where the result is legitimately not a solid (a sheet). Where SMLib can't take the record yet (a surface kind its conversion lacks), its check gives no verdict and is not graded. |
| `shells` | The total number of shells, where it isn't one per body: a body with a sealed void (2), several lumps kept in one body. |
| `body_count`, `faces`, `edges`, `vertices` | Exact counts, where the geometry fixes them. Faces and edges count whole analytic surfaces and curves once (a full cylinder side is one face). |
| `volume_mm3`, `area_mm2`, `center_of_mass`, `bbox` | As in `tests/oracle`: totals over every body, relative tolerance 1e-3 for volume and area, 1e-3 of the box diagonal for positions. |
| `tolerance` | Optional overrides: `rel`, `abs_mm`. |
@@ -1,10 +1,11 @@
{
"sources": [
"tangency-labs/solidcraft#168"
],
"what": "a rim on a coin's top face that meets the coin along one circle only (no shared area, no shared volume): it must not be joined into it",
"source": "analytic",
"method": "coin r10 h5: 500 pi; rim = ring r10..14 standing on z=5 for 3: pi*(196-100)*3 = 288 pi. They share only the circle r10 at z=5, so the result is two bodies (or a refusal, never one joined body); volume 788 pi = 2475.664. body_count 2",
"body_count": 2,
"volume_mm3": 2475.5750110287568
"sources": [
"tangency-labs/solidcraft#168"
],
"what": "a rim on a coin's top face that meets the coin along one circle only (no shared area, no shared volume): it must not be joined into it",
"source": "analytic",
"outcome": "solid_or_refused",
"method": "coin r10 h5: 500 pi; rim = ring r10..14 standing on z=5 for 3: pi*(196-100)*3 = 288 pi. They share only the circle r10 at z=5, so the right answer is a clean refusal or two bodies, never one joined body; volume 788 pi = 2475.664. body_count 2",
"body_count": 2,
"volume_mm3": 2475.5750110287568
}
@@ -4,8 +4,8 @@
],
"what": "a cut over the bottom edge of a revolved cylinder that holds a sealed spherical void on its axis: the body must not come out empty or refused",
"source": "analytic",
"method": "revolved cylinder r24 h60 minus the sealed sphere r2 at z=30 minus the box x 20..30, y -10..10, z -5..10 where it meets the cylinder: {x>=20, |y|<=10, x^2+y^2<=24^2} is Int from -10 to 10 of (sqrt(576-y^2) - 20) dy = 10*sqrt(476) + 576*asin(10/24) - 400 = 65.725 over z in 0..10. V = pi*24^2*60 - 4/3*pi*2^3 - 10*area = 107882.68. One body that holds two shells (outer and the void), so valid is false: the rig reads more than one shell as not a solid",
"valid": false,
"method": "revolved cylinder r24 h60 minus the sealed sphere r2 at z=30 minus the box x 20..30, y -10..10, z -5..10 where it meets the cylinder: {x>=20, |y|<=10, x^2+y^2<=24^2} is Int from -10 to 10 of (sqrt(576-y^2) - 20) dy = 10*sqrt(476) + 576*asin(10/24) - 400 = 65.725 over z in 0..10. V = pi*24^2*60 - 4/3*pi*2^3 - 10*area = 107882.68. One body with two shells (outer and the void)",
"body_count": 1,
"shells": 2,
"volume_mm3": 107882.68287918373
}
@@ -4,8 +4,8 @@
],
"what": "one combine of 64 separate pegs that do not touch: 36 s on truck, growing 4-9x per doubling; must finish in seconds",
"source": "analytic",
"method": "64 non-touching 48-gon pegs of circumradius 2, 1 mm tall, 6 mm apart: each area 0.5*48*2^2*sin(2pi/48) = 12.5305, V = 64 * 12.5305 * 1. The join keeps them in one body (several lumps). A hang is a failure: time should grow with the number of bodies. valid is false only because the one body holds 64 separate shells, which the rig's one-shell check does not allow",
"method": "64 non-touching 48-gon pegs of circumradius 2, 1 mm tall, 6 mm apart: each area 0.5*48*2^2*sin(2pi/48) = 12.5305, V = 64 * 12.5305 * 1. The join keeps them in one body (several lumps). A hang is a failure: time should grow with the number of bodies. One body with 64 shells",
"body_count": 1,
"volume_mm3": 801.9529,
"valid": false
}
"shells": 64,
"volume_mm3": 801.9529
}
@@ -5,8 +5,8 @@
],
"what": "intersect of a two-lump target (two spheres joined while apart) with a box holding the bottom half of each",
"source": "analytic",
"method": "box x -10..40, y -10..10, z -10..0 holds the z<=0 half of each r=4 sphere (centres (0,0,0), (30,0,0)): V = 2 * (2/3) pi 4^3 = 268.083. The body must not be removed. valid is false only because the one body holds two separate shells, which the rig's one-shell check does not allow",
"method": "box x -10..40, y -10..10, z -10..0 holds the z<=0 half of each r=4 sphere (centres (0,0,0), (30,0,0)): V = 2 * (2/3) pi 4^3 = 268.083. The body must not be removed. One body with two shells",
"body_count": 1,
"volume_mm3": 268.0826,
"valid": false
}
"shells": 2,
"volume_mm3": 268.0826
}
@@ -5,6 +5,7 @@
],
"what": "Join of a ring (r10..15) onto a coin (r10) that touch only along a circle: no fusion that moves the ring",
"source": "invariants",
"outcome": "refused",
"method": "the bodies share one circular edge and no area, so a join has no valid solid to give: the right answer is a clean refusal (New Body gives two independent solids). Succeeding means the kernel moved or rotated the ring to fuse it"
}
"outcome": "solid_or_refused",
"method": "the bodies share one circular edge and no area, so a join has no single manifold solid to give: the right answer is a clean refusal, or the two bodies left as they are (body_count 2). Fusing them means the kernel moved or rotated the ring",
"body_count": 2
}
@@ -834,7 +834,7 @@
{
"command": "file.export",
"params": {
"path": "/tmp/kernel-case-1985.step",
"path": "$OUT/kernel-case-1985.step",
"format": "step"
}
},
@@ -1103,7 +1103,7 @@
{
"command": "file.export",
"params": {
"path": "/tmp/kernel-case-2243.step",
"path": "$OUT/kernel-case-2243.step",
"format": "step"
}
},
@@ -1,16 +1,16 @@
{
"sources": [
"tangency-labs/solidcraft#3730",
"tangency-labs/solidcraft#3872"
],
"what": "a block with a closed cavity written as BREP_WITH_VOIDS whose void shell (outward-facing faces) is turned by ORIENTED_CLOSED_SHELL .F.; the cavity must be taken out, not added",
"source": "analytic",
"method": "V = 40*30*12.5 - 20*6*5 = 15000 - 600; A = 2(40*30+40*12.5+30*12.5) + 2(20*6+20*5+6*5) = 4150 + 500; faces 6+6, edges 12+12, vertices 8+8; valid is false only because a body with a void holds two shells (outer and cavity), which the one-shell validity check does not allow",
"valid": false,
"body_count": 1,
"volume_mm3": 14400.0,
"area_mm2": 4650.0,
"faces": 12,
"edges": 24,
"vertices": 16
"sources": [
"tangency-labs/solidcraft#3730",
"tangency-labs/solidcraft#3872"
],
"what": "a block with a closed cavity written as BREP_WITH_VOIDS whose void shell (outward-facing faces) is turned by ORIENTED_CLOSED_SHELL .F.; the cavity must be taken out, not added",
"source": "analytic",
"method": "V = 40*30*12.5 - 20*6*5 = 15000 - 600; A = 2(40*30+40*12.5+30*12.5) + 2(20*6+20*5+6*5) = 4150 + 500; faces 6+6, edges 12+12, vertices 8+8; one body with two shells (outer and cavity)",
"body_count": 1,
"shells": 2,
"volume_mm3": 14400.0,
"area_mm2": 4650.0,
"faces": 12,
"edges": 24,
"vertices": 16
}
+290
View File
@@ -0,0 +1,290 @@
[
{
"source": "tangency-labs/solidcraft#4139",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve join, \"boolean Union: no result\")"
},
{
"source": "tangency-labs/solidcraft#4093",
"why": "reproduction script cut off in the source (a 3-turn guided thread sweep cut; the generator stops mid-way) and the run takes about 48 s, over the case budget"
},
{
"source": "tangency-labs/solidcraft#4092",
"why": "reproduction JSON cut off in the source (the 50-command script stops mid-way, rib shapes not given in the text)"
},
{
"source": "tangency-labs/solidcraft#4037",
"why": "empty report: the loft failure arrived with no content"
},
{
"source": "tangency-labs/solidcraft#4006",
"why": "other area: import (STEP export of a revolve written as a cone of semi-angle pi/2; the revolve itself is right, and the import rig holds this as 4006-plane-written-as-cone-of-nearly-right-angle)"
},
{
"source": "tangency-labs/solidcraft#4005",
"why": "other area: import (STEP export writes a cylinder as a cone of semi-angle 8e-12; the revolve itself is right, and the import rig holds this as 4005-cylinder-written-as-near-zero-cone)"
},
{
"source": "tangency-labs/solidcraft#3960",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve join, \"boolean Union: no result\")"
},
{
"source": "tangency-labs/solidcraft#3837",
"why": "not geometry: exploded view steps, easing and trail lines (assembly presentation)"
},
{
"source": "tangency-labs/solidcraft#3806",
"why": "other area: import (IGES surface of revolution of an arc read as a whole sphere; held by the import rig as 3806-iges-revolved-arc-spherical-cap-dome)"
},
{
"source": "tangency-labs/solidcraft#3790",
"why": "feature request: square and triangular pipe sections, no geometry to grade (the pipe takes a circular section only)"
},
{
"source": "tangency-labs/solidcraft#3781",
"why": "UI feature request: a target-body picker in the Extrude, Sweep and Revolve dialogs (the command already takes targets, held by the loft targets case 271)"
},
{
"source": "tangency-labs/solidcraft#3752",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve join, \"boolean Union: no result\")"
},
{
"source": "tangency-labs/solidcraft#3726",
"why": "UI: the dialog was opened with no sections picked (\"select the sections, one sketch each first\"); no geometry"
},
{
"source": "tangency-labs/solidcraft#3724",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve join, \"boolean Union: no result\")"
},
{
"source": "tangency-labs/solidcraft#3717",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve join, \"boolean Union: no result\")"
},
{
"source": "tangency-labs/solidcraft#3697",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve join, \"unexpected result\" with only a screenshot)"
},
{
"source": "tangency-labs/solidcraft#3691",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (a 90 degree revolve joined to the bottom of a letter L; the design is only in an attached file)"
},
{
"source": "tangency-labs/solidcraft#3636",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (coil join, Union no result; the target body is not given and the pitch was typed with a decimal comma)"
},
{
"source": "tangency-labs/solidcraft#3635",
"why": "feature request: start and end conditions for extrude, hole and loft; no geometry"
},
{
"source": "tangency-labs/solidcraft#3545",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve join)"
},
{
"source": "tangency-labs/solidcraft#3433",
"why": "not geometry: GPU path tracer shader cache"
},
{
"source": "tangency-labs/solidcraft#3308",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (loft join of two sketches)"
},
{
"source": "tangency-labs/solidcraft#3241",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve join)"
},
{
"source": "tangency-labs/solidcraft#3215",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (a 15-profile revolve cut that runs for minutes)"
},
{
"source": "tangency-labs/solidcraft#3076",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve join of three profiles against a body with 29 curved faces)"
},
{
"source": "tangency-labs/solidcraft#3063",
"why": "UI: the dialog was opened with no sections picked; the reporter wants a spline loft that is not described"
},
{
"source": "tangency-labs/solidcraft#2993",
"why": "not reproduced and no geometry: a circle swept along a fit-point spline follows the path on current builds; the design with the failing sketch placement was not attached"
},
{
"source": "tangency-labs/solidcraft#2990",
"why": "other area: shell (shelling a loft; held by the shell rig as 3669-shell-lofted-square-frustum)"
},
{
"source": "tangency-labs/solidcraft#2954",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (twisted annular sweep cut; the design was lost)"
},
{
"source": "tangency-labs/solidcraft#2883",
"why": "UI: the dialog was opened with no profiles picked (\"select profiles of two or more sketches first\"); working as designed"
},
{
"source": "tangency-labs/solidcraft#2816",
"why": "not reproduced and no geometry: a surface sweep that went the opposite way from the path; the sketches were not attached (the sweep starts at the path end nearest the profile)"
},
{
"source": "tangency-labs/solidcraft#2811",
"why": "other area: fillets (performance of filleting many rib roots)"
},
{
"source": "tangency-labs/solidcraft#2802",
"why": "UI: leave sketch mode when Extrude starts; no geometry"
},
{
"source": "tangency-labs/solidcraft#2747",
"why": "no geometry: \"revolve does not work on a selected face of a cube\" with no axis or dimensions; a face profile has no axis lying in its plane to revolve about"
},
{
"source": "tangency-labs/solidcraft#2673",
"why": "tessellation: artefacts on the arc of a revolved half pill seen in a screenshot, with no dimensions that fix the sketch (display is owned elsewhere)"
},
{
"source": "tangency-labs/solidcraft#2656",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (sweep cut along an arc and a line)"
},
{
"source": "tangency-labs/solidcraft#2576",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (loft join of two sketches)"
},
{
"source": "tangency-labs/solidcraft#2515",
"why": "empty report: no body, no parameters, no geometry"
},
{
"source": "tangency-labs/solidcraft#2442",
"why": "empty report: the sweep failure arrived with no content"
},
{
"source": "tangency-labs/solidcraft#2350",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (crash while running a 5-section loft join named RainRidge; sketches not given)"
},
{
"source": "tangency-labs/solidcraft#2333",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (a 5 degree symmetric revolve join to skin a hole in a cylinder; no dimensions)"
},
{
"source": "tangency-labs/solidcraft#2216",
"why": "UI: an edge cannot be picked as a sweep path (\"select the path first\"); no geometry"
},
{
"source": "tangency-labs/solidcraft#2004",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (revolve cut, \"implausible result volume 298.2432\")"
},
{
"source": "tangency-labs/solidcraft#1988",
"why": "UI: hidden bodies are joined by a loft join (visibility scoping of the join participants); the loft with explicit targets is held by case 271"
},
{
"source": "tangency-labs/solidcraft#1775",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (loft cut of two sketches)"
},
{
"source": "tangency-labs/solidcraft#1402",
"why": "no geometry: an auto-report with only the failing command's parameters (sketch and profile ids), no sketch, axis or body to rebuild from (sweep join of six profiles; design not attached)"
},
{
"source": "tangency-labs/solidcraft#1213",
"why": "other area: fillets (a round or chamfer on the end circle of a bent lofted tube)"
},
{
"source": "tangency-labs/solidcraft#442",
"why": "other area: booleans (inspect.interference misses a 0.36 mm3 overlap with a small rib)"
},
{
"source": "tangency-labs/solidcraft#171",
"why": "not geometry: the CLI panics when its stdout pipe is closed"
},
{
"source": "tangency-labs/solidcraft#3987",
"why": "other area: import (revolve, sweep and loft joined to a part nested in a STEP assembly)"
},
{
"source": "tangency-labs/solidcraft#3901",
"why": "other area: import (STEP conformance parts, cones to a point)"
},
{
"source": "tangency-labs/solidcraft#3880",
"why": "other area: import (STEP conformance regression sweep)"
},
{
"source": "tangency-labs/solidcraft#3840",
"why": "not geometry: the pull request for the exploded view steps (#3837)"
},
{
"source": "tangency-labs/solidcraft#3818",
"why": "other area: tessellation (hovering a long helical edge)"
},
{
"source": "tangency-labs/solidcraft#3813",
"why": "other area: import (the fix for #3806, IGES revolved arc)"
},
{
"source": "tangency-labs/solidcraft#3318",
"why": "other area: booleans (symmetric through-all lens cut on a revolved ring that shares its outline cylinder; the reproduction is an example file not given in the report)"
},
{
"source": "tangency-labs/solidcraft#2815",
"why": "UI: the pull request finishing the sketch when Extrude or Revolve starts"
},
{
"source": "tangency-labs/solidcraft#2791",
"why": "other area: booleans (lens-profile cut into a revolved quarter sphere; the profile is not given in the report)"
},
{
"source": "tangency-labs/solidcraft#2486",
"why": "other area: shell (shelling revolved barrels; held by the shell rig)"
},
{
"source": "tangency-labs/solidcraft#2276",
"why": "not geometry: inspect.parameter_sweep checks a design over a parameter range (a design-check command, not a sweep feature)"
},
{
"source": "tangency-labs/solidcraft#2242",
"why": "UI: the arc sweep value box covered the end-point pick (the sketch arc \"sweep\", not a solid sweep)"
},
{
"source": "tangency-labs/solidcraft#1981",
"why": "not geometry: joint sweep (driving an assembly joint), not a solid sweep"
},
{
"source": "tangency-labs/solidcraft#1928",
"why": "other area: import (STEP export of revolved faces scaled across their axis)"
},
{
"source": "tangency-labs/solidcraft#1555",
"why": "not geometry: headless pictures on the GPU"
},
{
"source": "tangency-labs/solidcraft#1496",
"why": "other area: import (STEP export of shelled revolved bodies)"
},
{
"source": "tangency-labs/solidcraft#1099",
"why": "not geometry: startup crash on D3D12, tessellation pipeline fallback"
},
{
"source": "tangency-labs/solidcraft#709",
"why": "UI: unit labels in the primitive dialogs"
},
{
"source": "tangency-labs/solidcraft#705",
"why": "UI: Extrude and Revolve leave the Profiles field empty when the last sketch is used"
},
{
"source": "tangency-labs/solidcraft#536",
"why": "not geometry: inspect.interference pruning for large body counts"
},
{
"source": "tangency-labs/solidcraft#407",
"why": "not geometry: component placement frames when an extrude or revolve uses a sketch of another component (assembly)"
},
{
"source": "tangency-labs/solidcraft#174",
"why": "not geometry: the fix for the closed stdout pipe panic (#171)"
},
{
"source": "tangency-labs/solidcraft#85",
"why": "not geometry: batch rollback and deleting a sketch removes its pipe (document history)"
}
]
@@ -0,0 +1,31 @@
{
"sources": [
"tangency-labs/solidcraft#1995"
],
"what": "an M8x1 modelled thread in a 7 mm hole through a block (the report: the thread also changed the block's outer surface and made too many faces)",
"source": "analytic",
"method": "ISO 68-1 basic profile: H = P sqrt3/2, basic depth 5H/8. Internal groove: P/8 wide at the major radius d/2, widening by 2 tan30 per unit of radius toward the axis (3P/4 at the minor radius d/2 - 5H/8 = 3.4587), cut only where there is material (r >= hole radius 3.5). Volume per turn = 2 pi * integral from 3.5 to 4 of (P/8 + 2 tan30 (4 - r)) r dr = 4.79792 mm3 for P=1. Block 20x20x10 with a 7 mm through hole (rho=3.5), M8x1 over the full 10 mm (10 turns, both ends free): V = 4000 - pi 3.5^2 10 - 10 x 4.79792 = 3567.1757 mm3. The outer surface is untouched: the bbox stays the block's 20x20x10 and COM stays on the axis at z=5. Tolerance 1%: a modelled thread is a faceted helical solid (radial chord error up to 1% of the pitch on every wall).",
"outcome": "solid",
"body_count": 1,
"volume_mm3": 3567.1757,
"center_of_mass": [
0,
0,
5.0
],
"tolerance": {
"rel": 0.01
},
"bbox": {
"min": [
-10,
-10,
0
],
"max": [
10,
10,
10
]
}
}
@@ -0,0 +1,41 @@
{
"commands": [
{
"command": "solid.box",
"params": {
"corner": [
-10,
-10,
0
],
"length": 20,
"width": 20,
"height": 10,
"body_name": "Block"
}
},
{
"command": "solid.hole",
"params": {
"position": [
0,
0,
10
],
"diameter": 7
}
},
{
"command": "solid.thread",
"params": {
"face": [
3.5,
0,
5.0
],
"designation": "M8x1",
"modeled": true
}
}
]
}
@@ -0,0 +1,23 @@
{
"sources": [
"tangency-labs/solidcraft#3368"
],
"what": "booleans of a finely faceted body (a 1200-sided prism, 1202 flat faces, the kind of body a modelled thread leaves) with box tools: they must finish in bounded time with the exact result, not run for minutes",
"source": "analytic",
"method": "A regular N-gon of circumradius R (one vertex on +x) has area N/2 R^2 sin(2 pi/N). Plate: 1200-gon R=30, h=10: V0 = 600 * 900 * sin(0.3 deg) * 10 = 28274.2047. Cut: a 10x10 square pocket through the full thickness, entirely inside the plate: -10*10*10 = -1000. Join: a 12x12x5 box standing on the top face (z 10 to 15, x and y 8 to 20, inside the outline, touching the top face only in its base): +720. V = 27994.2047 mm3.",
"outcome": "solid",
"body_count": 1,
"volume_mm3": 27994.2047,
"bbox": {
"min": [
-30,
-30,
0
],
"max": [
30,
30,
15
]
}
}
File diff suppressed because one or more lines are too long
@@ -0,0 +1,23 @@
{
"sources": [
"tangency-labs/solidcraft#3368"
],
"what": "a finely faceted body (a 1200-sided prism) with a curved partner: a vertical bore and a horizontal cross hole drilled through it (the case where the B-rep ladder is bounded but must still decide)",
"source": "analytic",
"method": "A regular N-gon of circumradius R (one vertex on +x) has area N/2 R^2 sin(2 pi/N). Plate: 1200-gon R=30, h=10: V0 = 28274.2047. Vertical bore R=5 at (-15,12), through the whole thickness, inside the outline: -pi*25*10 = -785.3982. Cross hole R=3 along x at y=0, z=5 (z 2..8, inside the thickness): it spans the polygon's full chord on the x axis, which is 2R = 60 because vertices sit at angles 0 and 180 deg: -pi*9*60 = -1696.4600 (the hole is clear of the bore: bore y 7..17, hole y -3..3). V = 25792.3465 mm3.",
"outcome": "solid",
"body_count": 1,
"volume_mm3": 25792.3465,
"bbox": {
"min": [
-30,
-30,
0
],
"max": [
30,
30,
10
]
}
}
File diff suppressed because one or more lines are too long
@@ -0,0 +1,23 @@
{
"sources": [
"tangency-labs/solidcraft#3368"
],
"what": "two finely faceted bodies (1000-sided prisms, flat faces only): a faceted stud cut out of a faceted disc, then a faceted cap joined on top touching in a plane; both booleans must finish in bounded time with the exact result",
"source": "analytic",
"method": "A regular N-gon of circumradius R (one vertex on +x) has area N/2 R^2 sin(2 pi/N). Disc: 1000-gon R=30, h=10 (z 0..10). Stud: 1000-gon R=6, z -2..12, coaxial with the same vertex angles, so it removes its 10 mm inside the disc: -A6*10. Cap: 1000-gon R=20, z 10..14, touching the disc's top face in a plane and covering the hole's top (the hole stays open at the bottom, no sealed void): +A20*4. V = 500*sin(0.36 deg)*(900*10 - 36*10 + 400*4) = 32169.6971 mm3.",
"outcome": "solid",
"body_count": 1,
"volume_mm3": 32169.6971,
"bbox": {
"min": [
-30,
-30,
0
],
"max": [
30,
30,
14
]
}
}
File diff suppressed because one or more lines are too long
+12
View File
@@ -226,5 +226,17 @@
{
"source": "tangency-labs/solidcraft#1020",
"why": "CPU or window threads (off-thread evaluation, freezes), not modelled threads: no geometry"
},
{
"source": "tangency-labs/solidcraft#987",
"why": "auto-report with a fillet's four edge picks and a screenshot only ('a ghost in the thread creation'): no design, no thread parameters, nothing to rebuild or compute"
},
{
"source": "tangency-labs/solidcraft#3130",
"why": "auto-report with command parameters only (an M5 drilled hole at a point the comment reads as off the part): no design; a drilled M5 hole in a block works, so there is no geometry to grade"
},
{
"source": "tangency-labs/solidcraft#3824",
"why": "auto-report with command parameters only (an M5 drilled hole from sketch point 8, failing 'no cylindrical face there to thread'): the sketch's face is not in the report, and a drilled M5 hole from a point on a flat block face works"
}
]
+7 -1
View File
@@ -26,6 +26,8 @@ struct Options {
area: Option<String>,
timeout: Duration,
jobs: usize,
/// Where to keep every case's full result as JSON.
results: Option<String>,
}
fn options(rest: &[&str]) -> Result<Options, String> {
@@ -38,7 +40,7 @@ fn options(rest: &[&str]) -> Result<Options, String> {
};
let secs = arg("--timeout").map(|t| t.parse::<u64>().map_err(|e| format!("--timeout: {e}"))).transpose()?.unwrap_or(DEFAULT_TIMEOUT_S);
let jobs = arg("--jobs").map(|j| j.parse::<usize>().map_err(|e| format!("--jobs: {e}"))).transpose()?.unwrap_or(4).clamp(1, 32);
Ok(Options { kernels, cli: arg("--cli"), area: arg("--area"), timeout: Duration::from_secs(secs), jobs })
Ok(Options { kernels, cli: arg("--cli"), area: arg("--area"), timeout: Duration::from_secs(secs), jobs, results: arg("--results") })
}
fn read(path: &Path) -> Value {
@@ -323,6 +325,10 @@ pub fn run(rest: &[&str]) -> Result<(), String> {
return Err(format!("no cases (recipe.json + expected.json) under {}", dir.display()));
}
let results = run_all(&o, &list);
if let Some(path) = &o.results {
let text = serde_json::to_string_pretty(&results).map_err(|e| e.to_string())?;
std::fs::write(path, text).map_err(|e| format!("{path}: {e}"))?;
}
println!("{}", write_report(&o, &dir, &list, &results)?);
Ok(())
}
+3 -2
View File
@@ -46,10 +46,11 @@ commands:
replay the reference tests (tests/oracle/*/recipe.json), compare with each
case's expected.json and write docs/oracle.md (--cli: a solidcraft-cli
already built, instead of cargo run --release)
kernel-cases [--kernel default|smlib|both] [--area AREA] [--cli BIN] [--timeout S] [--jobs N]
kernel-cases [--kernel default|smlib|both] [--area AREA] [--cli BIN] [--timeout S] [--jobs N] [--results FILE]
the kernel regression rig: run every case in tests/kernel-cases/<area>/<id>/ (one
process each, killed after --timeout, default 180 s) with each kernel asked for,
grade it against the case's own answer and write docs/kernel-cases.md
grade it against the case's own answer and write docs/kernel-cases.md (--results:
every result as JSON too)
action-matrix [--bless] [--results FILE] [--from DIR]
try every ordinary action on every face, edge, vertex and body of the design
corpus and compare with tests/action_matrix/baseline.json (--bless rewrites it;