69cfd89ae883a4aa4de2accd2216980da482128d
668 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
9e6e0b8df1 |
Render workspace: complete experimental ribbon, resources and effects integration (#5493) (#5494)
* wip(render): reconcile completed material and image pipeline source with 0.20 (#5493)
Source-only integration reference for staged review, not a merge-ready aggregate.
Donor: 0xlillith/solidcraft@aea20b0115.
Upstream:
|
||
|
|
b7b25f9e2b |
Render workspace: first basic delivery to main (#6050)
* Normalize UI container violation paths across platforms (#5599)
Report repository-relative paths with forward slashes so diagnostics and the existing nested-package regression assertions agree on Windows and Unix. Keep the container detection rules unchanged.
Validation: official ui-containers gate and all seven focused xtask tests passed; rustfmt and diff checks passed. Only xtask/dependencies were compiled; no application build or heavy tests.
(cherry picked from commit 44b58d8e103a5fbc816ebf7c22b8de768ddf592b)
Scoped render-branch prerequisite from #4507, coordinated under #5493. No unrelated translation/kernel changes are included. Fresh Windows fmt, seven ui_containers regressions and the production container gate pass on render base
|
||
|
|
4612c5e6a9 |
Equal with three or more curves selected makes them all equal (#4985) (#5139)
* claim: #4985 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Equal with three or more curves selected makes them all equal (#4985) With more than two curves selected, Equal fell back to the pick tool and applied nothing. sketch.constraint.equal also takes curves: [2..200], each made equal to the first in one step (strict, so a conflict changes nothing), and the toolbar sends a selection of three or more curves as that list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
c0da9fe861 |
Trim cuts a line at its tangent point on a circle (#5074) (#5163)
* claim: #5074 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Trim cuts a line at its tangent point on a circle (#5074) A line the solver made tangent to a circle touches it within rounding noise, and the exact intersection missed the touch whenever the noise fell outside, so trim found no cut there and deleted the whole line. Trim takes its cut points from intersections_within at its own merge distance, as profile detection does (#588). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
19db763899 |
Tapped Hole: verified metric fine, UNC/UNF and parallel G/Rp catalogues (#4178)
* feat: expand tapped-hole catalogue with metric fine and Unified sizes * docs: distinguish metric designations from expanded tapped catalogue * feat: add internal pipe catalogue and checked Rc profile data * Connect parallel G and Rp catalogues to cylindrical tapped holes * fix(i18n): register tapped thread catalogue labels * fix(i18n): complete thread labels in required locales |
||
|
|
9a737bd63c |
Linked components: joints keep their face after Update Links (#3330) (#4874)
* claim: #3330 * Linked components: joints keep their face after Update Links (#3330) A linked design comes in as STEP text, which keeps no face names, so the faces of its bodies were named by their place in the file (`face:<k>`). An edit of the part that adds a face earlier in the file (a second hole of the same size) gave that place to another face, and a joint on the linked part moved there silently. When a link is made or updated, each imported face is matched to the part face it was written from (the same geometry), and the Import feature keeps that face's name in the part (`Feature::link_faces`, a new pending format change). The linked face is named `F<import>🔗<digest of that name>`, pieces keeping their qualifiers, so references follow the part's own history through Update Links as they do inside the part, and a face the part no longer has is reported. Linked faces still answer to `face:<k>`, so older references keep resolving; Update Links warns about joints that use them and reports joints that no longer solve. * Linked faces: a solid's twin keeps its own names; renamed faces count as an update Two solids of a part alike in one place each take the names of the solid the file names them after. Update Links reports a link whose part named its faces differently since as updated (a joint may follow that name to another face), not as unchanged; only a link getting its first names stays unchanged. * Linked faces: Extract to File carries the design's face names too Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: MateuszSychXpl <151755914+MateuszSychXpl@users.noreply.github.com> Co-authored-by: bherbruck <brennen.herbruck@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> |
||
|
|
4dc30c092d |
Mirror and pattern: a pattern or mirror feature as the source (#395) (#3998)
* claim: #395 * Mirror and pattern: a pattern or mirror feature as the source (#395) A pattern or mirror of features refused another pattern or mirror as a source ("Pat cannot be patterned or mirrored yet"). Such a source now stands for what it copied: its own sources are replayed at each of its transforms moved by each of ours, to any depth up to eight. Copies of a feature picked directly keep the instance numbers they had, so existing designs keep their face names; copies made through a nested pattern or mirror are numbered after them, so one feature reached two ways never names two copies alike. A pattern or mirror of bodies as the source is still refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e67ae66f3e |
Renaming a parameter follows it into sheet-metal and plastic rules and canvases (#4420) (#4423)
* claim: #4420 * Renaming a parameter follows it into sheet-metal and plastic rules and canvases (#4420) Document::rename_param rewrote other parameters, feature inputs, dimensions, configurations and joints, but not the expressions of sheet metal and plastic rules or the plane a canvas lies on, so after a rename the sheet metal and plastic features using them failed with "unknown parameter" and the canvas left the view. It renames them there now, and param_users lists them (a rule's field, a canvas's input), so a parameter they use can't be deleted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Parameters: rules' features in drives and the graph; shared rule field lists (#4420) A sheet metal or plastic rule that uses a parameter makes the sheet metal (or plastic) features rebuild when it changes, so parameters.users lists them in drives and parameters.graph links them. SheetRule::fields/fields_mut and PlasticRule::fields_mut replace the hand-written copies of the rules' fields in params.rs, eval.rs and sheet.manage_rules. Suggested by @CamWight. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fmt (#4420) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
807e367bdb |
Hole: place a Single hole by distances from reference edges (#37) (#2931)
A Single hole can take up to two straight edges of its face as references,
each with the distance of the hole's centre from that edge's line, measured
in the face's plane. `solid.hole` takes them as `references: [{edge, distance}]`;
the edges are found again by their persistent names, else their points, so
the hole follows them when the part changes, and each distance is a
parameter. A bad reference (no edge there, a curved edge, one square to the
face, parallel edges, a negative distance, a centre off the face) is refused.
In the Hole dialog, Reference 1 and 2 follow the face, each with its Distance
row; the canvas shows each distance as a dimension from its edge to the hole,
with a box just past the edge to type it in. Picking an edge measures its
distance (and its box takes the keyboard), typing one moves the hole, and
moving the hole measures them again. Edit Feature picks the edges again with
their distances.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
||
|
|
d2eb8cf639 |
Timeline: suppressing a feature keeps later features' body names (#4302) (#4311)
* claim: #4302 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Timeline: suppressing a feature keeps later features' body names (#4302) Bodies numbered by the counter (`BodyN`) take the next free number on every recompute, so suppressing a feature that made one moved every later counted body down one (`Body2` became `Body1`) and broke what named it, such as a Move of `Body2`. timeline.suppress now stores the current names of later features' counted bodies in their `body_names` first, as body.rename already does for a renamed counted body (#1109). Engine only: no evaluation or design-format change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Timeline: a body made while a feature is suppressed keeps its name (#4302) Suppressing a feature freed its counted name (`Body1`), so a body made meanwhile took it and became `Body3` once the feature was back. Suppress now also stores the suppressed feature's own counted names, and the evaluator adds the names stored on earlier suppressed features to the state's `reserved_body_names` (the names a rename freed, #4957), which the `BodyN` counter passes by. They are taken from the design before each feature is computed and are part of the state digest, so a cached result is only reused when they match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
89c1f02850 |
Sketch slots: provide typed dimension inputs for every variant (#2423) (#4318)
* claim: #2423 * fix(sketch): add typed dimensions to every slot tool (#2423) |
||
|
|
45edd5baf5 |
Fix midpoint picks in sketch dimensions (#4872)
Retain MID snaps across both picks and materialize reusable midpoint constraints for point-to-line and point-to-point dimensions. Let midpoint pairs choose horizontal or vertical spans with pointer placement before entering a value. Cover projected model edges, overlapping geometry, helper reuse, undo/cancel/reopen, and existing angular and line-circle workflows. |
||
|
|
2e5924ed5e |
Preserve construction references when axes and points are renamed (#4419) (#4449)
* claim: #4419 * fix: preserve renamed construction references (#4419) |
||
|
|
0dffb206b1 |
Assembly: ground the first part; drag free joint chains (#2804) (#2805)
* assembly(feat): ground first parts and drag free joint chains Ground the first top-level part when it is created and let face dragging reposition free occurrences or any member of a floating joint chain in one undo step. Preserve exact repeated-placement frames, joint values, modifier selection and Escape cancellation. Keep the accumulated fixture, viewport layout and documentation integration fixes from the existing PR. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(fix): update movable fixtures for first-part grounding Accept the documented grounded override in component creation, explicitly free movement fixtures, and keep linked clipboard pastes movable even in an empty document. Cover first and reused linked pastes, default insertion grounding, and single-step undo in the existing link tests. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): keep the motion-cost crank free Unground the first component in the document-level joint-face measurement fixture so its motion samples can rotate after first-part grounding. Preserve the rotation and shared-measurement assertions that caught the Linux CI failure. Signed-off-by: Karl Von Richter<karl@embeint.com> * assembly(test): free the frame placement fixture Create the frame-member placement fixture ungrounded before moving it above its root sketch. Keep its world-space member assertions while respecting first-part grounding in the frame tests added on main. Signed-off-by: Karl Von Richter<karl@embeint.com> --------- Signed-off-by: Karl Von Richter<karl@embeint.com> |
||
|
|
4353f34bd1 |
Delete removes a selected construction axis (#4692) (#4695)
* claim: #4692 * Delete removes a selected construction axis (#4692) Delete on a construction axis skipped it with "the origin axes can't be deleted". It now deletes the construction axis feature, like construction planes; the origin axes X, Y and Z are still refused. |
||
|
|
7e472bc4da |
Cancel Sketch: leave a sketch without keeping its changes (#3838) (#3938)
* claim: #3838 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SBN24y2TcqRcm2zn8Gkj27 * Cancel Sketch: leave a sketch without keeping its changes (#3838) sketch.cancel (Cancel Sketch, ribbon Exit group and the sketch's right-click menu) puts the design back as it was when the open sketch was created or opened for editing: a new sketch is removed with its dimension parameters, an edited one returns to how it was. It is one undo step, so Undo goes back into the sketch. The session remembers the design and the undo history at the point a sketch is entered. Cancel uses that only while the history still runs through it (the same steps before, every step since taken in this sketch); otherwise it refuses and points to Undo, so a stale entry can never throw away later work. The icon is the approved close glyph in the sketch accent (alias sketch_cancel); ja and zh carry the new label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SBN24y2TcqRcm2zn8Gkj27 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e1bf784014 |
Deleting an inserted file removes its components, placements and joints (#4100) (#4113)
* claim: #4100 * Deleting an inserted file removes its components, placements and joints (#4100) A STEP or mesh file inserted into a design makes a component tree. Deleting its feature left that tree behind: the components, their occurrences, the rigid joints that hold them and the bodies' component assignments. A later body that took an imported body's name was then placed in the stale component. Document::remove_component_tree removes a component subtree and everything that refers to it: the features made inside it, its occurrences, the joints on them with their motion links, joint origins, contact set members, motion study keys and exploded moves, body component and offset entries, standard part and link records, and configuration columns. Deleting an inserted file's feature and component.delete both use it; component.delete now also removes joints left pointing at a deleted occurrence. The body transfer refusal moves with it, unchanged. * Only an inserted file's feature takes its component tree when deleted Mark the feature a STEP, IGES or mesh insert makes (`inserted`), and remove the component tree on delete only for those and for a linked design's feature. Deleting a copied component's independent base deletes just that feature, as before. Older designs get the mark as they open (pending format change), except copied components' independent bases. |
||
|
|
3acb81964a |
Sketch offset keeps its source lines free to turn (#4464) (#4466)
* claim: #4464 * Sketch offset keeps its source lines free to turn (#4464) An offset adds a Parallel between each source line and its offset line. Since offsets became associative, the offset's points are held during a solve, so each Parallel pinned its source line to the offset line's current direction: a closed chain lost its turning freedom (8 degrees of freedom became 6), and Horizontal or an angle edit on a source line was refused as conflicting. The solver and the constructive reading now leave out a Parallel that ties an offset line to the source it follows while the association lives; the association already keeps them parallel. After Break the stored Parallel drives again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
efb45d7411 |
Delete in a rolled-back history warns about the features after the marker (#3471) (#3698)
* claim: #3471 * Delete in a rolled-back history warns about the features after the marker (#3471) With the timeline rolled back, the checks a delete runs first (the confirmation's "these features will fail", timeline.dependents and selection.delete's would_fail) compared models evaluated only up to the marker. Features after it, broken by the delete, were not listed, so their error marks turned up only once the timeline moved to the end. newly_broken_in_history evaluates both sides over the whole history when either has a marker (on copies; the model and document are unchanged) and is used by the delete's report and by timeline.dependents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
426f8ddd18 |
Rectangular and circular pattern: copies that miss the body are reported (#3042) (#3919)
* claim: #3042 * Warn when cut pattern copies remove no material A rectangular or circular pattern whose copies miss the body succeeded silently and those copies did nothing. The pattern now reports how many of its cut copies removed no material, and keeps the copies that land. |
||
|
|
27d2fe6ec0 |
Frames: profile library, members along frame sketch lines, and the Frame Member dialog (#4003) (#4004)
* claim: #4003 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: the profile library (#4003) The first slice of frames and weldments: the cross-sections structural members will be made of, each SolidCraft's own parametric definition built in code (no vendor or standard size tables are shipped). - solidcraft_doc::frame: bar, round bar, rectangular and round tube, angle, channel, I-beam and a generic T-slot extrusion as exact line/arc regions, with defaults worked out from the profile's size, refusals that name the dimension that does not fit, anchors and placement, and exact section properties (area, centroid, Ixx/Iyy/Ixy by Green's theorem). - frame.profile.list, frame.profile.properties (with mass per metre for a density) and frame.profile.insert (draws a profile into a sketch, locked by default, at a point, anchor and angle). - Tests against hand-computed values (rectangles, circles, composite rectangles by the parallel-axis theorem, fillet spandrels), hostile input, extrusion volume, undo; catalog entries in every locale; docs/frames.md; ROADMAP M15. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: drop the built-in T-slot profile (#4003) Aluminium extrusions and other vendor sections come from the user's own sketch (drawn or inserted from the vendor's DXF), so the library keeps the plain steel shapes only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: members along frame sketch lines (#4003) frame.member lays one body per straight line of a frame sketch (2D lines or 3D sketch lines), its cross-section square to the line from end to end: - profile: a built-in profile, or profile_sketch, a sketch whose material (nested loops alternating, so two circles make a tube) is the section in its own x and y around its origin; profiles picks override it. - anchor (origin, centre, centroid or a bounding-box corner or edge middle), angle (an angle expression, so a parameter), mirror. - Orientation: the profile's y as near world up as the line allows, x square to both; a vertical member's x is world X (frame::member_axes). - Members follow sketch and parameter edits, undo as one step, save and reopen (format: pending/frame-members.rs), and are named after the profile (Rect Tube 40x40x3, (2)…), numbering on past names already taken. Tests against hand-computed volumes and bounding boxes (rectangle, 3D tower lines, parameter edit, sketch tube profile and picks, anchor/angle/ mirror), refusals, undo/redo and reopen; walk fixtures and goldens; docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: fixes from the adversarial review (#4003) - Default member lines are what was drawn: projected and other linked curves and 3D wires (a face sketch's edges) and lines of no length are left out. - A profile sketch's material starts from its drawn profiles, as solid.extrude's "all" does, so a section sketched on a face works; the even-odd test uses outlines and boxes worked out once, capped at 256. - Member names are pinned to their lines (`names`, by line id; `body_name` is the base): deleting or adding a line, or deleting another feature, no longer renames other members, and frame.member stores every name it gives. body.rename renames a member on its line (also for later member features); a copy whose body_names were set still names its members by position. - Built-in profile dimensions are expressions (ProfileSpec): they follow parameters, bare numbers take the design's units, and they are feature inputs. frame.profile.properties/insert read them the same way. - Default root/toe radii shrink to the room a thick section leaves; radii given are checked by name; a radius must be 0 or at least 0.01 mm; error messages report the wall or flange value given, not twice it. - A line within 1e-6 rad of vertical orients as vertical, so rounding never turns a post a quarter turn. - A 2D frame sketch in a differently placed component is mapped into the member's frame, and member features recompute when placements change. - Caps before lookups for a design's `lines`; a line listed twice is refused; a 3D wire that runs back on itself is not a line. Regression tests for each, from the review's scenarios. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Frames: the Frame Member dialog on the ribbon (#4003) - Frame Member (MODEL > Create) opens a dialog: the frame sketch's lines picked in the view (or All Lines), a built-in profile and its dimensions or a section picked in another sketch, anchor, angle, mirror and name, with a live preview. Edit Feature reopens it filled in. - Lines picked in the view keep their sketch (a SKETCH_LINES input picks ExternalSketchCurve): line ids are each sketch's own, so two 3D sketches both have a `w2`, and the members went on the newer sketch's lines. - timeline.redefine takes frame.member. Members keep their names through an edit unless it gives them a new body_name; frame.member takes `names`. - A member whose section is a whole profile sketch keeps it when edited (the dialog shows the sketch instead of picking every region, which would fill a tube's hole). - An original frame_member icon, open for review, on the ribbon, timeline and browser. - The angle profile is listed as L-Angle, and web and flange as Web/Flange thickness, so they translate apart from the existing Angle, Web and Flange; the dialog's labels are in en, ja and zh. en-GB no longer repeats the frame command labels it spells the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
ec56df3ffd |
Preserve expression-positioned sketch fillet corners (#4097) (#4106)
* claim: #4097 * Sketch fillet keeps a corner placed by an expression (#4097) Filleting a corner whose position comes from parameter expressions deleted the point and its expressions, so the sketch gained two degrees of freedom and later parameter changes distorted the outline. keep_corner now also keeps fixed or expression-positioned points as virtual sharp corners. |
||
|
|
5d92ad1e23 |
Renaming a plane keeps its projections, canvases and hidden state (#4353) (#4354)
* claim: #4353 * Renaming a plane keeps its projections, canvases and hidden state (#4353) timeline.rename only renamed the feature in other features' references. A sketch's projection of a construction plane, a canvas placed on it and the hidden list keep it by name too, so they lost it: the sketch warned that the plane no longer exists, the canvas left the view and a hidden plane showed again. Document::rename_feature_keys renames it in sketch links and canvases, as rename_body_keys does for bodies; the selection follows in the command, and the hidden list in Session::refresh_from, so a hidden plane stays hidden through undo and redo too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e8a6a5d3ff |
DXF: write and read a Bézier at its own degree (#5269) (#5281)
* claim: #5269 * DXF: write and read a Bézier at its own degree (#5269) The DXF writer and reader held a spline's degree to 7, the value MAX_BEZIER_DEGREE had before #1642 raised it to 9. A G4 blend (one Bézier of degree 9) was written as a degree-7 SPLINE over its first 8 control points, so a flat pattern's cut-out stopped 4.444 mm short in the file. - seg_shape takes its limit from MAX_BEZIER_DEGREE: a Bézier is written whole, at its own degree. - read_dxf reads SPLINE degrees 1 to MAX_BEZIER_DEGREE, the degrees a sketch spline takes. - Tests: every Bézier degree 4 to 9, a degree-9 round trip, the reader's degrees, hostile SPLINE degrees and too few control points, the G4 cut-out exported and read back with its areas, and a degree-9 SPLINE with 2 to 10 points inserted into a sketch. Fixes #5269 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
17bac141c8 |
An intersect that would leave nothing is refused instead of deleting the body (#5295) (#5303)
* claim: #5295 * An empty intersect is refused instead of deleting the body (#5295) An intersect whose boolean came out empty removed the target body and reported success. The shared evaluator now refuses it when nothing of a named target would remain, when nothing of any target would remain, or when the tools meet a target and the result is still empty. An unnamed target the tools miss altogether is still removed, as an intersect with every body does (#5160). Sheet metal flat machining follows the same rule. * Sheet metal: an intersect with already removed material is refused (#5295) |
||
|
|
4b42ef50c7 |
Mesh leftovers from the ribbon redesign (#133) (#4471)
* claim: #133 * mesh: Save As Mesh declares the panel that shows it (#133) The ribbon redesign (#2176) removed the MESH tab, but three things still pointed at it: - `file.save_mesh` declared `.at("MESH", "MODIFY")`. The command inventory prints the placement a spec declares, so `docs/features.md` advertised a `MESH > MODIFY` location no ribbon has. Its real home is already INSERT / FILES (`SECTIONS` lists it), so the declaration now agrees with the ribbon; `destination()` resolved it there before and after, so nothing moves on screen. - The user guide sent people to "the Mesh tab under Modify" for Save as mesh. - A test now refuses any command that declares a tab the ribbon removed, and pins where Save As Mesh lives. `PLACEMENTS` keeps its MESH entries: those migrate toolbars users saved under the old panels, which is a different question from what a spec declares. --------- Co-authored-by: Geraldrunion <geraldrunion@users.noreply.github.com> |
||
|
|
769dfff1a5 |
Section Analysis: a Hatch option (#4563) (#4565)
* claim: #4563 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Section Analysis: a Hatch option, off for a plain cut in the body's colour (#4563) The Section Analysis dialog gets a Hatch check box beside Flip, and inspect.section a hatch?: bool (default true), so scripts, the CLI and the control channel reach it too. Hatched, a cut is its body's colour tinted toward the cap colour with 45 degree stripes, as before; off, it is the body's own solid colour. The viewport (cap alpha in the uniform), the CPU rasterizer and ui.render follow it, and the section keeps it when hidden and shown again or edited. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3ed1829cc7 | fix: retain circular sketch pattern Quantity expressions (#4435) (#4607) | ||
|
|
b982ccd8c4 |
Mesh Convert works without activating the mesh's component first (#4609) (#4613)
* claim: #4609 * Mesh Convert works without activating the component first (#4609) Inserting a mesh puts it in a new component while the parent stays active, so Convert Mesh always refused the first time. Convert now resolves the mesh body's owning component and adds the conversion there when the active component is that component or an ancestor, leaving the active component unchanged. From another branch it still refuses, and the error names the component to activate. |
||
|
|
a5f9ff45dd |
Sketch Symmetry: a dimensioned shape slides onto the axis (#4030) (#4626)
* claim: #4030 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch Symmetry: a dimensioned shape slides onto the axis (#4030) With a rectangle's width dimensioned, Symmetry of its two sides about an axis was refused: the second side can't move on its own, the axis never moves, and the ordinary solve that slides the whole rectangle only ran when every first-picked entity could move. One movable first entity is now enough. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
61360c3b0d |
Convert to Sheet Metal: a bend picked on its tangent edge connects, on rotated parts too (#4328) (#4630)
* claim: #4328 * Fix sheet conversion picks on tangent bend edges (#4328) Resolve cylindrical bends through the nearest edge's incident faces when a pick on a tangent boundary resolves to its planar panel. This keeps valid remote bends connected, including picks on the other skin of a shell. Keep conversion geometry and picks in the body's local frame, and format conversion diagnostics through its world placement. Cover rotated bend picks and disconnected-pick coordinates with synthetic regressions. |
||
|
|
eec6da060f |
Measure: report obtuse angles at a shared corner (#4625) (#4634)
* claim: #4625 * fix: measure obtuse corners independently of edge direction (#4625) |
||
|
|
96ce31153c |
Pattern and mirror: a rib as the source (#4593) (#4667)
* claim: #4593 * Pattern and mirror: a rib as the source (#4593) A pattern or mirror of features refused a rib as a source ("Rib1 cannot be patterned or mirrored yet"). A rib's walls run until they meet the body, so each copy is built again where it is: the rib's sketch is moved by the copy's transform and the walls are run against the bodies there, as a hole is drilled again at each copy. The copies join the body, as the rib does. The rib's own tool building moves into rib_tools, which the rib feature calls unmoved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a9c3c8bb8a |
Accept a leading = in expressions, so a fillet radius can be =d3 (#4681) (#4686)
* Sketch fillet radius: accept a leading = in an expression (#4681) * A second = after a name is still not a definition |
||
|
|
a147a7c083 |
Sketch Point: a point put on a midpoint or a curve snap is held there (#4691) (#4745)
* Sketch Point: a point put on a midpoint or a curve snap is held there (#4691) The Point tool sent only a snapped point's coordinates and sketch.point took only [x, y], so a point clicked on a line's midpoint (or on a curve, or a model vertex) was free to move off it. sketch.point now takes the snap forms the other draw commands take ("mid:<line>", "on:<curve>:x,y", {vertex}, {on_edge}); the snap makes the point with its constraint. The tool passes those snaps as themselves; a snap to an existing point still goes as coordinates, where `connect` joins them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Sketch Point: refuse a snap it can't read instead of answering as if it made a point sketch_project::snap_points leaves a snap it can't parse ("on:c1:abc", "on:c1", "on:c1:1,2,3") as it was given, and sketch.point then read that string back as the point it had made: no error, no point, and an id a script would go on to dimension. It now takes the snap only when it names a point of the sketch, and otherwise refuses, listing the snap forms (found by the test agent on #4745). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
84cad43154 |
Timeline marker: refuse a negative position, and name the command asked for (#4712) (#4749)
timeline.rollback / timeline.roll_to read a negative position as 0, so an agent passing -1 for "one step back" rolled the whole timeline back and every body disappeared, with no error. A negative position is now refused. The two commands shared one function that refused in roll_to's name; each now refuses in its own. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
9559ad398a |
Physical material: one rule for a body's material and its density (#4783) (#4785)
* claim: #4783 * Physical material: one rule for a body's material and its density (#4783) inspect.measure, component.properties, occurrence.properties and the Properties window took a body's material name from the raw assignment, but its density from Document::density, which falls back to the default material when the assigned one is unknown or has an unusable density. So a damaged or hand-edited design read one material and weighed another: a design material "Broken" at -3 g/cm³ read "Broken" at 1.29 g/cm³. One rule, in one place: - DEFAULT_MATERIAL (new, beside DEFAULT_DENSITY in the material library) is the default material's name. The library's first row uses it. - Document::body_material (new, beside Document::density) is the material a body's mass is computed with, as the library or the design spells it: the assigned one when it is known and has a usable density, else DEFAULT_MATERIAL. Document::density is that material's density, with the same value as before for every input. inspect.measure and the physical properties name body_material. inspect.measure now names every body's material, measured or not, since naming it takes no measuring; the density stays with the mass, on the bodies measured. So the Properties window shows the engine's name without a fallback of its own. The places that keep the assignment as stored (configuration cells, material.assign, material.edit, material.delete and the dialogs) only use the constant, so a configuration still keeps a damaged assignment as it is. The visible change: a body whose material is unknown, or has an unusable density, reads "Default", the material it weighs, and a miscased name reads as the library or the design spells it. A body inspect.measure can't measure now has its material too. Masses and densities don't change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a0fd39a7be |
Flange on a plain solid says how to start sheet metal (#2987) (#4789)
* claim: #2987 * Flange on a plain solid says how to start sheet metal (#2987) Flange, Flat Pattern, and Export DXF on a design with no sheet metal body now say how to make one: Flange > Base, or Convert to Sheet Metal on a plate's large flat face. An edge flange checks for a sheet metal body before it adds a feature. The message is in the catalogs, and engine messages that match a catalog entry are shown in the interface language. * Dialogs show a refusal without the engine's parameter prefix (#2987) The Flange dialog showed "invalid parameters for `sheet.flange`: " in front of the new guidance. The dialog already names its command, so the red refusal text leaves that prefix out and follows the interface language when the message is in the catalogs. Create Issue still gets the full text. |
||
|
|
e104e241a3 |
Rename a body: keep the names of siblings a later feature removed (#4880) (#4904)
* claim: #4880 * Rename a body: keep the names of siblings a later feature removed (#4880) Renaming a body sets the stored names of all bodies its feature made, so the siblings are not renumbered. Those names were read from the final model, where a body that a later feature removed no longer exists: its stored name was lost, it came back as `Ext (3)`, and the later Remove failed with "no body `Body3`". Read the siblings from the feature's own result instead, as the later features already are. * Test: renaming one half of a split leaves the other Renaming one half keeps the other half's name, also once a later feature joins that other half away, after both an incremental and a full evaluation. |
||
|
|
d1f5d6e223 |
History: drag features across the marker in one step, clearer drop feedback (#4938)
Dropping a feature just behind the history marker now rolls it back, and dropping it just before the marker makes it active again, in both the bottom strip and the left panel. timeline.reorder and timeline.move_many take an optional `active` param that sets the marker in the same command, so the move is one undo step and one recompute. A position on the wrong side of the marker for the requested `active` is refused. Drop feedback: - bottom strip: the drop line sits centred between two features (it used to touch the previous one) and shows at the first position (it used to be drawn outside the strip there) - left panel: a drop slot below the marker when it is at the end - no drop line when the marker is dragged back to where it is - a dragged feature is outlined in the drop line's green - grab cursor on the marker, grabbing cursor while dragging the marker or a feature Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
567bc50723 |
Snap fit: refuse sizes too small to build (#5022) (#5027)
* claim: #5022 * Plastic features: refuse sizes under 0.01 mm (#5022) A snap fit with a near-zero thickness (1e-9 mm) got past the size checks, which only asked for a positive number, and panicked in the kernel's intersection code. The boss, lip, groove and rest had the same gap. Every length of a plastic feature that becomes geometry (snap fit length, thickness, width, catch_depth and catch_length; boss diameter, height, hole_diameter, hole_depth and rib sizes; lip and groove width and height; rest width, length, height and thickness) must now be at least 0.01 mm. The check sits where the feature is evaluated, so a parameter changed later is refused the same way, and the message names the parameter. |
||
|
|
1a5fcd05d6 |
Extrude and loft: refuse duplicate profile indexes (#5023) (#5028)
* claim: #5023 * Extrude and loft: refuse repeated profile indexes (#5023) `profiles: [0, 0, ...]` with 10 000 copies built 10 000 identical bodies in about 35 s, and a loft section listing one profile 10 000 times took 25 s before it was refused. A list of profile indexes now refuses a repeated index while it is parsed ("profile 0 is listed twice"), as offset association ids already were. Before the profiles are resolved, a selection naming more profiles than its sketch has, an index the sketch doesn't have, or two points in the same profile is refused too. A design file that repeats an index still opens, using the profile once. |
||
|
|
da46c660df |
Coincident on two circles lays the second on the first (#5038)
Coincident with two circles (or arcs) picked was refused: "two curves must both be straight lines; otherwise choose a point and a curve". It now lays the second pick on the first: Concentric and Equal together, in one step, with the first staying put. A pair already concentric or equal gets only the other half; one already lying on the other is refused as nothing to add. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
dbbad6d4ee |
view.apply: keep the camera's roll, and refuse an up axis (#5087) (#5094)
* claim: #5087 * view.apply: keep the camera's roll, and refuse an up axis (#5087) An explicit camera was read as a named view, which has no roll or up, so roll was silently reset to 0 and up was ignored. Read roll as a finite number in radians, clamped to ±π, and refuse up with a message saying the up axis comes from the design settings. |
||
|
|
2dc31a30d4 |
Extract to File: move a component into its own linked design (#5113)
The component's sketches, features, bodies, subcomponents, the joints among them and the parameters they use move to a new .solidcraft design, keeping their ids and names, and the component becomes linked to it as Insert Design makes it. The new design must build the same bodies and the assembly must look the same afterwards, else nothing changes and no file is written. Joint faces on the component are found again on the linked bodies, and components that build the same bodies can become placements of the link. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
8b68eb7eac |
fix(extrude): a sketch on an inserted part joins and cuts it, through all too (#5115)
A STEP file inserted into a new design sits in its own component under the empty root, and a sketch on its face must join that part going out and cut it going in rather than make a separate body beside it. With a distance, main already resolves this; Through All with no distance gave `auto` no reach to probe, so it fell back to New Body and cut nothing. Through All now reaches past every body in its direction, and `auto` reads it as a cut (#1234). Co-authored-by: Steven <steven2021067613@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
5367ef4367 |
Extrude without a profile selection keeps holes in nested loops (#5172) (#5176)
* claim: #5172 * Extrude without profiles keeps nested loops as holes (#5172) With no `profiles`, solid.extrude took every region of the sketch, so circles drawn inside a plate outline were extruded as well and filled the plate's holes. The default now applies even-odd nesting to the drawn profiles: a loop inside an outline is its hole, a loop inside that hole is material again, and separate outlines all extrude. Sketches without nesting keep the `all` selection, and explicit `profiles` (including "all") are unchanged. Saved designs store their selection, so they recompute as before. |
||
|
|
caa1e6e196 |
component.create refuses parameters it does not take (#5174) (#5178)
* claim: #5174 * component.create refuses parameters it does not take (#5174) A call with `bodies` (or a misspelled key) used to succeed and make an empty component. Unknown keys are now refused before anything changes, the error lists the accepted parameters, and `bodies` points to component.move_bodies and component.from_bodies. |
||
|
|
8bd17cea42 |
Joints: a joint origin's name given as a face says to pass it as the origin (#5175) (#5179)
* claim: #5175 * Joints: a joint origin's name given as a face says to pass it as the origin (#5175) When the name in `face` or `circle` matches no face but is a joint origin, the error now says so instead of "no face is named". |
||
|
|
4256775274 |
Joint: avoid redundant analysis and residual placement work (#5185) (#5186)
* claim: #5185 * Joint: reuse residual placements and skip discarded mobility reports (#5185) |